Re: svn commit: r322029 - in head: usr.bin usr.sbin

2017-08-08 Thread Jeremie Le Hen 
On Sat, Aug 5, 2017 at 3:38 PM, Brooks Davis  wrote:
> On Fri, Aug 04, 2017 at 04:50:32PM +0200, Jeremie Le Hen wrote:
>> On Fri, Aug 4, 2017 at 12:42 AM, Ngie Cooper (yaneurabeya)
>>  wrote:
>> >
>> >> On Aug 3, 2017, at 14:30, Jeremie Le Hen  wrote:
>> >>
>> >> Author: jlh
>> >> Date: Thu Aug  3 21:30:12 2017
>> >> New Revision: 322029
>> >> URL: https://svnweb.freebsd.org/changeset/base/322029
>> >>
>> >> Log:
>> >>  rwho/ruptime/rwhod shouldn't be gated by RCMDS.
>> >
>> > The why in this commit and the next you made (r322031) would have 
>> > been incredibly helpful. If bugzilla disappears I only have the commit 
>> > history tracking the what.
>>
>> I agree, I realized this only afterwards.  I don't know how to fix this 
>> though.
>
> Reverting the change and reapplying it with a meaningful message will
> produce the best result.

OK thanks.  FYI this is submitted in r322277, with changes to
tools/build/mk/OptionalObsoleteFiles.inc as requested by jhb@.

Thanks all for your patience :-).
-- 
Jeremie Le Hen
j...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322029 - in head: usr.bin usr.sbin

2017-08-05 Thread Brooks Davis 
On Fri, Aug 04, 2017 at 04:50:32PM +0200, Jeremie Le Hen wrote:
> On Fri, Aug 4, 2017 at 12:42 AM, Ngie Cooper (yaneurabeya)
>  wrote:
> >
> >> On Aug 3, 2017, at 14:30, Jeremie Le Hen  wrote:
> >>
> >> Author: jlh
> >> Date: Thu Aug  3 21:30:12 2017
> >> New Revision: 322029
> >> URL: https://svnweb.freebsd.org/changeset/base/322029
> >>
> >> Log:
> >>  rwho/ruptime/rwhod shouldn't be gated by RCMDS.
> >
> > The why in this commit and the next you made (r322031) would have 
> > been incredibly helpful. If bugzilla disappears I only have the commit 
> > history tracking the what.
> 
> I agree, I realized this only afterwards.  I don't know how to fix this 
> though.

Reverting the change and reapplying it with a meaningful message will
produce the best result.

-- Brooks
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322029 - in head: usr.bin usr.sbin

2017-08-04 Thread John Baldwin 
On Thursday, August 03, 2017 09:30:12 PM Jeremie Le Hen wrote:
> Author: jlh
> Date: Thu Aug  3 21:30:12 2017
> New Revision: 322029
> URL: https://svnweb.freebsd.org/changeset/base/322029
> 
> Log:
>   rwho/ruptime/rwhod shouldn't be gated by RCMDS.
>   
>   PR: 220953
>   Reported by:peter@
>   Differential Revision:  https://reviews.freebsd.org/D11743
> 
> Modified:
>   head/usr.bin/Makefile
>   head/usr.sbin/Makefile

Don't forget to update tools/build/mk/OptionalObsoleteFiles.inc so that 
'make delete-old' doesn't incorrectly remove these.

The /etc/rc.d/rwhod script is also curently conditional on rcmds
(see etc/rc.d/Makefile) as is the 140.clean-rwho periodic script
(see etc/periodic/daily/Makefile).

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322029 - in head: usr.bin usr.sbin

2017-08-04 Thread Jeremie Le Hen 
On Fri, Aug 4, 2017 at 12:42 AM, Ngie Cooper (yaneurabeya)
 wrote:
>
>> On Aug 3, 2017, at 14:30, Jeremie Le Hen  wrote:
>>
>> Author: jlh
>> Date: Thu Aug  3 21:30:12 2017
>> New Revision: 322029
>> URL: https://svnweb.freebsd.org/changeset/base/322029
>>
>> Log:
>>  rwho/ruptime/rwhod shouldn't be gated by RCMDS.
>
> The why in this commit and the next you made (r322031) would have 
> been incredibly helpful. If bugzilla disappears I only have the commit 
> history tracking the what.

I agree, I realized this only afterwards.  I don't know how to fix this though.

> Cheers,
> -Ngie



-- 
Jeremie Le Hen
j...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322029 - in head: usr.bin usr.sbin

2017-08-03 Thread Ngie Cooper (yaneurabeya) 

> On Aug 3, 2017, at 14:30, Jeremie Le Hen  wrote:
> 
> Author: jlh
> Date: Thu Aug  3 21:30:12 2017
> New Revision: 322029
> URL: https://svnweb.freebsd.org/changeset/base/322029
> 
> Log:
>  rwho/ruptime/rwhod shouldn't be gated by RCMDS.

The why in this commit and the next you made (r322031) would have been 
incredibly helpful. If bugzilla disappears I only have the commit history 
tracking the what.
Cheers,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail