Re: svn commit: r322347 - in head/sys/x86: acpica include x86 xen

2017-08-11 Thread Roger Pau Monn 
On Fri, Aug 11, 2017 at 10:10:15AM +, Li-Wen Hsu wrote:
> On Thu, Aug 10, 2017 at 18:48:53 +0100, Roger Pau Monn wrote:
> > On Thu, Aug 10, 2017 at 10:20:59AM -0400, Ed Maste wrote:
> > > On 10 August 2017 at 05:15, Roger Pau Monné  wrote:
> > > > Author: royger
> > > > Date: Thu Aug 10 09:15:18 2017
> > > > New Revision: 322347
> > > > URL: https://svnweb.freebsd.org/changeset/base/322347
> > > >
> > > > Log:
> > > >   apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase
> > > 
> > > i386 is failing with:
> > 
> > Thanks for the heads up! Should be fixed in r322372, will keep an eye on
> > the CI.
> 
> It seems i386 LINT is still failing:
> 
> /workspace/src/sys/x86/acpica/srat.c:446:28: error: implicit declaration of 
> function 'PHYS_TO_DMAP' is invalid in C99 
> [-Werror,-Wimplicit-function-declaration]
> cpus = (struct cpu_info *)PHYS_TO_DMAP(addr);
>   ^
> 
> Could you also chcek this one? 
> https://ci.freebsd.org/job/FreeBSD-head-i386-LINT/2833/console

Sorry again for the breakage, should be fixed in r322403. Not sure if
it makes much sense to parse the SRAT on i386 anyway.

Roger.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322347 - in head/sys/x86: acpica include x86 xen

2017-08-11 Thread Li-Wen Hsu 
On Thu, Aug 10, 2017 at 18:48:53 +0100, Roger Pau Monn wrote:
> On Thu, Aug 10, 2017 at 10:20:59AM -0400, Ed Maste wrote:
> > On 10 August 2017 at 05:15, Roger Pau Monné  wrote:
> > > Author: royger
> > > Date: Thu Aug 10 09:15:18 2017
> > > New Revision: 322347
> > > URL: https://svnweb.freebsd.org/changeset/base/322347
> > >
> > > Log:
> > >   apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase
> > 
> > i386 is failing with:
> 
> Thanks for the heads up! Should be fixed in r322372, will keep an eye on
> the CI.

It seems i386 LINT is still failing:

/workspace/src/sys/x86/acpica/srat.c:446:28: error: implicit declaration of 
function 'PHYS_TO_DMAP' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
cpus = (struct cpu_info *)PHYS_TO_DMAP(addr);
  ^

Could you also chcek this one? 
https://ci.freebsd.org/job/FreeBSD-head-i386-LINT/2833/console

Thanks,
Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322347 - in head/sys/x86: acpica include x86 xen

2017-08-10 Thread Roger Pau Monné 
On Thu, Aug 10, 2017 at 10:20:59AM -0400, Ed Maste wrote:
> On 10 August 2017 at 05:15, Roger Pau Monné  wrote:
> > Author: royger
> > Date: Thu Aug 10 09:15:18 2017
> > New Revision: 322347
> > URL: https://svnweb.freebsd.org/changeset/base/322347
> >
> > Log:
> >   apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase
> 
> i386 is failing with:

Thanks for the heads up! Should be fixed in r322372, will keep an eye on
the CI.

Roger.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r322347 - in head/sys/x86: acpica include x86 xen

2017-08-10 Thread Ed Maste 
On 10 August 2017 at 05:15, Roger Pau Monné  wrote:
> Author: royger
> Date: Thu Aug 10 09:15:18 2017
> New Revision: 322347
> URL: https://svnweb.freebsd.org/changeset/base/322347
>
> Log:
>   apic_enumerator: only set mp_ncpus and mp_maxid at probe cpus phase

i386 is failing with:

13:55:08 --- mptable.o ---
13:55:08 /usr/src/sys/x86/x86/mptable.c:333:3: error: use of
undeclared identifier 'mp_ncpus'
13:55:08 mp_ncpus = 2;
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:334:3: error: use of
undeclared identifier 'mp_maxid'
13:55:08 mp_maxid = 1;
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:359:3: error: use of
undeclared identifier 'cpu_mask'
13:55:08 cpu_mask = 0;
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:360:51: error: use of
undeclared identifier 'cpu_mask'
13:55:08
mptable_walk_table(mptable_setup_cpus_handler, _mask);
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:480:39: error: use of
undeclared identifier 'mp_ncpus'
13:55:08 proc->apic_id < MAX_LAPIC_ID && mp_ncpus
< MAXCPU) {
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:481:4: error: use of
undeclared identifier 'mp_ncpus'
13:55:08 mp_ncpus++;
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:482:4: error: use of
undeclared identifier 'mp_maxid'
13:55:08 mp_maxid = mp_ncpus - 1;
13:55:08 ^
13:55:08 /usr/src/sys/x86/x86/mptable.c:482:15: error: use of
undeclared identifier 'mp_ncpus'
13:55:08 mp_maxid = mp_ncpus - 1;
13:55:08^
13:55:08 8 errors generated.
13:55:08 *** [mptable.o] Error code 1

https://ci.freebsd.org/job/FreeBSD-head-i386-build/3457/console
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"