Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include

2018-02-12 Thread Warner Losh
On Mon, Feb 12, 2018 at 8:57 AM, Joerg Sonnenberger  wrote:

> On Mon, Feb 12, 2018 at 02:48:14PM +, Warner Losh wrote:
> > Author: imp
> > Date: Mon Feb 12 14:48:14 2018
> > New Revision: 329164
> > URL: https://svnweb.freebsd.org/changeset/base/329164
> >
> > Log:
> >   We don't support gcc < 4.2.1, so varargs.h now is just #error
> >   always. Unifdef for versions prior to 4.2.1 and remove now-unused
> >   header files.
>
> In my experience it is better to really drop it. Keeping the header with
> an #error is just creating *more* pain than having no header at all.
>

My change didn't change anything here. It already was a #error. I just
changed it from #if  #error #endif to #error. I'll leave it to
the compliance folks to jump in and remove it. It's a posix header, it
seems. But nobody is using it and it can't be causing widespread problems
today or it would be on people's radar... It's not.

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include

2018-02-12 Thread Joerg Sonnenberger
On Mon, Feb 12, 2018 at 02:48:14PM +, Warner Losh wrote:
> Author: imp
> Date: Mon Feb 12 14:48:14 2018
> New Revision: 329164
> URL: https://svnweb.freebsd.org/changeset/base/329164
> 
> Log:
>   We don't support gcc < 4.2.1, so varargs.h now is just #error
>   always. Unifdef for versions prior to 4.2.1 and remove now-unused
>   header files.

In my experience it is better to really drop it. Keeping the header with
an #error is just creating *more* pain than having no header at all.

Joerg
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"