Re: svn commit: r330705 - head/sbin/mount

2018-03-10 Thread Warner Losh
On Sat, Mar 10, 2018 at 1:43 AM, Alexey Dokuchaev  wrote:

> On Fri, Mar 09, 2018 at 09:32:08PM +, Warner Losh wrote:
> > New Revision: 330705
> > URL: https://svnweb.freebsd.org/changeset/base/330705
> >
> > Log:
> >   Remove decade's old whine about msdos vs msdosfs.
> >
> >   Retain the compatibility silently though.
>
> Shouldn't it be the other way around?  That is, after a decade of whining
> people would've updated their configs/scripts and old (deprecated) gimmick
> can now be removed?  That's what usually implied by "deprecated", right?
>

Nope. We accept both because even after a decade, people's fingers haven't
changed. The original change was poorly socialized and met with scorn at
the time. It's better to just accept both as some people have changed and
others haven't. The 'deprecated' part never took hold, so I just removed
the warning because the consensus is we are never going to stop accepting
both.

Warner


> ./danfe
>
> > Modified: head/sbin/mount/mount.c
> > ...
> > @@ -589,11 +589,8 @@ mountfs(const char *vfstype, const char *spec,
> const c
> >   optbuf = catopt(optbuf, "update");
> >
> >   /* Compatibility glue. */
> > - if (strcmp(vfstype, "msdos") == 0) {
> > - warnx(
> > - "Using \"-t msdosfs\", since \"-t msdos\" is
> deprecated.");
> > + if (strcmp(vfstype, "msdos") == 0)
> >   vfstype = "msdosfs";
> > - }
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r330705 - head/sbin/mount

2018-03-10 Thread Alexey Dokuchaev
On Fri, Mar 09, 2018 at 09:32:08PM +, Warner Losh wrote:
> New Revision: 330705
> URL: https://svnweb.freebsd.org/changeset/base/330705
> 
> Log:
>   Remove decade's old whine about msdos vs msdosfs.
>   
>   Retain the compatibility silently though.

Shouldn't it be the other way around?  That is, after a decade of whining
people would've updated their configs/scripts and old (deprecated) gimmick
can now be removed?  That's what usually implied by "deprecated", right?

./danfe

> Modified: head/sbin/mount/mount.c
> ...
> @@ -589,11 +589,8 @@ mountfs(const char *vfstype, const char *spec, const c
>   optbuf = catopt(optbuf, "update");
>  
>   /* Compatibility glue. */
> - if (strcmp(vfstype, "msdos") == 0) {
> - warnx(
> - "Using \"-t msdosfs\", since \"-t msdos\" is deprecated.");
> + if (strcmp(vfstype, "msdos") == 0)
>   vfstype = "msdosfs";
> - }
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"