Re: svn commit: r330885 - head/sys/modules/cam

2018-03-14 Thread Warner Losh 
On Wed, Mar 14, 2018 at 10:14 AM, Hans Petter Selasky 
wrote:

> On 03/14/18 00:36, Warner Losh wrote:
>
>> Author: imp
>> Date: Tue Mar 13 23:36:15 2018
>> New Revision: 330885
>> URL: https://svnweb.freebsd.org/changeset/base/330885
>>
>> Log:
>>We need opt_compat.h after r330819 and 330820.
>>   Add opt_compat.h to fix the stand-alone build case.
>>   Sponsored by: Netflix.
>>
>> Modified:
>>head/sys/modules/cam/Makefile
>>
>> Modified: head/sys/modules/cam/Makefile
>> 
>> ==
>> --- head/sys/modules/cam/Makefile   Tue Mar 13 23:05:51 2018
>> (r330884)
>> +++ head/sys/modules/cam/Makefile   Tue Mar 13 23:36:15 2018
>> (r330885)
>> @@ -8,6 +8,7 @@ KMOD=   cam
>> # See sys/conf/options for the flags that go into the different
>> opt_*.h files.
>>   SRCS= opt_cam.h
>> +SRCS=  opt_compat.h
>>   SRCS+=opt_ada.h
>>   SRCS+=opt_scsi.h
>>   SRCS+=opt_cd.h
>>
>>
>>
> Hi,
>
> Should this be SRCS+= ?


Yes. I had an unclean build and it worked. Good eye.

Wanrer
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r330885 - head/sys/modules/cam

2018-03-14 Thread Hans Petter Selasky 

On 03/14/18 00:36, Warner Losh wrote:

Author: imp
Date: Tue Mar 13 23:36:15 2018
New Revision: 330885
URL: https://svnweb.freebsd.org/changeset/base/330885

Log:
   We need opt_compat.h after r330819 and 330820.
   
   Add opt_compat.h to fix the stand-alone build case.
   
   Sponsored by: Netflix.


Modified:
   head/sys/modules/cam/Makefile

Modified: head/sys/modules/cam/Makefile
==
--- head/sys/modules/cam/Makefile   Tue Mar 13 23:05:51 2018
(r330884)
+++ head/sys/modules/cam/Makefile   Tue Mar 13 23:36:15 2018
(r330885)
@@ -8,6 +8,7 @@ KMOD=   cam
  
  # See sys/conf/options for the flags that go into the different opt_*.h files.

  SRCS= opt_cam.h
+SRCS=  opt_compat.h
  SRCS+=opt_ada.h
  SRCS+=opt_scsi.h
  SRCS+=opt_cd.h




Hi,

Should this be SRCS+= ?

--HPS
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r330885 - head/sys/modules/cam

2018-03-13 Thread Warner Losh 
On Mar 13, 2018 6:07 PM, "Brooks Davis"  wrote:

On Tue, Mar 13, 2018 at 11:36:15PM +, Warner Losh wrote:
> Author: imp
> Date: Tue Mar 13 23:36:15 2018
> New Revision: 330885
> URL: https://svnweb.freebsd.org/changeset/base/330885
>
> Log:
>   We need opt_compat.h after r330819 and 330820.
>
>   Add opt_compat.h to fix the stand-alone build case.

Sorry about that.  I only tested with buildkernel.  I'll MFC this before
either of those.


Don't fret. I was on the review and missed it too.

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r330885 - head/sys/modules/cam

2018-03-13 Thread Brooks Davis 
On Tue, Mar 13, 2018 at 11:36:15PM +, Warner Losh wrote:
> Author: imp
> Date: Tue Mar 13 23:36:15 2018
> New Revision: 330885
> URL: https://svnweb.freebsd.org/changeset/base/330885
> 
> Log:
>   We need opt_compat.h after r330819 and 330820.
>   
>   Add opt_compat.h to fix the stand-alone build case.

Sorry about that.  I only tested with buildkernel.  I'll MFC this before
either of those.

-- Brooks


signature.asc
Description: PGP signature