Re: svn commit: r340722 - head/lib/libbe
Hello, On Wed, 21 Nov 2018 at 17:54, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by:bcr > > > > Approved by:krion (mentor, implicit), mat (mentor, > implicit) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > > > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? > > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer > with the appropriate bit" > > It probably would be fine to have said Approved by: bcr. > True. Perhaps as a ports committer I should even write "Approved by: bcr (doc)" to make it clear that I collected appropriate approvals before committing. I've been committing small patches to the src tree for a couple of months now and I've heard that "Reviewed by: bcr" is sufficient. I guess that now I understand that "Reviewed by" is for listing people and teams who reviewed the code and "Approved by" is for listing all the necessary approvals one has to collect in order to commit. I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? > mat@ and krion@ told me that I don't have to ask them about explicit approval before committing to doc or src. If I gather all the necessary approvals from doc and src committers then I am able to commit with an implicit approval from my mentors. > > As an aside, happy to approve any changes to these manpages as the > > current bectl/libbe maintainer for anyone that wants to improve them. > > =) > I'm really sorry, this is my fault. Usually, I request people, who recently contributed to a certain part of a tree or who are listed in the MAINTAINERS file, to review my changes. This time it was only meant to be a small improvement to our documentation without any actual content changes to the manual page itself so I only notified bcr. Regards, Mateusz ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
On Wed, Nov 21, 2018 at 08:54:10AM -0800, Rodney W. Grimes wrote: > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by:bcr > > > > Approved by:krion (mentor, implicit), mat (mentor, implicit) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > > > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? > > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer >with the appropriate bit" > > It probably would be fine to have said Approved by: bcr. > > I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? > > > > > As an aside, happy to approve any changes to these manpages as the > > current bectl/libbe maintainer for anyone that wants to improve them. > > =) > > That defanitly would of been a cleaner path. C'mon guys. Mateusz is doing a great job with documentation - THANK YOU! I would be more outraged that we still didn't appreciate him. Thanks, -- Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD committer | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 signature.asc Description: PGP signature
Re: svn commit: r340722 - head/lib/libbe
On Wed, Nov 21, 2018 at 10:54 AM Rodney W. Grimes wrote: > > > On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > > wrote: > > > > > > > Author: 0mp (ports committer) > > > > Date: Wed Nov 21 11:22:44 2018 > > > > New Revision: 340722 > > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > > > Log: > > > > libbe(3): Put each error value in separate line. > > > > > > > > As requested by a TODO in the source code. > > > > > > > > Reviewed by:bcr > > > > Approved by:krion (mentor, implicit), mat (mentor, implicit) > > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > > > Who with a src bit approved the commit to src? > > > > > > > I do want to clarify- bcr approved it in the review (explicitly with > > "... hereby approved!") -- are you mainly pointing out that he failed > > to annotate this properly in the commit, or is doc bit approval for a > > commit to a manpage in src insufficient? > > That is defanitly a bit of a grey area, from reading and re-reading > the commit bit page it is clear that a doc committer can commit > to src documentation, it is not clear if they can approve a commit > by someone else to the src tree, it does say > ""Approved by" from a non-mentored committer > with the appropriate bit" > > It probably would be fine to have said Approved by: bcr. > Agreed- I think this is fine given that it's within the scope of bcr's doc bit. > I still question what a out of scope commit that is > approved by: (mentor, implicit). I am not even sure > what that means in this context. Have his mentors > said he can commit anything anyplace without them > seeing it? If so then release the mentor/mentee bit > would be more appropriate? > I suspect it's that they're not interested in any doc changes he has, because they're not doc people. Well, mat@ is, but mat isn't mentoring him for docs, he's mentoring him for ports. Such approvals would just be rubber stamps anyways, because they as mentors might not necessarily be up-to-date on doc protocols. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
> On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes > wrote: > > > > > Author: 0mp (ports committer) > > > Date: Wed Nov 21 11:22:44 2018 > > > New Revision: 340722 > > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > > > Log: > > > libbe(3): Put each error value in separate line. > > > > > > As requested by a TODO in the source code. > > > > > > Reviewed by:bcr > > > Approved by:krion (mentor, implicit), mat (mentor, implicit) > > > Differential Revision: https://reviews.freebsd.org/D18063 > > > > Who with a src bit approved the commit to src? > > > > I do want to clarify- bcr approved it in the review (explicitly with > "... hereby approved!") -- are you mainly pointing out that he failed > to annotate this properly in the commit, or is doc bit approval for a > commit to a manpage in src insufficient? That is defanitly a bit of a grey area, from reading and re-reading the commit bit page it is clear that a doc committer can commit to src documentation, it is not clear if they can approve a commit by someone else to the src tree, it does say ""Approved by" from a non-mentored committer with the appropriate bit" It probably would be fine to have said Approved by: bcr. I still question what a out of scope commit that is approved by: (mentor, implicit). I am not even sure what that means in this context. Have his mentors said he can commit anything anyplace without them seeing it? If so then release the mentor/mentee bit would be more appropriate? > > As an aside, happy to approve any changes to these manpages as the > current bectl/libbe maintainer for anyone that wants to improve them. > =) That defanitly would of been a cleaner path. > > Thanks, > > Kyle Evans > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
On 2018-11-21 08:18:55 (-0800), Rodney W. Grimes wrote: > > Author: 0mp (ports committer) > > Date: Wed Nov 21 11:22:44 2018 > > New Revision: 340722 > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > Log: > > libbe(3): Put each error value in separate line. > > > > As requested by a TODO in the source code. > > > > Reviewed by: bcr > > Approved by: krion (mentor, implicit), mat (mentor, implicit) > > Differential Revision:https://reviews.freebsd.org/D18063 > > Who with a src bit approved the commit to src? > My understanding is that doc bits allow people to commit to src documentation, including man pages. (https://www.freebsd.org/doc/en/articles/committers-guide/committer.types.html) Best regards, Kristof ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes wrote: > > > Author: 0mp (ports committer) > > Date: Wed Nov 21 11:22:44 2018 > > New Revision: 340722 > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > Log: > > libbe(3): Put each error value in separate line. > > > > As requested by a TODO in the source code. > > > > Reviewed by:bcr > > Approved by:krion (mentor, implicit), mat (mentor, implicit) > > Differential Revision: https://reviews.freebsd.org/D18063 > > Who with a src bit approved the commit to src? > I do want to clarify- bcr approved it in the review (explicitly with "... hereby approved!") -- are you mainly pointing out that he failed to annotate this properly in the commit, or is doc bit approval for a commit to a manpage in src insufficient? As an aside, happy to approve any changes to these manpages as the current bectl/libbe maintainer for anyone that wants to improve them. =) Thanks, Kyle Evans ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
On Thu, Nov 22, 2018, 12:19 AM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net wrote: > > Author: 0mp (ports committer) > > Date: Wed Nov 21 11:22:44 2018 > > New Revision: 340722 > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > Log: > > libbe(3): Put each error value in separate line. > > > > As requested by a TODO in the source code. > > > > Reviewed by:bcr > > Approved by:krion (mentor, implicit), mat (mentor, implicit) > > Differential Revision: https://reviews.freebsd.org/D18063 > > Who with a src bit approved the commit to src? > I was asking myself the same question!! > > Modified: > > head/lib/libbe/libbe.3 > > > > Modified: head/lib/libbe/libbe.3 > > > == > > --- head/lib/libbe/libbe.3Wed Nov 21 06:36:15 2018(r340721) > > +++ head/lib/libbe/libbe.3Wed Nov 21 11:22:44 2018(r340722) > > @@ -28,7 +28,7 @@ > > .\" > > .\" $FreeBSD$ > > .\" > > -.Dd November 17, 2018 > > +.Dd November 21, 2018 > > .Dt LIBBE 3 > > .Os > > .Sh NAME > > @@ -440,30 +440,49 @@ The > > .Fn be_prop_list_free > > function will free the property list. > > .Sh DIAGNOSTICS > > -Upon error, one of the following values will be returned. > > -.\" TODO: make each entry on its own line. > > -.Bd -ragged -offset indent > > -BE_ERR_SUCCESS, > > -BE_ERR_INVALIDNAME, > > -BE_ERR_EXISTS, > > -BE_ERR_NOENT, > > -BE_ERR_PERMS, > > -BE_ERR_DESTROYACT, > > -BE_ERR_DESTROYMNT, > > -BE_ERR_BADPATH, > > -BE_ERR_PATHBUSY, > > -BE_ERR_PATHLEN, > > -BE_ERR_BADMOUNT, > > -BE_ERR_NOORIGIN, > > -BE_ERR_MOUNTED, > > -BE_ERR_NOMOUNT, > > -BE_ERR_ZFSOPEN, > > -BE_ERR_ZFSCLONE, > > -BE_ERR_IO, > > -BE_ERR_NOPOOL, > > -BE_ERR_NOMEM, > > +Upon error, one of the following values will be returned: > > +.Bl -dash -offset indent -compact > > +.It > > +BE_ERR_SUCCESS > > +.It > > +BE_ERR_INVALIDNAME > > +.It > > +BE_ERR_EXISTS > > +.It > > +BE_ERR_NOENT > > +.It > > +BE_ERR_PERMS > > +.It > > +BE_ERR_DESTROYACT > > +.It > > +BE_ERR_DESTROYMNT > > +.It > > +BE_ERR_BADPATH > > +.It > > +BE_ERR_PATHBUSY > > +.It > > +BE_ERR_PATHLEN > > +.It > > +BE_ERR_BADMOUNT > > +.It > > +BE_ERR_NOORIGIN > > +.It > > +BE_ERR_MOUNTED > > +.It > > +BE_ERR_NOMOUNT > > +.It > > +BE_ERR_ZFSOPEN > > +.It > > +BE_ERR_ZFSCLONE > > +.It > > +BE_ERR_IO > > +.It > > +BE_ERR_NOPOOL > > +.It > > +BE_ERR_NOMEM > > +.It > > BE_ERR_UNKNOWN > > -.Ed > > +.El > > .Sh SEE ALSO > > .Xr be 1 > > .Sh HISTORY > > > > > > -- > Rod Grimes > rgri...@freebsd.org > > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r340722 - head/lib/libbe
> Author: 0mp (ports committer) > Date: Wed Nov 21 11:22:44 2018 > New Revision: 340722 > URL: https://svnweb.freebsd.org/changeset/base/340722 > > Log: > libbe(3): Put each error value in separate line. > > As requested by a TODO in the source code. > > Reviewed by:bcr > Approved by:krion (mentor, implicit), mat (mentor, implicit) > Differential Revision: https://reviews.freebsd.org/D18063 Who with a src bit approved the commit to src? > Modified: > head/lib/libbe/libbe.3 > > Modified: head/lib/libbe/libbe.3 > == > --- head/lib/libbe/libbe.3Wed Nov 21 06:36:15 2018(r340721) > +++ head/lib/libbe/libbe.3Wed Nov 21 11:22:44 2018(r340722) > @@ -28,7 +28,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd November 17, 2018 > +.Dd November 21, 2018 > .Dt LIBBE 3 > .Os > .Sh NAME > @@ -440,30 +440,49 @@ The > .Fn be_prop_list_free > function will free the property list. > .Sh DIAGNOSTICS > -Upon error, one of the following values will be returned. > -.\" TODO: make each entry on its own line. > -.Bd -ragged -offset indent > -BE_ERR_SUCCESS, > -BE_ERR_INVALIDNAME, > -BE_ERR_EXISTS, > -BE_ERR_NOENT, > -BE_ERR_PERMS, > -BE_ERR_DESTROYACT, > -BE_ERR_DESTROYMNT, > -BE_ERR_BADPATH, > -BE_ERR_PATHBUSY, > -BE_ERR_PATHLEN, > -BE_ERR_BADMOUNT, > -BE_ERR_NOORIGIN, > -BE_ERR_MOUNTED, > -BE_ERR_NOMOUNT, > -BE_ERR_ZFSOPEN, > -BE_ERR_ZFSCLONE, > -BE_ERR_IO, > -BE_ERR_NOPOOL, > -BE_ERR_NOMEM, > +Upon error, one of the following values will be returned: > +.Bl -dash -offset indent -compact > +.It > +BE_ERR_SUCCESS > +.It > +BE_ERR_INVALIDNAME > +.It > +BE_ERR_EXISTS > +.It > +BE_ERR_NOENT > +.It > +BE_ERR_PERMS > +.It > +BE_ERR_DESTROYACT > +.It > +BE_ERR_DESTROYMNT > +.It > +BE_ERR_BADPATH > +.It > +BE_ERR_PATHBUSY > +.It > +BE_ERR_PATHLEN > +.It > +BE_ERR_BADMOUNT > +.It > +BE_ERR_NOORIGIN > +.It > +BE_ERR_MOUNTED > +.It > +BE_ERR_NOMOUNT > +.It > +BE_ERR_ZFSOPEN > +.It > +BE_ERR_ZFSCLONE > +.It > +BE_ERR_IO > +.It > +BE_ERR_NOPOOL > +.It > +BE_ERR_NOMEM > +.It > BE_ERR_UNKNOWN > -.Ed > +.El > .Sh SEE ALSO > .Xr be 1 > .Sh HISTORY > > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
