Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-21 Thread John Baldwin
On 5/20/19 10:34 AM, Rodney W. Grimes wrote: >> On Sun, May 19, 2019 at 9:56 AM Yoshihiro Ota wrote: >> >>> I wonder if we can use a tool to confirm coding style like >>> clang-format or something else. >>> >> >> I don't know... it might be hard to do that inside a man page... > > Given the

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-20 Thread Rodney W. Grimes
> On Sun, May 19, 2019 at 9:56 AM Yoshihiro Ota wrote: > > > I wonder if we can use a tool to confirm coding style like > > clang-format or something else. > > > > I don't know... it might be hard to do that inside a man page... Given the current tooling I concur, so we need .include for

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-20 Thread Bruce Evans
On Sun, 19 May 2019, Warner Losh wrote: On Sun, May 19, 2019 at 9:56 AM Yoshihiro Ota wrote: I wonder if we can use a tool to confirm coding style like clang-format or something else. I don't know... it might be hard to do that inside a man page... Examples in man pages need special

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-20 Thread Warner Losh
On Sun, May 19, 2019 at 9:56 AM Yoshihiro Ota wrote: > I wonder if we can use a tool to confirm coding style like > clang-format or something else. > I don't know... it might be hard to do that inside a man page... Warner ___ svn-src-all@freebsd.org

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-19 Thread Benedict Reuschling
Am 19.05.19 um 11:54 schrieb Yoshihiro Ota: > I wonder if we can use a tool to confirm coding style like > clang-format or something else. > > I tried to setup clang-format and 2 others in the past like > a year ago but wasn't able to do... > We were discussing that a little bit at BSDCan.

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-19 Thread Yoshihiro Ota
I wonder if we can use a tool to confirm coding style like clang-format or something else. I tried to setup clang-format and 2 others in the past like a year ago but wasn't able to do... Hiro On Sat, 18 May 2019 06:06:51 -0700 (PDT) "Rodney W. Grimes" wrote: > > Hello Konstantin and Bruce, >

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-18 Thread Rodney W. Grimes
> Hello Konstantin and Bruce, > > thank you for your comments. Clearly, this should have been addressed in > the review and checked by a second pair of eyes. I mostly did the man > page changes and can't comment much on the actual coding example. Two > people (dab and jilles) approved the

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-18 Thread Konstantin Belousov
On Sat, May 18, 2019 at 08:39:03AM -0400, Benedict Reuschling wrote: > Hello Konstantin and Bruce, > > thank you for your comments. Clearly, this should have been addressed in > the review and checked by a second pair of eyes. I mostly did the man > page changes and can't comment much on the

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-18 Thread Benedict Reuschling
Hello Konstantin and Bruce, thank you for your comments. Clearly, this should have been addressed in the review and checked by a second pair of eyes. I mostly did the man page changes and can't comment much on the actual coding example. Two people (dab and jilles) approved the revision in the

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-18 Thread Bruce Evans
On Sat, 18 May 2019, Konstantin Belousov wrote: On Sat, May 18, 2019 at 03:15:08AM +, Benedict Reuschling wrote: Author: bcr (doc committer) Date: Sat May 18 03:15:07 2019 New Revision: 347951 URL: https://svnweb.freebsd.org/changeset/base/347951 Log: MFC r347617: Add small EXAMPLE

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-18 Thread Konstantin Belousov
On Sat, May 18, 2019 at 03:15:08AM +, Benedict Reuschling wrote: > Author: bcr (doc committer) > Date: Sat May 18 03:15:07 2019 > New Revision: 347951 > URL: https://svnweb.freebsd.org/changeset/base/347951 > > Log: > MFC r347617: > Add small EXAMPLE section to bsearch.3. > >