Re: svn commit: r305968 - head/etc/autofs
On Mon, Sep 19, 2016 at 10:19:04PM -0600, Warner Losh wrote: > For MSDOS it's one thing and likely helps. But for ufs it doesn't > help. Soft updates already does an excellent job at reducing wear and > all async does is give added danger of dataloss. Linux distros don't > matter for UFS because different design decisions have been made for > ext[234] and UFS. SU mount of UFS and unexpected media loast can caused kernel panic at next mount this media. async mount don't have such issuse. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305968 - head/etc/autofs
Good point; fixed. On 0919T2219, Warner Losh wrote: > For MSDOS it's one thing and likely helps. But for ufs it doesn't > help. Soft updates already does an excellent job at reducing wear and > all async does is give added danger of dataloss. Linux distros don't > matter for UFS because different design decisions have been made for > ext[234] and UFS. > > Warner > > On Mon, Sep 19, 2016 at 9:43 PM, Edward Tomasz Napierala > wrote: > > Mounting removable media async improves performance and reduces wear. > > And AFAIK that's what most Linux distros used to do. > > > > On 0919T2032, Ronald Klop wrote: > >> Hi, > >> > >> Your commit message says in words exactly what the diff says in code. > >> Would you like to elaborate on why the change is made? I'm curious > >> because this could cause severe damage to the filesystem on unclean eject > >> of the media. > >> > >> Regards, > >> Ronald. > >> > >> > >> On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala > >> wrote: > >> > >> > Author: trasz > >> > Date: Mon Sep 19 08:51:27 2016 > >> > New Revision: 305968 > >> > URL: https://svnweb.freebsd.org/changeset/base/305968 > >> > > >> > Log: > >> > Make autofs use the "async" flag for msdosfs and ufs filesystems > >> > mounted > >> > on /media. > >> > MFC after: 1 month > >> > > >> > Modified: > >> > head/etc/autofs/special_media > >> > > >> > Modified: head/etc/autofs/special_media > >> > == > >> > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 > >> > (r305967) > >> > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 > >> > (r305968) > >> > @@ -46,6 +46,8 @@ print_map_entry() { > >> > "Cannot mount ${_fstype} formatted device > >> > /dev/${_p}: Install > >> > sysutils/fusefs-ntfs first" > >> > exit 1 > >> > fi > >> > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then > >> > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" > >> > else > >> > echo "-fstype=${_fstype},nosuid :/dev/${_p}" > >> > fi > >> > ___ > >> > svn-src-all@freebsd.org mailing list > >> > https://lists.freebsd.org/mailman/listinfo/svn-src-all > >> > To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" > > > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305968 - head/etc/autofs
For MSDOS it's one thing and likely helps. But for ufs it doesn't help. Soft updates already does an excellent job at reducing wear and all async does is give added danger of dataloss. Linux distros don't matter for UFS because different design decisions have been made for ext[234] and UFS. Warner On Mon, Sep 19, 2016 at 9:43 PM, Edward Tomasz Napierala wrote: > Mounting removable media async improves performance and reduces wear. > And AFAIK that's what most Linux distros used to do. > > On 0919T2032, Ronald Klop wrote: >> Hi, >> >> Your commit message says in words exactly what the diff says in code. >> Would you like to elaborate on why the change is made? I'm curious >> because this could cause severe damage to the filesystem on unclean eject >> of the media. >> >> Regards, >> Ronald. >> >> >> On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala >> wrote: >> >> > Author: trasz >> > Date: Mon Sep 19 08:51:27 2016 >> > New Revision: 305968 >> > URL: https://svnweb.freebsd.org/changeset/base/305968 >> > >> > Log: >> > Make autofs use the "async" flag for msdosfs and ufs filesystems >> > mounted >> > on /media. >> > MFC after: 1 month >> > >> > Modified: >> > head/etc/autofs/special_media >> > >> > Modified: head/etc/autofs/special_media >> > == >> > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 >> > (r305967) >> > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 >> > (r305968) >> > @@ -46,6 +46,8 @@ print_map_entry() { >> > "Cannot mount ${_fstype} formatted device >> > /dev/${_p}: Install >> > sysutils/fusefs-ntfs first" >> > exit 1 >> > fi >> > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then >> > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" >> > else >> > echo "-fstype=${_fstype},nosuid :/dev/${_p}" >> > fi >> > ___ >> > svn-src-all@freebsd.org mailing list >> > https://lists.freebsd.org/mailman/listinfo/svn-src-all >> > To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305968 - head/etc/autofs
Mounting removable media async improves performance and reduces wear. And AFAIK that's what most Linux distros used to do. On 0919T2032, Ronald Klop wrote: > Hi, > > Your commit message says in words exactly what the diff says in code. > Would you like to elaborate on why the change is made? I'm curious > because this could cause severe damage to the filesystem on unclean eject > of the media. > > Regards, > Ronald. > > > On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala > wrote: > > > Author: trasz > > Date: Mon Sep 19 08:51:27 2016 > > New Revision: 305968 > > URL: https://svnweb.freebsd.org/changeset/base/305968 > > > > Log: > > Make autofs use the "async" flag for msdosfs and ufs filesystems > > mounted > > on /media. > > MFC after: 1 month > > > > Modified: > > head/etc/autofs/special_media > > > > Modified: head/etc/autofs/special_media > > == > > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 > > (r305967) > > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 > > (r305968) > > @@ -46,6 +46,8 @@ print_map_entry() { > > "Cannot mount ${_fstype} formatted device > > /dev/${_p}: Install > > sysutils/fusefs-ntfs first" > > exit 1 > > fi > > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then > > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" > > else > > echo "-fstype=${_fstype},nosuid :/dev/${_p}" > > fi > > ___ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305968 - head/etc/autofs
Hi, Your commit message says in words exactly what the diff says in code. Would you like to elaborate on why the change is made? I'm curious because this could cause severe damage to the filesystem on unclean eject of the media. Regards, Ronald. On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala wrote: Author: trasz Date: Mon Sep 19 08:51:27 2016 New Revision: 305968 URL: https://svnweb.freebsd.org/changeset/base/305968 Log: Make autofs use the "async" flag for msdosfs and ufs filesystems mounted on /media. MFC after: 1 month Modified: head/etc/autofs/special_media Modified: head/etc/autofs/special_media == --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 (r305967) +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 (r305968) @@ -46,6 +46,8 @@ print_map_entry() { "Cannot mount ${_fstype} formatted device /dev/${_p}: Install sysutils/fusefs-ntfs first" exit 1 fi + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" else echo "-fstype=${_fstype},nosuid:/dev/${_p}" fi ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org" ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r305968 - head/etc/autofs
Author: trasz Date: Mon Sep 19 08:51:27 2016 New Revision: 305968 URL: https://svnweb.freebsd.org/changeset/base/305968 Log: Make autofs use the "async" flag for msdosfs and ufs filesystems mounted on /media. MFC after:1 month Modified: head/etc/autofs/special_media Modified: head/etc/autofs/special_media == --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 (r305967) +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 (r305968) @@ -46,6 +46,8 @@ print_map_entry() { "Cannot mount ${_fstype} formatted device /dev/${_p}: Install sysutils/fusefs-ntfs first" exit 1 fi + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" else echo "-fstype=${_fstype},nosuid :/dev/${_p}" fi ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"