Re: svn commit: r305988 - in head/sys: geom sys
On 0920T0934, Ngie Cooper (yaneurabeya) wrote: > > > On Sep 20, 2016, at 09:28, Alan Somers wrote: > > > > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin wrote: > >> On 20.09.2016 09:20, Alan Somers wrote: > >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala > >>> wrote: > Author: trasz > Date: Mon Sep 19 17:46:15 2016 > New Revision: 305988 > URL: https://svnweb.freebsd.org/changeset/base/305988 > > Log: > Remove unused bio_taskqueue(). > > MFC after:1 month > > Modified: > head/sys/geom/geom_io.c > head/sys/sys/bio.h > > >>> > >>> This is a KBI change, so you should bump __FreeBSD_version. You > >>> probably shouldn't MFC it, either. > >> > >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old > >> ATA stack. Do you know any other? > > > > Nothing in-tree. But it's publicly visible, so we have no way of > > knowing who might be using it out-of-tree. > > I’d have to check, but this might impact us (Isilon). We don’t use the > __FreeBSD_version #ifdefs though in our code, so it’s fine from my > perspective to leave things alone. > > That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t > impacted by this change? Did it go through a ports -exp run? I'm not sure if it's worth it. If something comes up, I'll fix it. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305988 - in head/sys: geom sys
On 0920T1020, Alan Somers wrote: > On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala > wrote: > > Author: trasz > > Date: Mon Sep 19 17:46:15 2016 > > New Revision: 305988 > > URL: https://svnweb.freebsd.org/changeset/base/305988 > > > > Log: > > Remove unused bio_taskqueue(). > > > > MFC after:1 month > > > > Modified: > > head/sys/geom/geom_io.c > > head/sys/sys/bio.h > > > > This is a KBI change, so you should bump __FreeBSD_version. You > probably shouldn't MFC it, either. Done, thanks. I won't MFC it either. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305988 - in head/sys: geom sys
> On Sep 20, 2016, at 09:28, Alan Somers wrote: > > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin wrote: >> On 20.09.2016 09:20, Alan Somers wrote: >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala >>> wrote: Author: trasz Date: Mon Sep 19 17:46:15 2016 New Revision: 305988 URL: https://svnweb.freebsd.org/changeset/base/305988 Log: Remove unused bio_taskqueue(). MFC after:1 month Modified: head/sys/geom/geom_io.c head/sys/sys/bio.h >>> >>> This is a KBI change, so you should bump __FreeBSD_version. You >>> probably shouldn't MFC it, either. >> >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old >> ATA stack. Do you know any other? > > Nothing in-tree. But it's publicly visible, so we have no way of > knowing who might be using it out-of-tree. I’d have to check, but this might impact us (Isilon). We don’t use the __FreeBSD_version #ifdefs though in our code, so it’s fine from my perspective to leave things alone. That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t impacted by this change? Did it go through a ports -exp run? Thanks, -Ngie signature.asc Description: Message signed with OpenPGP using GPGMail
Re: svn commit: r305988 - in head/sys: geom sys
On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin wrote: > On 20.09.2016 09:20, Alan Somers wrote: >> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala >> wrote: >>> Author: trasz >>> Date: Mon Sep 19 17:46:15 2016 >>> New Revision: 305988 >>> URL: https://svnweb.freebsd.org/changeset/base/305988 >>> >>> Log: >>> Remove unused bio_taskqueue(). >>> >>> MFC after:1 month >>> >>> Modified: >>> head/sys/geom/geom_io.c >>> head/sys/sys/bio.h >>> >> >> This is a KBI change, so you should bump __FreeBSD_version. You >> probably shouldn't MFC it, either. > > The last/only consumer of this KPI I know gone with FreeBSD 9 and old > ATA stack. Do you know any other? > > -- > Alexander Motin Nothing in-tree. But it's publicly visible, so we have no way of knowing who might be using it out-of-tree. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305988 - in head/sys: geom sys
On 20.09.2016 09:20, Alan Somers wrote: > On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala > wrote: >> Author: trasz >> Date: Mon Sep 19 17:46:15 2016 >> New Revision: 305988 >> URL: https://svnweb.freebsd.org/changeset/base/305988 >> >> Log: >> Remove unused bio_taskqueue(). >> >> MFC after:1 month >> >> Modified: >> head/sys/geom/geom_io.c >> head/sys/sys/bio.h >> > > This is a KBI change, so you should bump __FreeBSD_version. You > probably shouldn't MFC it, either. The last/only consumer of this KPI I know gone with FreeBSD 9 and old ATA stack. Do you know any other? -- Alexander Motin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r305988 - in head/sys: geom sys
On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Mon Sep 19 17:46:15 2016 > New Revision: 305988 > URL: https://svnweb.freebsd.org/changeset/base/305988 > > Log: > Remove unused bio_taskqueue(). > > MFC after:1 month > > Modified: > head/sys/geom/geom_io.c > head/sys/sys/bio.h > This is a KBI change, so you should bump __FreeBSD_version. You probably shouldn't MFC it, either. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r305988 - in head/sys: geom sys
Author: trasz
Date: Mon Sep 19 17:46:15 2016
New Revision: 305988
URL: https://svnweb.freebsd.org/changeset/base/305988
Log:
Remove unused bio_taskqueue().
MFC after:1 month
Modified:
head/sys/geom/geom_io.c
head/sys/sys/bio.h
Modified: head/sys/geom/geom_io.c
==
--- head/sys/geom/geom_io.c Mon Sep 19 17:31:05 2016(r305987)
+++ head/sys/geom/geom_io.c Mon Sep 19 17:46:15 2016(r305988)
@@ -884,26 +884,6 @@ g_io_schedule_down(struct thread *tp __u
}
void
-bio_taskqueue(struct bio *bp, bio_task_t *func, void *arg)
-{
- bp->bio_task = func;
- bp->bio_task_arg = arg;
- /*
-* The taskqueue is actually just a second queue off the "up"
-* queue, so we use the same lock.
-*/
- g_bioq_lock(&g_bio_run_up);
- KASSERT(!(bp->bio_flags & BIO_ONQUEUE),
- ("Bio already on queue bp=%p target taskq", bp));
- bp->bio_flags |= BIO_ONQUEUE;
- TAILQ_INSERT_TAIL(&g_bio_run_task.bio_queue, bp, bio_queue);
- g_bio_run_task.bio_queue_length++;
- wakeup(&g_wait_up);
- g_bioq_unlock(&g_bio_run_up);
-}
-
-
-void
g_io_schedule_up(struct thread *tp __unused)
{
struct bio *bp;
Modified: head/sys/sys/bio.h
==
--- head/sys/sys/bio.h Mon Sep 19 17:31:05 2016(r305987)
+++ head/sys/sys/bio.h Mon Sep 19 17:46:15 2016(r305988)
@@ -151,8 +151,6 @@ void bioq_insert_head(struct bio_queue_h
void bioq_insert_tail(struct bio_queue_head *head, struct bio *bp);
void bioq_remove(struct bio_queue_head *head, struct bio *bp);
-void bio_taskqueue(struct bio *bp, bio_task_t *fund, void *arg);
-
intphysio(struct cdev *dev, struct uio *uio, int ioflag);
#define physread physio
#define physwrite physio
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
