Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-20 Thread Bruce Evans
On Mon, 19 Sep 2016, John Baldwin wrote: On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: Log: Move sys/capsicum.h includes after types.h or param.h This is not actually documented or even implied in

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Warner Losh
If you read style(9) as an annotated example of best practices, you'll see that it is actually documented there, but poorly. It's the first one after cdefs for the FreeBSD ID. It says to include one or the other, with the implication it's first. It's the common interpretation of the project (this

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Warner Losh
On Mon, Sep 19, 2016 at 2:43 PM, Conrad E. Meyer wrote: > Author: cem > Date: Mon Sep 19 20:43:03 2016 > New Revision: 305998 > URL: https://svnweb.freebsd.org/changeset/base/305998 > > Log: > Move sys/capsicum.h includes after types.h or param.h > > This is not actually

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Conrad Meyer
If you re-read the sentences you've pasted carefully, I think you'll find it doesn't actually say that the types or param headers come before other sys/ headers. Just that sys/ headers come before non-sys/ headers. Best, Conrad On Mon, Sep 19, 2016 at 1:45 PM, Ngie Cooper (yaneurabeya)

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Ngie Cooper (yaneurabeya)
> On Sep 19, 2016, at 2:22 PM, John Baldwin wrote: > > On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: >> >>> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: >>> >>> Author: cem >>> Date: Mon Sep 19 20:43:03 2016 >>> New Revision: 305998

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread John Baldwin
On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: > > > On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: > > > > Author: cem > > Date: Mon Sep 19 20:43:03 2016 > > New Revision: 305998 > > URL: https://svnweb.freebsd.org/changeset/base/305998 > > > > Log: > >

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Ngie Cooper (yaneurabeya)
> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: > > Author: cem > Date: Mon Sep 19 20:43:03 2016 > New Revision: 305998 > URL: https://svnweb.freebsd.org/changeset/base/305998 > > Log: > Move sys/capsicum.h includes after types.h or param.h > > This is not actually

svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Conrad E. Meyer
Author: cem Date: Mon Sep 19 20:43:03 2016 New Revision: 305998 URL: https://svnweb.freebsd.org/changeset/base/305998 Log: Move sys/capsicum.h includes after types.h or param.h This is not actually documented or even implied in style(9). Make the change to match convention. Someone