Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-22 Thread Matthew Macy
On Tue, May 22, 2018 at 00:33 Eitan Adler wrote: > On 21 May 2018 at 01:34, Matt Macy wrote: > > Author: mmacy > > Date: Mon May 21 08:34:10 2018 > > New Revision: 333968 > > URL: https://svnweb.freebsd.org/changeset/base/333968 > > > > Log: > >

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-22 Thread Eitan Adler
On 21 May 2018 at 01:34, Matt Macy wrote: > Author: mmacy > Date: Mon May 21 08:34:10 2018 > New Revision: 333968 > URL: https://svnweb.freebsd.org/changeset/base/333968 > > Log: > in(6)_mcast: Expand out vnet set / restore macro so that they work in a > conditional block

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matthew Macy
Looking closer I think the ifp should always be set. I'll just add an assert to that effect and make it non-conditional. -M On Mon, May 21, 2018 at 1:55 AM, Marko Zec wrote: > On Mon, 21 May 2018 08:34:10 + > Matt Macy wrote: > >> Author: mmacy >> Date: Mon

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matthew Macy
Sorry about that On Mon, May 21, 2018 at 04:59 Hans Petter Selasky wrote: > On 05/21/18 13:49, Ed Maste wrote: > > After r333968 the build is also broken on all archs but amd64 and i386. > > It looks like amd64 and i386 build with VIMAGE enabled by default, while > the others

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Hans Petter Selasky
On 05/21/18 13:49, Ed Maste wrote: After r333968 the build is also broken on all archs but amd64 and i386. It looks like amd64 and i386 build with VIMAGE enabled by default, while the others not. 12-current. So both VIMAGE and non-VIMAGE should be tested. --HPS

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Ed Maste
On 21 May 2018 at 04:55, Marko Zec wrote: > On Mon, 21 May 2018 08:34:10 + > Matt Macy wrote: > >> Author: mmacy >> Date: Mon May 21 08:34:10 2018 >> New Revision: 333968 >> URL: https://svnweb.freebsd.org/changeset/base/333968 >> >> Log: >> in(6)_mcast:

Re: svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Marko Zec
On Mon, 21 May 2018 08:34:10 + Matt Macy wrote: > Author: mmacy > Date: Mon May 21 08:34:10 2018 > New Revision: 333968 > URL: https://svnweb.freebsd.org/changeset/base/333968 > > Log: > in(6)_mcast: Expand out vnet set / restore macro so that they work > in a

svn commit: r333968 - in head/sys: netinet netinet6

2018-05-21 Thread Matt Macy
Author: mmacy Date: Mon May 21 08:34:10 2018 New Revision: 333968 URL: https://svnweb.freebsd.org/changeset/base/333968 Log: in(6)_mcast: Expand out vnet set / restore macro so that they work in a conditional block Reported by: zec at fer.hr Modified: head/sys/netinet/in_mcast.c