Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Kostik Belousov
On Tue, Aug 31, 2010 at 11:17:05PM +0200, Dimitry Andric wrote: > Indeed, any subtraction is only in "u_char *p = (u_char *)PTOV(0);". If > you prefer, I will revert to the old expression, or maybe we could use > John's suggestion of: > > return (*(u_char *)PTOV(0x401) * 128 * 1024 + >

svn commit: r212081 - head/sys/dev/ata/chipsets

2010-08-31 Thread Alexander Motin
Author: mav Date: Wed Sep 1 06:43:41 2010 New Revision: 212081 URL: http://svn.freebsd.org/changeset/base/212081 Log: Increase device reset timeout from 10 to 15 seconds, same as in ahci(4). Some devices found need about 10-12 seconds to spinup. Modified: head/sys/dev/ata/chipsets/ata-ahci

svn commit: r212079 - head/sys/fs/ext2fs

2010-08-31 Thread Ulf Lilleengen
Author: lulf Date: Wed Sep 1 05:34:17 2010 New Revision: 212079 URL: http://svn.freebsd.org/changeset/base/212079 Log: - Remove duplicate comment. PR: kern/148820 Submitted by: pluknet Modified: head/sys/fs/ext2fs/ext2_alloc.c Modified: head/sys/fs/ext2fs/ext2_alloc.c

svn commit: r212078 - head/lib/libthr/thread

2010-08-31 Thread David Xu
Author: davidxu Date: Wed Sep 1 03:55:10 2010 New Revision: 212078 URL: http://svn.freebsd.org/changeset/base/212078 Log: pthread_atfork should acquire writer lock and protect the code with critical region. Modified: head/lib/libthr/thread/thr_fork.c Modified: head/lib/libthr/thread/thr_f

svn commit: r212077 - head/lib/libthr/thread

2010-08-31 Thread David Xu
Author: davidxu Date: Wed Sep 1 03:11:21 2010 New Revision: 212077 URL: http://svn.freebsd.org/changeset/base/212077 Log: Change atfork lock from mutex to rwlock, also make mutexes used by malloc() module private type, when private type mutex is locked/unlocked, thread critical region is en

svn commit: r212076 - head/lib/libthr/thread

2010-08-31 Thread David Xu
Author: davidxu Date: Wed Sep 1 02:18:33 2010 New Revision: 212076 URL: http://svn.freebsd.org/changeset/base/212076 Log: Add signal handler wrapper, the reason to add it becauses there are some cases we want to improve: 1) if a thread signal got a signal while in cancellation point,

svn commit: r212075 - head/sys/kern

2010-08-31 Thread David Xu
Author: davidxu Date: Wed Sep 1 01:26:07 2010 New Revision: 212075 URL: http://svn.freebsd.org/changeset/base/212075 Log: rescure comments from RELENG_4. Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c ===

Re: svn commit: r212047 - head/sys/kern

2010-08-31 Thread David Xu
Jilles Tjoelker wrote: On Tue, Aug 31, 2010 at 07:15:50AM +, David Xu wrote: Author: davidxu Date: Tue Aug 31 07:15:50 2010 New Revision: 212047 URL: http://svn.freebsd.org/changeset/base/212047 Log: If a process is being debugged, skips job control caused by SIGSTOP/SIGCONT signals,

svn commit: r212074 - head/lib/libjail

2010-08-31 Thread Jamie Gritton
Author: jamie Date: Tue Aug 31 23:14:03 2010 New Revision: 212074 URL: http://svn.freebsd.org/changeset/base/212074 Log: Whitespace and comment fixes. MFC after:3 days Modified: head/lib/libjail/jail.c Modified: head/lib/libjail/jail.c ===

Re: svn commit: r212050 - head/cddl/contrib/opensolaris/cmd/zpool

2010-08-31 Thread Philip M. Gollucci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Nice! On 08/31/10 10:41, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Tue Aug 31 10:41:53 2010 > New Revision: 212050 > URL: http://svn.freebsd.org/changeset/base/212050 > > Log: > When upgrading a pool which contain root file system, give us

svn commit: r212073 - head/lib/libjail

2010-08-31 Thread Jamie Gritton
Author: jamie Date: Tue Aug 31 21:50:09 2010 New Revision: 212073 URL: http://svn.freebsd.org/changeset/base/212073 Log: Don't over-allocate array values in jailparam_export. Fix a little comment typo. MFC after:3 days Modified: head/lib/libjail/jail.c Modified: head/lib/libjail/j

svn commit: r212072 - head/lib/libjail

2010-08-31 Thread Jamie Gritton
Author: jamie Date: Tue Aug 31 21:48:45 2010 New Revision: 212072 URL: http://svn.freebsd.org/changeset/base/212072 Log: Make it clear in the example that jailparam_export's return value should be freed. MFC after:3 days Modified: head/lib/libjail/jail.3 Modified: head/lib/libjail

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Dimitry Andric
On 2010-08-31 22:33, Kostik Belousov wrote: > Going into this mode, can you cite the spell that makes the NULL to > not point to anything ? There is 6.3.2.3, > > If a null pointer constant is converted to a pointer type, the resulting > pointer,

svn commit: r212071 - head/sys/dev/bge

2010-08-31 Thread Pyun YongHyeon
Author: yongari Date: Tue Aug 31 20:56:18 2010 New Revision: 212071 URL: http://svn.freebsd.org/changeset/base/212071 Log: Remove unnecessary atomic operation in bge_poll. bge(4) always holds a driver lock in the function entry and memory synchronization is handled by bus_dmamap_sync(9). Mo

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Kostik Belousov
On Tue, Aug 31, 2010 at 10:11:15PM +0200, Dimitry Andric wrote: > On 2010-08-31 21:51, Kostik Belousov wrote: > > What is the undefined behaviour you are claiming there ? > > Arithmetic on a NULL pointer, which is undefined. The C standard says > in 6.5.6 (additive operators): > > 3. For subtrac

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread John Baldwin
On Tuesday, August 31, 2010 3:53:54 pm Dimitry Andric wrote: > On 2010-08-31 21:37, John Baldwin wrote: > >> -return *(p + 0x401) * 128 * 1024 + *(u_int16_t *)(p + 0x594) * 1024 * 1024; > >> +return *p * 128 * 1024 + *(u_int16_t *)(p + (0x594 - 0x401)) * 1024 * 1024; > >> } > > > > Perh

svn commit: r212070 - head/sys/dev/fb

2010-08-31 Thread Jung-uk Kim
Author: jkim Date: Tue Aug 31 20:21:52 2010 New Revision: 212070 URL: http://svn.freebsd.org/changeset/base/212070 Log: Make sure the interrupt entry point is within the video ROM range. We must not change interrupt vector if it is not pointing the ROM itself. Actually, we just fail shadow

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Dimitry Andric
On 2010-08-31 21:51, Kostik Belousov wrote: > What is the undefined behaviour you are claiming there ? Arithmetic on a NULL pointer, which is undefined. The C standard says in 6.5.6 (additive operators): 3. For subtraction, one of the following shall hold: — both operands have arithmetic type

svn commit: r212069 - head/sys/dev/bge

2010-08-31 Thread Pyun YongHyeon
Author: yongari Date: Tue Aug 31 19:59:18 2010 New Revision: 212069 URL: http://svn.freebsd.org/changeset/base/212069 Log: bge_txeof() already checks whether it has to free transmitted mbufs or not by comparing reported TX consumer index with saved index. So remove unnecessary check done aft

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Dimitry Andric
On 2010-08-31 21:37, John Baldwin wrote: >> -return *(p + 0x401) * 128 * 1024 + *(u_int16_t *)(p + 0x594) * 1024 * >> 1024; >> +return *p * 128 * 1024 + *(u_int16_t *)(p + (0x594 - 0x401)) * 1024 * >> 1024; >> } > > Perhaps replace '(p + 0x594 - 0x401)' with just 'PTOV(0x594)'? > > I w

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Kostik Belousov
On Tue, Aug 31, 2010 at 06:11:50PM +, Dimitry Andric wrote: > Author: dim > Date: Tue Aug 31 18:11:50 2010 > New Revision: 212064 > URL: http://svn.freebsd.org/changeset/base/212064 > > Log: > Avoid directly manipulating a NULL pointer (which could result in > undefined behaviour) in sys/b

Re: svn commit: r212066 - in head/sys/boot/i386: efi loader zfsloader

2010-08-31 Thread Alexander Best
On Tue Aug 31 10, Xin LI wrote: > Author: delphij > Date: Tue Aug 31 19:01:12 2010 > New Revision: 212066 > URL: http://svn.freebsd.org/changeset/base/212066 > > Log: > For consistency, change all 'i386' and MACHINE_ARCH to x86. > > Reviewed by:jhb > MFC after: 1 week > > Modifi

Re: svn commit: r212061 - head/sys/dev/bge

2010-08-31 Thread John Baldwin
On Tuesday, August 31, 2010 1:54:49 pm Matthew Jacob wrote: > But not amd64 please. > > > Keep in mind the PAE case where you cannot effectively specify a 4GB > > boundary. I used a 2GB boundary for twa(4) in the PAE case to deal > > with the boundary issue. Probably though, bus_dma should jus

Re: svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread John Baldwin
On Tuesday, August 31, 2010 2:11:50 pm Dimitry Andric wrote: > Author: dim > Date: Tue Aug 31 18:11:50 2010 > New Revision: 212064 > URL: http://svn.freebsd.org/changeset/base/212064 > > Log: > Avoid directly manipulating a NULL pointer (which could result in > undefined behaviour) in sys/boot

svn commit: r212067 - head/cddl/contrib/opensolaris/cmd/zpool

2010-08-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Aug 31 19:01:46 2010 New Revision: 212067 URL: http://svn.freebsd.org/changeset/base/212067 Log: Eliminate confusing while () loop. In the first version of the code it was there to avoid gotos, but in the current version it serves no purpose. MFC after:2 weeks M

svn commit: r212066 - in head/sys/boot/i386: efi loader zfsloader

2010-08-31 Thread Xin LI
Author: delphij Date: Tue Aug 31 19:01:12 2010 New Revision: 212066 URL: http://svn.freebsd.org/changeset/base/212066 Log: For consistency, change all 'i386' and MACHINE_ARCH to x86. Reviewed by: jhb MFC after:1 week Modified: head/sys/boot/i386/efi/Makefile head/sys/boot/i386/l

svn commit: r212065 - head/sys/dev/bge

2010-08-31 Thread Pyun YongHyeon
Author: yongari Date: Tue Aug 31 18:48:09 2010 New Revision: 212065 URL: http://svn.freebsd.org/changeset/base/212065 Log: Handle PAE case correctly. You cannot effectively specify a 4GB boundary in PAE case so use a 2GB boundary for PAE as suggested by jhb. Pointed out by: jhb

Re: svn commit: r212047 - head/sys/kern

2010-08-31 Thread Jilles Tjoelker
On Tue, Aug 31, 2010 at 07:15:50AM +, David Xu wrote: > Author: davidxu > Date: Tue Aug 31 07:15:50 2010 > New Revision: 212047 > URL: http://svn.freebsd.org/changeset/base/212047 > Log: > If a process is being debugged, skips job control caused by SIGSTOP/SIGCONT > signals, because it is

svn commit: r212064 - head/sys/boot/pc98/boot2

2010-08-31 Thread Dimitry Andric
Author: dim Date: Tue Aug 31 18:11:50 2010 New Revision: 212064 URL: http://svn.freebsd.org/changeset/base/212064 Log: Avoid directly manipulating a NULL pointer (which could result in undefined behaviour) in sys/boot/pc98/boot2/boot2.c. Reviewed by: nyan Approved by: rpaulo (mentor)

Re: svn commit: r212061 - head/sys/dev/bge

2010-08-31 Thread Matthew Jacob
But not amd64 please. Keep in mind the PAE case where you cannot effectively specify a 4GB boundary. I used a 2GB boundary for twa(4) in the PAE case to deal with the boundary issue. Probably though, bus_dma should just always enforce a 4GB boundary, at least on x86. __

Re: svn commit: r212061 - head/sys/dev/bge

2010-08-31 Thread John Baldwin
On Tuesday, August 31, 2010 1:33:48 pm Pyun YongHyeon wrote: > Author: yongari > Date: Tue Aug 31 17:33:48 2010 > New Revision: 212061 > URL: http://svn.freebsd.org/changeset/base/212061 > > Log: > Split common parent DMA tag into ring DMA tag and TX/RX mbuf DMA > tag. All controllers that are

svn commit: r212063 - head/sys/vm

2010-08-31 Thread Matthew D Fleming
Author: mdf Date: Tue Aug 31 17:43:47 2010 New Revision: 212063 URL: http://svn.freebsd.org/changeset/base/212063 Log: Have memguard(9) crash with an easier-to-debug message on double-free. Reviewed by:zml MFC after: 3 weeks Modified: head/sys/vm/memguard.c Modified: head/sys

svn commit: r212062 - head/sys/boot/pc98/boot2

2010-08-31 Thread Dimitry Andric
Author: dim Date: Tue Aug 31 17:38:20 2010 New Revision: 212062 URL: http://svn.freebsd.org/changeset/base/212062 Log: Always compile pc98 boot2 with gcc instead of clang, just as with i386 boot2. Unfortunately both still are too big when compiled with clang. Reviewed by: nyan Approve

svn commit: r212061 - head/sys/dev/bge

2010-08-31 Thread Pyun YongHyeon
Author: yongari Date: Tue Aug 31 17:33:48 2010 New Revision: 212061 URL: http://svn.freebsd.org/changeset/base/212061 Log: Split common parent DMA tag into ring DMA tag and TX/RX mbuf DMA tag. All controllers that are not BCM5755 or higher have 4GB boundary DMA bug. Previously bge(4) used 32

svn commit: r212060 - in head: gnu/lib/libobjc sys/boot/i386/boot2

2010-08-31 Thread Dimitry Andric
Author: dim Date: Tue Aug 31 17:33:29 2010 New Revision: 212060 URL: http://svn.freebsd.org/changeset/base/212060 Log: Use a more robust way to substitute gcc for clang, when compiling gnu/lib/libobjc and sys/boot/i386/boot2, so it also works when using absolute paths and/or options, as in C

svn commit: r212058 - in head/sys: kern vm

2010-08-31 Thread Matthew D Fleming
Author: mdf Date: Tue Aug 31 16:57:58 2010 New Revision: 212058 URL: http://svn.freebsd.org/changeset/base/212058 Log: The realloc case for memguard(9) will copy too many bytes when reallocating to a smaller-sized allocation. Fix this issue. Noticed by: alc Reviewed by:alc Ap

svn commit: r212054 - in head/sys: conf powerpc/aim powerpc/booke powerpc/include powerpc/mpc85xx powerpc/powermac powerpc/powerpc

2010-08-31 Thread Nathan Whitehorn
Author: nwhitehorn Date: Tue Aug 31 15:27:46 2010 New Revision: 212054 URL: http://svn.freebsd.org/changeset/base/212054 Log: Restructure how reset and poweroff are handled on PowerPC systems, since the existing code was very platform specific, and broken for SMP systems trying to reboot fro

svn commit: r212053 - head/sys/powerpc/aim

2010-08-31 Thread Nathan Whitehorn
Author: nwhitehorn Date: Tue Aug 31 15:22:09 2010 New Revision: 212053 URL: http://svn.freebsd.org/changeset/base/212053 Log: Remove some code made obsolete by the powerpc64 import. Deleted: head/sys/powerpc/aim/trap_subr.S ___ svn-src-head@freebsd.

svn commit: r212052 - head/sbin/hastd

2010-08-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Aug 31 12:05:13 2010 New Revision: 212052 URL: http://svn.freebsd.org/changeset/base/212052 Log: Include process PID in log messages. Submitted by: Mikolaj Golub MFC after:2 weeks Modified: head/sbin/hastd/pjdlog.c Modified: head/sbin/hastd/pjdlog.c

svn commit: r212051 - head/sbin/hastd

2010-08-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Aug 31 12:03:29 2010 New Revision: 212051 URL: http://svn.freebsd.org/changeset/base/212051 Log: Correct error message. Submitted by: Mikolaj Golub MFC after:2 weeks Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

svn commit: r212050 - head/cddl/contrib/opensolaris/cmd/zpool

2010-08-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Aug 31 10:41:53 2010 New Revision: 212050 URL: http://svn.freebsd.org/changeset/base/212050 Log: When upgrading a pool which contain root file system, give user a hint that he should update boot code. MFC after:2 weeks Modified: head/cddl/contrib/opensolaris/c

svn commit: r212049 - head/sbin/hastd

2010-08-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Aug 31 09:38:43 2010 New Revision: 212049 URL: http://svn.freebsd.org/changeset/base/212049 Log: Forgot to add event.c and event.h in r212038. Pointed out by: pluknet MFC after:2 weeks Obtained from:Wheel Systems Sp. z o.o. http://www.wheelsystem

svn commit: r212048 - in head: usr.bin/usbhidaction usr.sbin/apmd

2010-08-31 Thread Kevin Lo
Author: kevlo Date: Tue Aug 31 07:19:10 2010 New Revision: 212048 URL: http://svn.freebsd.org/changeset/base/212048 Log: For consistency, cast result of getpid() to long Modified: head/usr.bin/usbhidaction/usbhidaction.c head/usr.sbin/apmd/apmd.c Modified: head/usr.bin/usbhidaction/usbhida

svn commit: r212047 - head/sys/kern

2010-08-31 Thread David Xu
Author: davidxu Date: Tue Aug 31 07:15:50 2010 New Revision: 212047 URL: http://svn.freebsd.org/changeset/base/212047 Log: If a process is being debugged, skips job control caused by SIGSTOP/SIGCONT signals, because it is managed by debugger, however a normal signal sent to a interruptibly s