Re: svn commit: r223637 - in head: . contrib/pf/authpf contrib/pf/ftp-proxy contrib/pf/man contrib/pf/pfctl contrib/pf/pflogd sbin/pflogd sys/conf sys/contrib/altq/altq sys/contrib/pf/net sys/modules

2011-12-15 Thread Gleb Smirnoff
Peter, On Fri, Dec 16, 2011 at 01:58:51PM +1100, Peter Jeremy wrote: P> On 2011-Jun-28 11:57:25 +, "Bjoern A. Zeeb" wrote: P> >Author: bz P> >Date: Tue Jun 28 11:57:25 2011 P> >New Revision: 223637 P> >URL: http://svn.freebsd.org/changeset/base/223637 P> > P> >Log: P> > Update packet filte

Re: svn commit: r223637 - in head: . contrib/pf/authpf contrib/pf/ftp-proxy contrib/pf/man contrib/pf/pfctl contrib/pf/pflogd sbin/pflogd sys/conf sys/contrib/altq/altq sys/contrib/pf/net sys/modules

2011-12-15 Thread Peter Jeremy
On 2011-Jun-28 11:57:25 +, "Bjoern A. Zeeb" wrote: >Author: bz >Date: Tue Jun 28 11:57:25 2011 >New Revision: 223637 >URL: http://svn.freebsd.org/changeset/base/223637 > >Log: > Update packet filter (pf) code to OpenBSD 4.5. Further to my mail last Wednesday, I've found nested "#ifdef __Free

svn commit: r228561 - in head: share/man/man4 sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/firmware sys/modules/cxgbe sys/modules/cxgbe/firmware tools/tools/cxgbetool

2011-12-15 Thread Navdeep Parhar
Author: np Date: Fri Dec 16 02:09:51 2011 New Revision: 228561 URL: http://svn.freebsd.org/changeset/base/228561 Log: Many updates to cxgbe(4) - Device configuration via plain text config file. Also able to operate when not attached to the chip as the master driver. - Generic "wor

svn commit: r228560 - head/sys/fs/nfsserver

2011-12-15 Thread Rick Macklem
Author: rmacklem Date: Fri Dec 16 00:58:41 2011 New Revision: 228560 URL: http://svn.freebsd.org/changeset/base/228560 Log: Patch the new NFS server in a manner analagous to r228520 for the old NFS server, so that it correctly handles a count == 0 argument for Commit. PR: kern

svn commit: r228559 - head/contrib/telnet/libtelnet

2011-12-15 Thread Dimitry Andric
Author: dim Date: Fri Dec 16 00:48:53 2011 New Revision: 228559 URL: http://svn.freebsd.org/changeset/base/228559 Log: In contrib/telnet/libtelnet/sra.c, use the correct number of bytes to zero the password buffer. MFC after:1 week Modified: head/contrib/telnet/libtelnet/sra.c Mod

svn commit: r228558 - head/lib/libsm

2011-12-15 Thread Dimitry Andric
Author: dim Date: Fri Dec 16 00:39:44 2011 New Revision: 228558 URL: http://svn.freebsd.org/changeset/base/228558 Log: Unfortunately, clang gives a warning about sendmail code that cannot be turned off yet. Since this is contrib code, and we don't really care about the warnings, just turn m

svn commit: r228557 - head/lib/libpmc

2011-12-15 Thread Dimitry Andric
Author: dim Date: Fri Dec 16 00:13:43 2011 New Revision: 228557 URL: http://svn.freebsd.org/changeset/base/228557 Log: In lib/libpmc/libpmc.c, struct pmc_cputype_map's pm_cputype field should be of type 'enum pmc_cputype', not 'enum pmc_class'. MFC after:1 week Modified: head/lib/l

svn commit: r228556 - head/sys/dev/aic7xxx/aicasm

2011-12-15 Thread Dimitry Andric
Author: dim Date: Fri Dec 16 00:04:28 2011 New Revision: 228556 URL: http://svn.freebsd.org/changeset/base/228556 Log: Add "%option noinput" to aicasm_scan.l and aicasm_macro_scan.l, so no unneeded input functions will be emitted. Spotted by: arundel MFC after:1 week Modified:

svn commit: r228555 - head/lib/libipsec

2011-12-15 Thread Dimitry Andric
Author: dim Date: Fri Dec 16 00:01:19 2011 New Revision: 228555 URL: http://svn.freebsd.org/changeset/base/228555 Log: In lib/libipsec/policy_token.l, use lex's standard "%option noinput" instead of hand-defining the YY_NO_INPUT macro. MFC after:1 week Modified: head/lib/libipsec/p

svn commit: r228554 - head/sys/contrib/ngatm/netnatm/msg

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 23:47:36 2011 New Revision: 228554 URL: http://svn.freebsd.org/changeset/base/228554 Log: In sys/contrib/ngatm/netnatm/msg/uni_ie.c, use a more appropriate way to tell the compiler some parameters are purposefully unused. MFC after:1 week Modified: head

Re: svn commit: r228552 - head/lib/libipsec

2011-12-15 Thread Alexander Best
On Thu Dec 15 11, Dimitry Andric wrote: > Author: dim > Date: Thu Dec 15 23:22:24 2011 > New Revision: 228552 > URL: http://svn.freebsd.org/changeset/base/228552 > > Log: > Define YY_NO_INPUT in lib/libipsec/policy_token.l, so lex's input() > function does not get defined needlessly. could su

svn commit: r228553 - head/contrib/file

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 23:28:17 2011 New Revision: 228553 URL: http://svn.freebsd.org/changeset/base/228553 Log: In contrib/file/softmagic.c, fix a potential format string security problem. (This fix has already been applied upstream, but we do not have the latest version of file in t

svn commit: r228552 - head/lib/libipsec

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 23:22:24 2011 New Revision: 228552 URL: http://svn.freebsd.org/changeset/base/228552 Log: Define YY_NO_INPUT in lib/libipsec/policy_token.l, so lex's input() function does not get defined needlessly. MFC after:1 week Modified: head/lib/libipsec/policy_t

svn commit: r228551 - head/share/mk

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 23:13:57 2011 New Revision: 228551 URL: http://svn.freebsd.org/changeset/base/228551 Log: Disable one more clang warning when WARNS <= 3. MFC after:1 week Modified: head/share/mk/bsd.sys.mk Modified: head/share/mk/bsd.sys.mk =

svn commit: r228550 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 23:06:46 2011 New Revision: 228550 URL: http://svn.freebsd.org/changeset/base/228550 Log: In cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c, the dt_popc() function assumes that either _ILP32 or _LP64 is defined, otherwise it has no suitable implementatio

svn commit: r228549 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 22:46:04 2011 New Revision: 228549 URL: http://svn.freebsd.org/changeset/base/228549 Log: In cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c, use the correct printf format for a key_t (aka long). MFC after:1 week Modified: head/cddl/contrib/open

svn commit: r228548 - head/cddl/contrib/opensolaris/lib/libdtrace/i386

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 22:37:33 2011 New Revision: 228548 URL: http://svn.freebsd.org/changeset/base/228548 Log: In cddl/contrib/opensolaris/lib/libdtrace/i386/dt_isadep.c, use the correct printf format for an unsigned long. MFC after:1 week Modified: head/cddl/contrib/openso

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Adrian Chadd
On 15 December 2011 02:15, Bernhard Schmidt wrote: >> So in short: if you're happy removing it, remove it. :) > > I agree on passing the frame as an argument to iac_check() and obtain > the mac from there, that definitely is required for more advanced > ACLs. Passing both tough, is imho not requi

svn commit: r228547 - head/cddl/contrib/opensolaris/lib/libdtrace/common

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 22:10:27 2011 New Revision: 228547 URL: http://svn.freebsd.org/changeset/base/228547 Log: Cast away a clang alignment warning in drti.c's fixsymbol() function. This code only runs on i386 and amd64, so there should be no problems if buf + sec->dofs_offset is not

svn commit: r228546 - head/share/mk

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 22:08:08 2011 New Revision: 228546 URL: http://svn.freebsd.org/changeset/base/228546 Log: Clang has more warnings enabled by default, and when using -Wall, so if WARNS is set to low values, some of them have to be disabled explicitly. MFC after:1 week Mod

svn commit: r228545 - head/lib/libutil

2011-12-15 Thread Baptiste Daroussin
Author: bapt (ports committer) Date: Thu Dec 15 22:07:36 2011 New Revision: 228545 URL: http://svn.freebsd.org/changeset/base/228545 Log: Modify pw_copy: - if pw is NULL and oldpw is not NULL then the oldpw is deleted - if pw->pw_name != oldpw->pw_name but pw->pw_uid == oldpw->pw_uid then

svn commit: r228544 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:05:23 2011 New Revision: 228544 URL: http://svn.freebsd.org/changeset/base/228544 Log: Remove redundant assignment. Found by: Clang Static Analyzer MFC after:1 week Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

svn commit: r228543 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:03:17 2011 New Revision: 228543 URL: http://svn.freebsd.org/changeset/base/228543 Log: Simplify code by changing functions types from int to avoid, as the functions always return 0. Found by: Clang Static Analyzer MFC after:1 week Modified: hea

svn commit: r228542 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:01:34 2011 New Revision: 228542 URL: http://svn.freebsd.org/changeset/base/228542 Log: Remove redundant setting of the error variable. Found by: Clang Static Analyzer MFC after:1 week Modified: head/sbin/hastd/control.c Modified: head/sbin/hastd

Re: svn commit: r228541 - head/etc/rc.d

2011-12-15 Thread Doug Barton
On 12/15/2011 13:06, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Thu Dec 15 21:06:37 2011 > New Revision: 228541 > URL: http://svn.freebsd.org/changeset/base/228541 > > Log: > - Put one file into one line. This makes keeping local changes and merging > with FreeBSD easier for vendors. >

svn commit: r228541 - head/etc/rc.d

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 21:06:37 2011 New Revision: 228541 URL: http://svn.freebsd.org/changeset/base/228541 Log: - Put one file into one line. This makes keeping local changes and merging with FreeBSD easier for vendors. - For optional files use variables starting with underscore.

svn commit: r228540 - head/lib/libc/stdlib

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 20:40:11 2011 New Revision: 228540 URL: http://svn.freebsd.org/changeset/base/228540 Log: Since clang does not support the tls_model attribute used in malloc.c yet (see LLVM PR 9788), and warns about it, rub it out for now. When clang grows support for this attr

svn commit: r228539 - head/sys/fs/ext2fs

2011-12-15 Thread Pedro F. Giffuni
Author: pfg Date: Thu Dec 15 20:31:18 2011 New Revision: 228539 URL: http://svn.freebsd.org/changeset/base/228539 Log: Bring in reallocblk to ext2fs. The feature has been standard for a while in UFS as a means to reduce fragmentation, therefore maintaining consistent performance with fi

svn commit: r228538 - head/lib/libc/rpc

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 20:27:36 2011 New Revision: 228538 URL: http://svn.freebsd.org/changeset/base/228538 Log: In lib/libc/rpc/crypt_client.c, fix a clang warning about an implicit conversion between enum desdir/desmode from include/rpc/des.h, and enum desdir/desmode from include/rpc

svn commit: r228537 - head/lib/libc/resolv

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 20:10:12 2011 New Revision: 228537 URL: http://svn.freebsd.org/changeset/base/228537 Log: Remove meaningless self-assignment in res_send.c, otherwise clang will warn about it. I guess this was originally done to silence a bogus warning by an older version of gcc

svn commit: r228536 - in head/lib/libthr/arch: amd64/include i386/include

2011-12-15 Thread Dimitry Andric
Author: dim Date: Thu Dec 15 19:42:25 2011 New Revision: 228536 URL: http://svn.freebsd.org/changeset/base/228536 Log: The TCB_GET32() and TCB_GET64() macros in the i386 and amd64-specific versions of pthread_md.h have a special case of dereferencing a null pointer. Clang warns about this w

Re: svn commit: r228495 - head/sys/sys

2011-12-15 Thread David Schultz
On Thu, Dec 15, 2011, Ed Schouten wrote: > Hello Bruce, > > * Bruce Evans , 20111215 15:12: > >- recently broken for K&R since it now uses signed instead of __signed > >- broken for longer for K&R and C90 since it uses long long. In working > > v

svn commit: r228535 - head/sys/i386/i386

2011-12-15 Thread Alan Cox
Author: alc Date: Thu Dec 15 17:54:23 2011 New Revision: 228535 URL: http://svn.freebsd.org/changeset/base/228535 Log: Simplify the implementation of the identity mapping in start_all_aps(). Since mpboot.s enables processor support for PG_PS before enabling paging, there is no reason that th

svn commit: r228533 - head/sys/kern

2011-12-15 Thread John Baldwin
Author: jhb Date: Thu Dec 15 15:17:19 2011 New Revision: 228533 URL: http://svn.freebsd.org/changeset/base/228533 Log: Use vm_mmap_to_errno(). Submitted by: kib Modified: head/sys/kern/uipc_shm.c Modified: head/sys/kern/uipc_shm.c

Re: svn commit: r228520 - head/sys/nfsserver

2011-12-15 Thread John Baldwin
On Wednesday, December 14, 2011 9:26:54 pm Xin LI wrote: > Author: delphij > Date: Thu Dec 15 02:26:53 2011 > New Revision: 228520 > URL: http://svn.freebsd.org/changeset/base/228520 > > Log: > Honor NFSv3 commit call (RFC 1813, Section 3.3.21) where when count is 0, > the full length from off

Re: svn commit: r228495 - head/sys/sys

2011-12-15 Thread Ed Schouten
Hello Bruce, * Bruce Evans , 20111215 15:12: > The 2 bugs are: > 1. Even __offsetof() is broken in the fallback case (that's all cases >where it uses a struct like the above and doesn't use a gccish builtin). >This is because __offsetof() uses size_t, but size_t is n

Re: svn commit: r228495 - head/sys/sys

2011-12-15 Thread Bruce Evans
On Thu, 15 Dec 2011, Ed Schouten wrote: Hello Bruce, After reading through your email, I think it's best to fix things using the following patch. Essentially it does the following: - It makes sure __alignof() is always present, by defining it as a macro for GCC < 2.95. I tested this with a

svn commit: r228532 - head/sys/net

2011-12-15 Thread Gleb Smirnoff
Author: glebius Date: Thu Dec 15 12:49:10 2011 New Revision: 228532 URL: http://svn.freebsd.org/changeset/base/228532 Log: Simplify rtrequest(RTM_ADD): ifa can't be NULL after rt_getifa_fib(). Modified: head/sys/net/route.c Modified: head/sys/net/route.c =

svn commit: r228531 - head/lib/libc/net

2011-12-15 Thread Michael Tuexen
Author: tuexen Date: Thu Dec 15 12:35:03 2011 New Revision: 228531 URL: http://svn.freebsd.org/changeset/base/228531 Log: Fix a bug where sctp_sendmdg() uses uninitialized memory. MFC after: 3 days. Modified: head/lib/libc/net/sctp_sys_calls.c Modified: head/lib/libc/net/sctp_sys_calls.

Re: svn commit: r228495 - head/sys/sys

2011-12-15 Thread Ed Schouten
Hello Bruce, After reading through your email, I think it's best to fix things using the following patch. Essentially it does the following: - It makes sure __alignof() is always present, by defining it as a macro for GCC < 2.95. - All the C1X macros can now be implemented using the ones we alr

svn commit: r228530 - in head/sys/arm: arm include

2011-12-15 Thread Rafal Jaworowski
Author: raj Date: Thu Dec 15 12:14:15 2011 New Revision: 228530 URL: http://svn.freebsd.org/changeset/base/228530 Log: ARM pmap fixes: - Write Buffers have to be drained after write to Page Table even if caches are in write-through mode. - Make sure to sync PTE in pmap_zero_page_ge

svn commit: r228529 - head/sys/sys

2011-12-15 Thread David Chisnall
Author: theraven Date: Thu Dec 15 11:21:56 2011 New Revision: 228529 URL: http://svn.freebsd.org/changeset/base/228529 Log: Add a pointless and superfluous GNUism that people at a certain large data aggregation and advertising company seem to believe is standard. Approved by: dim (mentor

svn commit: r228528 - head/lib/libc/stdlib

2011-12-15 Thread David Chisnall
Author: theraven Date: Thu Dec 15 11:16:41 2011 New Revision: 228528 URL: http://svn.freebsd.org/changeset/base/228528 Log: Small style(9) improvements. Approved by: dim (mentor) Modified: head/lib/libc/stdlib/quick_exit.c Modified: head/lib/libc/stdlib/quick_exit.c ===

svn commit: r228527 - head/sys/conf

2011-12-15 Thread Gleb Smirnoff
Author: glebius Date: Thu Dec 15 11:15:23 2011 New Revision: 228527 URL: http://svn.freebsd.org/changeset/base/228527 Log: Add RADIX_MPATH to LINT. Modified: head/sys/conf/NOTES Modified: head/sys/conf/NOTES == --- h

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Bernhard Schmidt
On Thu, Dec 15, 2011 at 10:35, Adrian Chadd wrote: > On 15 December 2011 00:02, Bernhard Schmidt wrote: > >> Why didn't you remove the mac argument? It is assign from wh->i_addr2 >> anyways, seems rather too redundant to me. > > Because the semantics for that right now are "check that MAC", so it

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Adrian Chadd
On 15 December 2011 00:02, Bernhard Schmidt wrote: > Why didn't you remove the mac argument? It is assign from wh->i_addr2 > anyways, seems rather too redundant to me. Because the semantics for that right now are "check that MAC", so it's the callers responsibility to determine which MAC in the

Re: svn commit: r228509 - in head: share/man/man9 sys/kern sys/sys

2011-12-15 Thread Kostik Belousov
> + switch (rv) { > + case KERN_INVALID_ADDRESS: > + case KERN_NO_SPACE: > + return (ENOMEM); > + case KERN_PROTECTION_FAILURE: > + return (EACCES); > + default: > + return (EINVAL); > + } You can replace this fragment with the call to vm

Re: svn commit: r228514 - head/sys/net80211

2011-12-15 Thread Bernhard Schmidt
On Thu, Dec 15, 2011 at 01:52, Adrian Chadd wrote: > Author: adrian > Date: Thu Dec 15 00:52:30 2011 > New Revision: 228514 > URL: http://svn.freebsd.org/changeset/base/228514 > > Log: >  Modify the ACL code slightly to support a few nifty things: > >  * Call it before sending probe responses, so