svn commit: r312369 - head/sys/powerpc/aim

2017-01-17 Thread Justin Hibbits
Author: jhibbits Date: Wed Jan 18 03:42:21 2017 New Revision: 312369 URL: https://svnweb.freebsd.org/changeset/base/312369 Log: Use the explicit expanded form of cmp. Clang apparently requires the explicit form of this instruction, and rejects uses which ignore the optional cmpD register.

svn commit: r312368 - head/sys/dev/cxgbe/tom

2017-01-17 Thread Navdeep Parhar
Author: np Date: Wed Jan 18 03:35:42 2017 New Revision: 312368 URL: https://svnweb.freebsd.org/changeset/base/312368 Log: cxgbe/tom: Fix a case where do_pass_accept_req wasn't properly restoring the VNET. This should have been in r311949. MFC after:2 days Modified: head/sys/dev/cx

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Ngie Cooper (yaneurabeya)
> On Jan 17, 2017, at 17:42, Daniel Eischen wrote: > > On Tue, 17 Jan 2017, Maxim Sobolev wrote: > >> Also there is at least one thing that makes enum less desirable from the >> point of view of application developer. Particularly it makes it impossible >> to use preprocessor to do a conditiona

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Daniel Eischen
On Tue, 17 Jan 2017, Maxim Sobolev wrote: Also there is at least one thing that makes enum less desirable from the point of view of application developer. Particularly it makes it impossible to use preprocessor to do a conditional compilation, which is especially important for the FreeBSD-specif

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
OK, guys, with all due respect I think I've heard enough to say that if somebody feels like this has to be enum feel free to jump in and tweak it out. As far as I understand there should be no user-visible differences either way, so it's not like we are going to be locked with this way forever. It'

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Ian Lepore
I actually don't agree that it's all good, but I also don't have the time to prove it's not (or prove myself wrong, which could certainly be the case). -- Ian On Tue, 2017-01-17 at 15:21 -0800, Conrad Meyer wrote: > Ian's potential objection has been met by Ben Kaduk and Eric van > Gyzen's respon

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Conrad Meyer
Ian's potential objection has been met by Ben Kaduk and Eric van Gyzen's responses. It seems like an enum is just fine. And I agree with Gleb that it is preferable. Conrad On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev wrote: > Well as other pointed out there are some concerns with using enums

svn commit: r312355 - in head/sys: amd64/cloudabi32 amd64/cloudabi64 arm/cloudabi32 arm64/cloudabi64 compat/cloudabi compat/cloudabi32 compat/cloudabi64 i386/cloudabi32

2017-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 22:05:52 2017 New Revision: 312355 URL: https://svnweb.freebsd.org/changeset/base/312355 Log: Catch up with changes to structure member names. Pointer/length pairs are now always named ${name} and ${name}_len. Modified: head/sys/amd64/cloudabi32/cloudabi32_sys

svn commit: r312354 - in head/sys/compat: cloudabi32 cloudabi64

2017-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 22:05:01 2017 New Revision: 312354 URL: https://svnweb.freebsd.org/changeset/base/312354 Log: Regenerate sources based on the system call tables. Modified: head/sys/compat/cloudabi32/cloudabi32_proto.h head/sys/compat/cloudabi32/cloudabi32_syscall.h head/sys/co

svn commit: r312353 - head/sys/contrib/cloudabi

2017-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 22:03:08 2017 New Revision: 312353 URL: https://svnweb.freebsd.org/changeset/base/312353 Log: Sync in the latest CloudABI generated source files. Languages like C++17 and Go provide direct support for slice types: pointer/length pairs. The CloudABI generator no

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
Well as other pointed out there are some concerns with using enums from C++ and ABI prospective. So it looks to me that there is no general consensus on that direction. -Max On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff wrote: > On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: >

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Gleb Smirnoff
On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: M> That being said, is there any other socket option value in there M> implemented as enum? I don't see anything obvious, so that I am curious if M> it would stick out as an odd one in there. What do you think? Simply because 30 years

svn commit: r312350 - head/sys/conf

2017-01-17 Thread Bryan Drewery
Author: bdrewery Date: Tue Jan 17 21:12:21 2017 New Revision: 312350 URL: https://svnweb.freebsd.org/changeset/base/312350 Log: Don't compute MPATH during install. This saves time when building over NFS. Nothing should be building during this phase anyhow. Sponsored by: Dell EMC Isi

Re: svn commit: r312236 - head/sys/net80211

2017-01-17 Thread Andriy Gapon
On 15/01/2017 22:43, Adrian Chadd wrote: > On 15 January 2017 at 11:56, Ian Lepore wrote: > >> >> What is the point of the !! in these macros? The expressions already >> have boolean type (even in C++ where it matters) due to the ==. >> Removing the !! would also make one level of parens redund

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Eric van Gyzen
On 01/17/2017 11:48, Benjamin Kaduk wrote: > On Tue, Jan 17, 2017 at 10:57 AM, Ian Lepore > wrote: > > In my experience, enums are a superior way to define integer constants > (compared to #define), but they are pure poison as variable types in > APIs and stru

svn commit: r312348 - head/sys/cam/ctl

2017-01-17 Thread Alexander Motin
Author: mav Date: Tue Jan 17 18:32:47 2017 New Revision: 312348 URL: https://svnweb.freebsd.org/changeset/base/312348 Log: Remove writing 'residual' field of struct ctl_scsiio. This field has no practical use and never readed. Initiators already receive respective residual size from fron

svn commit: r312347 - head/sys/boot/fdt/dts/arm

2017-01-17 Thread Luiz Otavio O Souza
Author: loos Date: Tue Jan 17 18:04:13 2017 New Revision: 312347 URL: https://svnweb.freebsd.org/changeset/base/312347 Log: The write-protect is not wired on uFW, disable it to allow writes to SD card. Sponsored by: Rubicon Communications, LLC (Netgate) Modified: head/sys/boot/fdt/dts/

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Benjamin Kaduk
On Tue, Jan 17, 2017 at 10:57 AM, Ian Lepore wrote: > In my experience, enums are a superior way to define integer constants > (compared to #define), but they are pure poison as variable types in > APIs and structures because their size is a compiler implementation > choice. > Well, to some exte

svn commit: r312346 - head/sys/dev/sdhci

2017-01-17 Thread Luiz Otavio O Souza
Author: loos Date: Tue Jan 17 17:41:14 2017 New Revision: 312346 URL: https://svnweb.freebsd.org/changeset/base/312346 Log: Set the the wp_disabled flag when asked to. While here, add the missing new line. MFC after:3 days Sponsored by: Rubicon Communications, LLC (Netgate) Modi

Re: svn commit: r312205 - in head/sys: kern net

2017-01-17 Thread Hans Petter Selasky
On 01/17/17 16:04, John Baldwin wrote: Then it gives a much slower boot by hanging for almost a minute waiting for USB or something. Hi, This might be related to a bug in the timer init which I've observed too. Can you show output from: vmstat -i When the booting is slow? --HPS __

Re: svn commit: r312205 - in head/sys: kern net

2017-01-17 Thread John Baldwin
On Tuesday, January 17, 2017 12:02:49 PM Bruce Evans wrote: > On Mon, 16 Jan 2017, John Baldwin wrote: > > > On Sunday, January 15, 2017 12:50:10 AM Sean Bruno wrote: > >> ... > >> Log: > >> Fix hangs in a uniprocessor configuration (qemu, virtualbox, real hw). > >> > >> sys/net/iflib.c: > >>

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Ian Lepore
In my experience, enums are a superior way to define integer constants (compared to #define), but they are pure poison as variable types in APIs and structures because their size is a compiler implementation choice. -- Ian On Tue, 2017-01-17 at 08:40 -0800, Maxim Sobolev wrote: > That being said,

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
That being said, is there any other socket option value in there implemented as enum? I don't see anything obvious, so that I am curious if it would stick out as an odd one in there. What do you think? -Max On Tue, Jan 17, 2017 at 6:22 AM, Maxim Sobolev wrote: > Of course it's possible. Do you

Re: svn commit: r311952 - head/sys/ddb

2017-01-17 Thread Bruce Evans
On Mon, 16 Jan 2017, Julian Elischer wrote: On 16/01/2017 11:53 AM, Bruce Evans wrote: On Sun, 15 Jan 2017, Adrian Chadd wrote: hah, i took this, then life got in the way. :) Bruce - what do you think of https://bz-attachments.freebsd.org/attachment.cgi?id=138881 ? Also https://bugs.freebs

svn commit: r312344 - in head/sys/cam: ata scsi

2017-01-17 Thread Sean Bruno
Author: sbruno Date: Tue Jan 17 14:52:48 2017 New Revision: 312344 URL: https://svnweb.freebsd.org/changeset/base/312344 Log: Add 4k quirk for Micron 5100 and Intel S3610 SSDs Submitted by: Jason Wolfe MFH: 1 week Sponsored by: Limelight Networks Differential Revision:

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
Of course it's possible. Do you guys want me to amend that patch? -Max On Mon, Jan 16, 2017 at 10:52 PM, Gleb Smirnoff wrote: > Hi! > > On Mon, Jan 16, 2017 at 05:46:38PM +, Maxim Sobolev wrote: > M> Author: sobomax > M> Date: Mon Jan 16 17:46:38 2017 > M> New Revision: 312296 > M> URL: h

svn commit: r312343 - head/sys/cam/ctl

2017-01-17 Thread Alexander Motin
Author: mav Date: Tue Jan 17 14:13:14 2017 New Revision: 312343 URL: https://svnweb.freebsd.org/changeset/base/312343 Log: Improve error message on duplicate iSCSI port. MFC after:2 weeks Modified: head/sys/cam/ctl/ctl_frontend_iscsi.c Modified: head/sys/cam/ctl/ctl_frontend_iscsi.c

svn commit: r312341 - head/sys/netpfil/ipfw

2017-01-17 Thread Andrey V. Elsukov
Author: ae Date: Tue Jan 17 10:50:28 2017 New Revision: 312341 URL: https://svnweb.freebsd.org/changeset/base/312341 Log: Initialize IPFW static rules rmlock with RM_RECURSE flag. This lock was replaced from rwlock in r272840. But unlike rwlock, rmlock doesn't allow recursion on rm_rlock(

svn commit: r312338 - in head: share/man/man4 sys/dev/sound/usb sys/dev/usb sys/dev/usb/quirk

2017-01-17 Thread Hans Petter Selasky
Author: hselasky Date: Tue Jan 17 08:15:10 2017 New Revision: 312338 URL: https://svnweb.freebsd.org/changeset/base/312338 Log: Add USB audio support for S/PDIF output with C-Media CM6206 devices. Submitted by: Julien Nadeau PR: 216131 MFC after:1