Re: svn commit: r316874 - head/sys/kern

Maxim Sobolev wrote in : so> I've committed another fix for the syslogd code in question which should so> hopefully make it functional again. Peter, please let me know if you still so> having any issues.

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On 4/16/17 08:30, Rodney W. Grimes wrote: >> >>> On 16 Apr 2017, at 13:07, Rodney W. Grimes >>> wrote: >>> > From replacing the rc4 algorithm with chacha20, this chalice has now become poisoned with the job of redesigning the entire structure of

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

Mark R V Murray writes: > "Dubious legal status"? Please go and look at the chacha that OpenSSH uses. > You will find it strangely familiar. I know exactly where that code comes from. It lacks a proper license. DES -- Dag-Erling Smørgrav - d...@des.no

Re: svn commit: r316978 - in head: contrib/zstd etc/mtree lib lib/libzstd share/mk usr.bin usr.bin/zstd

On Sun, Apr 16, 2017 at 12:35 AM, Baptiste Daroussin wrote: > > zstandard is the successor to lz4, That's not my understanding. zstandard is an improvement in every respect over zlib (gzip), but lz4 is faster, especially at decompression[*]. If you have data to the contrary

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On Sun, Apr 16, 2017 at 10:35 AM, Ian Lepore wrote: > On Sun, 2017-04-16 at 09:04 -0700, Rodney W. Grimes wrote: >> What watch list is this? And do we have a watch list that is just "New >> Phabricator >> created" so we can make just that incident go to some mailling list so

Re: svn commit: r316978 - in head: contrib/zstd etc/mtree lib lib/libzstd share/mk usr.bin usr.bin/zstd

On Sat, Apr 15, 2017 at 05:01:10PM -0700, Conrad Meyer wrote: > Can you tone down the condescension, Rod? Being rude doesn't help you > make your case. I'm going to have to +1 this. We're a huge community now. Comments that might be appropriate among a handful of people aren't as appropriate

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On Sun, Apr 16, 2017 at 10:35:59AM -0600, Ian Lepore wrote: > (The most basic rule would be "notify me about every new change put > up for review", which seems like it would be a real spam generator, > but at least one person uses such a rule.) I tried the latter once, as a test. I doubt many

svn commit: r317039 - in head/bin/sh: . tests/parser

Author: jilles Date: Sun Apr 16 22:10:02 2017 New Revision: 317039 URL: https://svnweb.freebsd.org/changeset/base/317039 Log: sh: Fix use after free when resetting an in-use alias. The special case of modifying an existing alias does not work correctly if the alias is currently in use.

svn commit: r317038 - head/bin/sh/tests/parser

Author: jilles Date: Sun Apr 16 21:57:25 2017 New Revision: 317038 URL: https://svnweb.freebsd.org/changeset/base/317038 Log: sh: Link the new test to the build. Modified: head/bin/sh/tests/parser/Makefile Modified: head/bin/sh/tests/parser/Makefile

svn commit: r317037 - in head/bin/sh: . tests/parser

Author: jilles Date: Sun Apr 16 21:42:43 2017 New Revision: 317037 URL: https://svnweb.freebsd.org/changeset/base/317037 Log: sh: Fix unalias -a while an alias is currently in use. It is a rare situation to modify aliases while an alias is currently in use, but this is handled for plain

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 20:26, Dag-Erling Smørgrav wrote: > > Mark Murray writes: >> Added: >> head/sys/crypto/chacha20/chacha.c (contents, props changed) >> head/sys/crypto/chacha20/chacha.h (contents, props changed) > > Really? You committed this code

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

Mark Murray writes: > Added: > head/sys/crypto/chacha20/chacha.c (contents, props changed) > head/sys/crypto/chacha20/chacha.h (contents, props changed) Really? You committed this code despite having been informed of its dubious legal status, and despite knowing full

svn commit: r317036 - head/lib/libjail

Author: pfg Date: Sun Apr 16 19:23:10 2017 New Revision: 317036 URL: https://svnweb.freebsd.org/changeset/base/317036 Log: libjail: make allocation in jailparam_all() somewhat more robust. Unsign some variables involved in allocation as they will never be negative anyways. Provide some

svn commit: r317035 - in head: contrib/traceroute sbin/route sbin/routed sys/net usr.bin/netstat usr.sbin/arp usr.sbin/ndp usr.sbin/rarpd usr.sbin/route6d

Author: pkelsey Date: Sun Apr 16 19:17:10 2017 New Revision: 317035 URL: https://svnweb.freebsd.org/changeset/base/317035 Log: Fix userland tools that don't check the format of routing socket messages before accessing message fields that may not be present, removing

svn commit: r317034 - in head/lib/libc: string tests/string

Author: bapt Date: Sun Apr 16 19:12:07 2017 New Revision: 317034 URL: https://svnweb.freebsd.org/changeset/base/317034 Log: Fix strcoll_l disagreeing with strxfrm by reworking the forward order case in wcscoll_l(). Illumos fixed this while grabbing back our patches:

svn commit: r317033 - head/sys/arm/freescale/imx

Author: ian Date: Sun Apr 16 17:53:44 2017 New Revision: 317033 URL: https://svnweb.freebsd.org/changeset/base/317033 Log: Convert probing to use an ofw_compat_data array, and add imx6ul to the list. Modified: head/sys/arm/freescale/imx/imx6_usbphy.c Modified:

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On Sun, 2017-04-16 at 09:04 -0700, Rodney W. Grimes wrote: > What watch list is this?  And do we have a watch list that is just "New > Phabricator > created" so we can make just that incident go to some mailling list so people > stop > getting caught off guard by commits that have been reviews

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 15:26, Conrad Meyer wrote: > * I believe you've taken the right approach. But somehow your import > of chacha should be reconciled with DES' import (i.e., keep only one > copy in the tree). > * I don't believe the chacha code being standard is an undue

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 17:04, Rodney W. Grimes > wrote: > So you can understand me being started when any of this arrived? I am > on several of the mailling list, and I think -security is probably one > of them. I was thoroughly ignored last time I tried to use

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> > > On 16 Apr 2017, at 15:21, Rodney W. Grimes > > wrote: > RC4 has been standard for many years. > >>> Probably another rapid mode of design rather than a thoughful mode, we > >>> have a chance to correct this here, and imho, should. > >> > >> Fix it,

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On 04/16/17 09:26, Conrad Meyer wrote: On Sun, Apr 16, 2017 at 2:19 AM, Mark R V Murray wrote: This does not use DES' Chacha20 commit, as I had already completed the testing for it, and received SO@ approval. DES's commit made Chaha20 a module. This is of no use to

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 15:21, Rodney W. Grimes > wrote: RC4 has been standard for many years. >>> Probably another rapid mode of design rather than a thoughful mode, we >>> have a chance to correct this here, and imho, should. >> >> Fix it, sure. What's wrong

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

Furthmore: chacha20.ko: 7 kB GENERIC w/out chacha20: 27095416 GENERIC w/ chacha20: 27097976 device chacha20 adds 2560 *bytes* to the kernel. That's +0.009%. Not worth bikeshedding about. Best, Conrad On Sun, Apr 16, 2017 at 7:26 AM, Conrad Meyer wrote: > On Sun, Apr 16,

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

On Sun, Apr 16, 2017 at 2:19 AM, Mark R V Murray wrote: > This does not use DES' Chacha20 commit, as I had already completed the > testing for it, and received SO@ approval. > > DES's commit made Chaha20 a module. This is of no use to arc4random(9), > which needs the code to be

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> > On 16 Apr 2017, at 13:30, Rodney W. Grimes > > wrote: > > > >> The RC4 algorithm is standard. Making the alogorithm pluggable means more > >> code, more testing and more time (time which I am rather short of). > > > > I would rather see a proper

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 13:30, Rodney W. Grimes > wrote: > >> The RC4 algorithm is standard. Making the alogorithm pluggable means more >> code, more testing and more time (time which I am rather short of). > > I would rather see a proper implementation later,

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> > > On 16 Apr 2017, at 13:07, Rodney W. Grimes > > wrote: > > > >>> From replacing the rc4 algorithm with chacha20, this chalice has now > >> become poisoned with the job of redesigning the entire structure of > >> kernel random-number generation. > >> > >>

Re: svn commit: r316874 - head/sys/kern

Am Sat, 15 Apr 2017 14:22:57 -0500 Larry Rosenman schrieb: > This looks MUCH better, startup was it’s usual speedy self. > > > > > ... same here with FreeBSD 12.0-CURRENT #23 r316999: Sun Apr 16 07:28:14 CEST 2017 amd64. Systems boot as usual again - speedy and

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 13:07, Rodney W. Grimes > wrote: > >>> From replacing the rc4 algorithm with chacha20, this chalice has now >> become poisoned with the job of redesigning the entire structure of >> kernel random-number generation. >> >> This may take a

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> > > On 16 Apr 2017, at 12:50, Rodney W. Grimes > > wrote: > > > >> This does not use DES' Chacha20 commit, as I had already completed the > >> testing for it, and received SO@ approval. > >> > >> DES's commit made Chaha20 a module. This is of no use to

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> On 16 Apr 2017, at 12:50, Rodney W. Grimes > wrote: > >> This does not use DES' Chacha20 commit, as I had already completed the >> testing for it, and received SO@ approval. >> >> DES's commit made Chaha20 a module. This is of no use to arc4random(9), >>

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

> This does not use DES' Chacha20 commit, as I had already completed the > testing for it, and received SO@ approval. > > DES's commit made Chaha20 a module. This is of no use to arc4random(9), > which needs the code to be standard. Also his API is different. > > I have no objection to reworking

Re: svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

This does not use DES' Chacha20 commit, as I had already completed the testing for it, and received SO@ approval. DES's commit made Chaha20 a module. This is of no use to arc4random(9), which needs the code to be standard. Also his API is different. I have no objection to reworking the

svn commit: r317015 - in head/sys: boot/forth conf crypto/chacha20 dev/random libkern sys

Author: markm Date: Sun Apr 16 09:11:02 2017 New Revision: 317015 URL: https://svnweb.freebsd.org/changeset/base/317015 Log: Replace the RC4 algorithm for generating in-kernel secure random numbers with Chacha20. Keep the API, though, as that is what the other *BSD's have done. Use the

Re: svn commit: r316982 - in head/sys: conf crypto/chacha20 modules modules/chacha20

> On 15 Apr 2017, at 21:51, Dag-Erling Smørgrav wrote: > > Author: des > Date: Sat Apr 15 20:51:53 2017 > New Revision: 316982 > URL: https://svnweb.freebsd.org/changeset/base/316982 > > Log: > 3BSD-licensed implementation of the chacha20 stream cipher, intended for > use

Re: svn commit: r316978 - in head: contrib/zstd etc/mtree lib lib/libzstd share/mk usr.bin usr.bin/zstd

On Sat, Apr 15, 2017 at 04:37:02PM -0700, Rodney W. Grimes wrote: > And we need this in base for what great purpose??? > zstandard is the successor to lz4, there are attempts to integrate zstandard in ZFS, Allan Jude is working on that, I am working on integrating in libstand to allow to boot a

Re: svn commit: r316977 - head/sys/dev/syscons

Am Sat, 15 Apr 2017 23:47:19 -0700 Kevin Oberman schrieb: > On Sat, Apr 15, 2017 at 10:55 PM, O. Hartmann > wrote: > > > Am Sat, 15 Apr 2017 18:00:18 -0700 > > Conrad Meyer schrieb: > > > > > On Sat, Apr 15, 2017 at 1:21 PM, O.

Re: svn commit: r316977 - head/sys/dev/syscons

On Sat, Apr 15, 2017 at 10:55 PM, O. Hartmann wrote: > Am Sat, 15 Apr 2017 18:00:18 -0700 > Conrad Meyer schrieb: > > > On Sat, Apr 15, 2017 at 1:21 PM, O. Hartmann > wrote: > > > Am Sat, 15 Apr 2017 20:03:50 + (UTC) > > >