Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Bruce Evans
On Thu, 28 Jun 2018, David Bright wrote: Log: Remove potential identifier conflict in the EV_SET macro. PR43905 pointed out a problem with the EV_SET macro if the passed struct kevent pointer were specified with an expression with side effects (e.g., "kevp++"). This was fixed in rS110241, b

svn commit: r335792 - head/tests/sys/audit

2018-06-28 Thread Alan Somers
Author: asomers Date: Fri Jun 29 04:52:27 2018 New Revision: 335792 URL: https://svnweb.freebsd.org/changeset/base/335792 Log: audit(4): add tests for several more administrative syscalls Includes ntp_adjtime, auditctl, acct, auditon, and clock_settime. Includes quotactl, mount, nmount,

svn commit: r335791 - head/tests/sys/audit

2018-06-28 Thread Alan Somers
Author: asomers Date: Fri Jun 29 04:46:15 2018 New Revision: 335791 URL: https://svnweb.freebsd.org/changeset/base/335791 Log: audit(4): add tests for setsid, wait4, wait6, and kill Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revisio

svn commit: r335790 - head/sys/vm

2018-06-28 Thread Alan Cox
Author: alc Date: Fri Jun 29 04:08:14 2018 New Revision: 335790 URL: https://svnweb.freebsd.org/changeset/base/335790 Log: Three changes to vm_phys_alloc_seg_contig(): 1. Optimize the order computation. 2. Update the pool for all of the chunks that are removed from the free page l

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

2018-06-28 Thread Mark Millard via svn-src-head
On 2018-Jun-28, at 6:04 PM, Mark Millard wrote: > On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: > >> [ ci.free.bsd.org jumped from -r335773 (built) to -r335784 (failed) >> for FreeBSD-head-amd64-gcc. It looked to me like the most likely >> breaking-change was the following but I've not tried

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

2018-06-28 Thread Mark Millard via svn-src-head
On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: > [ ci.free.bsd.org jumped from -r335773 (built) to -r335784 (failed) > for FreeBSD-head-amd64-gcc. It looked to me like the most likely > breaking-change was the following but I've not tried personal > builds to confirm. > ] > > It looks to me

head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

2018-06-28 Thread Mark Millard via svn-src-head
[ ci.free.bsd.org jumped from -r335773 (built) to -r335784 (failed) for FreeBSD-head-amd64-gcc. It looked to me like the most likely breaking-change was the following but I've not tried personal builds to confirm. ] It looks to me that: > Author: jhb > Date: Thu Jun 28 21:26:14 2018 > New R

Re: svn commit: r335787 - head/etc/rc.d

2018-06-28 Thread Cy Schubert
In message <201806282213.w5smdwta093...@repo.freebsd.org>, Ian Lepore writes: > Author: ian > Date: Thu Jun 28 22:13:32 2018 > New Revision: 335787 > URL: https://svnweb.freebsd.org/changeset/base/335787 > > Log: > When being verbose about various leapfile versions, also mention expiration > . >

Re: svn commit: r335786 - head/etc/rc.d

2018-06-28 Thread Cy Schubert
In message <201806282205.w5sm5t0c088...@repo.freebsd.org>, Ian Lepore writes: > Author: ian > Date: Thu Jun 28 22:05:29 2018 > New Revision: 335786 > URL: https://svnweb.freebsd.org/changeset/base/335786 > > Log: > Rename variable ntp_tmp_leapfile to have a leading underbar, to distinguish > i

Re: svn commit: r335779 - in head/sys: arm/broadcom/bcm2835 conf

2018-06-28 Thread Emmanuel Vadot
On Thu, 28 Jun 2018 21:14:33 + (UTC) Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Thu Jun 28 21:14:33 2018 > New Revision: 335779 > URL: https://svnweb.freebsd.org/changeset/base/335779 > > Log: > [rpi] Add SDHOST device driver for Raspberry Pi > > SDHOST is another SD controll

svn commit: r335788 - head

2018-06-28 Thread Bryan Drewery
Author: bdrewery Date: Thu Jun 28 22:24:16 2018 New Revision: 335788 URL: https://svnweb.freebsd.org/changeset/base/335788 Log: Fix unknown target check after r335450. X-MFC-with: r335450 Pointyhat to: bdrewery Sponsored by: Dell EMC Modified: head/Makefile.inc1 Modified: head/Mak

svn commit: r335787 - head/etc/rc.d

2018-06-28 Thread Ian Lepore
Author: ian Date: Thu Jun 28 22:13:32 2018 New Revision: 335787 URL: https://svnweb.freebsd.org/changeset/base/335787 Log: When being verbose about various leapfile versions, also mention expiration. The expiration date is actually more of a version number than the version date, because e

svn commit: r335786 - head/etc/rc.d

2018-06-28 Thread Ian Lepore
Author: ian Date: Thu Jun 28 22:05:29 2018 New Revision: 335786 URL: https://svnweb.freebsd.org/changeset/base/335786 Log: Rename variable ntp_tmp_leapfile to have a leading underbar, to distinguish it from variables with similar names which are set in rc.conf. This will make more sense as

svn commit: r335785 - head/sys/dev/iwn

2018-06-28 Thread Eitan Adler
Author: eadler Date: Thu Jun 28 21:59:45 2018 New Revision: 335785 URL: https://svnweb.freebsd.org/changeset/base/335785 Log: iwn: Correct Centrino Advanced-N 6235 constants The iwn 6235 is a 2x2 device (see https://ark.intel.com/products/66890/Intel-Centrino-Advanced-N-6235-Dual-Band)

svn commit: r335784 - head/sys/amd64/amd64

2018-06-28 Thread Mark Johnston
Author: markj Date: Thu Jun 28 21:40:31 2018 New Revision: 335784 URL: https://svnweb.freebsd.org/changeset/base/335784 Log: Invalidate the mapping before updating its physical address. Doing so ensures that all threads sharing the pmap have a consistent view of the mapping. This fixes t

svn commit: r335783 - head/sys/mips/malta

2018-06-28 Thread John Baldwin
Author: jhb Date: Thu Jun 28 21:27:34 2018 New Revision: 335783 URL: https://svnweb.freebsd.org/changeset/base/335783 Log: Support 2GB of memory on Malta systems with FreeBSD/mips. When 2GB of memory is enabled for QEMU's Malta emulation, the physical memory ends at an address of 2^32 - 1

svn commit: r335782 - head

2018-06-28 Thread John Baldwin
Author: jhb Date: Thu Jun 28 21:26:14 2018 New Revision: 335782 URL: https://svnweb.freebsd.org/changeset/base/335782 Log: Remove the various build flag hacks for GCC cross-compile. The xtoolchain GCC packages have not required these flags since ports commits r465416 and r466701. The in-

svn commit: r335779 - in head/sys: arm/broadcom/bcm2835 conf

2018-06-28 Thread Oleksandr Tymoshenko
Author: gonzo Date: Thu Jun 28 21:14:33 2018 New Revision: 335779 URL: https://svnweb.freebsd.org/changeset/base/335779 Log: [rpi] Add SDHOST device driver for Raspberry Pi SDHOST is another SD controller that is present on Raspberry Pi (the other one is SDHC and handled by bcm2835_sdhci

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 01:45 PM, Justin Hibbits wrote: >> Author: dab >> Date: Thu Jun 28 17:01:04 2018 >> New Revision: 335765 > > This breaks gcc builds, with the following errors: Fixed in r335776. Thanks to cem@ for a suggested fix (and to others that also suggested alternative fixes) and to jhibbi

svn commit: r335776 - head/sys/sys

2018-06-28 Thread David Bright
Author: dab Date: Thu Jun 28 20:37:17 2018 New Revision: 335776 URL: https://svnweb.freebsd.org/changeset/base/335776 Log: Fix compilation error in r335765 under gcc 4.2.1. The anonymous object initialization introduced in r335765 was acceptable to clang, but not gcc 4.2.1. Fix it for bot

svn commit: r335775 - head/sys/arm64/linux

2018-06-28 Thread Ed Maste
Author: emaste Date: Thu Jun 28 20:36:21 2018 New Revision: 335775 URL: https://svnweb.freebsd.org/changeset/base/335775 Log: Add stub arm64 linuxulator VDSO ldscript This needs to be revisited with the VDSO implementation, but is sufficient to allow the linux64 module to build on arm64 f

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Ed Schouten
2018-06-28 21:09 GMT+02:00 Conrad Meyer : > I think the right initializer is something like: > > *(kevp_) = (struct kevent) { > ... > .ext = { > [0] = 0, > [1] = 0, > ... > }, > }; The nice thing about using an inline function is that you can get rid of the compound literal: static __inline v

svn commit: r335773 - head/stand/efi/boot1

2018-06-28 Thread Warner Losh
Author: imp Date: Thu Jun 28 19:42:10 2018 New Revision: 335773 URL: https://svnweb.freebsd.org/changeset/base/335773 Log: Revert preference to be an int. While in base we use it as a boolean (of the wrong spelling), there's at least one out of tree user that needs it to be int since prio

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Conrad Meyer
I think the right initializer is something like: *(kevp_) = (struct kevent) { ... .ext = { [0] = 0, [1] = 0, ... }, }; (I.e., use a C99 array static initializer to initialize the array member of struct kevent.) Best, Conrad On Thu, Jun 28, 2018 at 11:45 AM, Justin Hibbits wrote: > Hi David

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Ed Schouten
Hi David, 2018-06-28 19:01 GMT+02:00 David Bright : > +#define EV_SET(kevp_, a, b, c, d, e, f) do { \ Some time ago I also looked into this and realised that it may even be possible to do something like this: static __inline void EV_SET(...) { } /* Compatibility for code that tests #ifdef EV_

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 02:04 PM, Bryan Drewery wrote: > On 6/28/2018 11:45 AM, Justin Hibbits wrote: >> Hi David, >> 18:02:13 /usr/src/bin/pwait/pwait.c:158: warning: initialized field >> overwritten >> 18:02:13 /usr/src/bin/pwait/pwait.c:158: warning: (near initialization >> for '(anonymous).ext') >> >>

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Bryan Drewery
On 6/28/2018 11:45 AM, Justin Hibbits wrote: > Hi David, > > On Thu, Jun 28, 2018 at 12:01 PM David Bright wrote: >> >> Author: dab >> Date: Thu Jun 28 17:01:04 2018 >> New Revision: 335765 >> URL: https://svnweb.freebsd.org/changeset/base/335765 >> >> Log: >> Remove potential identifier confli

svn commit: r335771 - head

2018-06-28 Thread Bryan Drewery
Author: bdrewery Date: Thu Jun 28 19:01:53 2018 New Revision: 335771 URL: https://svnweb.freebsd.org/changeset/base/335771 Log: SYSTEM_COMPILER/LINKER: Fix cross-build support after r335706. X-MFC-With: r335706 MFC after:2 weeks Sponsored by: Dell EMC Modified: head/Makefile.in

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread Justin Hibbits
Hi David, On Thu, Jun 28, 2018 at 12:01 PM David Bright wrote: > > Author: dab > Date: Thu Jun 28 17:01:04 2018 > New Revision: 335765 > URL: https://svnweb.freebsd.org/changeset/base/335765 > > Log: > Remove potential identifier conflict in the EV_SET macro. > > PR43905 pointed out a problem

svn commit: r335770 - head

2018-06-28 Thread Bryan Drewery
Author: bdrewery Date: Thu Jun 28 18:22:20 2018 New Revision: 335770 URL: https://svnweb.freebsd.org/changeset/base/335770 Log: tinderbox: If the clang lookup fails fallback to the old default behavior. This fixes errors from the MK_CLANG_BOOTSTRAP/MK_LLD_BOOTSTRAP lookups to not force us

svn commit: r335769 - head

2018-06-28 Thread John Baldwin
Author: jhb Date: Thu Jun 28 18:19:46 2018 New Revision: 335769 URL: https://svnweb.freebsd.org/changeset/base/335769 Log: Include existing MAKE_PARAMS_ when determining the universe toolchain. This fixes a warning for each RISCV target during universe by passing in the required CROSS_TOO

svn commit: r335768 - head/lib/libc/sys

2018-06-28 Thread Conrad Meyer
Author: cem Date: Thu Jun 28 18:17:20 2018 New Revision: 335768 URL: https://svnweb.freebsd.org/changeset/base/335768 Log: sigaction.2: Minor cleanups Add vertical space between struct definition and function prototype. Use "NULL" to describe zero pointers, instead of "zero." Remo

svn commit: r335767 - head/sys/vm

2018-06-28 Thread Alan Cox
Author: alc Date: Thu Jun 28 17:52:06 2018 New Revision: 335767 URL: https://svnweb.freebsd.org/changeset/base/335767 Log: Reflow one of the comments describing vm_phys_alloc_npages(). Modified: head/sys/vm/vm_phys.c Modified: head/sys/vm/vm_phys.c ===

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 12:06 PM, David A. Bright wrote: > On 06/28/2018 12:01 PM, David Bright wrote: > >> Author: dab >> Date: Thu Jun 28 17:01:04 2018 >> New Revision: 335765 >> URL: https://svnweb.freebsd.org/changeset/base/335765 >> >> Log: >> Remove potential identifier conflict in the EV_SET macro.

Re: svn commit: r335765 - head/sys/sys

2018-06-28 Thread David A. Bright
On 06/28/2018 12:01 PM, David Bright wrote: > Author: dab > Date: Thu Jun 28 17:01:04 2018 > New Revision: 335765 > URL: https://svnweb.freebsd.org/changeset/base/335765 > > Log: > Remove potential identifier conflict in the EV_SET macro. > > > Differential Revision: > https://bugs.fr

svn commit: r335766 - head/sys/dev/efidev

2018-06-28 Thread Ian Lepore
Author: ian Date: Thu Jun 28 17:07:20 2018 New Revision: 335766 URL: https://svnweb.freebsd.org/changeset/base/335766 Log: Add missing MODULE_VERSION() and MODULE_DEPEND(). Modified: head/sys/dev/efidev/efirtc.c Modified: head/sys/dev/efidev/efirtc.c =

svn commit: r335765 - head/sys/sys

2018-06-28 Thread David Bright
Author: dab Date: Thu Jun 28 17:01:04 2018 New Revision: 335765 URL: https://svnweb.freebsd.org/changeset/base/335765 Log: Remove potential identifier conflict in the EV_SET macro. PR43905 pointed out a problem with the EV_SET macro if the passed struct kevent pointer were specified with

svn commit: r335763 - head/etc/devd

2018-06-28 Thread Warner Losh
Author: imp Date: Thu Jun 28 15:00:18 2018 New Revision: 335763 URL: https://svnweb.freebsd.org/changeset/base/335763 Log: Fix quoting in sending the NOMATCH event to devmatch The NOMATCH event was previously quoted to protect it from shell expansion. However, that quoting now interferes

svn commit: r335762 - in head: . etc release/packages share/mk share/termcap usr.bin/vgrind

2018-06-28 Thread Brad Davis
Author: brd Date: Thu Jun 28 13:48:59 2018 New Revision: 335762 URL: https://svnweb.freebsd.org/changeset/base/335762 Log: Simplify using bsd.endian.mk and have it provide CAP_MKDB_ENDIAN, since it is the most common usage. Approved by: bapt (mentor) Modified: head/Makefile.inc1 hea

Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga

2018-06-28 Thread Rodney W. Grimes
> On Tue, Jun 26, 2018 at 10:18:39AM -0600, Ian Lepore wrote: > > On Tue, 2018-06-26 at 08:55 -0700, Rodney W. Grimes wrote: > > > > > > > > On Tue, Jun 26, 2018 at 05:21:27AM +, Alexey Dokuchaev wrote: > > > > > > > > > > On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > >

svn commit: r335760 - in head/sys: net netinet netinet6

2018-06-28 Thread Andrey V. Elsukov
Author: ae Date: Thu Jun 28 11:39:27 2018 New Revision: 335760 URL: https://svnweb.freebsd.org/changeset/base/335760 Log: Add NULL pointer check. encap_lookup_t method can be invoked by IP encap subsytem even if none of gif/gre/me interfaces are exist. Hash tables are allocated on demand,

svn commit: r335759 - head/sbin/ipfw

2018-06-28 Thread Andrey V. Elsukov
Author: ae Date: Thu Jun 28 09:42:30 2018 New Revision: 335759 URL: https://svnweb.freebsd.org/changeset/base/335759 Log: Remove extra "ipfw" from example. MFC after:1 week Modified: head/sbin/ipfw/ipfw.8 Modified: head/sbin/ipfw/ipfw.8 ==

Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga

2018-06-28 Thread Roger Pau Monné
On Tue, Jun 26, 2018 at 10:18:39AM -0600, Ian Lepore wrote: > On Tue, 2018-06-26 at 08:55 -0700, Rodney W. Grimes wrote: > > > > > > On Tue, Jun 26, 2018 at 05:21:27AM +, Alexey Dokuchaev wrote: > > > > > > > > On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > > > > > > > >

Re: svn commit: r335690 - head/sys/kern

2018-06-28 Thread Warner Losh
On Wed, Jun 27, 2018 at 7:46 AM, Warner Losh wrote: > > > On Wed, Jun 27, 2018 at 7:44 AM, Shawn Webb > wrote: > >> On Wed, Jun 27, 2018 at 07:42:52AM -0600, Warner Losh wrote: >> > On Wed, Jun 27, 2018 at 12:59 AM, Oliver Pinter < >> > oliver.pin...@hardenedbsd.org> wrote: >> > >> > > >> > > >>

Re: svn commit: r335690 - head/sys/kern

2018-06-28 Thread Warner Losh
On Thu, Jun 28, 2018 at 12:54 AM, Devin Teske wrote: > > On Jun 27, 2018, at 7:35 PM, Warner Losh wrote: > > > > On Wed, Jun 27, 2018 at 8:14 PM, Devin Teske wrote: > >> >> On Jun 27, 2018, at 6:58 PM, Warner Losh wrote: >> >> >> >> On Wed, Jun 27, 2018 at 7:49 PM, Devin Teske wrote: >> >>> >