Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/d

2018-08-21 Thread John Baldwin
On 8/22/18 3:44 AM, Matthew Macy wrote: > > > Could you please create a stable/11 deprecation change. > > > What does that entail other than an update to UPDATING in stable/11? There are helper functions such as gone_in(), etc. that you can use during attach, though in this case you might

svn commit: r338182 - in head: sbin/nvmecontrol sys/cam/nvme sys/dev/mpr sys/dev/nvme sys/sys usr.sbin/bhyve

2018-08-21 Thread Chuck Tuffli
Author: chuck Date: Wed Aug 22 04:29:24 2018 New Revision: 338182 URL: https://svnweb.freebsd.org/changeset/base/338182 Log: Make NVMe compatible with the original API The original NVMe API used bit-fields to represent fields in data structures defined by the specification (e.g. the

svn commit: r338178 - in head/sys: netinet netinet6

2018-08-21 Thread Matt Macy
Author: mmacy Date: Wed Aug 22 04:09:55 2018 New Revision: 338178 URL: https://svnweb.freebsd.org/changeset/base/338178 Log: in_mcast: fix copy paste error when clearing flag Modified: head/sys/netinet/in_mcast.c head/sys/netinet6/in6_mcast.c Modified: head/sys/netinet/in_mcast.c

svn commit: r338177 - in head/tools: kerneldoc/subsys tools

2018-08-21 Thread Matt Macy
Author: mmacy Date: Wed Aug 22 03:04:43 2018 New Revision: 338177 URL: https://svnweb.freebsd.org/changeset/base/338177 Log: r338172 followup - removal of stray drm references Deleted: head/tools/kerneldoc/subsys/Doxyfile-dev_drm Modified: head/tools/tools/README Modified:

svn commit: r338176 - in head: sys/conf sys/contrib/dev/drm2 tools/tools/drm

2018-08-21 Thread Matt Macy
Author: mmacy Date: Wed Aug 22 02:53:35 2018 New Revision: 338176 URL: https://svnweb.freebsd.org/changeset/base/338176 Log: r338172 follow - remove firmwares Deleted: head/sys/contrib/dev/drm2/ head/tools/tools/drm/ Modified: head/sys/conf/files Modified: head/sys/conf/files

Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/d

2018-08-21 Thread Matthew Macy
> > Could you please create a stable/11 deprecation change. > What does that entail other than an update to UPDATING in stable/11? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any

svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/dr...

2018-08-21 Thread Matt Macy
/UPDATING Wed Aug 22 01:50:12 2018(r338172) @@ -31,6 +31,13 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW: disable the most expensive debugging functionality run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) +20180821: + drm and drm2

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Matthew Macy
On Tue, Aug 21, 2018 at 16:52 Mark Johnston wrote: > On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > > Yes. See r338162. Thanks. > > You missed instances of the same bug in in_mcast.c and in6_mcast.c. Thanks > > > > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff > wrote: > >

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Mark Johnston
On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > Yes. See r338162. Thanks. You missed instances of the same bug in in_mcast.c and in6_mcast.c. > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff wrote: > > On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: > > M> @@ -3772,8

svn commit: r338168 - head/stand/lua

2018-08-21 Thread Kyle Evans
Author: kevans Date: Tue Aug 21 23:42:20 2018 New Revision: 338168 URL: https://svnweb.freebsd.org/changeset/base/338168 Log: lualoader: Refactor config line expressions A couple of issues addressed: 1.) Modules with - in the name were not recognized as modules 2.) The module regex

svn commit: r338166 - head/sys/dev/cxgbe

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 23:33:38 2018 New Revision: 338166 URL: https://svnweb.freebsd.org/changeset/base/338166 Log: cxgbe(4): Be explicit about ignoring the return value of cmpset in some cases. Reported by: Coverity (CIDs 1009398, 1009400, 1009401, 1357325, 1394783). All false

svn commit: r338167 - head/stand/lua

2018-08-21 Thread Kyle Evans
Author: kevans Date: Tue Aug 21 23:34:30 2018 New Revision: 338167 URL: https://svnweb.freebsd.org/changeset/base/338167 Log: lualoader: Just compare expression directly Modified: head/stand/lua/core.lua Modified: head/stand/lua/core.lua

svn commit: r338165 - head/usr.sbin/newsyslog

2018-08-21 Thread Conrad Meyer
Author: cem Date: Tue Aug 21 23:12:46 2018 New Revision: 338165 URL: https://svnweb.freebsd.org/changeset/base/338165 Log: newsyslog(8): Reject configurations that specify setuid or executable logs Prevent some classes of foot-shooting that may result in permissions problems.

svn commit: r338164 - head/usr.sbin/bhyve

2018-08-21 Thread Marcelo Araujo
Author: araujo Date: Tue Aug 21 23:11:26 2018 New Revision: 338164 URL: https://svnweb.freebsd.org/changeset/base/338164 Log: Fix resource leak when using strdup(3). Reported by: Coverity CID: 1394929 Sponsored by: iXsystems Inc. Modified: head/usr.sbin/bhyve/pci_nvme.c

svn commit: r338163 - head/sys/netinet6

2018-08-21 Thread Matt Macy
Author: mmacy Date: Tue Aug 21 23:03:02 2018 New Revision: 338163 URL: https://svnweb.freebsd.org/changeset/base/338163 Log: Fix null deref in mld_v1_transmit_report After r337866 it is possible for an in_multi6 to be referenced while mid teardown. Handle case of cleared ifnet pointer.

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Matthew Macy
Yes. See r338162. Thanks. -M On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff wrote: > On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: > M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct > ifmultiad > M> ll_ifma->ifma_ifp = NULL; /* XXX */

svn commit: r338162 - head/sys/net

2018-08-21 Thread Matt Macy
Author: mmacy Date: Tue Aug 21 22:59:22 2018 New Revision: 338162 URL: https://svnweb.freebsd.org/changeset/base/338162 Log: fix copy/paste error when clearing ifma flag CID: 1395119 Reported by: vangyzen Modified: head/sys/net/if.c Modified: head/sys/net/if.c

svn commit: r338161 - head/sys/dev/cxgbe/tom

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 22:19:34 2018 New Revision: 338161 URL: https://svnweb.freebsd.org/changeset/base/338161 Log: cxgbe/tom: Make sure 'matched' is always initialized before use. Reported by: Coverity (CID 1390894) MFC after:1 week Sponsored by: Chelsio Communications

svn commit: r338160 - head/sys/dev/cxgbe

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 22:15:57 2018 New Revision: 338160 URL: https://svnweb.freebsd.org/changeset/base/338160 Log: cxgbe(4): Do not leak memory in case of errors during VI initialization. Reported by: Coverity (CID 1392026) MFC after:1 week Sponsored by: Chelsio

svn commit: r338159 - head/sys/dev/cxgbe

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 21:42:17 2018 New Revision: 338159 URL: https://svnweb.freebsd.org/changeset/base/338159 Log: cxgbe(4): Make it clear that VI_INIT_DONE implies vi->ntxq > 0, and so rc will never be returned uninitialized. Reported by: Coverity (CID 1394884). This is a false

Re: svn commit: r337932 - in head/sys: net netinet

2018-08-21 Thread Gleb Smirnoff
On Tue, Aug 21, 2018 at 02:28:27PM -0700, Navdeep Parhar wrote: N> On 8/21/18 2:26 PM, Gleb Smirnoff wrote: N> > Navdeep, N> > N> > On Thu, Aug 16, 2018 at 11:46:38PM +, Navdeep Parhar wrote: N> > N> Author: np N> > N> Date: Thu Aug 16 23:46:38 2018 N> > N> New Revision: 337932 N> > N> URL:

svn commit: r338158 - head/sys/dev/cxgbe

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 21:32:51 2018 New Revision: 338158 URL: https://svnweb.freebsd.org/changeset/base/338158 Log: cxgbe(4): Check the RO bit properly before disabling relaxed ordering. Reported by: Coverity (CID 1384286) MFC after:1 week Sponsored by: Chelsio

svn commit: r338157 - in head/sys: arm64/conf conf

2018-08-21 Thread Oleksandr Tymoshenko
Author: gonzo Date: Tue Aug 21 21:30:19 2018 New Revision: 338157 URL: https://svnweb.freebsd.org/changeset/base/338157 Log: Add muge(4) to the arm64 GENERIC kernel muge(4) is the USB ethernet adapter that is used in RPi 3B+. Shipping it in GENERIC kernel allows using NFS root out of the

Re: svn commit: r337932 - in head/sys: net netinet

2018-08-21 Thread Navdeep Parhar
On 8/21/18 2:26 PM, Gleb Smirnoff wrote: > Navdeep, > > On Thu, Aug 16, 2018 at 11:46:38PM +, Navdeep Parhar wrote: > N> Author: np > N> Date: Thu Aug 16 23:46:38 2018 > N> New Revision: 337932 > N> URL: https://svnweb.freebsd.org/changeset/base/337932 > N> > N> Log: > N> Add the ability

Re: svn commit: r337932 - in head/sys: net netinet

2018-08-21 Thread Gleb Smirnoff
Navdeep, On Thu, Aug 16, 2018 at 11:46:38PM +, Navdeep Parhar wrote: N> Author: np N> Date: Thu Aug 16 23:46:38 2018 N> New Revision: 337932 N> URL: https://svnweb.freebsd.org/changeset/base/337932 N> N> Log: N> Add the ability to look up the 3b PCP of a VLAN interface. Use it in N>

Re: svn commit: r337866 - in head/sys: net netinet netinet6

2018-08-21 Thread Gleb Smirnoff
On Wed, Aug 15, 2018 at 08:23:09PM +, Matt Macy wrote: M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct ifmultiad M> ll_ifma->ifma_ifp = NULL; /* XXX */ M> if (--ll_ifma->ifma_refcount == 0) { M> if (ifp !=

svn commit: r338156 - head/sys/dev/cxgbe/common

2018-08-21 Thread Navdeep Parhar
Author: np Date: Tue Aug 21 21:08:58 2018 New Revision: 338156 URL: https://svnweb.freebsd.org/changeset/base/338156 Log: cxgbe(4): Avoid overflow while calculating channel rate. Reported by: Coverity (CID 1008352) MFC after:1 week Sponsored by: Chelsio Communications Modified:

Re: svn commit: r337978 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv

2018-08-21 Thread Kyle Evans
On Tue, Aug 21, 2018 at 1:26 PM, Brooks Davis wrote: > On Mon, Aug 20, 2018 at 08:08:01PM +0200, Michal Meloun wrote: >> >> On 20.08.2018 18:02, Kyle Evans wrote: >> > On Mon, Aug 20, 2018 at 11:00 AM, Michal Meloun >> > wrote: >> >> >> >> On 17.08.2018 18:19, Brooks Davis wrote: >> >>> Author:

svn commit: r338155 - in head: etc etc/bluetooth etc/defaults lib/libbluetooth usr.sbin/bluetooth/hccontrol usr.sbin/bluetooth/hcsecd

2018-08-21 Thread Brad Davis
Author: brd Date: Tue Aug 21 19:28:53 2018 New Revision: 338155 URL: https://svnweb.freebsd.org/changeset/base/338155 Log: Move all bluetooth related config files out of etc This helps with pkgbase by switching to CONFS so they are properly tagged as config files. Approved by: will

svn commit: r338154 - head/contrib/wpa/src/drivers

2018-08-21 Thread Cy Schubert
Author: cy Date: Tue Aug 21 19:17:35 2018 New Revision: 338154 URL: https://svnweb.freebsd.org/changeset/base/338154 Log: For CID 1394785, add a comment explaining that global->event_buf is not really a char * but a struct rt_msghdr *. MFC after:3 days Modified:

svn commit: r338153 - head/sys/fs/fuse

2018-08-21 Thread Fedor Uporov
Author: fsu Date: Tue Aug 21 18:50:29 2018 New Revision: 338153 URL: https://svnweb.freebsd.org/changeset/base/338153 Log: FUSE extattrs: fix issue when neither uio nor size were not passed to VOP_* (cosmetic only). Reviewed by:cem, pfg MFC after: 2 weeks Differential

svn commit: r338152 - head/sys/fs/fuse

2018-08-21 Thread Fedor Uporov
Author: fsu Date: Tue Aug 21 18:39:47 2018 New Revision: 338152 URL: https://svnweb.freebsd.org/changeset/base/338152 Log: FUSE extattrs: fix issue when neither uio nor size were not passed to VOP_*. The requested size was returned incorrectly in case uio == NULL from listextattr because

svn commit: r338151 - head/sys/fs/ext2fs

2018-08-21 Thread Fedor Uporov
Author: fsu Date: Tue Aug 21 18:39:29 2018 New Revision: 338151 URL: https://svnweb.freebsd.org/changeset/base/338151 Log: Change unused inodes counters behavior in the cylinder groups. Make it more close to native ext4 implementation to avoid fsck errors. Modified:

svn commit: r338150 - head/sys/fs/ext2fs

2018-08-21 Thread Fedor Uporov
Author: fsu Date: Tue Aug 21 18:39:02 2018 New Revision: 338150 URL: https://svnweb.freebsd.org/changeset/base/338150 Log: Fix directory blocks checksum updating logic. Count dirent tail in the searchslot logic in case of directory block search. Add htree root csum update function call

Re: svn commit: r337978 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv

2018-08-21 Thread Brooks Davis
On Mon, Aug 20, 2018 at 08:08:01PM +0200, Michal Meloun wrote: > > On 20.08.2018 18:02, Kyle Evans wrote: > > On Mon, Aug 20, 2018 at 11:00 AM, Michal Meloun > > wrote: > >> > >> On 17.08.2018 18:19, Brooks Davis wrote: > >>> Author: brooks > >>> Date: Fri Aug 17 16:19:47 2018 > >>> New

svn commit: r338149 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv

2018-08-21 Thread Brooks Davis
Author: brooks Date: Tue Aug 21 18:22:12 2018 New Revision: 338149 URL: https://svnweb.freebsd.org/changeset/base/338149 Log: Revert r337978: Rework rtld's TLS Variant I implementation to match r326794 Michal Meloun reports that it breaks ctype (isspace()..) related functions on armv7 so

svn commit: r338148 - head/sys/x86/isa

2018-08-21 Thread John Baldwin
Author: jhb Date: Tue Aug 21 17:13:51 2018 New Revision: 338148 URL: https://svnweb.freebsd.org/changeset/base/338148 Log: Remove 'imen' global variable from atpic(4). In pre-SMPng, the global 'imen' was used to track mask state of the hardware interrupts and was aligned to the masks

svn commit: r338147 - in head: etc libexec/ftpd

2018-08-21 Thread Brad Davis
Author: brd Date: Tue Aug 21 17:07:52 2018 New Revision: 338147 URL: https://svnweb.freebsd.org/changeset/base/338147 Log: Move ftpusers to libexec/ftpd/ Thsi helps with pkgbase by switching to CONFS so that ftpusers will be properly tagged as a config file. Approved by: will

svn commit: r338146 - in head: etc etc/syslog.d usr.sbin/syslogd

2018-08-21 Thread Brad Davis
Author: brd Date: Tue Aug 21 17:01:47 2018 New Revision: 338146 URL: https://svnweb.freebsd.org/changeset/base/338146 Log: Move all syslogd related configs to usr.sbin/syslogd/ This helps with pkgbase as it switches these to use CONFS which properly tags them as config files.

svn commit: r338145 - head/tools/build/mk

2018-08-21 Thread Alex Richardson
Author: arichardson Date: Tue Aug 21 16:52:14 2018 New Revision: 338145 URL: https://svnweb.freebsd.org/changeset/base/338145 Log: Relax the check added in 338096 Checking for any include below ${SRCTOP}/sys is too strict and breaks e.g. mkimg which includes sys/sys/disk. ABI issues will

svn commit: r338144 - in head: etc etc/devd sbin/devd

2018-08-21 Thread Brad Davis
Author: brd Date: Tue Aug 21 16:51:45 2018 New Revision: 338144 URL: https://svnweb.freebsd.org/changeset/base/338144 Log: Move all devd related configs to sbin/devd/ This helps with pkgbase as it switches these to using CONFS so they are properly tagged as config files. Approved

svn commit: r338143 - in head/sys: amd64/amd64 arm/arm arm64/arm64 compat/linuxkpi/common/src dev/hyperv/vmbus i386/i386 mips/mips powerpc/powerpc riscv/riscv sparc64/sparc64 vm x86/xen

2018-08-21 Thread Alan Cox
Author: alc Date: Tue Aug 21 16:43:46 2018 New Revision: 338143 URL: https://svnweb.freebsd.org/changeset/base/338143 Log: Eliminate kmem_malloc()'s unused arena parameter. (The arena parameter became unused in FreeBSD 12.x as a side-effect of the NUMA-related changes.) Reviewed by:

svn commit: r338142 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-08-21 Thread Mark Johnston
Author: markj Date: Tue Aug 21 16:37:37 2018 New Revision: 338142 URL: https://svnweb.freebsd.org/changeset/base/338142 Log: Set arc_kmem_cache_reap_retry_ms to 0 and make it configurable. r329759 introduced this parameter, which controls the rate at which ZFS UMA zones are drained when

svn commit: r338141 - head/release

2018-08-21 Thread Colin Percival
Author: cperciva Date: Tue Aug 21 15:30:47 2018 New Revision: 338141 URL: https://svnweb.freebsd.org/changeset/base/338141 Log: Quieten the svn (or svnlite) commands used to extract information from an SVN checkout for placement into an EC2 AMI. We only run these if there is a .svn

svn commit: r338140 - head/usr.bin/dtc

2018-08-21 Thread John-Mark Gurney
Author: jmg Date: Tue Aug 21 15:11:43 2018 New Revision: 338140 URL: https://svnweb.freebsd.org/changeset/base/338140 Log: minor grammar nit, to what? between them.. Modified: head/usr.bin/dtc/dtc.1 Modified: head/usr.bin/dtc/dtc.1

svn commit: r338139 - head/sys/cam/ctl

2018-08-21 Thread Edward Tomasz Napierala
Author: trasz Date: Tue Aug 21 14:34:24 2018 New Revision: 338139 URL: https://svnweb.freebsd.org/changeset/base/338139 Log: Remove unneccessary code, which also introduced a (very minor) race condition, due to a missing call to cfiscsi_target_release(). Discussed with: mav@

svn commit: r338138 - head/sys/netinet

2018-08-21 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 21 14:12:30 2018 New Revision: 338138 URL: https://svnweb.freebsd.org/changeset/base/338138 Log: Enabling the IPPROTO_IPV6 level socket option IPV6_USE_MIN_MTU on a TCP socket resulted in sending fragmented IPV6 packets. This is fixes by reducing the MSS to

svn commit: r338137 - head/sys/netinet

2018-08-21 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 21 14:07:36 2018 New Revision: 338137 URL: https://svnweb.freebsd.org/changeset/base/338137 Log: Fix the inheritance of IPv6 level socket options on TCP sockets. This was broken for IPv6 listening socket, which are not IPV6_ONLY, and the accepted TCP

svn commit: r338136 - in head: lib/libc/sys sys/kern sys/sys

2018-08-21 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 21 14:04:30 2018 New Revision: 338136 URL: https://svnweb.freebsd.org/changeset/base/338136 Log: Add SOL_SOCKET level socket option with name SO_DOMAIN to get the domain of a socket. This is helpful when testing and Solaris and Linux have the same socket

svn commit: r338135 - head/sys/netinet

2018-08-21 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 21 13:37:06 2018 New Revision: 338135 URL: https://svnweb.freebsd.org/changeset/base/338135 Log: Whitespace change. Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r338134 - head/sys/netinet

2018-08-21 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 21 13:25:32 2018 New Revision: 338134 URL: https://svnweb.freebsd.org/changeset/base/338134 Log: Refactor the SHUTDOWN_PENDING state handling. This is not a functional change but a preperation for the upcoming DTrace support. It is necessary to change the

svn commit: r338133 - head/usr.sbin/gstat

2018-08-21 Thread Marcelo Araujo
Author: araujo Date: Tue Aug 21 11:22:49 2018 New Revision: 338133 URL: https://svnweb.freebsd.org/changeset/base/338133 Log: - Add CSV output to gstat via -C flag. Add a -C option, similar to -B, that allows gstat to produce basic CSV output with absolute timestamps (ISO 8601, nearly.)

svn commit: r338130 - head/sys/dev/mly

2018-08-21 Thread John Baldwin
Author: jhb Date: Tue Aug 21 10:08:12 2018 New Revision: 338130 URL: https://svnweb.freebsd.org/changeset/base/338130 Log: De-spl mly(4). The driver already has mutex locking and holds its per-softc lock across calls to the one function that still used splcam(). Modified:

svn commit: r338129 - head/tools/build/mk

2018-08-21 Thread Alex Richardson
Author: arichardson Date: Tue Aug 21 09:35:56 2018 New Revision: 338129 URL: https://svnweb.freebsd.org/changeset/base/338129 Log: Fix -DWITHOUT_AUTO_OBJ build of rescue after r338096 Approved By: jhb (mentor) Modified: head/tools/build/mk/Makefile.boot Modified:

Re: svn commit: r338128 - in head: cddl/lib/libzpool cddl/usr.bin/ztest cddl/usr.sbin/zdb sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys sys/conf sys/modules/zfs

2018-08-21 Thread Bruce Evans
On Tue, 21 Aug 2018, John Baldwin wrote: On 8/21/18 4:45 AM, Matt Macy wrote: ... Log: Make dnode definition uniform on !x86 gcc4 requires -fms-extensions to accept anonymous union members It does not. Anonymous unions have been a standard gcc extension since ~1989, but these are

Re: svn commit: r338128 - in head: cddl/lib/libzpool cddl/usr.bin/ztest cddl/usr.sbin/zdb sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys sys/conf sys/modules/zfs

2018-08-21 Thread John Baldwin
On 8/21/18 4:45 AM, Matt Macy wrote: > Author: mmacy > Date: Tue Aug 21 03:45:09 2018 > New Revision: 338128 > URL: https://svnweb.freebsd.org/changeset/base/338128 > > Log: > Make dnode definition uniform on !x86 > > gcc4 requires -fms-extensions to accept anonymous union members > >

Re: svn commit: r338118 - head/sys/ufs/ffs

2018-08-21 Thread Dimitry Andric
On 20 Aug 2018, at 23:19, Kirk McKusick wrote: > > Author: mckusick > Date: Mon Aug 20 21:19:21 2018 > New Revision: 338118 > URL: https://svnweb.freebsd.org/changeset/base/338118 > > Log: > TRIM consolodation is supposed to be off by default > > Modified: > head/sys/ufs/ffs/ffs_alloc.c > >