Re: svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Bruce Evans
On Sat, 26 Jan 2019, Stefan Esser wrote: Am 26.01.19 um 22:59 schrieb Colin Percival: ... The length of the string was already being recalculated, by strcpy. It seems to me that this could be written as temp = malloc(slen + 1); if (temp == NULL) /* could not allocate memory

svn commit: r343486 - head/contrib/ipfilter/man

2019-01-26 Thread Cy Schubert
Author: cy Date: Sun Jan 27 02:31:42 2019 New Revision: 343486 URL: https://svnweb.freebsd.org/changeset/base/343486 Log: Fix a typo. MFC after:3 days Modified: head/contrib/ipfilter/man/ipnat.5 Modified: head/contrib/ipfilter/man/ipnat.5

svn commit: r343485 - in head: lib/libprocstat sys/kern sys/sys

2019-01-26 Thread Konstantin Belousov
Author: kib Date: Sun Jan 27 00:46:06 2019 New Revision: 343485 URL: https://svnweb.freebsd.org/changeset/base/343485 Log: Bump SPECNAMELEN to MAXNAMLEN. This includes the bump for cdevsw d_version. Otherwise, the impact on the ABI (not KBI) is surprisingly low. The most important

svn commit: r343484 - head/libexec/rtld-elf

2019-01-26 Thread Konstantin Belousov
Author: kib Date: Sun Jan 27 00:37:52 2019 New Revision: 343484 URL: https://svnweb.freebsd.org/changeset/base/343484 Log: Remove now redundand ifunc relocation code which should have been removed as part of r341441. This call to reloc_non_plt() may crash if ifunc resolvers use the

Re: svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Devin Teske
> On 26 Jan 2019, at 1:59 PM, Colin Percival wrote: > > On 1/26/19 1:36 PM, Rodney W. Grimes wrote: >>> Author: se >>> Date: Sat Jan 26 21:30:26 2019 >>> New Revision: 343480 >>> URL: https://svnweb.freebsd.org/changeset/base/343480 >>> >>> Log: >>> Silence Clang Scan warning about

Re: svn commit: r343483 - in head/sbin: newfs tunefs

2019-01-26 Thread Dmitry Morozovsky
Kirk, On Sat, 26 Jan 2019, Kirk McKusick wrote: > Author: mckusick > Date: Sat Jan 26 22:27:12 2019 > New Revision: 343483 > URL: https://svnweb.freebsd.org/changeset/base/343483 > > Log: > Update tunefs and newfs error messages for the -L (volume label) option > to note that underscores

svn commit: r343483 - in head/sbin: newfs tunefs

2019-01-26 Thread Kirk McKusick
Author: mckusick Date: Sat Jan 26 22:27:12 2019 New Revision: 343483 URL: https://svnweb.freebsd.org/changeset/base/343483 Log: Update tunefs and newfs error messages for the -L (volume label) option to note that underscores are valid. PR: 235182 Reported by: Rodney W.

Re: svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Stefan Esser
Am 26.01.19 um 22:59 schrieb Colin Percival: > On 1/26/19 1:36 PM, Rodney W. Grimes wrote: >>> Author: se >>> Date: Sat Jan 26 21:30:26 2019 >>> New Revision: 343480 >>> URL: https://svnweb.freebsd.org/changeset/base/343480 >>> >>> Log: >>> Silence Clang Scan warning about potentially unsafe use

svn commit: r343482 - head/lib/libfigpar

2019-01-26 Thread Stefan Esser
Author: se Date: Sat Jan 26 22:24:15 2019 New Revision: 343482 URL: https://svnweb.freebsd.org/changeset/base/343482 Log: Slightly improve previous commit that silenced a Clang Scan warning. The strdup() call does not take advantage of the known length of the source string. Replace by

Re: svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Colin Percival
On 1/26/19 1:36 PM, Rodney W. Grimes wrote: >> Author: se >> Date: Sat Jan 26 21:30:26 2019 >> New Revision: 343480 >> URL: https://svnweb.freebsd.org/changeset/base/343480 >> >> Log: >> Silence Clang Scan warning about potentially unsafe use of strcpy. >> >> While this is a false positive,

svn commit: r343481 - head/sys/net

2019-01-26 Thread Marius Strobl
Author: marius Date: Sat Jan 26 21:35:51 2019 New Revision: 343481 URL: https://svnweb.freebsd.org/changeset/base/343481 Log: - In _iflib_fl_refill(), don't mark an RX buffer as available in the corresponding bitmap before adding an mbuf has actually succeeded. Previously,

Re: svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Rodney W. Grimes
> Author: se > Date: Sat Jan 26 21:30:26 2019 > New Revision: 343480 > URL: https://svnweb.freebsd.org/changeset/base/343480 > > Log: > Silence Clang Scan warning about potentially unsafe use of strcpy. > > While this is a false positive, the use of strdup() simplifies the code. Though

svn commit: r343480 - head/lib/libfigpar

2019-01-26 Thread Stefan Esser
Author: se Date: Sat Jan 26 21:30:26 2019 New Revision: 343480 URL: https://svnweb.freebsd.org/changeset/base/343480 Log: Silence Clang Scan warning about potentially unsafe use of strcpy. While this is a false positive, the use of strdup() simplifies the code. MFC after:2 weeks

svn commit: r343479 - head/libexec/getty

2019-01-26 Thread Stefan Esser
Author: se Date: Sat Jan 26 20:43:28 2019 New Revision: 343479 URL: https://svnweb.freebsd.org/changeset/base/343479 Log: Fix potential buffer overflow and undefined behavior. The buffer allocated in read_chat() could be 1 element too short, if the chatstr parameter passed in is 1 or 3

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Ian Lepore
On Sat, 2019-01-26 at 11:11 -0800, Conrad Meyer wrote: > I didn't really feel the need to weigh in on this bikeshed thread > previously, but apparently some folks are calling for a revert. Why? > I don't really understand how this meets the high bar for summary > revert, even if you disagree with

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Conrad Meyer
I didn't really feel the need to weigh in on this bikeshed thread previously, but apparently some folks are calling for a revert. Why? I don't really understand how this meets the high bar for summary revert, even if you disagree with the change made (and disagreement is fine, of course). So

svn commit: r343478 - head/tools/kerneldoc/subsys

2019-01-26 Thread Alexander Leidinger
Author: netchild Date: Sat Jan 26 18:23:19 2019 New Revision: 343478 URL: https://svnweb.freebsd.org/changeset/base/343478 Log: Catch up with some years of driver development. Most impressive in terms of doxygen stuff are the isci and ocs_fc drivers. Added:

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Devin Teske
> On Jan 26, 2019, at 9:55 AM, Ian Lepore wrote: > > On Sat, 2019-01-26 at 09:17 -0800, Rodney W. Grimes wrote: >>> On Sat, 2019-01-26 at 13:18 +, Edward Napierala wrote: On 0125T1647, Devin Teske wrote: >> On Jan 25, 2019, at 1:13 AM, Edward Napierala < >> tr...@freebsd.org>

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Ian Lepore
On Sat, 2019-01-26 at 09:17 -0800, Rodney W. Grimes wrote: > > On Sat, 2019-01-26 at 13:18 +, Edward Napierala wrote: > > > On 0125T1647, Devin Teske wrote: > > > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala < > > > > > tr...@freebsd.org> > > > > > wrote: > > > > > On 0125T1530, Devin

svn commit: r343477 - head/sys/dev/iwm

2019-01-26 Thread Bjoern A. Zeeb
Author: bz Date: Sat Jan 26 17:52:12 2019 New Revision: 343477 URL: https://svnweb.freebsd.org/changeset/base/343477 Log: Fix logic errors in iwm_pcie_load_firmware_chunk introduced in r314065. * There's no reason to have a while() loop here, because: - if msleep returns 0, that

svn commit: r343476 - head

2019-01-26 Thread Andriy Voskoboinyk
== --- head/ObsoleteFiles.inc Sat Jan 26 17:17:25 2019(r343475) +++ head/ObsoleteFiles.inc Sat Jan 26 17:27:12 2019(r343476) @@ -38,6 +38,9 @@ # xargs -n1 | sort | uniq -d; # done +# 20190126: adv(4) / adw(4) removal +OLD_FILES

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Rodney W. Grimes
> On 0125T1647, Devin Teske wrote: > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala wrote: > > > On 0125T1530, Devin Teske wrote: > > >>> On Jan 25, 2019, at 12:28 AM, Edward Napierala > > >>> wrote: > > >>> On 0125T1441, Devin Teske wrote: > > > On Jan 25, 2019, at 1:37 PM, Edward

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Rodney W. Grimes
> On Sat, 2019-01-26 at 13:18 +, Edward Napierala wrote: > > On 0125T1647, Devin Teske wrote: > > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala > > > > wrote: > > > > On 0125T1530, Devin Teske wrote: > > > > > > On Jan 25, 2019, at 12:28 AM, Edward Napierala < > > > > > >

svn commit: r343475 - head/sys/geom/uzip

2019-01-26 Thread Andriy Voskoboinyk
Author: avos Date: Sat Jan 26 17:17:25 2019 New Revision: 343475 URL: https://svnweb.freebsd.org/changeset/base/343475 Log: geom_uzip(4): set 'gp != NULL' assertion on top of the function There was yet another access to this variable in g_trace() few lines upper. PR:

svn commit: r343474 - in head/sys: dev/bwi dev/iwi dev/ral dev/rtwn dev/usb/wlan net80211

2019-01-26 Thread Andriy Voskoboinyk
Author: avos Date: Sat Jan 26 17:00:55 2019 New Revision: 343474 URL: https://svnweb.freebsd.org/changeset/base/343474 Log: Remove 2GHz channel list copies from wireless drivers. Wrap ieee80211_add_channel_list_2ghz into another function which supplies default (1-14) channel list to it

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Ian Lepore
On Sat, 2019-01-26 at 13:18 +, Edward Napierala wrote: > On 0125T1647, Devin Teske wrote: > > > > > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala > > > wrote: > > > > > > On 0125T1530, Devin Teske wrote: > > > > > > > > > > > > > On Jan 25, 2019, at 12:28 AM, Edward Napierala < > > >

svn commit: r343473 - head/sys/geom/uzip

2019-01-26 Thread Andriy Voskoboinyk
Author: avos Date: Sat Jan 26 14:54:06 2019 New Revision: 343473 URL: https://svnweb.freebsd.org/changeset/base/343473 Log: geom_uzip(4): move NULL pointer KASSERT check before it is dereferenced PR: 203499 Submitted by: MFC after:5 days Modified:

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Edward Napierala
sob., 26 sty 2019 o 01:38 Rodney W. Grimes napisaƂ(a): > > > On 0125T1705, Rodney W. Grimes wrote: > > > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala > > > > > wrote: > > > > > > Chop with the big axe most of this as I need to clarify a miss statement. > > > ... > > > > > The change we're

svn commit: r343472 - head/share/man/man4

2019-01-26 Thread Andriy Voskoboinyk
Author: avos Date: Sat Jan 26 14:14:25 2019 New Revision: 343472 URL: https://svnweb.freebsd.org/changeset/base/343472 Log: otus(4): fix a typo in man page (802.11 -> 802.11n) MFC after:3 days Modified: head/share/man/man4/otus.4 Modified: head/share/man/man4/otus.4

svn commit: r343471 - head/lib/libcasper/libcasper

2019-01-26 Thread Mariusz Zaborski
Author: oshogbo Date: Sat Jan 26 14:10:49 2019 New Revision: 343471 URL: https://svnweb.freebsd.org/changeset/base/343471 Log: libcasper: do not run registered exit functions Casper library should not use exit(3) function because before setting it up applications may register it. Casper

svn commit: r343470 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2019-01-26 Thread Mariusz Zaborski
Author: oshogbo Date: Sat Jan 26 13:53:00 2019 New Revision: 343470 URL: https://svnweb.freebsd.org/changeset/base/343470 Log: zfs: allow to change cache flush sysctl There is no reason for this variable to be tunable. This variable is used as a barrier in few places. Discussed

Re: svn commit: r343440 - head/bin/sh

2019-01-26 Thread Edward Napierala
On 0125T1647, Devin Teske wrote: > > > > On Jan 25, 2019, at 1:13 AM, Edward Napierala wrote: > > > > On 0125T1530, Devin Teske wrote: > >> > >> > >>> On Jan 25, 2019, at 12:28 AM, Edward Napierala wrote: > >>> > >>> On 0125T1441, Devin Teske wrote: > > > > On Jan 25, 2019,