Re: svn commit: r348886 - in head/sys/riscv: include riscv

2019-06-10 Thread Mitchell Horne
On Mon, Jun 10, 2019 at 9:12 PM Ian Lepore wrote: > > On Tue, 2019-06-11 at 00:55 +, Mitchell Horne wrote: > > Author: mhorne > > Date: Tue Jun 11 00:55:54 2019 > > New Revision: 348886 > > URL: https://svnweb.freebsd.org/changeset/base/348886 > > > > Log: > > RISC-V: expose extension bits

Re: svn commit: r348886 - in head/sys/riscv: include riscv

2019-06-10 Thread Ian Lepore
On Tue, 2019-06-11 at 00:55 +, Mitchell Horne wrote: > Author: mhorne > Date: Tue Jun 11 00:55:54 2019 > New Revision: 348886 > URL: https://svnweb.freebsd.org/changeset/base/348886 > > Log: > RISC-V: expose extension bits in AT_HWCAP > > AT_HWCAP is a field in the elf auxiliary vector

svn commit: r348887 - head/usr.bin/procstat

2019-06-10 Thread Mitchell Horne
Author: mhorne Date: Tue Jun 11 00:59:46 2019 New Revision: 348887 URL: https://svnweb.freebsd.org/changeset/base/348887 Log: procstat: Recognize HWCAP and HWCAP2 with auxv command The two most recent additions to the elf auxiliary vector are HWCAP and HWCAP2 which describe platform

svn commit: r348886 - in head/sys/riscv: include riscv

2019-06-10 Thread Mitchell Horne
Author: mhorne Date: Tue Jun 11 00:55:54 2019 New Revision: 348886 URL: https://svnweb.freebsd.org/changeset/base/348886 Log: RISC-V: expose extension bits in AT_HWCAP AT_HWCAP is a field in the elf auxiliary vector meant to describe cpu-specific hardware features. For RISC-V we want to

svn commit: r348885 - in head/sys: arm/allwinner arm/broadcom/bcm2835 arm64/rockchip

2019-06-10 Thread Bjoern A. Zeeb
Author: bz Date: Mon Jun 10 23:25:40 2019 New Revision: 348885 URL: https://svnweb.freebsd.org/changeset/base/348885 Log: A bit of code hygiene (no functional changes). Hide unused code under #ifdef notyet (in one case the only caller is under that same ifdef), or if it is arm (not

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Warner Losh
On Mon, Jun 10, 2019 at 10:51 AM Conrad Meyer wrote: > On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote: > > Only headers and libraries should support -std=c89. has > > lots of support for compilers and POSIX versions going back to K C, > > and only the K parts are completely broken. > > Is

svn commit: r348883 - head/sys/vm

2019-06-10 Thread Doug Moore
Author: dougm Date: Mon Jun 10 22:06:40 2019 New Revision: 348883 URL: https://svnweb.freebsd.org/changeset/base/348883 Log: r348879 introduced a wrong-way comparison that broke mmap. This change rights that comparison. Reported by: pho Approved by: markj (mentor) MFC after: 3 days

svn commit: r348882 - head/sys/dev/sdhci

2019-06-10 Thread Luiz Otavio O Souza
Author: loos Date: Mon Jun 10 21:50:07 2019 New Revision: 348882 URL: https://svnweb.freebsd.org/changeset/base/348882 Log: Add support for the GPIO SD Card VCC regulator/switch and the GPIO SD Card detection pins to the Marvell Xenon SDHCI controller. These features are enable by

svn commit: r348881 - head/sys/vm

2019-06-10 Thread Doug Moore
Author: dougm Date: Mon Jun 10 21:34:07 2019 New Revision: 348881 URL: https://svnweb.freebsd.org/changeset/base/348881 Log: The computations of vm_map_splay_split and vm_map_splay_merge touch both children of every entry on the search path as part of updating values of the max_free field.

svn commit: r348878 - head/sys/arm/broadcom/bcm2835

2019-06-10 Thread Bjoern A. Zeeb
Author: bz Date: Mon Jun 10 21:24:38 2019 New Revision: 348878 URL: https://svnweb.freebsd.org/changeset/base/348878 Log: Add a bus_add_child device method to bcm2835_sdhci. This allows SDIO (through CAM) to attach to an upstream, e.g., .. sdhci_bcm0 pnpinfo

svn commit: r348879 - in head/sys: sys vm

2019-06-10 Thread Doug Moore
Author: dougm Date: Mon Jun 10 21:26:14 2019 New Revision: 348879 URL: https://svnweb.freebsd.org/changeset/base/348879 Log: Change the check for 'size' wrapping around to zero in kern_mmap to account for both the lower and upper bound modifications. Change the error returned to ENOMEM.

svn commit: r348880 - in head/sys: arm/mv arm64/conf conf

2019-06-10 Thread Luiz Otavio O Souza
Author: loos Date: Mon Jun 10 21:27:21 2019 New Revision: 348880 URL: https://svnweb.freebsd.org/changeset/base/348880 Log: Add the GPIO driver for the North/South bridge in Marvell Armada 37x0. The A3700 has a different GPIO controller and thus, do not use the old (and shared) code for

Re: svn commit: r348873 - head/sys/dev/atkbdc

2019-06-10 Thread Rodney W. Grimes
> Author: zeising (doc,ports committer) > Date: Mon Jun 10 18:19:49 2019 > New Revision: 348873 > URL: https://svnweb.freebsd.org/changeset/base/348873 > > Log: > psm(4): Enable touchpads and trackpads by default > > Enable synaptics and elantech touchpads, as well as IBM/Lenovo

Re: svn commit: r348876 - head/sys/opencrypto

2019-06-10 Thread John Baldwin
On 6/10/19 12:26 PM, John Baldwin wrote: > Author: jhb > Date: Mon Jun 10 19:26:57 2019 > New Revision: 348876 > URL: https://svnweb.freebsd.org/changeset/base/348876 > > Log: > Add warnings to /dev/crypto for deprecated algorithms. > > These algorithms are deprecated algorithms that will

svn commit: r348877 - head/share/mk

2019-06-10 Thread Bryan Drewery
Author: bdrewery Date: Mon Jun 10 19:38:35 2019 New Revision: 348877 URL: https://svnweb.freebsd.org/changeset/base/348877 Log: DPSRCS need to be built before recursing. MFC after:2 weeks Sponsored by: DellEMC Modified: head/share/mk/bsd.progs.mk Modified:

Re: svn commit: r348876 - head/sys/opencrypto

2019-06-10 Thread John Baldwin
On 6/10/19 12:26 PM, John Baldwin wrote: > Author: jhb > Date: Mon Jun 10 19:26:57 2019 > New Revision: 348876 > URL: https://svnweb.freebsd.org/changeset/base/348876 > > Log: > Add warnings to /dev/crypto for deprecated algorithms. > > These algorithms are deprecated algorithms that will

Re: svn commit: r348875 - head/sys/kgssapi/krb5

2019-06-10 Thread John Baldwin
On 6/10/19 12:22 PM, John Baldwin wrote: > Author: jhb > Date: Mon Jun 10 19:22:36 2019 > New Revision: 348875 > URL: https://svnweb.freebsd.org/changeset/base/348875 > > Log: > Add warnings for Kerberos GSS algorithms deprecated in RFCs 6649 and 8429. > > All of these algorithms are

svn commit: r348876 - head/sys/opencrypto

2019-06-10 Thread John Baldwin
Author: jhb Date: Mon Jun 10 19:26:57 2019 New Revision: 348876 URL: https://svnweb.freebsd.org/changeset/base/348876 Log: Add warnings to /dev/crypto for deprecated algorithms. These algorithms are deprecated algorithms that will have no in-kernel consumers in FreeBSD 13. Specifically,

svn commit: r348875 - head/sys/kgssapi/krb5

2019-06-10 Thread John Baldwin
Author: jhb Date: Mon Jun 10 19:22:36 2019 New Revision: 348875 URL: https://svnweb.freebsd.org/changeset/base/348875 Log: Add warnings for Kerberos GSS algorithms deprecated in RFCs 6649 and 8429. All of these algorithms are explicitly marked SHOULD NOT in one of these RFCs.

svn commit: r348874 - head/sys/vm

2019-06-10 Thread John Baldwin
Author: jhb Date: Mon Jun 10 19:01:54 2019 New Revision: 348874 URL: https://svnweb.freebsd.org/changeset/base/348874 Log: Remove an overly-aggressive assertion. While it is true that the new vmspace passed to vmspace_switch_aio will always have a valid reference due to the AIO job or

svn commit: r348873 - head/sys/dev/atkbdc

2019-06-10 Thread Niclas Zeising
Author: zeising (doc,ports committer) Date: Mon Jun 10 18:19:49 2019 New Revision: 348873 URL: https://svnweb.freebsd.org/changeset/base/348873 Log: psm(4): Enable touchpads and trackpads by default Enable synaptics and elantech touchpads, as well as IBM/Lenovo TrackPoints by default,

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Konstantin Belousov
On Mon, Jun 10, 2019 at 09:28:24AM -0700, Conrad Meyer wrote: > On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote: > > Only headers and libraries should support -std=c89. has > > lots of support for compilers and POSIX versions going back to K C, > > and only the K parts are completely broken.

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 9:17 AM Bruce Evans wrote: > Only headers and libraries should support -std=c89. has > lots of support for compilers and POSIX versions going back to K C, > and only the K parts are completely broken. Is this due to specific policy, or just inertia? (No one has

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Ian Lepore wrote: On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: On Mon, Jun 10, 2019 at 2:10 AM T??l Coosemans wrote: On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin wrote: ... URL:

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Shawn Webb
On Tue, Jun 11, 2019 at 01:33:23AM +1000, Bruce Evans wrote: > On Mon, 10 Jun 2019, Shawn Webb wrote: > > > On Mon, Jun 10, 2019 at 03:07:11AM +, Doug Moore wrote: > > > ... > > > Log: > > > There are times when a len==0 parameter to mmap is okay. But on a > > > 32-bit machine, a len

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Shawn Webb wrote: On Mon, Jun 10, 2019 at 03:07:11AM +, Doug Moore wrote: ... Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then,

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Tijl Coosemans
On Mon, 10 Jun 2019 06:43:26 -0700 Conrad Meyer wrote: > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: >> On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin >> wrote: >>> ... >>> URL: https://svnweb.freebsd.org/changeset/base/348847 >>> Log: >>> Use C11 anonymous unions. >>> >>>

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Ian Lepore
On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: > > > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans > > wrote: > > > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin > > > wrote: > > > > ... > > > > URL:

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Doug Moore
The comment and the code that rejects size==0, or doesn't, are copied below.  Konstantin Belousov is the last person to have touched most of it, and can better explain its meaning than I. Doug Moore     /*      * Enforce the constraints.      * Mapping of length 0 is only allowed for old

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
Hi Warner, That doesn't seem responsive to the question. On Mon, Jun 10, 2019 at 6:49 AM Warner Losh wrote: > > > > On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: >> >> On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: >> > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin >> >

svn commit: r348861 - head/sys/net80211

2019-06-10 Thread Bjoern A. Zeeb
Author: bz Date: Mon Jun 10 14:31:18 2019 New Revision: 348861 URL: https://svnweb.freebsd.org/changeset/base/348861 Log: Enhance the comment ieee80211_add_channel() to avoid a misunderstanding that the function does not work additive when repeatedly called for diffferent bands.

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Shawn Webb
Sounds good! I think the manpage still might still need a change to match the current behavior, or perhaps matching something similar to that vm_mmap.c comment. But that comment brings another question: what's the definition of "old binaries"? a.out? Thanks, -- Shawn Webb Cofounder / Security

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Doug Moore
This comment appears in vm_mmap.c: * Mapping of length 0 is only allowed for old binaries. and my intent was to say, to whoever wrote that comment, that I was not disallowing the mapping of length zero with this change.  I was only intending to affect a case in which the length was

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Warner Losh
On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: > On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: > > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin > > wrote: > > > ... > > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > > Log: > > > Use C11 anonymous unions. > >

svn commit: r348860 - head/sys/arm/allwinner

2019-06-10 Thread Bjoern A. Zeeb
Author: bz Date: Mon Jun 10 13:46:36 2019 New Revision: 348860 URL: https://svnweb.freebsd.org/changeset/base/348860 Log: allwinner mmc: move variable assignment into block "blksz is only used in one of the two blocks, so assign it inside that block rather than outside. MFC after:

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Conrad Meyer
On Mon, Jun 10, 2019 at 2:10 AM Tijl Coosemans wrote: > On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin > wrote: > > ... > > URL: https://svnweb.freebsd.org/changeset/base/348847 > > Log: > > Use C11 anonymous unions. > > > > Modified: head/sys/sys/ucred.h > ... > > Isn't this a userland

svn commit: r348854 - head/libexec/rc/rc.d

2019-06-10 Thread Conrad Meyer
Author: cem Date: Mon Jun 10 13:34:18 2019 New Revision: 348854 URL: https://svnweb.freebsd.org/changeset/base/348854 Log: /etc/rc.d/local: Fix typo in description PR: 238448 Submitted by: Marián Černý Modified: head/libexec/rc/rc.d/local Modified:

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Shawn Webb
On Mon, Jun 10, 2019 at 03:07:11AM +, Doug Moore wrote: > Author: dougm > Date: Mon Jun 10 03:07:10 2019 > New Revision: 348843 > URL: https://svnweb.freebsd.org/changeset/base/348843 > > Log: > There are times when a len==0 parameter to mmap is okay. But on a > 32-bit machine, a len

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Tijl Coosemans
On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin wrote: > Author: dchagin > Date: Mon Jun 10 05:28:03 2019 > New Revision: 348847 > URL: https://svnweb.freebsd.org/changeset/base/348847 > > Log: > Use C11 anonymous unions. > > PR: 215202 > Reported by:glebius >

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Andriy Gapon
On 10/06/2019 09:42, Doug Moore wrote: > -fwrapv concerns signed arithmetic.  This calculation is with unsigned > arithmetic, and the possibility of wrapping around to 0 is part of the > language. Oh, sorry for the noise! > On 6/10/19 1:35 AM, Andriy Gapon wrote: >> On 10/06/2019 06:07, Doug

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Doug Moore wrote: Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then, is not okay. Return failure in that case. Some overflows still

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Doug Moore
-fwrapv concerns signed arithmetic.  This calculation is with unsigned arithmetic, and the possibility of wrapping around to 0 is part of the language. Doug Moore On 6/10/19 1:35 AM, Andriy Gapon wrote: > On 10/06/2019 06:07, Doug Moore wrote: >> Author: dougm >> Date: Mon Jun 10 03:07:10 2019

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Andriy Gapon
On 10/06/2019 06:07, Doug Moore wrote: > Author: dougm > Date: Mon Jun 10 03:07:10 2019 > New Revision: 348843 > URL: https://svnweb.freebsd.org/changeset/base/348843 > > Log: > There are times when a len==0 parameter to mmap is okay. But on a > 32-bit machine, a len parameter just a few