svn commit: r357073 - head/sys/vm

2020-01-23 Thread Doug Moore
Author: dougm Date: Fri Jan 24 07:48:11 2020 New Revision: 357073 URL: https://svnweb.freebsd.org/changeset/base/357073 Log: Most uses of vm_map_clip_start follow a call to vm_map_lookup. Define an inline function vm_map_lookup_clip_start that invokes them both and use it in places that

svn commit: r357072 - head/sys/kern

2020-01-23 Thread Mateusz Guzik
Author: mjg Date: Fri Jan 24 07:47:44 2020 New Revision: 357072 URL: https://svnweb.freebsd.org/changeset/base/357072 Log: vfs: allow v_usecount to transition 0->1 without the interlock There is nothing to do but to bump the count even during said transition. There are 2 places which can

svn commit: r357071 - in head/sys: kern ufs/ffs

2020-01-23 Thread Mateusz Guzik
Author: mjg Date: Fri Jan 24 07:45:59 2020 New Revision: 357071 URL: https://svnweb.freebsd.org/changeset/base/357071 Log: vfs: stop handling VI_OWEINACT in vget vget is almost always called with LK_SHARED, meaning the flag (if present) is almost guaranteed to get cleared. Stop handling

svn commit: r357070 - head/sys/kern

2020-01-23 Thread Mateusz Guzik
Author: mjg Date: Fri Jan 24 07:44:25 2020 New Revision: 357070 URL: https://svnweb.freebsd.org/changeset/base/357070 Log: vfs: stop unlocking the vnode upfront in vput Doing so runs into races with filesystems which make half-constructed vnodes visible to other users, while depending on

svn commit: r357069 - head/sys/kern

2020-01-23 Thread Mateusz Guzik
Author: mjg Date: Fri Jan 24 07:42:57 2020 New Revision: 357069 URL: https://svnweb.freebsd.org/changeset/base/357069 Log: lockmgr: don't touch the lock past unlock This evens it up with other locking primitives. Note lock profiling still touches the lock, which again is in line with

svn commit: r357068 - head/usr.sbin/ntp/libntpevent

2020-01-23 Thread Adrian Chadd
Author: adrian Date: Fri Jan 24 06:24:40 2020 New Revision: 357068 URL: https://svnweb.freebsd.org/changeset/base/357068 Log: [ntp] Don't compile in the ssl routines into libevent if MK_OPENSSL is no Most of ntpd still handles MK_OPENSSL ok, but the libevent import brought in the SSL

Re: svn commit: r357028 - head/sys/vm

2020-01-23 Thread Alexey Dokuchaev
On Wed, Jan 22, 2020 at 07:33:00PM -1000, Jeff Roberson wrote: > You may be asking yourself, why did jeff just squish a bunch of code > around with little functional change. I could not justify adding more > complexity to a 900 line function with a handful of gotos. It is ~300 > lines now. I

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 06:18:15PM -1000, Jeff Roberson wrote: J> > That was https://reviews.freebsd.org/D23242 J> J> Ok thank you. Can you tag commits so people can see the discussion? Was J> it in one I missed? When I'm committing a long patch series I include the J> link in all of them.

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Jeff Roberson
On Thu, 23 Jan 2020, Gleb Smirnoff wrote: On Thu, Jan 23, 2020 at 05:09:14PM -1000, Jeff Roberson wrote: J> While we don't have a policy strictly requiring reviews it is the norm to J> have substantial changes socialized and reviewed. I appreciate the work J> that you are doing but it likely

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 05:09:14PM -1000, Jeff Roberson wrote: J> While we don't have a policy strictly requiring reviews it is the norm to J> have substantial changes socialized and reviewed. I appreciate the work J> that you are doing but it likely should've been discussed somewhere J> more

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Jeff Roberson
On Thu, 23 Jan 2020, Gleb Smirnoff wrote: On Thu, Jan 23, 2020 at 08:33:58PM -0500, Ryan Stone wrote: R> > Because at interrupt level we can batch multiple packets in a single epoch. R> > This speeds up unfiltered packet forwarding performance by 5%. R> > R> > With driver level pfil hooks I

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 08:33:58PM -0500, Ryan Stone wrote: R> > Because at interrupt level we can batch multiple packets in a single epoch. R> > This speeds up unfiltered packet forwarding performance by 5%. R> > R> > With driver level pfil hooks I would claim even more improvement, because

svn commit: r357067 - in head: lib/libbe lib/libbe/tests sbin/bectl

2020-01-23 Thread Kyle Evans
Author: kevans Date: Fri Jan 24 02:18:09 2020 New Revision: 357067 URL: https://svnweb.freebsd.org/changeset/base/357067 Log: Drop "All Rights Reserved" from all libbe/bectl files I sent out an e-mail on 2020/01/21 with a plan to do this to Kyle, Rob, and Wes; all parties have responded

svn commit: r357066 - head/lib/libc/stdlib

2020-01-23 Thread Conrad Meyer
Author: cem Date: Fri Jan 24 01:39:29 2020 New Revision: 357066 URL: https://svnweb.freebsd.org/changeset/base/357066 Log: random(3): Abstract routines into _r versions on explicit state The existing APIs simply pass the implicit global state to the _r variants. No functional change.

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
On Thu, Jan 23, 2020 at 8:25 PM Gleb Smirnoff wrote: > Because at interrupt level we can batch multiple packets in a single epoch. > This speeds up unfiltered packet forwarding performance by 5%. > > With driver level pfil hooks I would claim even more improvement, because > before > the change

svn commit: r357065 - head/lib/libc/stdlib

2020-01-23 Thread Conrad Meyer
Author: cem Date: Fri Jan 24 01:32:16 2020 New Revision: 357065 URL: https://svnweb.freebsd.org/changeset/base/357065 Log: random(3): Abstract state into a single context object No functional change. Reviewed by: kevans, markm Differential Revision:

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 08:17:46PM -0500, Ryan Stone wrote: R> On Thu, Jan 23, 2020 at 6:05 PM Gleb Smirnoff wrote: R> > R> > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: R> > R> What is a driver's responsibility now for entering/leaving the net epoch now? R> > R> > For drivers

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 08:17:46PM -0500, Ryan Stone wrote: R> On Thu, Jan 23, 2020 at 6:05 PM Gleb Smirnoff wrote: R> > R> > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: R> > R> What is a driver's responsibility now for entering/leaving the net epoch now? R> > R> > For drivers

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
On Thu, Jan 23, 2020 at 6:05 PM Gleb Smirnoff wrote: > > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: > R> What is a driver's responsibility now for entering/leaving the net epoch > now? > > For drivers that are 'special', entering the net epoch is necessary. Special > usually

svn commit: r357063 - head/sys/x86/cpufreq

2020-01-23 Thread Conrad Meyer
Author: cem Date: Thu Jan 23 23:52:57 2020 New Revision: 357063 URL: https://svnweb.freebsd.org/changeset/base/357063 Log: cpufreq(4): Fix missing MODULE_DEPEND on hwpstate_intel DRIVER_MODULE does not actually define a MODULE_VERSION, which is required to satisfy a MODULE_DEPENDency.

svn commit: r357062 - head/share/man/man9

2020-01-23 Thread John Baldwin
Author: jhb Date: Thu Jan 23 23:36:58 2020 New Revision: 357062 URL: https://svnweb.freebsd.org/changeset/base/357062 Log: Correct the return types of fueword*(). MFC after:1 week Sponsored by: DARPA Modified: head/share/man/man9/fetch.9 Modified: head/share/man/man9/fetch.9

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 04:08:32PM -0700, Ian Lepore wrote: I> On Thu, 2020-01-23 at 15:05 -0800, Gleb Smirnoff wrote: I> > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: I> > R> What is a driver's responsibility now for entering/leaving the net epoch now? I> > I> > For drivers that

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ian Lepore
On Thu, 2020-01-23 at 15:05 -0800, Gleb Smirnoff wrote: > On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: > R> What is a driver's responsibility now for entering/leaving the net epoch > now? > > For drivers that are 'special', entering the net epoch is necessary. Special > usually

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
On Thu, Jan 23, 2020 at 02:17:33PM -0500, Ryan Stone wrote: R> What is a driver's responsibility now for entering/leaving the net epoch now? For drivers that are 'special', entering the net epoch is necessary. Special usually means running if_input outside network interrupt context. However,

svn commit: r357061 - head/sys/netpfil/pf

2020-01-23 Thread Kristof Provost
Author: kp Date: Thu Jan 23 22:13:41 2020 New Revision: 357061 URL: https://svnweb.freebsd.org/changeset/base/357061 Log: pf: Apply kif flags to new group members If we have a 'set skip on ' rule this flag it set on the group kif, but must also be set on all members. pfctl does this when

Re: svn commit: r356990 - head/etc

2020-01-23 Thread Cy Schubert
In message <202001231914.00njehsm030...@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > [ Charset UTF-8 unsupported, converting... ] > > On Wed, 22 Jan 2020 at 13:40, Ed Maste wrote: > > > > > > Author: emaste > > > Date: Wed Jan 22 18:40:19 2020 > > > New Revision: 356990 > > > URL:

Re: svn commit: r357002 - in head: share/man/man4 sys/conf sys/kern sys/modules/cpufreq sys/sys sys/x86/cpufreq

2020-01-23 Thread Conrad Meyer
(I had to look that up.) Yeah, they're different. Speedstep is est(4), the ~15-year old predecessor to Speedshift. They serve similar purposes but purportedly (and plausibly) Speedshift does a better job; also SpeedStep is maybe going away entirely in newer CPUs. Current gens like Skylake and

Re: svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Ryan Stone
What is a driver's responsibility now for entering/leaving the net epoch now? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r356990 - head/etc

2020-01-23 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Wed, 22 Jan 2020 at 13:40, Ed Maste wrote: > > > > Author: emaste > > Date: Wed Jan 22 18:40:19 2020 > > New Revision: 356990 > > URL: https://svnweb.freebsd.org/changeset/base/356990 > > > > Log: > > Tag NLS aliases with package=runtime > >

Re: svn commit: r357055 - head/sys/sparc64/sparc64

2020-01-23 Thread Mark Johnston
On Thu, Jan 23, 2020 at 08:22:55AM -1000, Jeff Roberson wrote: > On Thu, 23 Jan 2020, Mark Johnston wrote: > > > Author: markj > > Date: Thu Jan 23 17:18:58 2020 > > New Revision: 357055 > > URL: https://svnweb.freebsd.org/changeset/base/357055 > > > > Log: > > sparc64: Busy the TSB page before

Re: svn commit: r357055 - head/sys/sparc64/sparc64

2020-01-23 Thread Jeff Roberson
On Thu, 23 Jan 2020, Mark Johnston wrote: Author: markj Date: Thu Jan 23 17:18:58 2020 New Revision: 357055 URL: https://svnweb.freebsd.org/changeset/base/357055 Log: sparc64: Busy the TSB page before freeing it in pmap_release(). This is now required by vm_page_free(). PR:243534

svn commit: r357056 - head/sys/sys

2020-01-23 Thread Ed Maste
Author: emaste Date: Thu Jan 23 17:38:17 2020 New Revision: 357056 URL: https://svnweb.freebsd.org/changeset/base/357056 Log: add MIPS-specific PT header ELF definitions Submitted by: David Carlier MFC after:1 week Differential Revision:https://reviews.freebsd.org/D19428

svn commit: r357055 - head/sys/sparc64/sparc64

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 17:18:58 2020 New Revision: 357055 URL: https://svnweb.freebsd.org/changeset/base/357055 Log: sparc64: Busy the TSB page before freeing it in pmap_release(). This is now required by vm_page_free(). PR: 243534 Reported and tested by: Michael

svn commit: r357054 - head/sys/x86/x86

2020-01-23 Thread Konstantin Belousov
Author: kib Date: Thu Jan 23 17:08:33 2020 New Revision: 357054 URL: https://svnweb.freebsd.org/changeset/base/357054 Log: Fix r356919. Instead of waiting for pc_curthread which is overwritten by init_secondary_tail(), wait for non-NULL pc_curpcb, to be set by the first context switch.

svn commit: r357053 - in head: share/man/man4 sys/netgraph

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 16:45:48 2020 New Revision: 357053 URL: https://svnweb.freebsd.org/changeset/base/357053 Log: ng_nat: Pass IPv6 packets through. ng_nat implements NAT for IPv4 traffic only. When connected to an ng_ether node it erroneously handled IPv6 packets as well.

svn commit: r357052 - head/sys/vm

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 16:45:10 2020 New Revision: 357052 URL: https://svnweb.freebsd.org/changeset/base/357052 Log: vm_map_submap(): Avoid unnecessary clipping. A submap can only be created from an entry spanning the entire request range. In particular, if vm_map_lookup_entry()

svn commit: r357051 - head/sys/dev/bge

2020-01-23 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 23 16:36:58 2020 New Revision: 357051 URL: https://svnweb.freebsd.org/changeset/base/357051 Log: With MSI interrupts bge(4) just schedules taskqueue. Enter the network epoch in the taskqueue handler. Reported by: kib Modified: head/sys/dev/bge/if_bge.c

svn commit: r357050 - head/sys/kern

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 16:24:51 2020 New Revision: 357050 URL: https://svnweb.freebsd.org/changeset/base/357050 Log: Set td_oncpu before dropping the thread lock during a switch. After r355784 we no longer hold a thread's thread lock when switching it out. Preserve the previous

svn commit: r357049 - in head/sys/arm64: arm64 include

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 16:10:38 2020 New Revision: 357049 URL: https://svnweb.freebsd.org/changeset/base/357049 Log: Print missing ID_AA64PFR{0,1}_EL1 register fields. MFC after:1 week Sponsored by: The FreeBSD Foundation Differential Revision:

svn commit: r357048 - head/sys/arm64/arm64

2020-01-23 Thread Mark Johnston
Author: markj Date: Thu Jan 23 16:07:27 2020 New Revision: 357048 URL: https://svnweb.freebsd.org/changeset/base/357048 Log: arm64: Don't enable interrupts in init_secondary(). Doing so can cause deadlocks or panics during boot, if an interrupt handler accesses uninitialized per-CPU

svn commit: r357047 - head/tests

2020-01-23 Thread Ed Maste
Author: emaste Date: Thu Jan 23 15:59:30 2020 New Revision: 357047 URL: https://svnweb.freebsd.org/changeset/base/357047 Log: Tag /usr/tests/local symlink with package=tests As with the rest of /usr/tests, so that it is handled correctly on pkgbase-installed/updated systems.

Re: svn commit: r356990 - head/etc

2020-01-23 Thread Ed Maste
On Wed, 22 Jan 2020 at 13:40, Ed Maste wrote: > > Author: emaste > Date: Wed Jan 22 18:40:19 2020 > New Revision: 356990 > URL: https://svnweb.freebsd.org/changeset/base/356990 > > Log: > Tag NLS aliases with package=runtime This commit message does not match the change, it should be

svn commit: r357045 - head/sys/sparc64/sparc64

2020-01-23 Thread Ed Maste
Author: emaste Date: Thu Jan 23 14:11:02 2020 New Revision: 357045 URL: https://svnweb.freebsd.org/changeset/base/357045 Log: Apply r355819 to sparc64 - fix assertion failure after r355784 From r355819: Repeat the spinlock_enter/exit pattern from amd64 on other architectures to fix an

svn commit: r357043 - head/sys/conf

2020-01-23 Thread Takahashi Yoshihiro
Author: nyan Date: Thu Jan 23 13:56:12 2020 New Revision: 357043 URL: https://svnweb.freebsd.org/changeset/base/357043 Log: Fix kernel-tags target. - A depend-file is broken up into .depend.*.o files. [1] - Fix an assembly file support. PR: 241746 Submitted by: leres

Re: svn commit: r356919 - head/sys/x86/x86

2020-01-23 Thread Konstantin Belousov
On Wed, Jan 22, 2020 at 06:39:22PM -0800, Ryan Libby wrote: > On Mon, Jan 20, 2020 at 9:23 AM Konstantin Belousov wrote: > > > > Author: kib > > Date: Mon Jan 20 17:23:03 2020 > > New Revision: 356919 > > URL: https://svnweb.freebsd.org/changeset/base/356919 > > > > Log: > > x86: Wait for

svn commit: r357042 - in head/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3

2020-01-23 Thread Andriy Gapon
Author: avg Date: Thu Jan 23 11:05:03 2020 New Revision: 357042 URL: https://svnweb.freebsd.org/changeset/base/357042 Log: vmxnet3: add support for RSS kernel option We observe at least one problem: if a UDP socket is connect(2)-ed, then a received packet that matches the connection

svn commit: r357041 - in head: stand/usb sys/modules/usb/template

2020-01-23 Thread Hans Petter Selasky
Author: hselasky Date: Thu Jan 23 10:40:34 2020 New Revision: 357041 URL: https://svnweb.freebsd.org/changeset/base/357041 Log: Fix build of stand/usb . MFC after:1 week Sponsored by: Mellanox Technologies Modified: head/stand/usb/usbcore.mk

svn commit: r357040 - head/sys/dev/virtio/scsi

2020-01-23 Thread Andriy Gapon
Author: avg Date: Thu Jan 23 10:13:56 2020 New Revision: 357040 URL: https://svnweb.freebsd.org/changeset/base/357040 Log: virtio_scsi: use max target ID plus one as the initiator ID This bus does not really have a concept of the initiator ID, so use a guaranteed dummy one that won't

svn commit: r357039 - head/sys/netinet

2020-01-23 Thread Alexander V. Chernikov
Author: melifaro Date: Thu Jan 23 09:46:45 2020 New Revision: 357039 URL: https://svnweb.freebsd.org/changeset/base/357039 Log: Bring indentation back to normal after r357038. No functional changes. MFC after:3 weeks Modified: head/sys/netinet/ip_divert.c Modified:

svn commit: r357038 - head/sys/netinet

2020-01-23 Thread Alexander V. Chernikov
Author: melifaro Date: Thu Jan 23 09:14:28 2020 New Revision: 357038 URL: https://svnweb.freebsd.org/changeset/base/357038 Log: Fix epoch-related panic in ipdivert, ensuring in_broadcast() is called within epoch. Simplify gigantic div_output() by splitting it into 3 functions,

Re: svn commit: r357002 - in head: share/man/man4 sys/conf sys/kern sys/modules/cpufreq sys/sys sys/x86/cpufreq

2020-01-23 Thread Ravi Pokala
-Original Message- From: on behalf of Conrad Meyer Date: 2020-01-22, Wednesday at 15:28 To: , , Subject: svn commit: r357002 - in head: share/man/man4 sys/conf sys/kern sys/modules/cpufreq sys/sys sys/x86/cpufreq Author: cem Date: Wed Jan 22 23:28:42 2020 New Revision:

Re: svn commit: r357004 - in head/sys: kern sys

2020-01-23 Thread Hans Petter Selasky
On 2020-01-23 02:24, Gleb Smirnoff wrote: Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log: Enter the network epoch for interrupt handlers of INTR_TYPE_NET. Provide tunable to limit how many times handlers