Re: svn commit: r333263 - in head: lib/libjail sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/compat/linprocfs sys/compat/linsysfs sys/fs/devfs sys/fs/fdescfs sys/fs/nullfs sys/fs/procfs sys/fs/ps

2018-11-16 Thread Alan Somers
On Fri, May 4, 2018 at 2:54 PM Jamie Gritton wrote: > Author: jamie > Date: Fri May 4 20:54:27 2018 > New Revision: 333263 > URL: https://svnweb.freebsd.org/changeset/base/333263 > > Log: > Make it easier for filesystems to count themselves as jail-enabled, > by doing most of the work in a n

svn commit: r340455 - head/lib/libc/sys

2018-11-15 Thread Alan Somers
Author: asomers Date: Thu Nov 15 16:13:25 2018 New Revision: 340455 URL: https://svnweb.freebsd.org/changeset/base/340455 Log: fcntl.2: document an additional error condition MFC after:2 weeks Modified: head/lib/libc/sys/fcntl.2 Modified: head/lib/libc/sys/fcntl.2 ==

svn commit: r340314 - head/lib/libjail

2018-11-09 Thread Alan Somers
Author: asomers Date: Sat Nov 10 03:10:22 2018 New Revision: 340314 URL: https://svnweb.freebsd.org/changeset/base/340314 Log: libjail: fix handling of allow.mount.fusefs in jailparam_init fusefs is inconsistently named. The kernel module is named "fuse", but the mount helper is named "mo

Re: svn commit: r339085 - head/sys/security/audit

2018-10-02 Thread Alan Somers
On Tue, Oct 2, 2018 at 9:58 AM Robert Watson wrote: > Author: rwatson > Date: Tue Oct 2 15:58:17 2018 > New Revision: 339085 > URL: https://svnweb.freebsd.org/changeset/base/339085 > > Log: > Rework the logic around quick checks for auditing that take place at > system-call entry and wheneve

Re: svn commit: r335584 - head/sys/crypto/aesni

2018-10-01 Thread Alan Somers
On Sat, Jun 23, 2018 at 12:20 PM Conrad Meyer wrote: > Author: cem > Date: Sat Jun 23 18:20:17 2018 > New Revision: 335584 > URL: https://svnweb.freebsd.org/changeset/base/335584 > > Log: > aesni(4): Fix {de,en}crypt operations that allocated a buffer > > aesni(4) allocates a contiguous buffe

Re: svn commit: r337497 - in head: . contrib/mdocml contrib/tnftp/src etc/root share/skel tools/tools/nanobsd/pcengines/Files/root tools/tools/nanobsd/rescue/Files/root usr.bin/mail usr.bin/man usr.bi

2018-08-24 Thread Alan Somers
On Fri, Aug 24, 2018 at 8:12 PM Kyle Evans wrote: > On Wed, Aug 8, 2018 at 2:24 PM Alan Somers wrote: > > > > Author: asomers > > Date: Wed Aug 8 19:24:20 2018 > > New Revision: 337497 > > URL: https://svnweb.freebsd.org/changeset/base/337497 > > >

svn commit: r338258 - head/usr.bin/tftp

2018-08-23 Thread Alan Somers
Author: asomers Date: Thu Aug 23 17:00:07 2018 New Revision: 338258 URL: https://svnweb.freebsd.org/changeset/base/338258 Log: tftp(1): switch default transfer mode to binary netascii is obsolete and inefficient. It isn't even supported by many clients. Better to use binary mode by defaul

svn commit: r338216 - head/libexec/tftpd

2018-08-22 Thread Alan Somers
Author: asomers Date: Wed Aug 22 23:31:27 2018 New Revision: 338216 URL: https://svnweb.freebsd.org/changeset/base/338216 Log: tftpd: Fix data corruption bug with netascii Transferring files in netascii format requires, among other things, translating all CR characters to a CR,NUL pair. t

Re: svn commit: r337736 - in head/sys: netinet netinet6

2018-08-17 Thread Alan Somers
On Fri, Aug 17, 2018 at 10:53 AM, Olivier Cochard-Labbé wrote: > On Fri, Aug 17, 2018 at 3:33 PM Andrey V. Elsukov > wrote: > >> >> I think it is because IPv4 tests use broadcast addresses in some places. >> The attached patch fixes the test for me. >> >> > I confirm it was a typo from me, and I

svn commit: r337984 - head/tests/sys/netipsec/tunnel

2018-08-17 Thread Alan Somers
Author: asomers Date: Fri Aug 17 18:37:22 2018 New Revision: 337984 URL: https://svnweb.freebsd.org/changeset/base/337984 Log: Fix sys/netipsec/tunnel tests after r337736 Originally, these tests accidentally used broadcast addresses when they should've used unicast addresses. That the te

Re: svn commit: r337736 - in head/sys: netinet netinet6

2018-08-17 Thread Alan Somers
On Fri, Aug 17, 2018 at 7:31 AM, Andrey V. Elsukov wrote: > On 16.08.2018 21:34, Alan Somers wrote: > > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov > <mailto:a...@freebsd.org>> wrote: > > > > Author: ae > > Date: Tue Aug 14 07:54:14 2018 &

svn commit: r337973 - head/etc

2018-08-17 Thread Alan Somers
Author: asomers Date: Fri Aug 17 15:18:57 2018 New Revision: 337973 URL: https://svnweb.freebsd.org/changeset/base/337973 Log: Add Modbus Application Protocol to /etc/services IANA reassigned ports 502 and 802 on 2014-06-10 PR: 213276 Submitted by: mark.marti...@ijs.si MF

svn commit: r337933 - in head/tests: freebsd_test_suite sys/opencrypto

2018-08-16 Thread Alan Somers
Author: asomers Date: Thu Aug 16 23:49:56 2018 New Revision: 337933 URL: https://svnweb.freebsd.org/changeset/base/337933 Log: Fix sys/opencrypto/blake2_test when kern.cryptodevallowsoft=0 Two of these testcases require software crypto to be enabled. Curiously, it isn't by default. P

svn commit: r337930 - in head/tests/sys: aio file kern kern/pipe posixshm

2018-08-16 Thread Alan Somers
Author: asomers Date: Thu Aug 16 22:04:00 2018 New Revision: 337930 URL: https://svnweb.freebsd.org/changeset/base/337930 Log: Revert r337929 FreeBSD's mkstemp sets the temporary file's permissions to 600, and has ever since mkstemp was added in 1987. Coverity's warning is still relevant

svn commit: r337929 - in head/tests/sys: aio file kern kern/pipe posixshm

2018-08-16 Thread Alan Somers
Author: asomers Date: Thu Aug 16 21:36:19 2018 New Revision: 337929 URL: https://svnweb.freebsd.org/changeset/base/337929 Log: Fix Coverity warnings about mkstemp in tests umask(2) should always be used prior to mkstemp(3) so the temporary file won't be created with insecure permissions.

Re: svn commit: r337736 - in head/sys: netinet netinet6

2018-08-16 Thread Alan Somers
On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov wrote: > Author: ae > Date: Tue Aug 14 07:54:14 2018 > New Revision: 337736 > URL: https://svnweb.freebsd.org/changeset/base/337736 > > Log: > Restore ability to send ICMP and ICMPv6 redirects. > > It was lost when tryforward appeared. Now ip

svn commit: r337911 - head/tests/sys/opencrypto

2018-08-16 Thread Alan Somers
Author: asomers Date: Thu Aug 16 15:44:48 2018 New Revision: 337911 URL: https://svnweb.freebsd.org/changeset/base/337911 Log: Fix the sys/opencrypto/runtests test when aesni(4) is already loaded Apparently kldstat requires the full module name, including busname Reported by: Jenkins

Re: svn commit: r337419 - head/usr.bin/sed

2018-08-16 Thread Alan Somers
On Tue, Aug 7, 2018 at 8:47 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Tue Aug 7 14:47:39 2018 > New Revision: 337419 > URL: https://svnweb.freebsd.org/changeset/base/337419 > > Log: > sed(1): partial fix for the case of the regex delimited with '['. > > We don't generally support the

svn commit: r337779 - head/usr.bin/tftp

2018-08-14 Thread Alan Somers
Author: asomers Date: Tue Aug 14 17:20:31 2018 New Revision: 337779 URL: https://svnweb.freebsd.org/changeset/base/337779 Log: tftp: Close a resource leak when putting files Reported by: Coverity CID: 1394842 MFC after:2 weeks Modified: head/usr.bin/tftp/main.c Modifie

svn commit: r337497 - in head: . contrib/mdocml contrib/tnftp/src etc/root share/skel tools/tools/nanobsd/pcengines/Files/root tools/tools/nanobsd/rescue/Files/root usr.bin/mail usr.bin/man usr.bin...

2018-08-08 Thread Alan Somers
Author: asomers Date: Wed Aug 8 19:24:20 2018 New Revision: 337497 URL: https://svnweb.freebsd.org/changeset/base/337497 Log: Switch the default pager for most commands to less Finally, a pager for the nineties. MFC after:Never Relnotes: Yes Differential Revision:h

svn commit: r337482 - head/share/man/man9

2018-08-08 Thread Alan Somers
Author: asomers Date: Wed Aug 8 18:50:42 2018 New Revision: 337482 URL: https://svnweb.freebsd.org/changeset/base/337482 Log: Bring VOP_LOOKUP(9) up to date * Remove the cn_hash field (removed by r51906) * Add the cn_lkflags field (added by r144285) * Remove duplicate definition of cnp

svn commit: r337222 - in head: sys/kern sys/sys tests/sys/kern

2018-08-02 Thread Alan Somers
_test+=timeout="15" +ATF_TESTS_C+= unix_socketpair_test ATF_TESTS_C+= waitpid_nohang ATF_TESTS_C+= pdeathsig Added: head/tests/sys/kern/unix_socketpair_test.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tests/sys/kern/unix_socketpair_te

Re: svn commit: r336640 - head/share/mk

2018-07-30 Thread Alan Somers
On Mon, Jul 23, 2018 at 10:11 AM, Brad Davis wrote: > Author: brd > Date: Mon Jul 23 16:11:03 2018 > New Revision: 336640 > URL: https://svnweb.freebsd.org/changeset/base/336640 > > Log: > Add the initial DIRS infrastructure for creating directories with the > necessary owner, group, mode and

svn commit: r336914 - in head: lib/libnetbsd/sys sbin/fsck_ffs share/man/man3 sys/compat/linux sys/compat/linuxkpi/common/include/linux sys/dev/acpica sys/dev/drm2/i915 sys/dev/efidev sys/dev/isp s...

2018-07-30 Thread Alan Somers
Author: asomers Date: Mon Jul 30 15:46:40 2018 New Revision: 336914 URL: https://svnweb.freebsd.org/changeset/base/336914 Log: Make timespecadd(3) and friends public The timespecadd(3) family of macros were imported from NetBSD back in r35029. However, they were initially guarded by #ifde

svn commit: r336875 - head/tests/sys/audit

2018-07-29 Thread Alan Somers
Author: asomers Date: Sun Jul 29 20:34:44 2018 New Revision: 336875 URL: https://svnweb.freebsd.org/changeset/base/336875 Log: audit(4): add tests for sysctl(3) and sysarch(2) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:

svn commit: r336874 - head/sys/compat/freebsd32

2018-07-29 Thread Alan Somers
Author: asomers Date: Sun Jul 29 19:20:13 2018 New Revision: 336874 URL: https://svnweb.freebsd.org/changeset/base/336874 Log: freebsd32_getrusage(2): skip freebsd32_rusage_out on error PR: 230153 Reported by: kib MFC after:2 weeks X-MFC-With: 336871 Differential Re

svn commit: r336871 - head/sys/compat/freebsd32

2018-07-29 Thread Alan Somers
Author: asomers Date: Sun Jul 29 18:22:26 2018 New Revision: 336871 URL: https://svnweb.freebsd.org/changeset/base/336871 Log: getrusage(2): fix return value under 32-bit emulation According to the man page, getrusage(2) should return EFAULT if the rusage argument lies outside of the proc

svn commit: r336838 - in head/lib: libauditd libbsm

2018-07-28 Thread Alan Somers
Author: asomers Date: Sat Jul 28 20:04:39 2018 New Revision: 336838 URL: https://svnweb.freebsd.org/changeset/base/336838 Log: Disable -Wcast-align in libbsm and libauditd Along with some pending upstream changes, this will allow raising the WARNS level. Reviewed by: cem, aniketp

svn commit: r336728 - in head: etc/mtree tests/sys tests/sys/auditpipe

2018-07-25 Thread Alan Somers
Author: asomers Date: Thu Jul 26 00:16:41 2018 New Revision: 336728 URL: https://svnweb.freebsd.org/changeset/base/336728 Log: Introduce test program for auditpipe(4) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:https

Re: svn commit: r336625 - head/usr.sbin/pw

2018-07-23 Thread Alan Somers
On Sun, Jul 22, 2018 at 5:41 PM, Ian Lepore wrote: > Author: ian > Date: Sun Jul 22 23:41:40 2018 > New Revision: 336625 > URL: https://svnweb.freebsd.org/changeset/base/336625 > > Log: > Make pw(8) showuser work the same with or without -R for non-root > users. Without -R, pw(8) uses getpw

Re: svn commit: r336619 - head/lib/libc/gen

2018-07-23 Thread Alan Somers
On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert wrote: > In message <20180734.w6mmykpn030...@repo.freebsd.org>, Ian Lepore > writes: > > Author: ian > > Date: Sun Jul 22 22:34:20 2018 > > New Revision: 336619 > > URL: https://svnweb.freebsd.org/changeset/base/336619 > > > > Log: > > Set the p

svn commit: r336617 - head/tests/sys/acl

2018-07-22 Thread Alan Somers
Author: asomers Date: Sun Jul 22 21:00:11 2018 New Revision: 336617 URL: https://svnweb.freebsd.org/changeset/base/336617 Log: Temporarily disable the sys/acl/00 and sys/acl/02 tests These tests are failing due to PR 229930. Unfortunately, TAP tests can't be marked as expected failures.

svn commit: r336613 - head/contrib/openbsm/libauditd

2018-07-22 Thread Alan Somers
Author: asomers Date: Sun Jul 22 18:06:42 2018 New Revision: 336613 URL: https://svnweb.freebsd.org/changeset/base/336613 Log: auditd(8): Log a better error when no hostname is set in audit_control Cherry-pick from https://github.com/openbsm/openbsm/commit/01ba03b Reviewed by: cem O

svn commit: r336609 - in head: libexec/tftpd usr.bin/tftp

2018-07-22 Thread Alan Somers
Author: asomers Date: Sun Jul 22 17:10:12 2018 New Revision: 336609 URL: https://svnweb.freebsd.org/changeset/base/336609 Log: Fix several Coverity warnings in tftp Some of the changes are in the libexec/tftpd directory, but to functions that are only used by tftp(1) (they share some code

svn commit: r336605 - head/libexec/tftpd

2018-07-22 Thread Alan Somers
Author: asomers Date: Sun Jul 22 16:14:30 2018 New Revision: 336605 URL: https://svnweb.freebsd.org/changeset/base/336605 Log: Fix multiple Coverity warnings in tftpd(8) * Initialize uninitialized variable (CID 1006502) * strcpy => strlcpy (CID 1006792, 1006791, 1006790) * Check functio

svn commit: r336604 - in head: sys/security/audit tests/sys/audit

2018-07-22 Thread Alan Somers
Author: asomers Date: Sun Jul 22 14:11:52 2018 New Revision: 336604 URL: https://svnweb.freebsd.org/changeset/base/336604 Log: Fix audit of chflagsat, lgetfh, and setfib These syscalls were always supposed to have been auditted, but due to oversights never were. PR: 228374

svn commit: r336595 - head/sbin/pfctl/tests

2018-07-21 Thread Alan Somers
Author: asomers Date: Sun Jul 22 03:58:01 2018 New Revision: 336595 URL: https://svnweb.freebsd.org/changeset/base/336595 Log: Skip the pftcl(8) tests if pf isn't loaded. Previously, they would simply fail. MFC after:2 weeks Modified: head/sbin/pfctl/tests/pfctl_test.sh Modifie

Re: svn commit: r334944 - in head/usr.bin/indent: . tests

2018-07-21 Thread Alan Somers
On Sun, Jun 10, 2018 at 11:35 PM, Piotr Pawel Stefaniak wrote: > Author: pstef > Date: Mon Jun 11 05:35:57 2018 > New Revision: 334944 > URL: https://svnweb.freebsd.org/changeset/base/334944 > > Log: > indent(1): rename -nsac/-sac ("space after cast") to -ncs/-cs > > Also update tests and the

svn commit: r336594 - head/contrib/netbsd-tests/fs

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 23:54:40 2018 New Revision: 336594 URL: https://svnweb.freebsd.org/changeset/base/336594 Log: Fix tmpfs detection in the sys/fs/tmpfs tests This code was originally written for NetBSD. r306031 tried to adapt it to FreeBSD, but didn't correctly handle the

svn commit: r336588 - head/tests/sys/fs/tmpfs

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 20:14:01 2018 New Revision: 336588 URL: https://svnweb.freebsd.org/changeset/base/336588 Log: Fix sys.fs.tmpfs.mknod_test.{char, block} by reverting r321967 In r321967 ngie "fixed" these tests by changing their expectations to match the device numbers prod

svn commit: r336587 - head/libexec/tftpd

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 19:48:31 2018 New Revision: 336587 URL: https://svnweb.freebsd.org/changeset/base/336587 Log: tftpd(8): when completing an WRQ, flush the file before acknowleding receipt tftpd(8) should flush a newly written file to disk before ACKing the final DATA pack

svn commit: r336586 - head/tests/sys/netipsec/tunnel

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 19:28:07 2018 New Revision: 336586 URL: https://svnweb.freebsd.org/changeset/base/336586 Log: Clear expected failures for aesni_aes_gcm tests These tests were fixed by r335584 PR: 228094 PR: 201447 MFC after:2 weeks X-MFC-W

svn commit: r336582 - head/usr.sbin/makefs/tests

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 17:24:14 2018 New Revision: 336582 URL: https://svnweb.freebsd.org/changeset/base/336582 Log: makefs(8): add test case for PR 229929 Fix two failing makefs test cases by adding "-M 1m", which was already used for every other FFS test case. Add a new test

Re: svn commit: r335673 - in head: etc/defaults etc/rc.d lib/geom/eli share/man/man5

2018-07-21 Thread Alan Somers
On Tue, Jun 26, 2018 at 12:07 PM, Ben Woods wrote: > Author: woodsb02 (ports committer) > Date: Tue Jun 26 18:07:16 2018 > New Revision: 335673 > URL: https://svnweb.freebsd.org/changeset/base/335673 > > Log: > geli attach multiple providers > > Allow attaching of multiple geli providers at o

svn commit: r336580 - head/tests/sys/audit

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 16:34:38 2018 New Revision: 336580 URL: https://svnweb.freebsd.org/changeset/base/336580 Log: audit(4): add test cases for chflagsat(2), lgetfh(2), setfib(2) These three syscalls aren't currently audited correctly, so the tests are marked as expected failu

svn commit: r336579 - head/tests/sys/audit

2018-07-21 Thread Alan Somers
Author: asomers Date: Sat Jul 21 16:26:00 2018 New Revision: 336579 URL: https://svnweb.freebsd.org/changeset/base/336579 Log: audit(4): add more test cases for auditon(2) auditon(2) is an ioctl-like syscall with several different variants, each of which has a distinct audit event. This

svn commit: r336565 - in head: etc/defaults sys/fs/fuse usr.sbin/jail

2018-07-20 Thread Alan Somers
Author: asomers Date: Fri Jul 20 21:35:31 2018 New Revision: 336565 URL: https://svnweb.freebsd.org/changeset/base/336565 Log: Allow mounting FUSE filesystems in jails Reviewed by: jamie MFC after:2 weeks Relnotes: yes Differential Revision:https://reviews.freebsd.org

svn commit: r336564 - head/tests/sys/audit

2018-07-20 Thread Alan Somers
Author: asomers Date: Fri Jul 20 18:59:48 2018 New Revision: 336564 URL: https://svnweb.freebsd.org/changeset/base/336564 Log: Separate the audit(4) tests for auditon(2)'s individual commands auditon(2) is an ioctl-like syscall with several different variants, each of which has a distinct

svn commit: r336466 - head/tools/regression/sockets/unix_cmsg

2018-07-18 Thread Alan Somers
Author: asomers Date: Thu Jul 19 00:22:18 2018 New Revision: 336466 URL: https://svnweb.freebsd.org/changeset/base/336466 Log: Fix the build of tools/regression/sockets/unix_cmsg MFC after:2 weeks Modified: head/tools/regression/sockets/unix_cmsg/Makefile Modified: head/tools/regres

svn commit: r336418 - head/tests/sys/audit

2018-07-17 Thread Alan Somers
Author: asomers Date: Tue Jul 17 15:12:55 2018 New Revision: 336418 URL: https://svnweb.freebsd.org/changeset/base/336418 Log: audit(4): add tests for _exit(2), cap_enter(2), and cap_getmode(2) Also, fix a bug in common code that could cause other tests to fail: using ppoll(2) in combinat

svn commit: r336319 - head/sys/security/audit

2018-07-15 Thread Alan Somers
Author: asomers Date: Sun Jul 15 21:10:19 2018 New Revision: 336319 URL: https://svnweb.freebsd.org/changeset/base/336319 Log: auditon(2): fix A_SETPOLICY with 64-bit values A_SETPOLICY is supposed to work with either 64 or 32-bit values, but due to a typo the 64-bit version has never wor

svn commit: r336205 - head/sys/kern

2018-07-11 Thread Alan Somers
Author: asomers Date: Wed Jul 11 19:38:42 2018 New Revision: 336205 URL: https://svnweb.freebsd.org/changeset/base/336205 Log: Don't acquire evclass_lock with a spinlock held When the "pc" audit class is enabled and auditd is running, witness will panic during thread exit because au_event

svn commit: r335899 - head/contrib/openbsm/bin/auditd

2018-07-03 Thread Alan Somers
Author: asomers Date: Tue Jul 3 17:37:16 2018 New Revision: 335899 URL: https://svnweb.freebsd.org/changeset/base/335899 Log: auditd(8): register signal handlers interrutibly auditd_wait_for_events() relies on read(2) being interrupted by signals, but it registers signal handlers with si

svn commit: r335842 - head/tests/sys/audit

2018-07-01 Thread Alan Somers
Author: asomers Date: Sun Jul 1 16:05:50 2018 New Revision: 335842 URL: https://svnweb.freebsd.org/changeset/base/335842 Log: audit(4): add tests for procctl(2) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:https://re

svn commit: r335792 - head/tests/sys/audit

2018-06-28 Thread Alan Somers
Author: asomers Date: Fri Jun 29 04:52:27 2018 New Revision: 335792 URL: https://svnweb.freebsd.org/changeset/base/335792 Log: audit(4): add tests for several more administrative syscalls Includes ntp_adjtime, auditctl, acct, auditon, and clock_settime. Includes quotactl, mount, nmount,

svn commit: r335791 - head/tests/sys/audit

2018-06-28 Thread Alan Somers
Author: asomers Date: Fri Jun 29 04:46:15 2018 New Revision: 335791 URL: https://svnweb.freebsd.org/changeset/base/335791 Log: audit(4): add tests for setsid, wait4, wait6, and kill Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revisio

svn commit: r335703 - head/tests/sys/audit

2018-06-27 Thread Alan Somers
Author: asomers Date: Wed Jun 27 15:28:09 2018 New Revision: 335703 URL: https://svnweb.freebsd.org/changeset/base/335703 Log: audit(4): fix Coverity issues Fix several incorrect buffer size arguments and a file descriptor leak. Submitted by: aniketp Reported by: Coverity CID:

svn commit: r335679 - head/tests/sys/audit

2018-06-26 Thread Alan Somers
Author: asomers Date: Tue Jun 26 20:26:57 2018 New Revision: 335679 URL: https://svnweb.freebsd.org/changeset/base/335679 Log: audit(4): add tests for the process-control audit class Tested syscalls include rfork(2), chdir(2), fchdir(2), chroot(2), getresuid(2), getresgid(2), setpriority(

svn commit: r335677 - head/tests/sys/audit

2018-06-26 Thread Alan Somers
Author: asomers Date: Tue Jun 26 19:26:07 2018 New Revision: 335677 URL: https://svnweb.freebsd.org/changeset/base/335677 Log: audit(4): add tests for pipe, posix_openpt, shm_open, and shm_unlink Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differ

svn commit: r335528 - head/tests/sys/audit

2018-06-21 Thread Alan Somers
Author: asomers Date: Fri Jun 22 02:56:03 2018 New Revision: 335528 URL: https://svnweb.freebsd.org/changeset/base/335528 Log: audit(4): add tests for Sys V semaphore operations Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:

svn commit: r335381 - head/usr.bin/top

2018-06-19 Thread Alan Somers
Author: asomers Date: Tue Jun 19 18:32:06 2018 New Revision: 335381 URL: https://svnweb.freebsd.org/changeset/base/335381 Log: top(1): Fix Coverity warning Don't call strerror on negative errnos Reported by: Coverity CID: 976708 Reviewed by: eadler Differential Revisio

svn commit: r335378 - head/tests/sys/audit

2018-06-19 Thread Alan Somers
Author: asomers Date: Tue Jun 19 17:41:46 2018 New Revision: 335378 URL: https://svnweb.freebsd.org/changeset/base/335378 Log: audit(4): add tests for sendmsg, recvmsg, shutdown, and sendfile Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differenti

svn commit: r335374 - head/tests/sys/audit

2018-06-19 Thread Alan Somers
Author: asomers Date: Tue Jun 19 16:55:39 2018 New Revision: 335374 URL: https://svnweb.freebsd.org/changeset/base/335374 Log: audit(4): add tests for utimes(2) and friends, mprotect, and undelete Includes utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2), and undelete(2). und

svn commit: r335354 - head/tests/sys/audit

2018-06-18 Thread Alan Somers
Author: asomers Date: Tue Jun 19 01:32:33 2018 New Revision: 335354 URL: https://svnweb.freebsd.org/changeset/base/335354 Log: audit(4): add tests for ioctl(2) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:https://revi

svn commit: r335320 - head/tests/sys/audit

2018-06-18 Thread Alan Somers
Author: asomers Date: Mon Jun 18 15:37:43 2018 New Revision: 335320 URL: https://svnweb.freebsd.org/changeset/base/335320 Log: audit(4): Add tests for {get/set}auid, {get/set}audit, {get/set}audit_addr Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018)

svn commit: r335319 - head/tests/sys/audit

2018-06-18 Thread Alan Somers
Author: asomers Date: Mon Jun 18 15:27:31 2018 New Revision: 335319 URL: https://svnweb.freebsd.org/changeset/base/335319 Log: audit(4): add tests for send, recv, sendto, and recvfrom Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revis

svn commit: r335318 - head/tests/sys/audit

2018-06-18 Thread Alan Somers
Author: asomers Date: Mon Jun 18 15:07:10 2018 New Revision: 335318 URL: https://svnweb.freebsd.org/changeset/base/335318 Log: audit(4): add tests for extattr_set_file and friends Includes extattr_{set_file, _set_fd, _set_link, _delete_file, _delete_fd, _delete_link} Submitted by: an

svn commit: r335311 - head/tests/sys/audit

2018-06-17 Thread Alan Somers
Author: asomers Date: Mon Jun 18 04:12:58 2018 New Revision: 335311 URL: https://svnweb.freebsd.org/changeset/base/335311 Log: Fix 32-bit build after 335307 This was correct in the final version on Phabricator, but somehow I screwed up applying the patch locally. Reported by: linimo

svn commit: r335307 - head/tests/sys/audit

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 21:29:35 2018 New Revision: 335307 URL: https://svnweb.freebsd.org/changeset/base/335307 Log: audit(4): add tests for Sys V shared memory syscalls includes shmget, shmat, shmdt, and shmctl Submitted by: aniketp MFC after:2 weeks Sponsored by: Go

svn commit: r335294 - head/tests/sys/audit

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 17:43:55 2018 New Revision: 335294 URL: https://svnweb.freebsd.org/changeset/base/335294 Log: audit(4): add tests for connect, connectat, and accept Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revisio

svn commit: r335290 - in head: etc/mtree usr.sbin/praudit usr.sbin/praudit/tests usr.sbin/praudit/tests/input

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 17:31:16 2018 New Revision: 335290 URL: https://svnweb.freebsd.org/changeset/base/335290 Log: praudit(1): add tests Submitted by: aniketp MFC after:2 weeks X-MFC-With: 335287 Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:

svn commit: r335287 - head/contrib/openbsm/bin/praudit

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 17:10:35 2018 New Revision: 335287 URL: https://svnweb.freebsd.org/changeset/base/335287 Log: praudit(1): return 0 on success Cherry pick https://github.com/openbsm/openbsm/commit/ed83bb3 Submitted by: aniketp Reviewed by: rwatson, 0mp Obtained fro

svn commit: r335285 - head/tests/sys/audit

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 16:24:46 2018 New Revision: 335285 URL: https://svnweb.freebsd.org/changeset/base/335285 Log: audit(4): Add tests for a few syscalls in the ad class The ad audit class is for administrative commands. This commit adds test for settimeofday, adjtime, and ge

svn commit: r335284 - head/tests/sys/audit

2018-06-17 Thread Alan Somers
Author: asomers Date: Sun Jun 17 15:22:27 2018 New Revision: 335284 URL: https://svnweb.freebsd.org/changeset/base/335284 Log: audit(4): add tests for extattr_get_file(2) and friends This commit includes extattr_{get_file, get_fd, get_link, list_file, list_fd, list_link}. It does not inc

svn commit: r335275 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Author: asomers Date: Sun Jun 17 03:10:25 2018 New Revision: 335275 URL: https://svnweb.freebsd.org/changeset/base/335275 Log: audit(4): add tests for chflags and friends chflags, fchflags, and lchflags (but not chflagsat) are included. Submitted by: aniketp MFC after:2 weeks S

Re: svn commit: r335260 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Correction: these are tests for SysV message queues. POSIX message queues are TODO. On Sat, Jun 16, 2018 at 12:22 PM, Alan Somers wrote: > Author: asomers > Date: Sat Jun 16 18:22:35 2018 > New Revision: 335260 > URL: https://svnweb.freebsd.org/changeset/base/335260 > > Log:

svn commit: r335261 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Author: asomers Date: Sat Jun 16 18:29:24 2018 New Revision: 335261 URL: https://svnweb.freebsd.org/changeset/base/335261 Log: audit(4): add tests for pathconf(2) and friends pathconf, lpathconf, and fpathconf are included Submitted by: aniketp MFC after:2 weeks Sponsored by: G

svn commit: r335260 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Author: asomers Date: Sat Jun 16 18:22:35 2018 New Revision: 335260 URL: https://svnweb.freebsd.org/changeset/base/335260 Log: audit(4): add tests for POSIX message queues Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:

svn commit: r335256 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Author: asomers Date: Sat Jun 16 15:38:59 2018 New Revision: 335256 URL: https://svnweb.freebsd.org/changeset/base/335256 Log: audit(4): add tests for chown(2) and friends Includes chown, fchown, lchown, and fchownat Submitted by: aniketp MFC after:2 weeks Sponsored by: Google,

svn commit: r335255 - head/tests/sys/audit

2018-06-16 Thread Alan Somers
Author: asomers Date: Sat Jun 16 15:25:08 2018 New Revision: 335255 URL: https://svnweb.freebsd.org/changeset/base/335255 Log: audit(4): add tests for bind(2), bindat(2), and listen(2) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revi

svn commit: r335215 - head/tests/sys/audit

2018-06-15 Thread Alan Somers
Author: asomers Date: Fri Jun 15 16:41:28 2018 New Revision: 335215 URL: https://svnweb.freebsd.org/changeset/base/335215 Log: audit(4): Add a few tests for network-related syscalls Add tests for socket(2), socketpair(2), and setsockopt(2) Submitted by: aniketp MFC after:2 weeks

svn commit: r335208 - head/tests/sys/audit

2018-06-15 Thread Alan Somers
Author: asomers Date: Fri Jun 15 15:36:10 2018 New Revision: 335208 URL: https://svnweb.freebsd.org/changeset/base/335208 Log: audit(4): improve formatting in tests/sys/audit/open.c [skip ci] Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Diffe

svn commit: r335207 - head/tests/sys/audit

2018-06-15 Thread Alan Somers
Author: asomers Date: Fri Jun 15 15:32:02 2018 New Revision: 335207 URL: https://svnweb.freebsd.org/changeset/base/335207 Log: audit(4): add tests for access(2), chmod(2), and friends access(2), eaccess(2), faccessat(2), chmod(2), fchmod(2), lchmod(2), and fchmodat(2). Submitted by:

svn commit: r335145 - head/tests/sys/audit

2018-06-14 Thread Alan Somers
Author: asomers Date: Thu Jun 14 15:04:49 2018 New Revision: 335145 URL: https://svnweb.freebsd.org/changeset/base/335145 Log: audit(4): add tests for fhopen, fhstat, and fhstatfs Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc. (GSoC 2018) Differential Revision:

svn commit: r335140 - head/tests/sys/audit

2018-06-14 Thread Alan Somers
Author: asomers Date: Thu Jun 14 14:53:01 2018 New Revision: 335140 URL: https://svnweb.freebsd.org/changeset/base/335140 Log: audit(4): fix typo from r335136 Typo in Makefile accidentally disabled some older tests MFC after:2 weeks X-MFC-With: 335136 Modified: head/tests/sy

svn commit: r335136 - head/tests/sys/audit

2018-06-14 Thread Alan Somers
Author: asomers Date: Thu Jun 14 13:42:58 2018 New Revision: 335136 URL: https://svnweb.freebsd.org/changeset/base/335136 Log: audit(4): add tests for flock, fcntl, and fsync Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc (GSoC 2018) Differential Revision:

svn commit: r335105 - head/tests/sys/audit

2018-06-13 Thread Alan Somers
Author: asomers Date: Thu Jun 14 02:30:43 2018 New Revision: 335105 URL: https://svnweb.freebsd.org/changeset/base/335105 Log: audit(4): add tests for statfs(2), fstatfs(2), and getfsstat(2) Submitted by: aniketp MFC after:2 weeks Sponsored by: Google, Inc (GSoC 2018) Differential

svn commit: r335067 - head/tests/sys/audit

2018-06-13 Thread Alan Somers
Author: asomers Date: Wed Jun 13 17:01:57 2018 New Revision: 335067 URL: https://svnweb.freebsd.org/changeset/base/335067 Log: audit(4): Fix file descriptor leaks in ATF tests Submitted by: aniketp Reported by: Coverity CID: 1393343 1393346 1392695 1392781 1391709 1392078 1392

svn commit: r335060 - head/sys/security/audit

2018-06-13 Thread Alan Somers
Author: asomers Date: Wed Jun 13 14:55:31 2018 New Revision: 335060 URL: https://svnweb.freebsd.org/changeset/base/335060 Log: audit(4): fix the definition of ARG_TERMID_ADDR Due to a copy/paste error in r168688, ARG_TERMID_ADDR has the same definition as ARG_SADDRUNIX. Fix it. The

svn commit: r334933 - head/tests/sys/audit

2018-06-10 Thread Alan Somers
Author: asomers Date: Sun Jun 10 21:36:29 2018 New Revision: 334933 URL: https://svnweb.freebsd.org/changeset/base/334933 Log: audit(4): add tests for stat(2) and friends This revision adds auditability tests for stat, lstat, fstat, and fstatat, all from the fa audit class. More tests fr

svn commit: r334668 - head/tests/sys/audit

2018-06-05 Thread Alan Somers
Author: asomers Date: Tue Jun 5 20:13:24 2018 New Revision: 334668 URL: https://svnweb.freebsd.org/changeset/base/334668 Log: audit(4): add tests for open(2) and openat(2) These syscalls are atypical, because each one corresponds to several different audit events, and they each pass seve

svn commit: r334592 - head/tests/sys/audit

2018-06-03 Thread Alan Somers
Author: asomers Date: Sun Jun 3 23:36:29 2018 New Revision: 334592 URL: https://svnweb.freebsd.org/changeset/base/334592 Log: audit(4): add tests for the cl audit class The only syscalls in this class are close, closefrom, munmap, and revoke. Submitted by: aniketp MFC after:2 we

svn commit: r334547 - head/lib/libutil

2018-06-02 Thread Alan Somers
Author: asomers Date: Sat Jun 2 22:40:16 2018 New Revision: 334547 URL: https://svnweb.freebsd.org/changeset/base/334547 Log: pty.3: Add a HISTORY section These functions were first added in 4.3 BSD-Reno, according to http://unix.superglobalmegacorp.com/ and the CSRG svn repository.

svn commit: r334496 - head/tests/sys/audit

2018-06-01 Thread Alan Somers
Author: asomers Date: Fri Jun 1 21:24:10 2018 New Revision: 334496 URL: https://svnweb.freebsd.org/changeset/base/334496 Log: audit(4): add tests for the fd audit class The only syscalls in this class are rmdir, unlink, unlinkat, rename, and renameat. Also, set is_exclusive for all audi

svn commit: r334487 - head/tests/sys/audit

2018-06-01 Thread Alan Somers
Author: asomers Date: Fri Jun 1 16:23:47 2018 New Revision: 334487 URL: https://svnweb.freebsd.org/changeset/base/334487 Log: audit(4): Add tests for the fw class of syscalls. truncate and ftruncate are the only syscalls in this class, apart from certain variations of open and openat, wh

svn commit: r334471 - head/tests/sys/audit

2018-05-31 Thread Alan Somers
Author: asomers Date: Fri Jun 1 01:37:07 2018 New Revision: 334471 URL: https://svnweb.freebsd.org/changeset/base/334471 Log: audit(4): Add tests for the fr class of syscalls readlink and readlinkat are the only syscalls in this class. open and openat are as well, but they'll be handled

svn commit: r334403 - head/sys/security/audit

2018-05-30 Thread Alan Somers
Author: asomers Date: Wed May 30 21:50:23 2018 New Revision: 334403 URL: https://svnweb.freebsd.org/changeset/base/334403 Log: #include in security/audit/audit_ioctl.h security/audit/audit_ioctl.h uses a type from bsm/audit.h, so needs to include it. And it needs to know the type's size

svn commit: r334395 - head/tests/sys

2018-05-30 Thread Alan Somers
Author: asomers Date: Wed May 30 19:58:36 2018 New Revision: 334395 URL: https://svnweb.freebsd.org/changeset/base/334395 Log: Revert r334362 Reconnect tests/sys/audit now that the GCC issue is fixed by 334388 MFC after:2 weeks X-MFC-With: 334362, 334360, 334388 Modified: he

svn commit: r334394 - head/share/man/man4

2018-05-30 Thread Alan Somers
Author: asomers Date: Wed May 30 19:57:15 2018 New Revision: 334394 URL: https://svnweb.freebsd.org/changeset/base/334394 Log: auditpipe(4): fix some ioctl arguments in the man page Fix the argument types for the AUDITPIPE_[GS]ET_PRESELECT_(NA)?FLAGS ioctls. Also, fix some grammar. [

svn commit: r334390 - head/contrib/openbsm/libbsm

2018-05-30 Thread Alan Somers
Author: asomers Date: Wed May 30 17:05:48 2018 New Revision: 334390 URL: https://svnweb.freebsd.org/changeset/base/334390 Log: au_read_rec(3): correct return value in man page Submitted by: aniketp Reviewed by: csjp (earlier version) MFC after:2 weeks Sponsored by: Google, Inc. (

<    1   2   3   4   5   6   7   8   9   10   >