Re: svn commit: r334360 - in head: etc/mtree tests/sys tests/sys/audit

2018-05-30 Thread Alan Somers
On Tue, May 29, 2018 at 6:10 PM, Ed Maste wrote: > On 29 May 2018 at 19:08, Alan Somers wrote: > > Author: asomers > > Date: Tue May 29 23:08:33 2018 > > New Revision: 334360 > > URL: https://svnweb.freebsd.org/changeset/base/334360 > > > > Log: >

svn commit: r334388 - head/contrib/openbsm/bsm

2018-05-30 Thread Alan Somers
Author: asomers Date: Wed May 30 15:51:48 2018 New Revision: 334388 URL: https://svnweb.freebsd.org/changeset/base/334388 Log: Fix OpenBSM with GCC with -Wredundant-decls Upstream change ed47534 consciously added some redundant functional declarations, and I'm not sure why. AFAICT they we

Re: svn commit: r334362 - head/tests/sys

2018-05-29 Thread Alan Somers
Thanks Ed. I'll try to figure out the root cause for this. On Tue, May 29, 2018 at 6:36 PM, Ed Maste wrote: > Author: emaste > Date: Wed May 30 00:36:58 2018 > New Revision: 334362 > URL: https://svnweb.freebsd.org/changeset/base/334362 > > Log: > Temporarily disconnect audit tests > > Audi

svn commit: r334360 - in head: etc/mtree tests/sys tests/sys/audit

2018-05-29 Thread Alan Somers
Author: asomers Date: Tue May 29 23:08:33 2018 New Revision: 334360 URL: https://svnweb.freebsd.org/changeset/base/334360 Log: Add initial set of tests for audit(4) This change includes the framework for testing the auditability of various syscalls, and includes changes for the first 12.

svn commit: r334296 - head/sys/security/audit

2018-05-28 Thread Alan Somers
Author: asomers Date: Mon May 28 20:47:39 2018 New Revision: 334296 URL: https://svnweb.freebsd.org/changeset/base/334296 Log: Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...) Due to an oversight in r195280, auditon(A_SETCLASS, ...) would cause a tailq element to get added to

svn commit: r333251 - head/usr.bin/time

2018-05-04 Thread Alan Somers
Author: asomers Date: Fri May 4 14:39:32 2018 New Revision: 333251 URL: https://svnweb.freebsd.org/changeset/base/333251 Log: time(1): use the monotonic clock The monotonic clock is more appropriate than the realtime clock for measuring durations. Reviewed by: ken, jilles Differe

svn commit: r332631 - in head: sys/kern tests/sys/aio

2018-04-16 Thread Alan Somers
Author: asomers Date: Mon Apr 16 18:12:15 2018 New Revision: 332631 URL: https://svnweb.freebsd.org/changeset/base/332631 Log: lio_listio: return EAGAIN instead of EIO when out of resources This behavior is already documented by the man page, and suggested by POSIX. Reviewed by: jhb

svn commit: r331358 - head/libexec/tftpd/tests

2018-03-22 Thread Alan Somers
Author: asomers Date: Thu Mar 22 14:51:05 2018 New Revision: 331358 URL: https://svnweb.freebsd.org/changeset/base/331358 Log: tftpd: misc Coverity cleanup in the tests A bunch of unchecked return values from open(2) and read(2) Reported by: Coverity CID: 1386900, 1386911,

Re: svn commit: r330894 - in head/sys/contrib/zstd: . contrib/meson doc doc/images lib lib/common lib/compress lib/decompress lib/deprecated lib/dictBuilder lib/legacy programs tests zlibWrapper zlibW

2018-03-17 Thread Alan Somers
On Tue, Mar 13, 2018 at 9:00 PM, Conrad Meyer wrote: > Author: cem > Date: Wed Mar 14 03:00:17 2018 > New Revision: 330894 > URL: https://svnweb.freebsd.org/changeset/base/330894 > > Log: > Update to Zstandard 1.3.3 > > Includes patch to conditionalize use of __builtin_clz(ll) on > __has_buil

svn commit: r331105 - head/sys/security/audit

2018-03-17 Thread Alan Somers
Author: asomers Date: Sat Mar 17 17:56:08 2018 New Revision: 331105 URL: https://svnweb.freebsd.org/changeset/base/331105 Log: audit(4): fix a typo in a comment no functional change Modified: head/sys/security/audit/audit_bsm_klib.c Modified: head/sys/security/audit/audit_bsm_klib.c ===

svn commit: r331104 - head/tests/sys/aio

2018-03-17 Thread Alan Somers
Author: asomers Date: Sat Mar 17 17:52:47 2018 New Revision: 331104 URL: https://svnweb.freebsd.org/changeset/base/331104 Log: aio_kqueue_test: fix the build when DEBUG=1 Also, make the debug output more verbose Modified: head/tests/sys/aio/aio_kqueue_test.c Modified: head/tests/sys/aio

svn commit: r331103 - head/tests/sys/aio

2018-03-17 Thread Alan Somers
Author: asomers Date: Sat Mar 17 17:48:21 2018 New Revision: 331103 URL: https://svnweb.freebsd.org/changeset/base/331103 Log: aio: add an ATF test case for aio_fsync error conditions Modified: head/tests/sys/aio/aio_test.c Modified: head/tests/sys/aio/aio_test.c

Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys

2018-03-14 Thread Alan Somers
On Wed, Mar 14, 2018 at 5:11 PM, Shawn Webb wrote: > On Wed, Mar 14, 2018 at 05:06:09PM -0600, Alan Somers wrote: > > On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb > > wrote: > > > > > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > > > O

Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys

2018-03-14 Thread Alan Somers
On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb wrote: > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb > > wrote: > > > > > On Sun, Feb 25, 2018 at 02:29:43PM +, Alan Somers wrote: > > > > A

Re: svn commit: r330952 - head/sys/kern

2018-03-14 Thread Alan Somers
Well, you _would_ be able to, except the public instance has been down for 3 weeks :( https://scan.coverity.com/ On Wed, Mar 14, 2018 at 4:46 PM, Conrad Meyer wrote: > I believe they didn't come from the public FreeBSD Coverity instance, > and I don't think ID numbers are portable between instan

Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys

2018-03-14 Thread Alan Somers
On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb wrote: > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > Author: asomers > > Date: Sun Feb 25 14:29:43 2018 > > New Revision: 329984 > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > >

Re: svn commit: r330696 - in head/libexec/tftpd: . tests

2018-03-10 Thread Alan Somers
%hhx instead", > + "Expected %#hhx at position %zd; got %hhx instead", > expected[i], i, actual[i]); > } > } > > On Sat, Mar 10, 2018 at 12:30 AM Alan Somers wrote: > >> Author: asomers >> Date: Fri Mar 9 15:

svn commit: r330742 - head/libexec/tftpd/tests

2018-03-10 Thread Alan Somers
Author: asomers Date: Sat Mar 10 18:07:31 2018 New Revision: 330742 URL: https://svnweb.freebsd.org/changeset/base/330742 Log: tftpd: fix the build of tests on i386 after 330696 It's those darn printf format specifiers again Reported by: cy, kibab MFC after:20 days X-MFC-With:

Re: svn commit: r330644 - in head/sys/dev/mlx5: . mlx5_core

2018-03-09 Thread Alan Somers
Yeah, looks like it's working now. Thanks. On Fri, Mar 9, 2018 at 8:25 PM, Conrad Meyer wrote: > Hi Alan, > > I think I fixed it in r330714, if you want to update to that revision. > > Best, > Conrad > > On Fri, Mar 9, 2018 at 7:14 PM, Alan Somers wrote: >

Re: svn commit: r330644 - in head/sys/dev/mlx5: . mlx5_core

2018-03-09 Thread Alan Somers
On Thu, Mar 8, 2018 at 2:47 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Mar 8 09:47:09 2018 > New Revision: 330644 > URL: https://svnweb.freebsd.org/changeset/base/330644 > > Log: > Updates for PCI and health monitor recovery in mlx5core. > This patch accumulates the follow

svn commit: r330720 - in head/libexec/tftpd: . tests

2018-03-09 Thread Alan Somers
Author: asomers Date: Sat Mar 10 01:50:43 2018 New Revision: 330720 URL: https://svnweb.freebsd.org/changeset/base/330720 Log: tftpd: reject unknown opcodes If tftpd receives a command with an unknown opcode, it simply exits 1. It doesn't send an ERROR packet, and the client will hang wa

svn commit: r330719 - in head/libexec/tftpd: . tests

2018-03-09 Thread Alan Somers
Author: asomers Date: Sat Mar 10 01:43:55 2018 New Revision: 330719 URL: https://svnweb.freebsd.org/changeset/base/330719 Log: tftpd: Abort on an WRQ access violation On a WRQ (write request) tftpd checks whether the client has access permission for the file in question. If not, then the

svn commit: r330718 - in head/libexec/tftpd: . tests

2018-03-09 Thread Alan Somers
Author: asomers Date: Sat Mar 10 01:35:26 2018 New Revision: 330718 URL: https://svnweb.freebsd.org/changeset/base/330718 Log: tftpd: Verify world-writability for WRQ when using relative paths tftpd(8) says that files may only be written if they already exist and are publicly writable. t

svn commit: r330710 - in head: libexec/tftpd libexec/tftpd/tests usr.bin/tftp

2018-03-09 Thread Alan Somers
Author: asomers Date: Fri Mar 9 23:25:18 2018 New Revision: 330710 URL: https://svnweb.freebsd.org/changeset/base/330710 Log: tftpd: Flush files as soon as they are fully received On an RRQ, tftpd doesn't exit as soon as it's finished receiving a file. Instead, it waits five seconds just

svn commit: r330709 - head/etc/mtree

2018-03-09 Thread Alan Somers
Author: asomers Date: Fri Mar 9 23:17:29 2018 New Revision: 330709 URL: https://svnweb.freebsd.org/changeset/base/330709 Log: Commit missing file from r330696 MFC after:3 weeks X-MFC-With: 330696 Modified: head/etc/mtree/BSD.tests.dist Modified: head/etc/mtree/BSD.tests.dist ==

Re: svn commit: r330696 - in head/libexec/tftpd: . tests

2018-03-09 Thread Alan Somers
On Fri, Mar 9, 2018 at 8:52 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: asomers > > Date: Fri Mar 9 15:30:20 2018 > > New Revision: 330696 > > URL: https://svnweb.freebsd.org/changeset/base/330696 > > > > Log: > > Add some functional tests for tftpd(8) > > > > tf

svn commit: r330696 - in head/libexec/tftpd: . tests

2018-03-09 Thread Alan Somers
r 9 15:30:20 2018 (r330696) @@ -0,0 +1,1006 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2018 Alan Somers. All rights reserved. + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following

svn commit: r330627 - head/share/man/man9

2018-03-07 Thread Alan Somers
Author: asomers Date: Thu Mar 8 03:19:04 2018 New Revision: 330627 URL: https://svnweb.freebsd.org/changeset/base/330627 Log: g_bio(9): fix a documentation oversight from r163870 MFC after:3 weeks Modified: head/share/man/man9/g_bio.9 Modified: head/share/man/man9/g_bio.9 =

svn commit: r330515 - head/usr.sbin/spray

2018-03-05 Thread Alan Somers
Author: asomers Date: Mon Mar 5 16:13:29 2018 New Revision: 330515 URL: https://svnweb.freebsd.org/changeset/base/330515 Log: spray: fix the spelling in an output string MFC after:3 weeks Modified: head/usr.sbin/spray/spray.c Modified: head/usr.sbin/spray/spray.c ==

svn commit: r330514 - head/libexec/rpc.sprayd

2018-03-05 Thread Alan Somers
Author: asomers Date: Mon Mar 5 16:11:07 2018 New Revision: 330514 URL: https://svnweb.freebsd.org/changeset/base/330514 Log: rpc.sprayd: raise WARNS to 6 MFC after:3 weeks Modified: head/libexec/rpc.sprayd/Makefile head/libexec/rpc.sprayd/sprayd.c Modified: head/libexec/rpc.spra

svn commit: r330295 - head/cddl/contrib/opensolaris/lib/libzfs/common

2018-03-02 Thread Alan Somers
Author: asomers Date: Fri Mar 2 21:26:48 2018 New Revision: 330295 URL: https://svnweb.freebsd.org/changeset/base/330295 Log: ZFS: fix adding vdevs to very large pools r323791 changed the return value of zpool_read_label. Error paths that previously returned 0 began to return -1 instead

svn commit: r330076 - head/sbin/ipfw

2018-02-27 Thread Alan Somers
Author: asomers Date: Tue Feb 27 17:12:33 2018 New Revision: 330076 URL: https://svnweb.freebsd.org/changeset/base/330076 Log: fix typo in ipfw(8). No functional change. Submitted by: zxzharmlesszxz Pull Request: https://github.com/freebsd/freebsd/pull/132 Modified: head/sbin/ipfw/tab

svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys

2018-02-25 Thread Alan Somers
Author: asomers Date: Sun Feb 25 14:29:43 2018 New Revision: 329984 URL: https://svnweb.freebsd.org/changeset/base/329984 Log: Don't declare __assfail as static It gets called by dmu_buf_init_user, which is inline but not static. So it needs global linkage itself. Reported by: GCC-

Re: svn commit: r328612 - head/lib/libc/stdlib

2018-02-25 Thread Alan Somers
I'm seeing the same error during the build of usr.sbin/nologin for riscv.riscv64sf. Has anybody figured out a solution yet? On Thu, Feb 1, 2018 at 9:09 PM, Warner Losh wrote: > > > On Thu, Feb 1, 2018 at 8:34 PM, Steve Wills wrote: > >> This, somehow, seems to have broken the mips64 build: >>

Re: svn commit: r329910 - head/sys/cddl/contrib/opensolaris/uts/common/sys

2018-02-25 Thread Alan Somers
On Sun, Feb 25, 2018 at 6:52 AM, Dimitry Andric wrote: > On 24 Feb 2018, at 17:01, Alan Somers wrote: > > > > Author: asomers > > Date: Sat Feb 24 16:01:21 2018 > > New Revision: 329910 > > URL: https://svnweb.freebsd.org/changeset/base/329910 > >

Re: svn commit: r329722 - head/cddl/usr.sbin/zdb

2018-02-24 Thread Alan Somers
On Sat, Feb 24, 2018 at 5:19 PM, Conrad Meyer wrote: > On Wed, Feb 21, 2018 at 8:40 PM, Alan Somers wrote: > > On Wed, Feb 21, 2018 at 8:51 AM, Alan Somers > wrote: > >> > >> Author: asomers > >> Date: Wed Feb 21 15:51:48 2018 > >> New Revis

svn commit: r329910 - head/sys/cddl/contrib/opensolaris/uts/common/sys

2018-02-24 Thread Alan Somers
Author: asomers Date: Sat Feb 24 16:01:21 2018 New Revision: 329910 URL: https://svnweb.freebsd.org/changeset/base/329910 Log: Implement CTASSERT using _Static_assert Prevents warnings about "unused typedef" with GCC-6 Reported by: GCC-6 MFC after:18 days X-MFC-With: 329722

svn commit: r329909 - head/share/mk

2018-02-24 Thread Alan Somers
Author: asomers Date: Sat Feb 24 15:13:20 2018 New Revision: 329909 URL: https://svnweb.freebsd.org/changeset/base/329909 Log: tests: require ksh93 in the Kyuafiles for all atf-ksh93 test programs Modified: head/share/mk/atf.test.mk Modified: head/share/mk/atf.test.mk ===

Re: svn commit: r329874 - in head: etc/mtree tests/sys/net

2018-02-23 Thread Alan Somers
On Fri, Feb 23, 2018 at 7:05 PM, Kubilay Kocak wrote: > On 2/24/18 5:18 AM, Alan Somers wrote: > > Unfortunately, most of the tests are disabled because they fairly > frequently > > trigger panics. > > Do the atf_skip annotations/reasons show up in the output even

svn commit: r329874 - in head: etc/mtree tests/sys/net

2018-02-23 Thread Alan Somers
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +# POSSIBILITY OF SUCH DAMAGES. +# +# Authors: Alan Somers (Spectra Logic Corporation) +# +# $FreeBSD$ + +# Outline: +# For each cloned interface type, do three tests +# 1) Create and destroy it +# 2) Create, up, and destroy it +# 3) Create, disable IPv

svn commit: r329872 - head/usr.sbin/mptutil

2018-02-23 Thread Alan Somers
Author: asomers Date: Fri Feb 23 17:20:53 2018 New Revision: 329872 URL: https://svnweb.freebsd.org/changeset/base/329872 Log: Delete copypasta Reported by: rpokala MFC after:20 days X-MFC-With: 329845 Sponsored by: Spectra Logic Corp Modified: head/usr.sbin/mptutil/mpt_conf

Re: svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug

2018-02-23 Thread Alan Somers
On Fri, Feb 23, 2018 at 7:47 AM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: asomers > > Date: Fri Feb 23 03:11:43 2018 > > New Revision: 329853 > > URL: https://svnweb.freebsd.org/changeset/base/329853 > > > > Log: > > libifconfig: multiple feature additions > > > >

svn commit: r329853 - in head: lib/libifconfig share/examples/libifconfig usr.sbin/wlandebug

2018-02-22 Thread Alan Somers
Author: asomers Date: Fri Feb 23 03:11:43 2018 New Revision: 329853 URL: https://svnweb.freebsd.org/changeset/base/329853 Log: libifconfig: multiple feature additions Added the ability to: * Create virtual interfaces * Create vlan interfaces * Get interface fib * Get interface gr

svn commit: r329845 - head/usr.sbin/mptutil

2018-02-22 Thread Alan Somers
Author: asomers Date: Fri Feb 23 00:17:50 2018 New Revision: 329845 URL: https://svnweb.freebsd.org/changeset/base/329845 Log: Fix numerous Coverity issues in mptutil Most are memory or file descriptor leaks. Three were unannotated fallthroughs in a switch/case statement. One was an integ

svn commit: r329830 - head/sbin/nvmecontrol

2018-02-22 Thread Alan Somers
Author: asomers Date: Thu Feb 22 17:47:16 2018 New Revision: 329830 URL: https://svnweb.freebsd.org/changeset/base/329830 Log: nvmecontrol: fix build on amd64/clang Broken by:329824 Sponsored by: Spectra Logic Corp Modified: head/sbin/nvmecontrol/identify.c Modified: head/sbin/nvm

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Alan Somers
On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New Revision: 329824 >

Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

2018-02-22 Thread Alan Somers
On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > Author: wma > Date: Thu Feb 22 13:32:31 2018 > New Revision: 329824 > URL: https://svnweb.freebsd.org/changeset/base/329824 > > Log: > NVMe: Add big-endian support > > Remove bitfields from defined structures as they are not portable. >

Re: svn commit: r329722 - head/cddl/usr.sbin/zdb

2018-02-21 Thread Alan Somers
On Wed, Feb 21, 2018 at 8:51 AM, Alan Somers wrote: > Author: asomers > Date: Wed Feb 21 15:51:48 2018 > New Revision: 329722 > URL: https://svnweb.freebsd.org/changeset/base/329722 > > Log: > zdb: raise WARNS from 0 to 2 > > This has only been possible since r3

svn commit: r329754 - in head/sbin/dhclient: . tests

2018-02-21 Thread Alan Somers
Author: asomers Date: Wed Feb 21 21:13:08 2018 New Revision: 329754 URL: https://svnweb.freebsd.org/changeset/base/329754 Log: dhclient: raise WARNS to 4 Mostly const-correctness fixes. There were also some variable-shadowing, unused variable, and a couple of sockaddr type-correctness cha

svn commit: r329750 - head/lib/libifconfig

2018-02-21 Thread Alan Somers
Author: asomers Date: Wed Feb 21 20:45:43 2018 New Revision: 329750 URL: https://svnweb.freebsd.org/changeset/base/329750 Log: libifconfig: fix ifconfig_set_metric Due to a copy/paste error, ifconfig_set_metric actually set the mtu, not the metric. See Also: https://github.com/Savage

svn commit: r329722 - head/cddl/usr.sbin/zdb

2018-02-21 Thread Alan Somers
Author: asomers Date: Wed Feb 21 15:51:48 2018 New Revision: 329722 URL: https://svnweb.freebsd.org/changeset/base/329722 Log: zdb: raise WARNS from 0 to 2 This has only been possible since r329694 and r329508 MFC after:3 weeks X-MFC-With: 329694 X-MFC-With: 329508 Sponso

svn commit: r329657 - head/cddl/contrib/opensolaris/cmd/zdb

2018-02-20 Thread Alan Somers
Author: asomers Date: Tue Feb 20 19:54:06 2018 New Revision: 329657 URL: https://svnweb.freebsd.org/changeset/base/329657 Log: Fix memory leaks in zdb introduced by r329508 Reported by: Coverity CID: 1386185 MFC after:3 weeks X-MFC-With: 329508 Sponsored by: Spectra

svn commit: r329606 - in head/usr.bin/tail: . tests

2018-02-19 Thread Alan Somers
Author: asomers Date: Mon Feb 19 22:09:49 2018 New Revision: 329606 URL: https://svnweb.freebsd.org/changeset/base/329606 Log: tail: fix "tail -r" for piped input that begins with '\n' A subtle logic bug, probably introduced in r311895, caused tail to print the first two lines of piped in

svn commit: r329412 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-02-16 Thread Alan Somers
Author: asomers Date: Fri Feb 16 21:59:08 2018 New Revision: 329412 URL: https://svnweb.freebsd.org/changeset/base/329412 Log: zfs: fix formatting in a log statement Submitted by: Dave Baukus MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified: head/sys/cddl/contrib/open

svn commit: r329384 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-02-16 Thread Alan Somers
Author: asomers Date: Fri Feb 16 16:56:09 2018 New Revision: 329384 URL: https://svnweb.freebsd.org/changeset/base/329384 Log: Handle generic pathconf attributes in the .zfs ctldir MFC instructions: change the value of _PC_LINK_MAX to INT_MAX Reported by: jhb MFC after:19 days

Re: svn commit: r329265 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-02-16 Thread Alan Somers
On Thu, Feb 15, 2018 at 12:18 PM, John Baldwin wrote: > On Wednesday, February 14, 2018 03:49:31 PM Alan Somers wrote: > > Author: asomers > > Date: Wed Feb 14 15:49:31 2018 > > New Revision: 329265 > > URL: https://svnweb.freebsd.org/changeset/base/329265 &

svn commit: r329344 - head/cddl/usr.sbin/zfsd

2018-02-15 Thread Alan Somers
Author: asomers Date: Thu Feb 15 21:30:30 2018 New Revision: 329344 URL: https://svnweb.freebsd.org/changeset/base/329344 Log: Optimize zfsd for the happy case If there are no damaged pools, then ignore all GEOM events. We only use them to fix damaged pools. However, still pay attention

svn commit: r329284 - in head: cddl/usr.sbin/zfsd lib/libdevdctl

2018-02-14 Thread Alan Somers
Author: asomers Date: Wed Feb 14 23:52:39 2018 New Revision: 329284 URL: https://svnweb.freebsd.org/changeset/base/329284 Log: zfsd: Allow zfsd to work on any type of GEOM provider cddl/usr.sbin/zfsd/zfsd_event.cc Remove the check for da and ada devices. This way zfsd can work on m

svn commit: r329277 - head/etc/mtree

2018-02-14 Thread Alan Somers
Author: asomers Date: Wed Feb 14 21:02:38 2018 New Revision: 329277 URL: https://svnweb.freebsd.org/changeset/base/329277 Log: Add mtree entry for 329275 MFC after:3 weeks X-MFC-With: 329275 Sponsored by: Spectra Logic Corp Modified: head/etc/mtree/BSD.tests.dist Modified: hea

svn commit: r329275 - in head: sys/geom/part tests/sys/geom/class tests/sys/geom/class/part

2018-02-14 Thread Alan Somers
s/sys/geom/class/part/misc.sh == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/tests/sys/geom/class/part/misc.sh Wed Feb 14 20:26:09 2018 (r329275) @@ -0,0 +1,187 @@ +# Copyright

svn commit: r329273 - in head: sys/geom/eli tests/sys/geom/class/eli

2018-02-14 Thread Alan Somers
se file is newly added) +++ head/tests/sys/geom/class/eli/misc_test.sh Wed Feb 14 20:15:32 2018 (r329273) @@ -0,0 +1,177 @@ +# Copyright (c) 2018 Alan Somers +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permit

svn commit: r329265 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-02-14 Thread Alan Somers
Author: asomers Date: Wed Feb 14 15:49:31 2018 New Revision: 329265 URL: https://svnweb.freebsd.org/changeset/base/329265 Log: Implement .vop_pathconf and .vop_getacl for the .zfs ctldir zfsctl_common_pathconf will report all the same variables that regular ZFS volumes report. zfsctl_comm

svn commit: r329236 - head/contrib/netbsd-tests/kernel

2018-02-13 Thread Alan Somers
Author: asomers Date: Tue Feb 13 19:17:33 2018 New Revision: 329236 URL: https://svnweb.freebsd.org/changeset/base/329236 Log: Fix Coverity CIDs in the sys/kern/sysv_test tests CID 979810: strcpy => strlcpy CID 1193367: don't leak a file descriptor CID 1299856: Check the return value of

svn commit: r329174 - head/sys/sys

2018-02-12 Thread Alan Somers
Author: asomers Date: Mon Feb 12 17:42:28 2018 New Revision: 329174 URL: https://svnweb.freebsd.org/changeset/base/329174 Log: Fix a comment. No functional change. MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified: head/sys/sys/aio.h Modified: head/sys/sys/aio.h ===

svn commit: r329108 - in head: contrib/netbsd-tests/lib/libc/sys tools/regression/sockets/socketpair

2018-02-10 Thread Alan Somers
Author: asomers Date: Sat Feb 10 19:43:52 2018 New Revision: 329108 URL: https://svnweb.freebsd.org/changeset/base/329108 Log: Convert tools/regression/sockets/socketpair to ATF Reviewed by: cem MFC after:3 weeks Differential Revision:https://reviews.freebsd.org/D14305 Del

Re: svn commit: r329064 - head/share/zoneinfo

2018-02-09 Thread Alan Somers
On Fri, Feb 9, 2018 at 8:50 AM, Warner Losh wrote: > Author: imp > Date: Fri Feb 9 15:50:32 2018 > New Revision: 329064 > URL: https://svnweb.freebsd.org/changeset/base/329064 > > Log: > We don't actually need env here, so drop it. All shells allow setting > of shell variables for the next c

svn commit: r329067 - head/cddl/contrib/opensolaris/cmd/zpool

2018-02-09 Thread Alan Somers
Author: asomers Date: Fri Feb 9 16:08:57 2018 New Revision: 329067 URL: https://svnweb.freebsd.org/changeset/base/329067 Log: Fix "zpool add" crash when a replacing vdev has a spare child Fix an assertion in zpool that causes a crash when running any "zpool add" command on a spare that c

svn commit: r328849 - in head: sbin/geom/class/cache sbin/geom/class/concat sbin/geom/class/journal sbin/geom/class/label sbin/geom/class/mirror sbin/geom/class/raid3 sbin/geom/class/shsec sbin/geo...

2018-02-04 Thread Alan Somers
Author: asomers Date: Sun Feb 4 14:49:55 2018 New Revision: 328849 URL: https://svnweb.freebsd.org/changeset/base/328849 Log: geom: don't write stack garbage in disk labels Most consumers of g_metadata_store were passing in partially unallocated memory, resulting in stack garbage being w

svn commit: r328605 - head/cddl/usr.sbin/zfsd

2018-01-30 Thread Alan Somers
Author: asomers Date: Tue Jan 30 21:25:43 2018 New Revision: 328605 URL: https://svnweb.freebsd.org/changeset/base/328605 Log: zfsd: Don't spare a vdev that's being replaced If a zfs pool contains a replacing vdev (either created manually by "zpool replace" or by zfsd(8) via autoreplace b

Re: svn commit: r323314 - in head/sbin/geom: class/virstor misc

2018-01-29 Thread Alan Somers
On Fri, Sep 8, 2017 at 9:08 AM, Conrad Meyer wrote: > Author: cem > Date: Fri Sep 8 15:08:17 2017 > New Revision: 323314 > URL: https://svnweb.freebsd.org/changeset/base/323314 > > Log: > Audit userspace geom code for leaking memory to disk > > Any geom class using g_metadata_store, as well

svn commit: r328343 - head/usr.bin/time

2018-01-24 Thread Alan Somers
Author: asomers Date: Wed Jan 24 17:12:34 2018 New Revision: 328343 URL: https://svnweb.freebsd.org/changeset/base/328343 Log: time(1): use clock_gettime(2) instead of gettimeofday(2) This is a prerequisite to adding support for the monotonic clock Reviewed by: ken, imp MFC after:

svn commit: r328296 - head/sys/netinet6

2018-01-23 Thread Alan Somers
Author: asomers Date: Tue Jan 23 19:40:05 2018 New Revision: 328296 URL: https://svnweb.freebsd.org/changeset/base/328296 Log: sys/netinet6: fix typos in comments. No functional change. MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified: head/sys/netinet6/in6.c head/sys

svn commit: r328266 - in head: contrib/netbsd-tests/lib/libc/sys lib/libc/sys

2018-01-22 Thread Alan Somers
Author: asomers Date: Mon Jan 22 21:45:54 2018 New Revision: 328266 URL: https://svnweb.freebsd.org/changeset/base/328266 Log: mlock(2): correct documentation for error conditions. The man page is years out of date regarding errors. Our implementation _does_ allow unaligned addresses, and

svn commit: r328108 - in head: sbin/geom/class/nop sys/geom/nop tests/sys/geom/class/nop

2018-01-17 Thread Alan Somers
Author: asomers Date: Thu Jan 18 05:57:10 2018 New Revision: 328108 URL: https://svnweb.freebsd.org/changeset/base/328108 Log: gnop(8): add the ability to set a nop provider's physical path While I'm here, expand the existing tests a bit. MFC after:3 weeks Differential Revision:

svn commit: r327862 - head/sbin/dhclient

2018-01-11 Thread Alan Somers
Author: asomers Date: Fri Jan 12 04:26:40 2018 New Revision: 327862 URL: https://svnweb.freebsd.org/changeset/base/327862 Log: dhclient(8): add missing include stdbool is technically needed, though we can get away without it due to header pollution. MFC after:3 days Modified:

svn commit: r327739 - head/contrib/subversion/subversion/svn svnadmin/hooks/scripts

2018-01-09 Thread Alan Somers
Author: asomers Date: Tue Jan 9 21:02:39 2018 New Revision: 327739 URL: https://svnweb.freebsd.org/changeset/base/327739 Log: Add Pull Request to the Subversion commit template Reviewed by: emaste MFC after:2 weeks Differential Revision:https://reviews.freebsd.org/D13178

svn commit: r327685 - head/tests/sys/geom/class/eli

2018-01-07 Thread Alan Somers
Author: asomers Date: Mon Jan 8 00:10:45 2018 New Revision: 327685 URL: https://svnweb.freebsd.org/changeset/base/327685 Log: geli: optimize tests Reduce the geli tests' runtime by about a third: * In integrity_test:copy, use a file-backed md(4) device instead of a malloc'd one.

svn commit: r327683 - in head: . tests/sys/geom/class/eli

2018-01-07 Thread Alan Somers
Author: asomers Date: Sun Jan 7 22:21:07 2018 New Revision: 327683 URL: https://svnweb.freebsd.org/changeset/base/327683 Log: geli: convert remaining TAP tests to ATF MFC after:2 weeks Deleted: head/tests/sys/geom/class/eli/nokey_test.sh head/tests/sys/geom/class/eli/readonly_test

svn commit: r327682 - head/tests/sys/geom/class/eli

2018-01-07 Thread Alan Somers
Author: asomers Date: Sun Jan 7 21:57:52 2018 New Revision: 327682 URL: https://svnweb.freebsd.org/changeset/base/327682 Log: Fix typo from r327666 MFC after:13 days X-MFC-With: 327666 Modified: head/tests/sys/geom/class/eli/init_test.sh Modified: head/tests/sys/geom/class/eli/

svn commit: r327666 - head/tests/sys/geom/class/eli

2018-01-06 Thread Alan Somers
Author: asomers Date: Sun Jan 7 02:30:08 2018 New Revision: 327666 URL: https://svnweb.freebsd.org/changeset/base/327666 Log: geli: fix parallel execution of tests The trick is not to destroy an md(4) device during a test. That can create a "double-free" situation, because we also destr

svn commit: r327662 - in head: . tests/sys/geom/class/eli

2018-01-06 Thread Alan Somers
Author: asomers Date: Sun Jan 7 00:44:22 2018 New Revision: 327662 URL: https://svnweb.freebsd.org/changeset/base/327662 Log: geli: convert most tests from TAP to ATF I'm leaving readonly_test and nokey_test alone for now. In a future commit they should be broken up into several smaller

svn commit: r327353 - head/tests/sys/geom/class/eli

2017-12-29 Thread Alan Somers
Author: asomers Date: Fri Dec 29 18:42:55 2017 New Revision: 327353 URL: https://svnweb.freebsd.org/changeset/base/327353 Log: geli: fix the resize test on arm64 The resize test used bsdlabel(8), which is not available on all architectures. Change it to use gpart(8) instead, which should

svn commit: r327352 - head/tests/sys/geom/class/eli

2017-12-29 Thread Alan Somers
Author: asomers Date: Fri Dec 29 18:09:06 2017 New Revision: 327352 URL: https://svnweb.freebsd.org/changeset/base/327352 Log: Fix a harmless typo from r310786 I copy/pasted a reference to an undefined shell variable. MFC after:2 weeks Modified: head/tests/sys/geom/class/eli/con

svn commit: r327347 - head/tests/sys/geom/class/eli

2017-12-29 Thread Alan Somers
Author: asomers Date: Fri Dec 29 16:13:06 2017 New Revision: 327347 URL: https://svnweb.freebsd.org/changeset/base/327347 Log: geli: factor out some common code in the geli tests No functional change. MFC after:2 weeks Sponsored by: Spectra Logic Corp Modified: head/tests/sys/

svn commit: r327346 - head/tests/sys/geom/class/eli

2017-12-29 Thread Alan Somers
Author: asomers Date: Fri Dec 29 16:06:10 2017 New Revision: 327346 URL: https://svnweb.freebsd.org/changeset/base/327346 Log: Fix potential TOCTTOU bug in the geli tests This change mostly reverts r293436, which introduced the bug due to a belief that geli(8) would allocate md(4) devices

svn commit: r326853 - head/sbin/dhclient

2017-12-14 Thread Alan Somers
Author: asomers Date: Thu Dec 14 15:41:32 2017 New Revision: 326853 URL: https://svnweb.freebsd.org/changeset/base/326853 Log: dhclient(8): raise WARNS to 3 Mostly had to fix a lot of signed/unsigned comparison warnings MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified

svn commit: r326834 - head/sbin/dhclient

2017-12-13 Thread Alan Somers
Author: asomers Date: Wed Dec 13 20:48:20 2017 New Revision: 326834 URL: https://svnweb.freebsd.org/changeset/base/326834 Log: dhclient(8): Don't shift through the sign bit of a signed int PR: 208007 Submitted by: Michael McConville MFC after:3 weeks Modified: head/sbi

svn commit: r326799 - head/contrib/less

2017-12-12 Thread Alan Somers
Author: asomers Date: Tue Dec 12 17:34:35 2017 New Revision: 326799 URL: https://svnweb.freebsd.org/changeset/base/326799 Log: less(1): diff reduction vs upstream No functional change. MFC after:3 weeks Sponsored by: Spectra Logic Corp Modified: head/contrib/less/main.c Modif

svn commit: r326698 - head/usr.bin/at

2017-12-08 Thread Alan Somers
Author: asomers Date: Fri Dec 8 17:15:20 2017 New Revision: 326698 URL: https://svnweb.freebsd.org/changeset/base/326698 Log: at(1): annotate some intended switch-case fallthroughs Reported by: Coverity CID: 1008191 MFC after:3 weeks Sponsored by: Spectra Logic Corp Mo

svn commit: r326652 - in head/usr.bin/dc: . tests

2017-12-06 Thread Alan Somers
= --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/dc/tests/bcode.sh Thu Dec 7 02:08:55 2017 (r326652) @@ -0,0 +1,144 @@ +# SPDX-License-Identifier: BSD-2-Clause-FreeBSD +# +# Copyright (c)

svn commit: r326646 - head/lib/libcam

2017-12-06 Thread Alan Somers
Author: asomers Date: Wed Dec 6 23:24:11 2017 New Revision: 326646 URL: https://svnweb.freebsd.org/changeset/base/326646 Log: Fix a null-pointer dereference and a tautological check in cam_get_device Reported by: Coverity CID: 1017964 MFC after:3 weeks Sponsored by: Spe

svn commit: r326640 - in head/lib/libc: gen tests/gen

2017-12-06 Thread Alan Somers
Author: asomers Date: Wed Dec 6 22:06:48 2017 New Revision: 326640 URL: https://svnweb.freebsd.org/changeset/base/326640 Log: Optimize telldir(3) Currently each call to telldir() requires a malloc and adds an entry to a linked list which must be traversed on future telldir(), seekdir(),

Re: svn commit: r326624 - head/sys/cam/ata

2017-12-06 Thread Alan Somers
, are there any such monstrosities? > > -Ravi (rpokala@) > > -Original Message- > From: on behalf of Alan Somers > > Date: 2017-12-06, Wednesday at 09:01 > To: , , < > svn-src-head@freebsd.org> > Subject: svn commit: r326624 - head/sys/cam/ata > &g

svn commit: r326624 - head/sys/cam/ata

2017-12-06 Thread Alan Somers
Author: asomers Date: Wed Dec 6 17:01:25 2017 New Revision: 326624 URL: https://svnweb.freebsd.org/changeset/base/326624 Log: cam: fix sign-extension error in adagetparams adagetparams contains a sign-extension error that will cause the sector count to be incorrectly calculated for ATA d

Re: svn commit: r282485 - head/lib/libc/gen

2017-12-05 Thread Alan Somers
On Tue, May 5, 2015 at 8:52 AM, Julian Elischer wrote: > Author: julian > Date: Tue May 5 14:52:33 2015 > New Revision: 282485 > URL: https://svnweb.freebsd.org/changeset/base/282485 > > Log: > Tweak seekdir, telldir and readdir so that when htere are deletes going > on, > as seek to teh las

svn commit: r326556 - in head: etc/mtree usr.bin/dc usr.bin/dc/tests

2017-12-04 Thread Alan Somers
(empty, because file is newly added) +++ head/usr.bin/dc/tests/inout.sh Tue Dec 5 04:22:35 2017 (r326556) @@ -0,0 +1,102 @@ +# SPDX-License-Identifier: BSD-2-Clause-FreeBSD +# +# Copyright (c) 2017 Alan Somers +# All rights reserved. +# +# Redistribution and use in source and bin

Re: svn commit: r326497 - in head: etc/mtree tests/sys tests/sys/netipsec tests/sys/netipsec/tunnel

2017-12-03 Thread Alan Somers
On Sun, Dec 3, 2017 at 6:52 AM, Kristof Provost wrote: > Author: kp > Date: Sun Dec 3 13:52:35 2017 > New Revision: 326497 > URL: https://svnweb.freebsd.org/changeset/base/326497 > > Log: > Add IPSec tests in tunnel mode > > Some IPSec in tunnel mode allowing to test multiple IPSec > confi

svn commit: r326455 - head/usr.bin/dc

2017-12-01 Thread Alan Somers
Author: asomers Date: Sat Dec 2 06:05:03 2017 New Revision: 326455 URL: https://svnweb.freebsd.org/changeset/base/326455 Log: Reap dead code usr.bin/dc/inout.c Reap some dead code that was killed back in 2003 in OpenBSD, in version 1.8 of this file. MFC after:3 wee

svn commit: r326401 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2017-11-30 Thread Alan Somers
Author: asomers Date: Thu Nov 30 15:36:06 2017 New Revision: 326401 URL: https://svnweb.freebsd.org/changeset/base/326401 Log: Fix assertion when ZFS fails to open certain devices "panic: vdev_geom_close_locked: cp->private is NULL" This panic will result if ZFS fails to open a device due

svn commit: r326400 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2017-11-30 Thread Alan Somers
Author: asomers Date: Thu Nov 30 15:34:55 2017 New Revision: 326400 URL: https://svnweb.freebsd.org/changeset/base/326400 Log: Revert r326399 Accidentally committed wrong file Pointy hat to:asomers Sponsored by: Spectra Logic Corp Modified: head/sys/cddl/contrib/opensolari

<    1   2   3   4   5   6   7   8   9   10   >