svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455 Log: Make struct ifnet readable and comprehensible again by grouping and ordering related variables, fields and locks next to each other. Add more comments to variables.

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http://svnweb.freebsd.org/changeset/base/257455 Log: Make struct ifnet readable and comprehensible again

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 20:27, Ian Lepore wrote: On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann wrote: Author: andre Date: Thu Oct 31 15:46:10 2013 New Revision: 257455 URL: http

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 21:15, Ian Lepore wrote: On Thu, 2013-10-31 at 21:05 +0100, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 01:27:25PM -0600, Ian Lepore wrote: ... Is there any chance all this reworking might get us to a position where the protocol header in an mbuf doesn't have to be 32-bit aligned

Re: svn commit: r257455 - head/sys/net

2013-10-31 Thread Andre Oppermann
On 31.10.2013 23:32, Ian Lepore wrote: On Thu, 2013-10-31 at 23:17 +0100, Andre Oppermann wrote: On 31.10.2013 20:27, Ian Lepore wrote: On Thu, 2013-10-31 at 20:08 +0100, Andre Oppermann wrote: On 31.10.2013 19:03, Luigi Rizzo wrote: On Thu, Oct 31, 2013 at 03:46:10PM +, Andre Oppermann

svn commit: r257391 - in head/sys: dev/snc mips/nlm/dev/net

2013-10-30 Thread Andre Oppermann
Author: andre Date: Wed Oct 30 16:56:46 2013 New Revision: 257391 URL: http://svnweb.freebsd.org/changeset/base/257391 Log: nclude missing net/if_var.h. Due to header pollution it wasn't noticed before. Modified: head/sys/dev/snc/dp83932.c head/sys/mips/nlm/dev/net/xlpge.c Modified:

Re: svn commit: r257391 - in head/sys: dev/snc mips/nlm/dev/net

2013-10-30 Thread Andre Oppermann
On 30.10.2013 18:40, Sergey Kandaurov wrote: On 30 October 2013 20:56, Andre Oppermann an...@freebsd.org wrote: Author: andre Date: Wed Oct 30 16:56:46 2013 New Revision: 257391 URL: http://svnweb.freebsd.org/changeset/base/257391 Log: nclude missing net/if_var.h. Due to header

svn commit: r257351 - head/sys/net

2013-10-29 Thread Andre Oppermann
Author: andre Date: Tue Oct 29 17:48:08 2013 New Revision: 257351 URL: http://svnweb.freebsd.org/changeset/base/257351 Log: Move all interface queue related structures, macros and definitions from net/if_var to it own new net/ifq.h. For now net/ifq.h is unconditionally included through

svn commit: r256920 - head/sys/netinet

2013-10-22 Thread Andre Oppermann
Author: andre Date: Tue Oct 22 18:24:34 2013 New Revision: 256920 URL: http://svnweb.freebsd.org/changeset/base/256920 Log: The TCP delayed ACK logic isn't aware of LRO passing up large aggregated segments thinking it received only one segment. This causes it to enable the delay the ACK for

Re: svn commit: r255608 - in head/sys: conf kern modules/cxgb/cxgb modules/sfxge modules/ti sys vm

2013-09-16 Thread Andre Oppermann
On 16.09.2013 08:25, Konstantin Belousov wrote: Author: kib Date: Mon Sep 16 06:25:54 2013 New Revision: 255608 URL: http://svnweb.freebsd.org/changeset/base/255608 Log: Remove zero-copy sockets code. It only worked for anonymous memory, and the equivalent functionality is now provided

Re: svn commit: r254773 - head/sys/net

2013-09-08 Thread Andre Oppermann
On 07.09.2013 17:30, Mikolaj Golub wrote: Hi, On Sat, Aug 24, 2013 at 11:17:25AM +, Andre Oppermann wrote: Author: andre Date: Sat Aug 24 11:17:25 2013 New Revision: 254773 URL: http://svnweb.freebsd.org/changeset/base/254773 Log: Resolve the confusion between the head_list

svn commit: r254973 - in head/sys: kern sys

2013-08-27 Thread Andre Oppermann
Author: andre Date: Tue Aug 27 20:52:02 2013 New Revision: 254973 URL: http://svnweb.freebsd.org/changeset/base/254973 Log: Pad m_hdr on 32bit architectures to to prevent alignment and padding problems with the way MLEN, MHLEN, and struct mbuf are set up. CTASSERT's are provided to

svn commit: r254910 - head/sys/dev/xen/netback

2013-08-26 Thread Andre Oppermann
Author: andre Date: Mon Aug 26 13:17:37 2013 New Revision: 254910 URL: http://svnweb.freebsd.org/changeset/base/254910 Log: Fix mbuf debugging printf()'s after the recent mbuf header changes. Modified: head/sys/dev/xen/netback/netback.c Modified: head/sys/dev/xen/netback/netback.c

Re: svn commit: r254527 - in head/sys: net80211 netinet sys

2013-08-26 Thread Andre Oppermann
On 26.08.2013 11:43, Gleb Smirnoff wrote: A Author: andre A Date: Mon Aug 19 14:25:11 2013 A New Revision: 254527 A URL: http://svnweb.freebsd.org/changeset/base/254527 A A Log: A Reorder the mbuf defines to make more sense and group related flags A together. A A Add M_FLAG_PRINTF for use

Re: svn commit: r254779 - head/sys/kern

2013-08-26 Thread Andre Oppermann
On 26.08.2013 12:50, Gleb Smirnoff wrote: On Sat, Aug 24, 2013 at 12:24:59PM +, Andre Oppermann wrote: A Author: andre A Date: Sat Aug 24 12:24:58 2013 A New Revision: 254779 A URL: http://svnweb.freebsd.org/changeset/base/254779 A A Log: A Avoid code duplication for mbuf initialization

Re: svn commit: r254805 - head/sys/sys

2013-08-26 Thread Andre Oppermann
On 26.08.2013 13:00, Gleb Smirnoff wrote: On Sat, Aug 24, 2013 at 07:58:36PM +, Andre Oppermann wrote: A Author: andre A Date: Sat Aug 24 19:58:36 2013 A New Revision: 254805 A URL: http://svnweb.freebsd.org/changeset/base/254805 A A Log: A Add mtodo(m, o) macro taking an additional offset

svn commit: r254830 - head/sys/kern

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 09:40:15 2013 New Revision: 254830 URL: http://svnweb.freebsd.org/changeset/base/254830 Log: Adjust socow_iodone() after r254799. Sponsored by: The FreeBSD Foundation Modified: head/sys/kern/uipc_cow.c Modified: head/sys/kern/uipc_cow.c

svn commit: r254831 - head/sys/net

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 09:41:37 2013 New Revision: 254831 URL: http://svnweb.freebsd.org/changeset/base/254831 Log: Remove unnecessary setup of the m-pkthdr.header pointer. Sponsored by: The FreeBSD Foundation Modified: head/sys/net/if_fddisubr.c head/sys/net/if_iso88025subr.c

svn commit: r254832 - head/sys/ofed/drivers/net/mlx4

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 09:45:26 2013 New Revision: 254832 URL: http://svnweb.freebsd.org/changeset/base/254832 Log: Change m-pkthdr.header to m-pkthdr.PH_loc.ptr after r254804 to transiently store pointers to packet headers. Sponsored by: The FreeBSD Foundation Modified:

svn commit: r254834 - in head/sys: netinet netinet6

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 09:49:00 2013 New Revision: 254834 URL: http://svnweb.freebsd.org/changeset/base/254834 Log: For now limit printf(9) %x of the 64bit pkthdr.csum_flags field to 32bits. The upper 32bits are not occupied for now. Sponsored by: The FreeBSD Foundation

svn commit: r254842 - in head/sys: compat/ndis dev/cas dev/hatm dev/if_ndis dev/iscsi_initiator dev/lge dev/mwl dev/wb kern sys

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 10:57:09 2013 New Revision: 254842 URL: http://svnweb.freebsd.org/changeset/base/254842 Log: Give (*ext_free) an int return value allowing for very sophisticated external mbuf buffer management capabilities in the future. For now only EXT_FREE_OK is defined

svn commit: r254857 - head/sys/sys

2013-08-25 Thread Andre Oppermann
Author: andre Date: Sun Aug 25 13:30:37 2013 New Revision: 254857 URL: http://svnweb.freebsd.org/changeset/base/254857 Log: Fix CSUM compatibility mapping. SCTP is a layer 4 protocol. Submitted by: tuexen Modified: head/sys/sys/mbuf.h Modified: head/sys/sys/mbuf.h

svn commit: r254769 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 10:13:59 2013 New Revision: 254769 URL: http://svnweb.freebsd.org/changeset/base/254769 Log: Introduce typedef for pfil hook callback function and replace all spelled out occurrences with it. Reviewed by: eri Modified: head/sys/net/pfil.c

svn commit: r254770 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 10:30:20 2013 New Revision: 254770 URL: http://svnweb.freebsd.org/changeset/base/254770 Log: Convert one instance of pfil hook callback missed in r254769. Modified: head/sys/net/pfil.c Modified: head/sys/net/pfil.c

svn commit: r254771 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 10:36:33 2013 New Revision: 254771 URL: http://svnweb.freebsd.org/changeset/base/254771 Log: Internalize pfil_hook_get(). There are no outside consumers of this API, it is only safe for internal use and even the pfil(9) man page says so in the BUGS section.

svn commit: r254772 - head/share/man/man9

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 10:38:02 2013 New Revision: 254772 URL: http://svnweb.freebsd.org/changeset/base/254772 Log: pfil_hook_get() has been internalized in r254771 and is no longer part of the API. It wasn't safe for external use in any case. Modified: head/share/man/man9/pfil.9

svn commit: r254773 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 11:17:25 2013 New Revision: 254773 URL: http://svnweb.freebsd.org/changeset/base/254773 Log: Resolve the confusion between the head_list and the hook list. The linked list of pfil hooks is changed to chain and this term is applied consistently. The

svn commit: r254774 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 11:24:15 2013 New Revision: 254774 URL: http://svnweb.freebsd.org/changeset/base/254774 Log: ename PFIL_LIST_[UN]LOCK() to PFIL_HEADLIST_[UN]LOCK() to avoid confusion with the pfil_head chain locking macros. Modified: head/sys/net/pfil.c head/sys/net/pfil.h

svn commit: r254775 - head/share/man/man9

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 11:57:02 2013 New Revision: 254775 URL: http://svnweb.freebsd.org/changeset/base/254775 Log: Adjust for the pfil_func_t typedef added in r254769. Modified: head/share/man/man9/pfil.9 Modified: head/share/man/man9/pfil.9

svn commit: r254777 - head/sys/net

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 12:03:24 2013 New Revision: 254777 URL: http://svnweb.freebsd.org/changeset/base/254777 Log: Whitespace, style cleanups, and improved comments. Modified: head/sys/net/pfil.h Modified: head/sys/net/pfil.h

svn commit: r254779 - head/sys/kern

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 12:24:58 2013 New Revision: 254779 URL: http://svnweb.freebsd.org/changeset/base/254779 Log: Avoid code duplication for mbuf initialization and use m_init() instead in mb_ctor_mbuf() and mb_ctor_pack(). Modified: head/sys/kern/kern_mbuf.c Modified:

svn commit: r254780 - in head/sys: kern sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 13:15:42 2013 New Revision: 254780 URL: http://svnweb.freebsd.org/changeset/base/254780 Log: dd a 24 bits wide ext_flags field to m_ext by reducing ext_type to 8 bits. ext_type is an enumerator and the number of types we have is a mere dozen. A couple of

Re: svn commit: r254780 - in head/sys: kern sys

2013-08-24 Thread Andre Oppermann
On 24.08.2013 15:15, Andre Oppermann wrote: Author: andre Date: Sat Aug 24 13:15:42 2013 New Revision: 254780 URL: http://svnweb.freebsd.org/changeset/base/254780 Log: dd a 24 bits wide ext_flags field to m_ext by reducing ext_type to 8 bits. ext_type is an enumerator and the number

svn commit: r254799 - in head/sys: dev/cas dev/hatm dev/iscsi_initiator dev/lge dev/mwl kern sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 16:57:44 2013 New Revision: 254799 URL: http://svnweb.freebsd.org/changeset/base/254799 Log: Add an mbuf pointer parameter to (*ext_free) to give the external free function access to the mbuf the external memory was attached to. Mechanically adjust all

svn commit: r254800 - in head/sys/dev: cxgb sfxge

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 17:14:14 2013 New Revision: 254800 URL: http://svnweb.freebsd.org/changeset/base/254800 Log: Remove unnecessary setup of the m-pkthdr.header pointer. Sponsored by: The FreeBSD Foundation Modified: head/sys/dev/cxgb/cxgb_sge.c

svn commit: r254803 - in head/sys/dev: jme nfe

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 19:38:36 2013 New Revision: 254803 URL: http://svnweb.freebsd.org/changeset/base/254803 Log: Change local variable tso_segsz to tsosegsz to avoid mbuf.h macro conflicts. Sponsored by: The FreeBSD Foundation Modified: head/sys/dev/jme/if_jme.c

svn commit: r254804 - in head/sys: dev/cxgb dev/e1000 dev/ixgbe dev/patm dev/qlxgb kern net netinet netinet6 sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 19:51:18 2013 New Revision: 254804 URL: http://svnweb.freebsd.org/changeset/base/254804 Log: Restructure the mbuf pkthdr to make it fit for upcoming capabilities and features. The changes in particular are: o Remove rarely used header pointer and replace

svn commit: r254805 - head/sys/sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 19:58:36 2013 New Revision: 254805 URL: http://svnweb.freebsd.org/changeset/base/254805 Log: Add mtodo(m, o) macro taking an additional offset into the mbuf data section. Sponsored by: The FreeBSD Foundation Modified: head/sys/sys/mbuf.h Modified:

svn commit: r254807 - head/sys/sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 20:26:41 2013 New Revision: 254807 URL: http://svnweb.freebsd.org/changeset/base/254807 Log: Compact m_hdr by packing the type and flags fields into one uint32_t. The mbuf type is an enumerator with only a handful of types in use and thus reduced from int

svn commit: r254812 - in head/sys: kern sys

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 21:09:57 2013 New Revision: 254812 URL: http://svnweb.freebsd.org/changeset/base/254812 Log: Remove unused m_free_fast(). The difference to m_free() is only 2 predictable branches nowadays. However as a pre-condition the caller had to ensure that the mbuf

svn commit: r254814 - head/sys/kern

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 21:25:53 2013 New Revision: 254814 URL: http://svnweb.freebsd.org/changeset/base/254814 Log: After r254779 error must always be present in mb_ctor_pack(), not only when MAC is defined. Reported by: gjb / tinderbox Sponsored by: The FreeBSD Foundation

Re: svn commit: r254779 - head/sys/kern

2013-08-24 Thread Andre Oppermann
On 24.08.2013 23:13, Glen Barber wrote: On Sat, Aug 24, 2013 at 12:24:59PM +, Andre Oppermann wrote: Author: andre Date: Sat Aug 24 12:24:58 2013 New Revision: 254779 URL: http://svnweb.freebsd.org/changeset/base/254779 Log: Avoid code duplication for mbuf initialization and use m_init

svn commit: r254815 - head/share/man/man9

2013-08-24 Thread Andre Oppermann
Author: andre Date: Sat Aug 24 21:30:35 2013 New Revision: 254815 URL: http://svnweb.freebsd.org/changeset/base/254815 Log: Fix BUGS section after botched modify in r254772. Reported by: bjk Modified: head/share/man/man9/pfil.9 Modified: head/share/man/man9/pfil.9

Re: svn commit: r254772 - head/share/man/man9

2013-08-24 Thread Andre Oppermann
On 24.08.2013 23:25, Benjamin Kaduk wrote: On Sat, Aug 24, 2013 at 6:38 AM, Andre Oppermann an...@freebsd.org mailto:an...@freebsd.org wrote: Author: andre Date: Sat Aug 24 10:38:02 2013 New Revision: 254772 URL: http://svnweb.freebsd.org/changeset/base/254772 Log

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-21 Thread Andre Oppermann
On 19.08.2013 23:45, Navdeep Parhar wrote: On 08/19/13 13:58, Andre Oppermann wrote: On 19.08.2013 19:33, Navdeep Parhar wrote: On 08/19/13 04:16, Andre Oppermann wrote: Author: andre Date: Mon Aug 19 11:16:53 2013 New Revision: 254520 URL: http://svnweb.freebsd.org/changeset/base/254520 Log

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-21 Thread Andre Oppermann
On 20.08.2013 00:03, Navdeep Parhar wrote: On 08/19/13 14:08, Andre Oppermann wrote: On 19.08.2013 19:40, Peter Grehan wrote: I recently tried some experiments to reduce the number of mbuf and cluster allocations in a 40G NIC driver. M_NOFREE and EXT_EXTREF proved very useful and the code

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 20.08.2013 00:38, Peter Grehan wrote: Hi Andre, (moving to the more appropriate freebsd-net) I'm sorry for ambushing but this stuff has to be done. I have provided an alternative way of handling it and I'm happy to help you with your use case to make it good for you and to prevent the

Re: svn commit: r254519 - in head/sys: netinet netinet6 sys

2013-08-21 Thread Andre Oppermann
On 20.08.2013 05:04, Julian Elischer wrote: On 8/19/13 7:08 PM, Andre Oppermann wrote: Author: andre Date: Mon Aug 19 11:08:36 2013 New Revision: 254519 URL: http://svnweb.freebsd.org/changeset/base/254519 Log: Move the global M_SKIP_FIREWALL mbuf flags to a protocol layer specific flag

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 20.08.2013 05:13, Julian Elischer wrote: On 8/20/13 6:38 AM, Peter Grehan wrote: Hi Andre, (moving to the more appropriate freebsd-net) I'm sorry for ambushing but this stuff has to be done. I have provided an alternative way of handling it and I'm happy to help you with your use case

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-21 Thread Andre Oppermann
On 21.08.2013 17:03, Peter Grehan wrote: The way to go should be 4K clusters as they are native to the architecture. IIRC a PCIe DMA can't cross a 4K boundary anyway That's a 4G boundary, for some devices. I meant a single PCIe DMA transaction can be at most 4K before it has to set up

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Andre Oppermann
On 20.08.2013 20:13, Davide Italiano wrote: On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann an...@freebsd.org wrote: On 19.08.2013 19:37, Navdeep Parhar wrote: Why reuse the freed up bits so soon (at least one of which I think was prematurely GC'ed -- see my other email on M_NOFREE

Re: svn commit: r254524 - head/sys/sys

2013-08-21 Thread Andre Oppermann
On 21.08.2013 17:59, Davide Italiano wrote: On Wed, Aug 21, 2013 at 5:30 PM, Andre Oppermann an...@freebsd.org wrote: On 20.08.2013 20:13, Davide Italiano wrote: On Tue, Aug 20, 2013 at 7:42 PM, Andre Oppermann an...@freebsd.org wrote: On 19.08.2013 19:37, Navdeep Parhar wrote: Why reuse

svn commit: r254605 - in head/sys: kern sys

2013-08-21 Thread Andre Oppermann
Author: andre Date: Wed Aug 21 18:12:04 2013 New Revision: 254605 URL: http://svnweb.freebsd.org/changeset/base/254605 Log: Revert r254520 and resurrect the M_NOFREE mbuf flag and functionality. Requested by: np, grehan Modified: head/sys/kern/kern_mbuf.c head/sys/kern/uipc_mbuf.c

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 21.08.2013 18:38, Navdeep Parhar wrote: On 08/21/13 08:08, Andre Oppermann wrote: On 20.08.2013 00:38, Peter Grehan wrote: snip If there's an alternative to M_NOFREE, I'd be more than happy to use that. Set up your own (*ext_free) function and omit freeing of the mbuf itself. Make

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 21.08.2013 20:23, Navdeep Parhar wrote: I believe we need an extra patch to get M_NOFREE correct. I've had it forever in some of my internal repos but never committed it upstream (just plain forgot). Since this stuff is fresh in your mind, can you review this: diff -r cd78031b7885

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-21 Thread Andre Oppermann
On 21.08.2013 21:59, Navdeep Parhar wrote: On 08/21/13 12:41, Scott Long wrote: On Aug 21, 2013, at 8:59 AM, Andre Oppermann an...@freebsd.org wrote: On 19.08.2013 23:45, Navdeep Parhar wrote: On 08/19/13 13:58, Andre Oppermann wrote: On 19.08.2013 19:33, Navdeep Parhar wrote: On 08/19/13

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 21.08.2013 21:40, Navdeep Parhar wrote: On 08/21/13 12:22, Andre Oppermann wrote: On 21.08.2013 20:23, Navdeep Parhar wrote: I believe we need an extra patch to get M_NOFREE correct. I've had it forever in some of my internal repos but never committed it upstream (just plain forgot

Re: M_NOFREE removal (was Re: svn commit: r254520 - in head/sys: kern sys)

2013-08-21 Thread Andre Oppermann
On 21.08.2013 22:52, Navdeep Parhar wrote: On 08/21/13 13:44, Andre Oppermann wrote: On 21.08.2013 21:40, Navdeep Parhar wrote: On 08/21/13 12:22, Andre Oppermann wrote: On 21.08.2013 20:23, Navdeep Parhar wrote: I believe we need an extra patch to get M_NOFREE correct. I've had it forever

Re: svn commit: r254524 - head/sys/sys

2013-08-20 Thread Andre Oppermann
On 19.08.2013 19:37, Navdeep Parhar wrote: On 08/19/13 06:56, Andre Oppermann wrote: Author: andre Date: Mon Aug 19 13:56:14 2013 New Revision: 254524 URL: http://svnweb.freebsd.org/changeset/base/254524 Log: Add four additional M_PROTOFLAGS[9-12] for protocol specific use. Discussed

svn commit: r254516 - in head/sys/dev: bce bxe mge ti

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:20:20 2013 New Revision: 254516 URL: http://svnweb.freebsd.org/changeset/base/254516 Log: Remove unused and incomplete support for delayed fragment checksums from bce(4), bxe(4), mge(4) and ti(4) drivers. Modified: head/sys/dev/bce/if_bce.c

svn commit: r254517 - head/sys/netinet

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:30:15 2013 New Revision: 254517 URL: http://svnweb.freebsd.org/changeset/base/254517 Log: Remove unused M_FRAG, M_FIRSTFRAG and M_LASTFRAG tagging from ip_fragment(). There wasn't any real driver (and hardware) support for it. Modern hardware does full

svn commit: r254518 - head/sys/netinet

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:34:10 2013 New Revision: 254518 URL: http://svnweb.freebsd.org/changeset/base/254518 Log: Move ip_reassemble()'s use of the global M_FRAG mbuf flag to a protocol layer specific flag instead. The flag is only relevant while the packet stays in the IP

svn commit: r254519 - in head/sys: netinet netinet6 sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 11:08:36 2013 New Revision: 254519 URL: http://svnweb.freebsd.org/changeset/base/254519 Log: Move the global M_SKIP_FIREWALL mbuf flags to a protocol layer specific flag instead. The flag is only used within the IP and IPv6 layer 3 protocols. Because

svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 11:16:53 2013 New Revision: 254520 URL: http://svnweb.freebsd.org/changeset/base/254520 Log: Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users for a very long time, if ever. Should such a functionality ever be needed again the

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
On 19.08.2013 13:23, Davide Italiano wrote: On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann an...@freebsd.org wrote: Modified: head/sys/sys/mbuf.h == --- head/sys/sys/mbuf.h Mon Aug 19 11:08:36 2013(r254519

svn commit: r254521 - in head/sys: netinet sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 12:30:18 2013 New Revision: 254521 URL: http://svnweb.freebsd.org/changeset/base/254521 Log: Move the SCTP specific definition of M_NOTIFICATION onto a protocol specific mbuf flag from sys/mbuf.h to netinet/sctp_os_bsd.h. It is only relevant within SCTP.

svn commit: r254523 - in head/sys: net net80211 netinet netinet6 netpfil/pf ofed/drivers/infiniband/ulp/ipoib sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 13:27:32 2013 New Revision: 254523 URL: http://svnweb.freebsd.org/changeset/base/254523 Log: Add m_clrprotoflags() to clear protocol specific mbuf flags at up and downwards layer crossings. Consistently use it within IP, IPv6 and ethernet protocols.

svn commit: r254524 - head/sys/sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 13:56:14 2013 New Revision: 254524 URL: http://svnweb.freebsd.org/changeset/base/254524 Log: Add four additional M_PROTOFLAGS[9-12] for protocol specific use. Discussed with: trociny, glebius, adrian Modified: head/sys/sys/mbuf.h Modified:

svn commit: r254526 - in head/sys: net80211 sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 14:07:31 2013 New Revision: 254526 URL: http://svnweb.freebsd.org/changeset/base/254526 Log: Migrate the net80211 protocol specific use of M_FRAG, M_FIRSTFRAG and M_LASTFRAG flags to protocol specific flags. Remove the now unused M_FRAG, M_FIRSTFRAG and

svn commit: r254527 - in head/sys: net80211 netinet sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 14:25:11 2013 New Revision: 254527 URL: http://svnweb.freebsd.org/changeset/base/254527 Log: Reorder the mbuf defines to make more sense and group related flags together. Add M_FLAG_PRINTF for use with printf(9) %b indentifier. Use the generic mbuf

svn commit: r254537 - head/sys/sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 16:47:06 2013 New Revision: 254537 URL: http://svnweb.freebsd.org/changeset/base/254537 Log: Bump __FreeBSD_version to 146 after the addition of M_PROTO[9-12] and removal of M_NOFREE|M_FRAG|M_FIRSTFRAG|M_LASTFRAG mbuf flags. Modified: head/sys/sys/param.h

Re: svn commit: r254527 - in head/sys: net80211 netinet sys

2013-08-19 Thread Andre Oppermann
On 19.08.2013 17:12, Adrian Chadd wrote: Hi, Would you please bump FreeBSD_version ? Done: New Revision: 254537 URL: http://svnweb.freebsd.org/changeset/base/254537 Log: Bump __FreeBSD_version to 146 after the addition of M_PROTO[9-12] and removal of

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
On 19.08.2013 19:33, Navdeep Parhar wrote: On 08/19/13 04:16, Andre Oppermann wrote: Author: andre Date: Mon Aug 19 11:16:53 2013 New Revision: 254520 URL: http://svnweb.freebsd.org/changeset/base/254520 Log: Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
On 19.08.2013 19:40, Peter Grehan wrote: I recently tried some experiments to reduce the number of mbuf and cluster allocations in a 40G NIC driver. M_NOFREE and EXT_EXTREF proved very useful and the code changes to the kernel were minimal. See user/np/cxl_tuning. The experiment was quite

svn commit: r253395 - head/sys/netinet

2013-07-16 Thread Andre Oppermann
Author: andre Date: Tue Jul 16 16:37:08 2013 New Revision: 253395 URL: http://svnweb.freebsd.org/changeset/base/253395 Log: Free the non-fatal timestamp missing debug string manually as it is not covered by the catch-all free for the error cases. Found by: Coverity Modified:

Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-15 Thread Andre Oppermann
On 15.07.2013 20:38, Mikolaj Golub wrote: On Mon, Jul 15, 2013 at 11:36:16AM +0200, Ulrich Spörlein wrote: Hey Andre, I don't see why this commit triggers it, but Coverity Scan found a new resource leak in this file. syncache_expand() will leak *s when line 1071 is reached. The failed: case

svn commit: r253254 - head/sys/netinet

2013-07-12 Thread Andre Oppermann
Author: andre Date: Fri Jul 12 07:43:56 2013 New Revision: 253254 URL: http://svnweb.freebsd.org/changeset/base/253254 Log: Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache. Reported by: trociny, rodrigc Modified: head/sys/netinet/tcp_syncache.h Modified:

Re: svn commit: r253254 - head/sys/netinet

2013-07-12 Thread Andre Oppermann
On 12.07.2013 09:43, Andre Oppermann wrote: Author: andre Date: Fri Jul 12 07:43:56 2013 New Revision: 253254 URL: http://svnweb.freebsd.org/changeset/base/253254 Log: Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache. Reported by: trociny, rodrigc Sorry

svn commit: r253204 - head/sys/kern

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 12:46:35 2013 New Revision: 253204 URL: http://svnweb.freebsd.org/changeset/base/253204 Log: Fix style issues, a typo in kern.ipc.nmbufs and correctly plave and expose the value of the tunable maxmbufmem as kern.ipc.maxmbufmem through sysctl. Reported by:

svn commit: r253207 - head/sys/kern

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 12:53:13 2013 New Revision: 253207 URL: http://svnweb.freebsd.org/changeset/base/253207 Log: Make use of the fact that uma_zone_set_max(9) already returns the rounded limit making a call to uma_zone_get_max(9) unnecessary. MFC after:1 day Modified:

svn commit: r253208 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
1970 (empty, because file is newly added) +++ head/sys/crypto/siphash/siphash.c Thu Jul 11 14:18:38 2013 (r253208) @@ -0,0 +1,241 @@ +/*- + * Copyright (c) 2013 Andre Oppermann an...@freebsd.org + * All rights reserved. + * + * Redistribution and use in source and binary forms

svn commit: r253210 - in head/sys: conf netinet

2013-07-11 Thread Andre Oppermann
. - * Copyright (c) 2006 Andre Oppermann, Internet Business Solutions AG + * Copyright (c) 2006,2013 Andre Oppermann, Internet Business Solutions AG * All rights reserved. * * This software was developed for the FreeBSD Project by Jonathan Lemon * and McAfee Research, the Security Research Division

Re: svn commit: r253208 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
On 11.07.2013 16:18, Andre Oppermann wrote: Author: andre Date: Thu Jul 11 14:18:38 2013 New Revision: 253208 URL: http://svnweb.freebsd.org/changeset/base/253208 Log: SipHash is a cryptographically strong pseudo-random function (a.k.a. keyed hash function) optimized for speed on short

svn commit: r253214 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 16:27:11 2013 New Revision: 253214 URL: http://svnweb.freebsd.org/changeset/base/253214 Log: Fix const propagation issues to make GCC happy. Submitted by: Michael Butler i...@protected-networks.net Modified: head/sys/crypto/siphash/siphash.c Modified:

svn commit: r253150 - head/sys/netinet

2013-07-10 Thread Andre Oppermann
Author: andre Date: Wed Jul 10 12:06:01 2013 New Revision: 253150 URL: http://svnweb.freebsd.org/changeset/base/253150 Log: Extend debug logging of TCP timestamp related specification violations. Update related comments and style. Modified: head/sys/netinet/tcp_input.c

Re: svn commit: r253081 - in head: sys/net sys/netinet sys/netinet6 sys/netipsec tools/tools/crypto usr.bin/netstat

2013-07-09 Thread Andre Oppermann
On 09.07.2013 11:32, Andrey V. Elsukov wrote: Author: ae Date: Tue Jul 9 09:32:06 2013 New Revision: 253081 URL: http://svnweb.freebsd.org/changeset/base/253081 Log: Prepare network statistics structures for migration to PCPU counters. Use uint64_t as type for all fields of structures.

Re: svn commit: r252209 - in head: share/man/man9 sys/kern sys/sys

2013-06-26 Thread Andre Oppermann
On 25.06.2013 20:44, John Baldwin wrote: Author: jhb Date: Tue Jun 25 18:44:15 2013 New Revision: 252209 URL: http://svnweb.freebsd.org/changeset/base/252209 Log: Several improvements to rmlock(9). Many of these are based on patches provided by Isilon. - Add an rm_assert() supporting

Re: svn commit: r251894 - in head: lib/libmemstat sys/vm

2013-06-18 Thread Andre Oppermann
On 18.06.2013 06:50, Jeff Roberson wrote: Author: jeff Date: Tue Jun 18 04:50:20 2013 New Revision: 251894 URL: http://svnweb.freebsd.org/changeset/base/251894 Log: Refine UMA bucket allocation to reduce space consumption and improve performance. - Always free to the alloc bucket if

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-18 Thread Andre Oppermann
On 18.06.2013 18:40, Tijl Coosemans wrote: On 2013-06-18 04:53, Peter Wemm wrote: Author: peter Date: Tue Jun 18 02:53:45 2013 New Revision: 251886 URL: http://svnweb.freebsd.org/changeset/base/251886 Log: Introduce svnlite so that we can check out our source code again. This is

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-18 Thread Andre Oppermann
On 18.06.2013 19:04, Alexey Dokuchaev wrote: Being able to checkout the sources is very desirable, but not at the cost of importing another heavy 3rd-party tool, which Subversion is. Just wanted to note that applaud Peter for actually doing something (tm) even though it came as a surprise to

svn commit: r251296 - in head/sys: net netinet

2013-06-03 Thread Andre Oppermann
Author: andre Date: Mon Jun 3 12:55:13 2013 New Revision: 251296 URL: http://svnweb.freebsd.org/changeset/base/251296 Log: Allow drivers to specify a maximum TSO length in bytes if they are limited in the amount of data they can handle at once. Drivers can set ifp-if_hw_tsomax before

svn commit: r251297 - head/sys/dev/xen/netfront

2013-06-03 Thread Andre Oppermann
Author: andre Date: Mon Jun 3 13:00:33 2013 New Revision: 251297 URL: http://svnweb.freebsd.org/changeset/base/251297 Log: Specify a maximum TSO length limiting the segment chain to what the Xen host side can handle after defragmentation. This prevents the driver from throwing away too

Re: svn commit: r250658 - in head: share/mk sys/conf tools/build/options

2013-05-17 Thread Andre Oppermann
On 15.05.2013 15:04, Brooks Davis wrote: Author: brooks Date: Wed May 15 13:04:10 2013 New Revision: 250658 URL: http://svnweb.freebsd.org/changeset/base/250658 Log: Add a new option WITHOUT_FORMAT_EXTENSIONS to disable flags related to checking our kernel printf extensions. This is

svn commit: r250365 - head/sys/kern

2013-05-08 Thread Andre Oppermann
Author: andre Date: Wed May 8 14:13:14 2013 New Revision: 250365 URL: http://svnweb.freebsd.org/changeset/base/250365 Log: When the accept queue is full print the number of already pending new connections instead of by how many we're over the limit, which is always 1. Noticed by:

svn commit: r250300 - in head/sys: kern net netinet sys

2013-05-06 Thread Andre Oppermann
Author: andre Date: Mon May 6 16:42:18 2013 New Revision: 250300 URL: http://svnweb.freebsd.org/changeset/base/250300 Log: Back out r249318, r249320 and r249327 due to a heisenbug most likely related to a race condition in the ipi_hash_lock with the exact cause currently unknown but under

svn commit: r249843 - head/sys/kern

2013-04-24 Thread Andre Oppermann
Author: andre Date: Wed Apr 24 13:54:55 2013 New Revision: 249843 URL: http://svnweb.freebsd.org/changeset/base/249843 Log: Base the calculation of maxmbufmem in part on kmem_map size instead of kernel_map size to prevent kernel memory exhaustion by mbufs and a subsequent panic on physical

svn commit: r249317 - head/sys/netinet

2013-04-09 Thread Andre Oppermann
Author: andre Date: Tue Apr 9 20:52:26 2013 New Revision: 249317 URL: http://svnweb.freebsd.org/changeset/base/249317 Log: Fix a race condition on tcp listen socket teardown with pending connections in the accept queue and contiguous new incoming SYNs. Compared to the original

svn commit: r249318 - in head/sys: kern net netinet

2013-04-09 Thread Andre Oppermann
Author: andre Date: Tue Apr 9 21:02:20 2013 New Revision: 249318 URL: http://svnweb.freebsd.org/changeset/base/249318 Log: Change certain heavily used network related mutexes and rwlocks to reside on their own cache line to prevent false sharing with other nearby structures, especially for

Re: svn commit: r248417 - head/sys/sys

2013-03-17 Thread Andre Oppermann
On 17.03.2013 10:33, Gleb Smirnoff wrote: On Sun, Mar 17, 2013 at 10:02:09AM +0100, Andre Oppermann wrote: A On 17.03.2013 08:39, Gleb Smirnoff wrote: A Author: glebius A Date: Sun Mar 17 07:39:45 2013 A New Revision: 248417 A URL: http://svnweb.freebsd.org/changeset/base/248417 A A Log

Re: svn commit: r248323 - head/sys/netinet

2013-03-15 Thread Andre Oppermann
On 15.03.2013 13:53, Gleb Smirnoff wrote: Author: glebius Date: Fri Mar 15 12:53:53 2013 New Revision: 248323 URL: http://svnweb.freebsd.org/changeset/base/248323 Log: - Use m_getcl() instead of hand allocating. Sponsored by:Nginx, Inc. Modified: head/sys/netinet/tcp_output.c

  1   2   3   >