Re: svn commit: r354076 - head/sys/dev/ow

2019-10-26 Thread Bruce Evans
On Fri, 25 Oct 2019, Andriy Gapon wrote: On 25/10/2019 18:46, Ian Lepore wrote: On Fri, 2019-10-25 at 15:38 +, Andriy Gapon wrote: Author: avg Date: Fri Oct 25 15:38:09 2019 New Revision: 354076 URL: https://svnweb.freebsd.org/changeset/base/354076 Log: owc_gpiobus_read_data: compare

Re: svn commit: r353640 - head/sys/kern

2019-10-23 Thread Bruce Evans
On Tue, 22 Oct 2019, Alan Somers wrote: On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: Author: andrew Date: Wed Oct 16 13:21:01 2019 New Revision: 353640 URL: https://svnweb.freebsd.org/changeset/base/353640 Log: Stop leaking information from the kernel through timespec The

Re: svn commit: r353103 - head/sys/net

2019-10-04 Thread Bruce Evans
On Fri, 4 Oct 2019, John Baldwin wrote: On 10/4/19 6:43 AM, Kyle Evans wrote: Author: kevans Date: Fri Oct 4 13:43:07 2019 New Revision: 353103 URL: https://svnweb.freebsd.org/changeset/base/353103 Log: tuntap(4): loosen up tunclose restrictions Realistically, this cannot work. We don't

Re: svn commit: r352795 - head/lib/libc/sys

2019-10-02 Thread Bruce Evans
On Tue, 1 Oct 2019, Ed Maste wrote: On Tue, 1 Oct 2019 at 12:23, Brooks Davis wrote: This isn't true with CHERI and as a result I've moved the variadic argument handling (except for syscall() and __syscall()) into libc. My grep found: open, openat, fcntl, semsys, msgsys, shmsys Is that the

Re: svn commit: r352846 - head/lib/libc/sys

2019-09-29 Thread Bruce Evans
On Sun, 29 Sep 2019, Konstantin Belousov wrote: On Sat, Sep 28, 2019 at 05:15:48PM +, Warner Losh wrote: Author: imp Date: Sat Sep 28 17:15:48 2019 New Revision: 352846 URL: https://svnweb.freebsd.org/changeset/base/352846 Log: Revert the mode_t -> int changes and add a warning in the

Re: svn commit: r352795 - head/lib/libc/sys

2019-09-27 Thread Bruce Evans
On Fri, 27 Sep 2019, Konstantin Belousov wrote: On Fri, Sep 27, 2019 at 08:32:20PM +0200, Mateusz Guzik wrote: On 9/27/19, Warner Losh wrote: Author: imp Date: Fri Sep 27 16:11:47 2019 New Revision: 352795 URL: https://svnweb.freebsd.org/changeset/base/352795 Log: Document varadic args as

Re: svn commit: r351700 - head/lib/libc/string

2019-09-25 Thread Bruce Evans
On Wed, 25 Sep 2019, Ed Maste wrote: On Fri, 20 Sep 2019 at 08:14, Bruce Evans wrote: Optimizing this function [memchr] is especially unimportant, Why? Because it is almost never used, and most of its uses are unimportant. It is used a whole 26 times in all of /usr/src/*bin: - sh/exec.c

Re: svn commit: r352661 - head/sys/netinet/tcp_stacks

2019-09-24 Thread Bruce Evans
On Tue, 24 Sep 2019, Randall Stewart wrote: Log: lets put (void) in a couple of functions to keep older platforms that are stuck with gcc happy (ppc). The changes are needed in both bbr and rack. You mean "Don't use K declarations. clang is too broken to warn about K declarations even

Re: svn commit: r351700 - head/lib/libc/string

2019-09-20 Thread Bruce Evans
On Mon, 2 Sep 2019, Ed Maste wrote: Author: emaste Date: Mon Sep 2 13:56:44 2019 New Revision: 351700 URL: https://svnweb.freebsd.org/changeset/base/351700 Log: libc: Use musl's optimized memchr Parentheses added to HASZERO macro to avoid a GCC warning. Reviewed by: kib, mjg Obtained

Re: svn commit: r351659 - in head: contrib/libc++/include contrib/netbsd-tests/lib/libc/ssp gnu/lib/libssp include lib/libc/stdio

2019-09-13 Thread Bruce Evans
On Sun, 1 Sep 2019, Cy Schubert wrote: I'm replying to this reply since I lost the original mail. In message <201909011612.x81gc5dw097...@repo.freebsd.org>, Ed Maste writes: Author: emaste Date: Sun Sep 1 16:12:05 2019 New Revision: 351659 URL:

svn commit: r346631 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals

svn commit: r346639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346580 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the

svn commit: r346641 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

Re: svn commit: r346554 - head/sys/netinet

2019-09-03 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which

svn commit: r346486 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c

svn commit: r346454 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

svn commit: r346488 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much

svn commit: r346416 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first

svn commit: r346279 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c

svn commit: r346280 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran

svn commit: r346278 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

svn commit: r346276 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Tue Apr 16 14:28:33 2019 New Revision: 346276 URL: https://svnweb.freebsd.org/changeset/base/346276 Log: Fix a variable name in r346215. Clearing of the right of the screen was broken, except it worked accidentally in most cases where the virtual screen is larger than the

svn commit: r346215 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Sun Apr 14 13:37:50 2019 New Revision: 346215 URL: https://svnweb.freebsd.org/changeset/base/346215 Log: For writing and reading single pixels, avoid some pessimizations for depths > 8. Add some smaller optimizations for these depths. Use a more generic method for all

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Bruce Evans wrote: On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previ

Re: svn commit: r346176 - head/sys/sys

2019-09-03 Thread Bruce Evans
On Sat, 13 Apr 2019, Warner Losh wrote: Fix sbttons for values > 2s Add test against negative times. Add code to cope with larger values properly. Discussed with: bde@ (quite some time ago, for an earlier version) I am unhappy with previous attempted fixes in this area, and still have

svn commit: r346025 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:54:15 2019 New Revision: 346025 URL: https://svnweb.freebsd.org/changeset/base/346025 Log: Fix copying of MEMBUFs to MEMBUFs. This case was implemented by using the same code as the VIDBUF8 case, so it only worked for depths <= 8. The 2 directions for

svn commit: r346024 - head/usr.sbin/vidcontrol

2019-09-03 Thread Bruce Evans
Author: bde Date: Mon Apr 8 04:07:37 2019 New Revision: 346024 URL: https://svnweb.freebsd.org/changeset/base/346024 Log: Fix restoring the geometry when recovering from an error. Just restore the previous geometry, and don't do extra work to calculate the default geometry so as to reset

Re: svn commit: r345900 - head/sbin/fsck_msdosfs

2019-09-03 Thread Bruce Evans
On Fri, 5 Apr 2019, Ed Maste wrote: On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: +static const u_char dot_name[] = { + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; +static const u_char dotdot_name[] = { + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; + Does it make

Re: svn commit: r345853 - head/usr.bin/rctl

2019-09-03 Thread Bruce Evans
On Wed, 3 Apr 2019, Enji Cooper wrote: On Apr 3, 2019, at 1:37 PM, Mateusz Guzik wrote: Author: mjg Date: Wed Apr 3 20:37:14 2019 New Revision: 345853 URL: https://svnweb.freebsd.org/changeset/base/345853 Log: rctl: fix sysctl kern.racct.enable use after r341182 The value was changed

Re: svn commit: r345807 - head/usr.bin/top

2019-09-03 Thread Bruce Evans
On Tue, 2 Apr 2019, Dimitry Andric wrote: Author: dim Date: Tue Apr 2 18:01:54 2019 New Revision: 345807 URL: https://svnweb.freebsd.org/changeset/base/345807 Log: Fix regression in top(1) after r344381, causing informational messages to no longer be displayed. This was because the

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Sun, Mar 31, 2019 at 10:27:54PM +1100, Bruce Evans wrote: On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sun, 31 Mar 2019, Konstantin Belousov wrote: On Mon, Apr 01, 2019 at 12:04:45AM +1100, Bruce Evans wrote: Serial consoles are not always available. Better debuggers switch the screen mode as necessary. I recently noticed another mode switching problem. On i386, cycling through about 50

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Sat, 30 Mar 2019, Konstantin Belousov wrote: On Sat, Mar 30, 2019 at 03:24:40PM +1100, Bruce Evans wrote: On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL

svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV. r80270 has the usual wrong fix for unsafe signal handling -- just set a flag and return to let an event loop check

svn commit: r345698 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 16:30:19 2019 New Revision: 345698 URL: https://svnweb.freebsd.org/changeset/base/345698 Log: Fix restoring to graphics modes in VGLEnd(). Correct restoring was only attempted for mode 258 (800x600x4 P). (This was the only useful graphics mode supported in

Re: svn commit: r345696 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Konstantin Belousov wrote: On Fri, Mar 29, 2019 at 03:57:09PM +, Bruce Evans wrote: Author: bde Date: Fri Mar 29 15:57:08 2019 New Revision: 345696 URL: https://svnweb.freebsd.org/changeset/base/345696 Log: Fix endless loops for handling SIGBUS and SIGSEGV

svn commit: r345695 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Fri Mar 29 15:20:48 2019 New Revision: 345695 URL: https://svnweb.freebsd.org/changeset/base/345695 Log: Fix races in mouse signal handling almost properly using the INTOFF/INTON method as in /bin/sh. We still do technically undefined things in the signal handler, but

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Fri, 29 Mar 2019, Alexey Dokuchaev wrote: On Fri, Mar 29, 2019 at 05:40:05PM +1100, Bruce Evans wrote: ... -optionsBOOT_TAG=\"---<>---\" +optionsBOOT_TAG=\"\" Useful variations are not always easy to invent. I usually just add 1 for numeric value

Re: svn commit: r345680 - head/sys/conf

2019-09-03 Thread Bruce Evans
On Thu, 28 Mar 2019, Ravi Pokala wrote: -Original Message- From: on behalf of Kyle Evans Date: 2019-03-28, Thursday at 21:00 To: , , Subject: svn commit: r345680 - head/sys/conf Author: kevans Date: Fri Mar 29 04:00:46 2019 New Revision: 345680 URL:

svn commit: r345639 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 12:28:29 2019 New Revision: 345639 URL: https://svnweb.freebsd.org/changeset/base/345639 Log: Fix VGLGetXY(), VGLSetXY() and VGLClear() for MEMBUFs in depths > 8. This depends on PixelBytes being properly initialized, which it is for all bitmaps constructed

svn commit: r345643 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 14:21:22 2019 New Revision: 345643 URL: https://svnweb.freebsd.org/changeset/base/345643 Log: Fix VGLLine() in depths > 8. It started truncating its color arg to 8 bits using plot() in r229415. The version in r229415 is also more than 3 times slower in

svn commit: r345637 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Thu Mar 28 09:51:37 2019 New Revision: 345637 URL: https://svnweb.freebsd.org/changeset/base/345637 Log: Oops, r345496 got the pointer args backwards for bcopy() in VGLClear for segmented modes. Also fix some style bugs in the 2 changed lines. libvgl uses a very

svn commit: r345585 - head/lib/libvgl

2019-09-03 Thread Bruce Evans
Author: bde Date: Wed Mar 27 18:03:34 2019 New Revision: 345585 URL: https://svnweb.freebsd.org/changeset/base/345585 Log: Fix accessing pixels under the mouse cursor: Reading of single pixels didn't look under the cursor. Copying of 1x1 bitmaps didn't look under the cursor for either

Re: svn commit: r351319 - in head/usr.sbin/makefs: ffs msdos

2019-08-29 Thread Bruce Evans
On Wed, 21 Aug 2019, Ed Maste wrote: Author: emaste Date: Wed Aug 21 01:45:29 2019 New Revision: 351319 URL: https://svnweb.freebsd.org/changeset/base/351319 Log: makefs: use `char *` not `void *` for buf b_data, drop casts in msdos (The kernel uses caddr_t.) This is much better than

Re: svn commit: r350713 - head/sys/kern

2019-08-08 Thread Bruce Evans
On Thu, 8 Aug 2019, Conrad Meyer wrote: Log: ddb(4): Add 'sysctl' command Implement `sysctl` in `ddb` by overriding `SYSCTL_OUT`. When handling the req, we install custom ddb in/out handlers. The out handler prints straight to the debugger, while the in handler ignores all input. This

Re: svn commit: r350532 - head/sys/netinet6

2019-08-02 Thread Bruce Evans
On Fri, 2 Aug 2019, Bjoern A. Zeeb wrote: Log: frag6.c: sort includes Sort includes and remove duplicate kernel.h as well as the unneeded systm.h. sys/systm.h is always needed, since it defines macros and functions which might be needed in other headers. frag6.c even uses KASSERT()

Re: svn commit: r350179 - head/lib/libutil

2019-07-20 Thread Bruce Evans
On Sat, 20 Jul 2019, John Baldwin wrote: Log: expand_number(3) parses suffixes, not prefixes. This is not quite correct, although conflating prefixes and suffixes is one of the bugs that I pointed out in mails about [de]humanize_number and expand_number() long ago. Bugs in expand_number()

Re: svn commit: r349391 - head/sys/kern

2019-07-17 Thread Bruce Evans
On Tue, 16 Jul 2019, Alan Somers wrote: On Tue, Jul 16, 2019 at 3:48 AM Bruce Evans wrote: On Mon, 15 Jul 2019, John Baldwin wrote: ... I'm not sure which variants are most readable: ... C) if (fp->f_seqcount + howmany(resid, 16384) < fp->f_seqcount) fp-&g

Re: svn commit: r349391 - head/sys/kern

2019-07-16 Thread Bruce Evans
On Mon, 15 Jul 2019, John Baldwin wrote: On 7/14/19 12:08 PM, Conrad Meyer wrote: This change restores the possible overflow beyond IO_SEQMAX that the removed conditional prevented. On Tue, Jun 25, 2019 at 12:44 PM Alan Somers wrote: I thought the same for a while on Tue, Jan 25, then

Re: svn commit: r349989 - head/sys/kern

2019-07-15 Thread Bruce Evans
On Sun, 14 Jul 2019, Michael Tuexen wrote: Log: Improve the input validation for l_linger. When using the SOL_SOCKET level socket option SO_LINGER, the structure struct linger is used as the option value. The component l_linger is of type int, but internally copied to the field so_linger of

Re: svn commit: r349896 - head/contrib/telnet/telnet

2019-07-11 Thread Bruce Evans
On Thu, 11 Jul 2019, Enji Cooper wrote: On Jul 10, 2019, at 3:36 PM, Philip Paeps wrote: Author: philip Date: Wed Jul 10 22:36:14 2019 New Revision: 349896 URL: https://svnweb.freebsd.org/changeset/base/349896 Log: telnet: fix minor style violation While here also fix a very unlikely NULL

Re: svn commit: r349890 - head/contrib/telnet/telnet

2019-07-11 Thread Bruce Evans
On Thu, 11 Jul 2019, Alexey Dokuchaev wrote: On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: New Revision: 349890 URL: https://svnweb.freebsd.org/changeset/base/349890 Log: telnet: fix a couple of snprintf() buffer overflows I see few fixes in this fix. I see even more

Re: svn commit: r349791 - head/sys/vm

2019-07-09 Thread Bruce Evans
On Mon, 8 Jul 2019, Scott Long wrote: This isn???t the first time I???ve witnessed your passion on this topic. It would help immensely if there was some documentation, maybe in /sys/sys/param.h, or maybe even in a manual page, on what a ???click??? is, what a ???db??? is, why they???re

Re: svn commit: r349791 - head/sys/vm

2019-07-06 Thread Bruce Evans
On Sat, 6 Jul 2019, Doug Moore wrote: Log: Fix style(9) violations involving division by PAGE_SIZE. It is style violation to even use an explicit division by PAGE_SIZE instead of the btoc() conversion macro (*). Modified: head/sys/vm/swap_pager.c

Re: svn commit: r349503 - head/contrib/ipfilter/man

2019-06-28 Thread Bruce Evans
On Fri, 28 Jun 2019, Cy Schubert wrote: Log: Document the -B, binary logfile, and the -C config file options. Reference the ipmon.5 man page and ipmon.conf. PR:238816 MFC after: 1 week Modified: head/contrib/ipfilter/man/ipmon.8 Modified:

Re: svn commit: r349459 - head/sys/sys

2019-06-28 Thread Bruce Evans
On Thu, 27 Jun 2019, Andriy Gapon wrote: On 27/06/2019 20:37, Bruce Evans wrote: On Thu, 27 Jun 2019, Andriy Gapon wrote: On 27/06/2019 18:47, Bruce Evans wrote: On Thu, 27 Jun 2019, Andriy Gapon wrote: Log: ??upgrade the warning printf-s in bus accessors to KASSERT-s ??After this change

Re: svn commit: r349459 - head/sys/sys

2019-06-27 Thread Bruce Evans
On Thu, 27 Jun 2019, Andriy Gapon wrote: On 27/06/2019 18:47, Bruce Evans wrote: On Thu, 27 Jun 2019, Andriy Gapon wrote: Log: ??upgrade the warning printf-s in bus accessors to KASSERT-s ??After this change sys/bus.h includes sys/systm.h. This is further namespace pollution.?? sys

Re: svn commit: r349459 - head/sys/sys

2019-06-27 Thread Bruce Evans
On Thu, 27 Jun 2019, Andriy Gapon wrote: Log: upgrade the warning printf-s in bus accessors to KASSERT-s After this change sys/bus.h includes sys/systm.h. This is further namespace pollution. sys/systm.h is a prerequiste for all kernel headers except sys/param.h and the headers that that

Re: svn commit: r349248 - in head/sys: fs/fifofs kern sys

2019-06-21 Thread Bruce Evans
On Thu, 20 Jun 2019, Alan Somers wrote: Log: fcntl: fix overflow when setting F_READAHEAD VOP_READ and VOP_WRITE take the seqcount in blocks in a 16-bit field. However, fcntl allows you to set the seqcount in bytes to any nonnegative 31-bit value. The result can be a 16-bit overflow, which

Re: svn commit: r349233 - head/sys/sys

2019-06-21 Thread Bruce Evans
On Thu, 20 Jun 2019, Warner Losh wrote: On Thu, Jun 20, 2019, 11:44 AM Bruce Evans wrote: On Thu, 20 Jun 2019, Alan Somers wrote: On Thu, Jun 20, 2019 at 10:43 AM Bruce Evans wrote: Summary: and the headers that it includes should declare minimal types to compile (so __int64_t

Re: svn commit: r349233 - head/sys/sys

2019-06-20 Thread Bruce Evans
On Thu, 20 Jun 2019, Alan Somers wrote: On Thu, Jun 20, 2019 at 10:43 AM Bruce Evans wrote: Summary: and the headers that it includes should declare minimal types to compile (so __int64_t is enough). Most uses of this header require including domain-specific headers which declare

Re: svn commit: r349233 - head/sys/sys

2019-06-20 Thread Bruce Evans
On Thu, 20 Jun 2019, Alan Somers wrote: On Thu, Jun 20, 2019 at 9:14 AM Ian Lepore wrote: On Thu, 2019-06-20 at 14:35 +, Alan Somers wrote: Author: asomers Date: Thu Jun 20 14:35:28 2019 New Revision: 349233 URL: https://svnweb.freebsd.org/changeset/base/349233 Log: #include from

Re: svn commit: r349029 - head/sys/kern

2019-06-14 Thread Bruce Evans
On Fri, 14 Jun 2019, Alexander Motin wrote: On 14.06.2019 08:58, Bruce Evans wrote: On Fri, 14 Jun 2019, Alexander Motin wrote: Log: ??Update td_runtime of running thread on each statclock(). ??Normally td_runtime is updated on context switch, but there are some kernel ??threads that due

Re: svn commit: r349029 - head/sys/kern

2019-06-14 Thread Bruce Evans
On Fri, 14 Jun 2019, Alexander Motin wrote: Log: Update td_runtime of running thread on each statclock(). Normally td_runtime is updated on context switch, but there are some kernel threads that due to high absolute priority may run for many seconds without context switches (yes, that is

Re: svn commit: r348847 - head/sys/sys

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Ian Lepore wrote: On Mon, 2019-06-10 at 07:49 -0600, Warner Losh wrote: On Mon, Jun 10, 2019, 7:44 AM Conrad Meyer wrote: On Mon, Jun 10, 2019 at 2:10 AM T??l Coosemans wrote: On Mon, 10 Jun 2019 05:28:04 + (UTC) Dmitry Chagin wrote: ... URL:

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Shawn Webb wrote: On Mon, Jun 10, 2019 at 03:07:11AM +, Doug Moore wrote: ... Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then,

Re: svn commit: r348843 - head/sys/vm

2019-06-10 Thread Bruce Evans
On Mon, 10 Jun 2019, Doug Moore wrote: Log: There are times when a len==0 parameter to mmap is okay. But on a 32-bit machine, a len parameter just a few bytes short of 4G, rounded up to a page boundary and hitting zero then, is not okay. Return failure in that case. Some overflows still

Re: svn commit: r348419 - in head: crypto/heimdal/lib/ipc share/man/man4 sys/compat/linux sys/kern sys/sys usr.sbin/mountd

2019-06-04 Thread Bruce Evans
On Tue, 4 Jun 2019, Gleb Smirnoff wrote: On Thu, May 30, 2019 at 02:24:27PM +, Dmitry Chagin wrote: D> Author: dchagin D> ... D> Log: D> Complete LOCAL_PEERCRED support. Cache pid of the remote process in the D> struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Bruce Evans
On Mon, 20 May 2019, Conrad Meyer wrote: Log: Extract eventfilter declarations to sys/_eventfilter.h sys/_eventhandler.h has 2 identical 72-line copies of the correct version. The second copy of the reinclusion guard works as a guard against the doubling too. This allows replacing

Re: svn commit: r347953 - head/cddl/contrib/opensolaris/cmd/zfs

2019-05-18 Thread Bruce Evans
On Sat, 18 May 2019, Toomas Soome wrote: On 18 May 2019, at 15:37, Alexey Dokuchaev wrote: On Sat, May 18, 2019 at 12:27:22PM +, Allan Jude wrote: New Revision: 347953 URL: https://svnweb.freebsd.org/changeset/base/347953 Log: MFV/ZoL: `zfs userspace` ignored all unresolved UIDs after

Re: svn commit: r347484 - head/sys/kern

2019-05-12 Thread Bruce Evans
On Sat, 11 May 2019, Doug Moore wrote: On 5/11/19 5:52 AM, Bruce Evans wrote: On Sat, 11 May 2019, Doug Moore wrote: +#ifdef HAVE_INLINE_FFS +?? case sizeof(int): +?? return (ffs(mask) - 1); +#endif This is unreachable, since sizeof(int) is 4 on all supported arches

Re: svn commit: r347484 - head/sys/kern

2019-05-11 Thread Bruce Evans
On Sat, 11 May 2019, Doug Moore wrote: Log: When bitpos can't be implemented with an inline ffs* instruction, change the binary search so that it does not depend on a single bit only being set in the bitmask. Use bitpos more generally, and avoid some clearing of bits to accommodate its

Re: svn commit: r347063 - head/sys/kern

2019-05-07 Thread Bruce Evans
On Tue, 7 May 2019, John Baldwin wrote: On 5/7/19 8:45 AM, Bruce Evans wrote: On Mon, 6 May 2019, John Baldwin wrote: On 5/6/19 11:45 AM, Mark Johnston wrote: On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: On 5/3/19 2:26 PM, Mark Johnston wrote: Author: markj Date: Fri May

Re: svn commit: r347063 - head/sys/kern

2019-05-07 Thread Bruce Evans
On Mon, 6 May 2019, John Baldwin wrote: On 5/6/19 11:45 AM, Mark Johnston wrote: On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: On 5/3/19 2:26 PM, Mark Johnston wrote: Author: markj Date: Fri May 3 21:26:44 2019 New Revision: 347063 URL:

svn commit: r347054 - head/lib/libvgl

2019-05-03 Thread Bruce Evans
Author: bde Date: Fri May 3 13:06:46 2019 New Revision: 347054 URL: https://svnweb.freebsd.org/changeset/base/347054 Log: Fix copying planar bitmaps when the horizontal start and end are both not multiples of 8. Then the misaligned pixels at the end were not copied. Clean up variable

svn commit: r346895 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 16:26:29 2019 New Revision: 346895 URL: https://svnweb.freebsd.org/changeset/base/346895 Log: Support all reasonable cursor sizes. Reduce the size of the standard cursor from 16x16 (with 6 columns unused) to 10x16 and rename it to the "small" cursor. Add a

svn commit: r346890 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 15:58:05 2019 New Revision: 346890 URL: https://svnweb.freebsd.org/changeset/base/346890 Log: Oops, r346889 broke showing of the mouse cursor after clearing, by forgetting to tell the bitmap-copying clearing method to preserve the cursor. Modified:

svn commit: r346889 - head/lib/libvgl

2019-04-29 Thread Bruce Evans
Author: bde Date: Mon Apr 29 14:13:53 2019 New Revision: 346889 URL: https://svnweb.freebsd.org/changeset/base/346889 Log: Refactor and simplify hiding the mouse cursor and fix bugs caused by complications in the previous methods. r346761 broke showing the mouse cursor after changing its

svn commit: r346761 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 18:28:54 2019 New Revision: 346761 URL: https://svnweb.freebsd.org/changeset/base/346761 Log: Use __VGLBitmapCopy() directly to show the mouse cursor. The mouse cursor must be merged with the shadow buffer on the way to the screen, and __VGLBitmapCopy() now has

svn commit: r346754 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 16:38:23 2019 New Revision: 346754 URL: https://svnweb.freebsd.org/changeset/base/346754 Log: Merge __VGLGetXY() back into VGLGetXY(). They were split to simplify the organization of fixes for the mouse cursor, but after optimizations VGLGetXY() automatically

svn commit: r346752 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 16:14:23 2019 New Revision: 346752 URL: https://svnweb.freebsd.org/changeset/base/346752 Log: In VGLClear(), check for the overlap of the mouse cursor in the whole display, not just in the unpanned top left corner. This currently makes no difference since the

svn commit: r346747 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 14:44:20 2019 New Revision: 346747 URL: https://svnweb.freebsd.org/changeset/base/346747 Log: Remove save/restore of the crtc and gdc registers when showing and hiding the mouse cursor. The showing and hiding is often done asynchronously in a not very safe

svn commit: r346745 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:49:06 2019 New Revision: 346745 URL: https://svnweb.freebsd.org/changeset/base/346745 Log: Fix the only known remaining (libvgl) bug for 24-bit modes, and enable support for 24-bit modes. The non-segmented case has worked for a long time, but the segmented

svn commit: r346744 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:22:54 2019 New Revision: 346744 URL: https://svnweb.freebsd.org/changeset/base/346744 Log: Restore the line width in VGLEnd(). The line width may be changed by VGLSetVScreenSize(), but is not restored by mode switches to at least standard text mode, so must

svn commit: r346743 - head/lib/libvgl

2019-04-26 Thread Bruce Evans
Author: bde Date: Fri Apr 26 13:04:10 2019 New Revision: 346743 URL: https://svnweb.freebsd.org/changeset/base/346743 Log: Fix an off-by-1 error for copying overlapping bitmaps in r346416. For nonzero height, the first line in the original order was not copied, and for zero height, garbage

Re: svn commit: r346593 - head/sys/sys

2019-04-26 Thread Bruce Evans
On Fri, 26 Apr 2019, Mark Johnston wrote: On Fri, Apr 26, 2019 at 10:38:36AM +0300, Konstantin Belousov wrote: On Fri, Apr 26, 2019 at 02:04:56AM -0400, Mark Johnston wrote: On Thu, Apr 25, 2019 at 11:22:22AM +0300, Konstantin Belousov wrote: On Thu, Apr 25, 2019 at 07:38:21AM +0200,

svn commit: r346678 - head/lib/libvgl

2019-04-25 Thread Bruce Evans
Author: bde Date: Thu Apr 25 15:48:23 2019 New Revision: 346678 URL: https://svnweb.freebsd.org/changeset/base/346678 Log: Restore doing nothing for calls to VGLEnd() after the first. I broke this in r346631. VGLEnd() clears some state variables as it restores state, but not all of them,

svn commit: r346641 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 16:03:35 2019 New Revision: 346641 URL: https://svnweb.freebsd.org/changeset/base/346641 Log: Avoid hiding and unhiding the mouse cursor when copying bitmaps to the screen. Instead, copy a merged bitmap 1 line at a time. This fixes flashing of the cursor and

svn commit: r346639 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 15:35:29 2019 New Revision: 346639 URL: https://svnweb.freebsd.org/changeset/base/346639 Log: Refactor mouse freezing and fix some minor bugs. VGLMouseFreeze() now only defers mouse signals and leaves it to higher levels to hide and unhide the mouse cursor if

svn commit: r346631 - head/lib/libvgl

2019-04-24 Thread Bruce Evans
Author: bde Date: Wed Apr 24 13:15:56 2019 New Revision: 346631 URL: https://svnweb.freebsd.org/changeset/base/346631 Log: Fix some races and screeen clearing in VGLEnd(). The mouse signal SIGUSR2 was not turned off for normal termination and in some other cases. Thus mouse signals

svn commit: r346580 - head/lib/libvgl

2019-04-22 Thread Bruce Evans
Author: bde Date: Mon Apr 22 19:31:16 2019 New Revision: 346580 URL: https://svnweb.freebsd.org/changeset/base/346580 Log: Fix mouse cursor coloring in depths > 8 (previously, a hack that only worked right for white interiors and black borders was used). Advertise this by changing the

Re: svn commit: r346554 - head/sys/netinet

2019-04-22 Thread Bruce Evans
On Mon, 22 Apr 2019, Bjoern A. Zeeb wrote: On 22 Apr 2019, at 14:20, Bjoern A. Zeeb wrote: Log: Remove some excessive brackets. No functional change. But it includes a stye bug; sorry; I had re-indented the lines to validate the change. Ill remedy this with the follow-up commit which

svn commit: r346488 - head/lib/libvgl

2019-04-21 Thread Bruce Evans
Author: bde Date: Sun Apr 21 16:17:35 2019 New Revision: 346488 URL: https://svnweb.freebsd.org/changeset/base/346488 Log: Use a shadow buffer and never read from the frame buffer. Remove large slow code for reading from the frame buffer. Reading from the frame buffer is usually much

svn commit: r346486 - head/lib/libvgl

2019-04-21 Thread Bruce Evans
Author: bde Date: Sun Apr 21 10:33:09 2019 New Revision: 346486 URL: https://svnweb.freebsd.org/changeset/base/346486 Log: Fix missing restoring of the mouse cursor position, the border color and the blank state after a screen switch. Modified: head/lib/libvgl/main.c

svn commit: r346454 - head/lib/libvgl

2019-04-20 Thread Bruce Evans
Author: bde Date: Sat Apr 20 20:29:03 2019 New Revision: 346454 URL: https://svnweb.freebsd.org/changeset/base/346454 Log: Make libvgl mostly work without superuser privilege in direct modes by not doing any unnecessary PIO instructions or refusing to start when the i/o privilege needed for

svn commit: r346416 - head/lib/libvgl

2019-04-19 Thread Bruce Evans
Author: bde Date: Fri Apr 19 20:29:49 2019 New Revision: 346416 URL: https://svnweb.freebsd.org/changeset/base/346416 Log: Fix copying of overlapping bitmaps. The cases of copying within the screen bitmap and within a single MEMBUF were broken when first source line is before the first

svn commit: r346280 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:52:04 2019 New Revision: 346280 URL: https://svnweb.freebsd.org/changeset/base/346280 Log: Sigh, r346279 was also a test version with the reduced size doubled (so it was actually double the full size in current kernels where the reduction is null, so overran

svn commit: r346279 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:41:45 2019 New Revision: 346279 URL: https://svnweb.freebsd.org/changeset/base/346279 Log: Oops, r346278 committed a test version with the change annulled. Modified: head/lib/libvgl/main.c Modified: head/lib/libvgl/main.c

svn commit: r346278 - head/lib/libvgl

2019-04-16 Thread Bruce Evans
Author: bde Date: Tue Apr 16 15:31:23 2019 New Revision: 346278 URL: https://svnweb.freebsd.org/changeset/base/346278 Log: Quick fix for slow clearing and context switches of large frame buffers with old kernels, by breaking the support for large frame buffers in the same way as for current

  1   2   3   4   5   6   7   8   9   10   >