On Thu, 23 Nov 2017, Konstantin Belousov wrote:
On Fri, Nov 24, 2017 at 12:10:09AM +1100, Bruce Evans wrote:
On Thu, 23 Nov 2017, Konstantin Belousov wrote:
* ...
Below is the cast to uintmax_t and unsigned format for sysctl(8).
This adds style bugs by expanding lines from length 79 to 81
On Thu, 23 Nov 2017, Konstantin Belousov wrote:
Log:
vmstat: use 64-bit counters from struct vmtotal.
Consistently print counters using unsigned intmax type.
Not very consistently. After fixing 0.01% of libxo (just add __printflike()
to xo_emit(), the following errors are detected:
X vmst
On Thu, 23 Nov 2017, Edward Tomasz Napierala wrote:
Log:
Mark kgmon(8) obsolete, redirecting users to pmcstat(8).
It isn't obsolete. pmcstat can't do at least full (non-statistical)
call graphs and high-resolution profiling.
gmon in the kernel is slow to use in the SMP case and dangerous to
On Thu, 23 Nov 2017, Konstantin Belousov wrote:
On Thu, Nov 23, 2017 at 04:24:13AM +1100, Bruce Evans wrote:
sysctl/sysctl.c:
sysctl(8) has bogus support for prettyprinting struct vmtotal (sysctl
shouldn't have any prettyprinting, especially not for structs that have
specia
On Wed, 22 Nov 2017, Konstantin Belousov wrote:
On Wed, Nov 22, 2017 at 08:59:21AM +1100, Bruce Evans wrote:
On Tue, 21 Nov 2017, Konstantin Belousov wrote:
Log:
systat: use and correctly display 64bit counters.
...
Using unsigned types gives sign extension bugs as usual. In old versions
On Tue, 21 Nov 2017, Konstantin Belousov wrote:
Log:
systat: use and correctly display 64bit counters.
Following struct vmtotal changes, make systat use and correctly
display 64-bit counters. Switch to humanize_number(3) to overcome
homegrown arithmetics limits in pretty printing large num
On Tue, 21 Nov 2017, Bruce Evans wrote:
On Tue, 21 Nov 2017, Bruce Evans wrote:
On Mon, 20 Nov 2017, Conrad Meyer wrote:
Log:
msdosfs(5): Reflect READONLY attribute in file mode
...
This undoes only a small part of READONLY changes in r254627 (which are
small part of of r253627). I think
On Mon, 20 Nov 2017, Warner Losh wrote:
Author: imp
Date: Mon Nov 20 22:41:22 2017
New Revision: 326037
URL: https://svnweb.freebsd.org/changeset/base/326037
Log:
Add -mno-avx2 for clang as well as -mno-avx. We don't want either of
them when asking for no SIMD.
Is this needed. For SSE, -mn
On Mon, 20 Nov 2017, Ed Maste wrote:
Hi Bruce, notes on a few of the points you raised (I'll look at others later):
On 19 November 2017 at 04:07, Bruce Evans wrote:
The vendor version is in libc/string. It has been ANSIfied, but the
libkern version has large churning to "optimiz
On Tue, 21 Nov 2017, Bruce Evans wrote:
On Mon, 20 Nov 2017, Conrad Meyer wrote:
Log:
msdosfs(5): Reflect READONLY attribute in file mode
...
This undoes only a small part of READONLY changes in r254627 (which are
small part of of r253627). I think r254627 got the READONLY semantics
wrong
yle fix.
dep->de_Attributes &= ~ATTR_READONLY;
else
dep->de_Attributes |= ATTR_READONLY;
ATTR_READONLY was only accessible via file flags APIs except for this.
It is write-only here too.
Most relevant
On Sat, 18 Nov 2017, Warner Losh wrote:
On Sat, Nov 18, 2017 at 3:42 AM, Bruce Evans wrote:
since it flags all c99 and newer usages as syntax errors. We've been
This shouldn't break use of lint on K&R or C90 sources. But types.h is
broken. It no longer supports K&R,
On Sat, 18 Nov 2017, Pedro Giffuni wrote:
On 11/18/17 09:15, Stefan Esser wrote:
OTOH, we should probably consider other tools, like sparse:
https://sparse.wiki.kernel.org/index.php/Main_Page
The license is fine and it plays nice with the compiler.
It builds on -CURRENT, but the Makefile n
On Sun, 19 Nov 2017, Ed Maste wrote:
Log:
ANSIfy sys/libkern
PR:223641
Submitted by: o...@j.email.ne.jp
MFC after: 1 week
This churns libkern further away from its "vendor" version which is mostly
in libc. I'm still waiting for you to back out previous churning of
kern/m
On Fri, 17 Nov 2017, Warner Losh wrote:
On Fri, Nov 17, 2017 at 6:34 PM, Rodney W. Grimes <
free...@pdx.rh.cn85.dnsmgr.net> wrote:
[ Charset UTF-8 unsupported, converting... ]
Kib@ posted to arch that we were removing it, nobody objected, we
removed
it. If it was a working feature that migh
On Wed, 15 Nov 2017, Mark Millard wrote:
Bruce Evans brde at optusnet.com.au wrote on
Tue Nov 14 12:41:50 UTC 2017 :
- memcpy.3. It was already documented in the BUGS section that memcpy() is
implemented as bcopy() and therefore the "strings" "may overlap"
On Tue, 14 Nov 2017, Ed Maste wrote:
Log:
disallow clock_settime too far in the future to avoid panic
clock_ts_to_ct has a KASSERT that the converted year fits into four
digits. By default (sysctl debug.allow_insane_settime is 0) the kernel
disallows a time too far in the future, using a v
On Mon, 13 Nov 2017, Warner Losh wrote:
Add notes about overlapping copies.
Add notes to each of these that specifically state that results are
undefined if the strings overlap. In the case of memcpy, we document
the overlapping behavior on FreeBSD (pre-existing). For str*, it is
left unsp
On Sun, 12 Nov 2017, Bruce Evans wrote:
On Sun, 12 Nov 2017, Mateusz Guzik wrote:
Log:
amd64: stop nesting preemption counter in spinlock_enter
Discussed with:jhb
This seems to break it. i386 still has the old code.
...
The main broken case is:
- both levels initially 0
On Sun, 12 Nov 2017, Mateusz Guzik wrote:
Log:
amd64: stop nesting preemption counter in spinlock_enter
Discussed with:jhb
This seems to break it. i386 still has the old code.
It also moves the critical section a little, so that it is inconsistent
for enter/exit. I think the crit
On Fri, 10 Nov 2017, Conrad Meyer wrote:
Log:
systm.h: Include cdefs.h first
Ever since r143063, machine/atomic.h requires cdefs.h. So, include it
first. Weak support: style(9) tells us to include cdefs.h first.
This just moves a style bug. The existing include of sys/cdefs.h was bogus.
On Sun, 5 Nov 2017, Konstantin Belousov wrote:
On Sun, Nov 05, 2017 at 11:42:51AM -0700, Warner Losh wrote:
On Sun, Nov 5, 2017 at 11:32 AM, Conrad Meyer wrote:
E.g.,
--- a/sys/ufs/ffs/ffs_alloc.c
+++ b/sys/ufs/ffs/ffs_alloc.c
@@ -304,8 +304,7 @@ retry:
}
if (bp->b_blkno ==
On Sun, 5 Nov 2017, Mateusz Guzik wrote:
On Sun, Nov 5, 2017 at 9:15 PM, Konstantin Belousov
wrote:
On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote:
IMO, the only reason ASSERT-style macros exist is to hide the
conditional-on-build-type part of the operation. That is, to avoid
ha
On Sun, 5 Nov 2017, Ed Maste wrote:
Log:
ANSIfy sys/kern/md4c.c
PR:223453
Submitted by: o...@j.email.ne.jp
MFC After: 2 weeks
This doesn't ANSIfy md4c.c, but churns its style away from both the
vendor version and the copy in libmd.
The style is very non-KNF, but is prese
On Sun, 5 Nov 2017, Konstantin Belousov wrote:
On Mon, Nov 06, 2017 at 01:46:49AM +1100, Bruce Evans wrote:
On Sun, 5 Nov 2017, Konstantin Belousov wrote:
On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote:
On Sun, 22 Oct 2017, Konstantin Belousov wrote:
Author: kib
Date: Sun Oct
On Sun, 5 Nov 2017, Konstantin Belousov wrote:
On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote:
On Sun, 22 Oct 2017, Konstantin Belousov wrote:
Author: kib
Date: Sun Oct 22 08:11:45 2017
New Revision: 324853
URL: https://svnweb.freebsd.org/changeset/base/324853
Log:
Remove the
On Sun, 22 Oct 2017, Edward Tomasz Napierala wrote:
Log:
Add OID for the vm.overcommit sysctl. This makes it possible to remove
one call to sysctl(2) from jemalloc startup code. (That also requires
changes to jemalloc, but I plan to push those to upstream first.)
This change has many style
On Sun, 22 Oct 2017, Konstantin Belousov wrote:
Author: kib
Date: Sun Oct 22 08:11:45 2017
New Revision: 324853
URL: https://svnweb.freebsd.org/changeset/base/324853
Log:
Remove the support for mknod(S_IFMT), which created dummy vnodes with
VBAD type.
FFS ffs_write() VOP catches such vnodes
On Mon, 9 Oct 2017, Alan Somers wrote:
Log:
Remove embedded newlines from sysctl variable descriptions
This doesn't fix the main bug of writing man pages in sysctl descriptions.
Modified: head/sys/dev/pccbb/pccbb_isa.c
{Please ignore my previous null reply]
On Mon, 9 Oct 2017, Sergey Kandaurov wrote:
On 9 October 2017 at 13:24, Edward Tomasz Napierala
wrote:
Author: trasz
Date: Mon Oct 9 10:24:06 2017
New Revision: 324427
URL: https://svnweb.freebsd.org/changeset/base/324427
Log:
Document "tdnam" keywo
On Mon, 9 Oct 2017, Sergey Kandaurov wrote:
On 9 October 2017 at 13:24, Edward Tomasz Napierala
wrote:
Author: trasz
Date: Mon Oct 9 10:24:06 2017
New Revision: 324427
URL: https://svnweb.freebsd.org/changeset/base/324427
Log:
Document "tdnam" keyword to ps(1), and add "tdname" alias.
On Sun, 1 Oct 2017, Ian Lepore wrote:
On Sun, 2017-10-01 at 22:37 +0200, O. Hartmann wrote:
Author: avg
Log:
\xa0 unbreak kernel builds on sparc64 and powerpc after r324163, ZFS
Channel Programs
\xa0\xa0
\xa0 The custom iscntrl() in ZFS Lua code expects a signed argumnet,
so
\xa0 remove th
On Tue, 26 Sep 2017, Emmanuel Vadot wrote:
On Tue, 26 Sep 2017 13:24:57 +0300
Konstantin Belousov wrote:
On Tue, Sep 26, 2017 at 09:18:18AM +, Emmanuel Vadot wrote:
@@ -1940,14 +1936,16 @@ add_expdir(struct dirlist **dpp, char *cp, int len)
{
struct dirlist *dp;
- dp = (s
On Sat, 16 Sep 2017, Alexander Leidinger wrote:
Quoting Bruce Evans (from Sat, 16 Sep 2017 13:46:37
+1000 (EST)):
It gives lesser breakage here:
- with an old PCI em, an error that occur every few makeworlds over nfs now
hang the hardware. It used to be recovered from afger about 10
On Fri, 15 Sep 2017, Scott Long wrote:
On Sep 13, 2017, at 9:12 AM, Sean Bruno wrote:
#blamebruno
A large burden.
Reviewed by:sbruno
Approved by:sbruno (mentor)
Sponsored by:Limelight Networks
Differential Revision:https://reviews.freebsd.org/D12235
*gasps at the LoC cou
On Wed, 13 Sep 2017, John Baldwin wrote:
On Wednesday, September 13, 2017 09:09:42 AM Sean Bruno wrote:
On 09/13/17 08:35, John Baldwin wrote:
On Wednesday, September 13, 2017 03:56:04 AM Sean Bruno wrote:
Author: sbruno
Date: Wed Sep 13 03:56:03 2017
New Revision: 323518
URL: https://svnweb
On Mon, 11 Sep 2017, Mateusz Guzik wrote:
On Mon, Sep 11, 2017 at 10:24 AM, Ryan Libby wrote:
On Mon, Sep 11, 2017 at 12:30 AM, Mateusz Guzik wrote:
[...]
That said, looking now at the struct I think its use should be retired
from the kernel. It can remain in headers for userspace use.
Mo
On Sun, 10 Sep 2017, Mateusz Guzik wrote:
Log:
Move vmmeter atomic counters into dedicated cache lines
Prior to the change they were subject to extreme false sharing.
In particular this change shaves about 3 seconds real time of -j 80
buildkernel.
Changes that small are hard to measure.
On Sat, 9 Sep 2017, David Chisnall wrote:
On 8 Sep 2017, at 21:09, Mateusz Guzik wrote:
Author: mjg
Date: Fri Sep 8 20:09:14 2017
New Revision: 323329
URL: https://svnweb.freebsd.org/changeset/base/323329
Log:
Allow __builtin_memset instead of bzero for small buffers of known size
This c
On Sat, 9 Sep 2017, Mateusz Guzik wrote:
Log:
Fix riscv and powerpc compilation after r323329.
On these archs bzero is a C function, which triggers a compilation error
as the compiler tries to expand the macro.
bzero() is a C function on all arches. It is just written in C on these
archs.
On Tue, 5 Sep 2017, Ryan Libby wrote:
Log:
gnu binutils: FSGSBASE assembly/disassembly
Enable the in-tree binutils to assemble and disassemble amd64 FSGSBASE
instructions (rdfsbase, rdgsbase, wrfsbase, wrgsbase), used in the base
system since r322763.
Thanks.
This gives one last gasp f
On Fri, 8 Sep 2017, Ngie Cooper (yaneurabeya) wrote:
On Sep 8, 2017, at 13:09, Mateusz Guzik wrote:
...
Log:
Allow __builtin_memset instead of bzero for small buffers of known size
This change breaks all platforms that use gcc. If it???s not reverted in the
next 3 hours, I???ll revert it.
On Tue, 29 Aug 2017, John Baldwin wrote:
On Tuesday, August 29, 2017 12:18:18 PM Maxim Sobolev wrote:
John, OK, maybe you are right and the current status quo was just an
accident. I am curious what do you and other people think about expressing
expected structure size and padding more explicit
On Mon, 28 Aug 2017, Ryan Libby wrote:
On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev wrote:
Hi John,
Thanks for your feedback! To address the points that you've raised:
1. I've tested on both 32 and 64 bit platforms, it seems not to be the
case. See imp's comment and my reply here
https://
On Thu, 24 Aug 2017, Alan Somers wrote:
On Wed, Aug 9, 2017 at 1:05 AM, Bruce Evans wrote:
On Tue, 8 Aug 2017, Alan Somers wrote:
...
The compile-time definition of AIO_LISTIO_MAX seems to be broken. I think
POSIX species that AIO_LISTIO_MAX shall not be defined if the value of
On Fri, 25 Aug 2017, Conrad Meyer wrote:
On Fri, Aug 25, 2017 at 3:49 PM, Bruce Evans wrote:
get_off_t() but not the higher level is fixed in my version.
Would you mind incorporating your version of dd into FreeBSD, or
publishing it so someone else can?
I guess it is in my queue, but
On Fri, 25 Aug 2017, Matt Joras wrote:
On 08/25/2017 10:17, Conrad Meyer wrote:
This change seems to break buildworld on MIPS:
/home/cem/head.svn/bin/dd/args.c: In function 'f_bs':
/home/cem/head.svn/bin/dd/args.c:188: warning: format '%zd' expects
type 'signed size_t', but argument 3 has type
On Fri, 25 Aug 2017, Conrad Meyer wrote:
Well, not negative, just large uint64_t numbers that would be negative
as off_t (int64_t).
E.g., dd if=/dev/kmem bs=1 iseek=0xf...foo count=8. I think we
would like that to work. I don't recall whether it does or not before
this change.
This is b
On Fri, 25 Aug 2017, Alan Somers wrote:
Log:
dd(1): Incorrect casting of arguments
It is indeed now incorrect.
dd(1) casts many of its numeric arguments from uintmax_t to intmax_t and
back again to detect whether or not the original arguments were negative.
This is not correct, and cause
Author: bde
Date: Fri Aug 25 10:57:17 2017
New Revision: 322884
URL: https://svnweb.freebsd.org/changeset/base/322884
Log:
Fix bugs in (mostly) not-yet-activated parts of early/emergency output:
- map the hard-coded frame buffer address above KERNBASE. Using the
physical address only w
Author: bde
Date: Fri Aug 25 07:04:41 2017
New Revision: 322878
URL: https://svnweb.freebsd.org/changeset/base/322878
Log:
Support setting the colors of cursors for the VGA renderer.
Advertise this by changing the defaults to mostly red. If you don't like
this, change them (almost) back
Author: bde
Date: Fri Aug 25 02:41:01 2017
New Revision: 322870
URL: https://svnweb.freebsd.org/changeset/base/322870
Log:
Oops, the previous commit was missing 1 line.
Modified:
head/sys/dev/syscons/syscons.c
Modified: head/sys/dev/syscons/syscons.c
=
Author: bde
Date: Fri Aug 25 02:37:32 2017
New Revision: 322869
URL: https://svnweb.freebsd.org/changeset/base/322869
Log:
Fix missing switching of the terminal emulator when switching the
terminal state for kernel console output.
r56043 in 2000 added many complications to support dynamic
Author: bde
Date: Sat Aug 19 23:13:33 2017
New Revision: 322709
URL: https://svnweb.freebsd.org/changeset/base/322709
Log:
Fix setting of defaults for the text cursor.
There was already a per-vty defaults field, but it was useless since it was
only initialized when propagating the global
Author: bde
Date: Sat Aug 19 21:40:42 2017
New Revision: 322708
URL: https://svnweb.freebsd.org/changeset/base/322708
Log:
Rename curr_curs_attr to base_curr_attr. The actual current cursor
attribute field is curs_attr. The base field holds user data translated
in a reversible way and is n
Author: bde
Date: Sat Aug 19 19:33:16 2017
New Revision: 322705
URL: https://svnweb.freebsd.org/changeset/base/322705
Log:
Use better hard-coded defaults for the cursor shape, and remove nearby
redundant initializations.
Hard-code base = 0, height = (approx. 1/8 of the boot-time font heig
Author: bde
Date: Sat Aug 19 12:14:46 2017
New Revision: 322693
URL: https://svnweb.freebsd.org/changeset/base/322693
Log:
Reduce complexity and backwards compatibilty a little by removing new aliases
and repurposing "blink". Improve accuracy of documentation of historical
mistakes and othe
Author: bde
Date: Fri Aug 18 15:40:40 2017
New Revision: 322662
URL: https://svnweb.freebsd.org/changeset/base/322662
Log:
Fix syscons escape sequence for setting the local cursor type. This sequence
was aliased to a vt sequence, causing and fixing various bugs.
For syscons, this restore
Author: bde
Date: Fri Aug 18 14:04:14 2017
New Revision: 322656
URL: https://svnweb.freebsd.org/changeset/base/322656
Log:
Improve names for cons25 sequences.
In a recent commit, I forgot to expand an X to an abbreviation of "BORDER".
Fix this and some nearby bad names.
The descripti
Author: bde
Date: Fri Aug 18 12:45:00 2017
New Revision: 322655
URL: https://svnweb.freebsd.org/changeset/base/322655
Log:
Fix vt100 escape sequence for showing and hiding the cursor in syscons.
It should toggle between 2 states, but it used a cut-down version of
support for a related 3-stat
Author: bde
Date: Fri Aug 18 10:38:49 2017
New Revision: 322651
URL: https://svnweb.freebsd.org/changeset/base/322651
Log:
Fix missing syscons escape sequence for setting the border color.
Modified:
head/sys/dev/syscons/scterm-teken.c
head/sys/teken/sequences
head/sys/teken/teken.h
head
Author: bde
Date: Thu Aug 17 20:25:50 2017
New Revision: 322634
URL: https://svnweb.freebsd.org/changeset/base/322634
Log:
I misplaced a newline in the previous commit. Fix this, and move line
breaks in the vt case to the same places that the man(1) puts then in
the SYNOPSIS. This was alre
Author: bde
Date: Thu Aug 17 18:08:45 2017
New Revision: 322626
URL: https://svnweb.freebsd.org/changeset/base/322626
Log:
Update vidcontrol -c to support all cursor appearance setting
capabilities.
Most of the capabilities (all of the arcane ones) were in FreeBSD-2.0.5,
but were harder
Author: bde
Date: Wed Aug 16 15:14:46 2017
New Revision: 322579
URL: https://svnweb.freebsd.org/changeset/base/322579
Log:
Fix setting of the border color. Teken doesn't support syscons' escape
sequence "ESC [ %d A" for this although that was used here. I will fix
teken later, but use the
Author: bde
Date: Wed Aug 16 10:59:37 2017
New Revision: 322575
URL: https://svnweb.freebsd.org/changeset/base/322575
Log:
Undeprecate the CONS_CURSORTYPE ioctl. It was "deprecated" in 2001,
but it was actually extended then and it is still used (just once) in
/usr/src by its primary user (
On Wed, 9 Aug 2017, Warner Losh wrote:
Log:
Mark geom classes as deprecated.
geom_bsd, geom_mbr and geom_sunlabel have been obsolete since Marcel
Moolenaar's geom_part was in FreeBSD 7. They haven't been in GENERIC
since FreeBSD 8. Add warning when used.
geom_vol_ffs has been obsolete sin
On Tue, 8 Aug 2017, Emmanuel Vadot wrote:
On Tue, 8 Aug 2017 23:55:52 +1000 (EST)
Bruce Evans wrote:
On Tue, 8 Aug 2017, Emmanuel Vadot wrote:
Log:
vmstat: Always emit a space after the free-memory column
When displaying in non-human form, if the free-memory number
is large (more than
On Tue, 8 Aug 2017, Alan Somers wrote:
Log:
Make p1003_1b.aio_listio_max a tunable
p1003_1b.aio_listio_max is now a tunable. Its value is reflected in the
sysctl of the same name, and the sysconf(3) variable _SC_AIO_LISTIO_MAX.
Its value will be bounded from below by the compile-time consta
On Tue, 8 Aug 2017, Emmanuel Vadot wrote:
Log:
vmstat: Always emit a space after the free-memory column
When displaying in non-human form, if the free-memory number
is large (more than 7 digits), there is no space between it and
the page fault column.
PR:221290
Submitted by:
On Sat, 5 Aug 2017, Konstantin Belousov wrote:
On Sat, Aug 05, 2017 at 12:26:03PM +1000, Bruce Evans wrote:
+#defineminor(x)((int)(x))
Another nice simplification. Strictly, it should be (int)(dev_t)(x) since
the pseudo-prototype says that the arg is converted to dev_t, but
On Fri, 4 Aug 2017, Alan Cox wrote:
Log:
In case readers are misled by expressions that combine multiplication and
division, add parentheses to make the precedence explicit.
Submitted by: Doug Moore
Requested by: imp
Reviewed by: imp
MFC after: 1 week
X-MFC after: r321840
Dif
On Thu, 3 Aug 2017, Konstantin Belousov wrote:
On Thu, Aug 03, 2017 at 07:34:56PM +1000, Bruce Evans wrote:
I see another problem. Masking with 0xf and casting to unsigned
are gratuitously different spellings for extracting the low 32 bits.
I prefer the cast.
Below is one more
On Fri, 4 Aug 2017, Colin Percival wrote:
On 08/03/17 23:28, Hans Petter Selasky wrote:
On 08/03/17 16:37, Conrad Meyer wrote:
Is it not important that the subtraction and result are evaluated
without truncation?
ticks is a circular counter. Assuming time = 0 and jiffies = -1U, then "delay"
On Thu, 3 Aug 2017, Joerg Sonnenberger wrote:
On Thu, Aug 03, 2017 at 05:53:43PM +1000, Bruce Evans wrote:
Freestanding versions (static and otherwise) cause problems with builtins.
-ffreestanding turns off all builtins. The static memcpy used to be
ifdefed so as to use __builtin_memcpy
On Thu, 3 Aug 2017, Konstantin Belousov wrote:
On Thu, Aug 03, 2017 at 01:21:56PM +1000, Bruce Evans wrote:
It would be better to remove the comments.
makedev() actually has a man page (a FreeBSD addition makedev(3)).
This could have been better, and is now out of date. The largest error
is
On Thu, 3 Aug 2017, Ngie Cooper wrote:
Log:
Fix the return types for printf and putchar to match their libc and
POSIX equivalents
Both printf and putchar return int, not void.
This will allow code that leverages the libcalls and checks/rely on the
return type to interchangeably between lo
On Wed, 2 Aug 2017, Konstantin Belousov wrote:
On Wed, Aug 02, 2017 at 02:38:50PM +0200, Hans Petter Selasky wrote:
On 08/02/17 14:36, Hans Petter Selasky wrote:
On 08/02/17 12:14, Konstantin Belousov wrote:
+#definemajor(x)((int)((dev_t)(x) >> 32))/* major number */
+#definem
On Fri, 21 Jul 2017, Ryan Libby wrote:
Log:
__pcpu: gcc -Wredundant-decls
Pollution from counter.h made __pcpu visible in amd64/pmap.c. Delete
the existing extern decl of __pcpu in amd64/pmap.c and avoid referring
to that symbol, instead accessing the pcpu region via PCPU_SET macros.
Also
On Fri, 21 Jul 2017, Konstantin Belousov wrote:
On Thu, Jul 20, 2017 at 04:02:02PM -0700, Ryan Libby wrote:
On Thu, Jul 20, 2017 at 3:33 AM, Konstantin Belousov
wrote:
On Thu, Jul 20, 2017 at 02:08:30AM -0700, Ryan Libby wrote:
On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote
On Thu, 20 Jul 2017, Ryan Libby wrote:
On Thu, Jul 20, 2017 at 1:01 AM, Bruce Evans wrote:
On Thu, 20 Jul 2017, Ryan Libby wrote:
Modified: head/sys/amd64/include/efi.h
==
--- head/sys/amd64/include/efi.hThu
On Thu, 20 Jul 2017, Ryan Libby wrote:
Log:
efi: restrict visibility of EFIABI_ATTR-declared functions
In-tree gcc (4.2) doesn't understand __attribute__((ms_abi))
(EFIABI_ATTR). Avoid declaring functions with that attribute when the
compiler is detected to be gcc < 4.4.
Thanks. I used
On Tue, 18 Jul 2017, Ian Lepore wrote:
On Tue, 2017-07-18 at 18:08 +1000, Bruce Evans wrote:
[lots of stuff about locking and accurate time-setting]
Good idea.
My inittodr() waits for the seconds register to change.? This
increases
boot time by an average of 0.5 seconds, but is needed to
On Mon, 17 Jul 2017, Konstantin Belousov wrote:
On Mon, Jul 17, 2017 at 10:29:33AM -0600, Ian Lepore wrote:
I assumed the reason the efirt code was using the same mutex that
protected access to the at rtc was because under the hood, the efi rt
clock is really the same hardware too, accessed via
On Mon, 17 Jul 2017, Ian Lepore wrote:
On Thu, 2017-07-13 at 01:42 +1000, Bruce Evans wrote:
On Wed, 12 Jul 2017, Ian Lepore wrote:
Log:
Protect access to the AT realtime clock with its own mutex.
The mutex protecting access to the registered realtime clock should not be
overloaded to
On Thu, 13 Jul 2017, Rodney W. Grimes wrote:
On Tuesday, July 11, 2017 02:35:15 PM Ian Lepore wrote:
I think the docs on this are pretty clear... under -u it says:
The set of options is determined by applying the options specified
in the argument to -o and finally applying the -r or -w
On Wed, 12 Jul 2017, John Baldwin wrote:
On Wednesday, July 12, 2017 08:08:42 PM Bruce Evans wrote:
On Tue, 11 Jul 2017, John Baldwin wrote:
Log:
Consistently use vop_stdpathconf() for default pathconf values.
...
This is sort of backwards. Not many settings are the same for most
file
On Wed, 12 Jul 2017, Ian Lepore wrote:
Log:
Protect access to the AT realtime clock with its own mutex.
The mutex protecting access to the registered realtime clock should not be
overloaded to protect access to the atrtc hardware, which might not even be
the registered rtc. More importantly
On Tue, 11 Jul 2017, John Baldwin wrote:
On Tuesday, July 11, 2017 02:35:15 PM Ian Lepore wrote:
I think the docs on this are pretty clear... under -u it says:
The set of options is determined by applying the options specified
in the argument to -o and finally applying the -r or -w opt
On Tue, 11 Jul 2017, John Baldwin wrote:
Log:
Consistently use vop_stdpathconf() for default pathconf values.
Update filesystems not currently using vop_stdpathconf() in pathconf
VOPs to use vop_stdpathconf() for any configuration variables that do
not have filesystem-specific values. vop_
Author: bde
Date: Mon Jul 10 09:00:35 2017
New Revision: 320869
URL: https://svnweb.freebsd.org/changeset/base/320869
Log:
Fix attribute flipping for cut marking in pixel mode. The text-mode
code was used, so the lightness bit was not flipped, so the flipping
was unnecessarily null in some
Author: bde
Date: Sun Jul 9 12:13:37 2017
New Revision: 320829
URL: https://svnweb.freebsd.org/changeset/base/320829
Log:
Move open coding of construction of attributes for cut regions and
text cursors to functions so that it is easier to fix and improve.
This commit doesn't fix anything ex
Author: bde
Date: Sat Jul 8 17:30:33 2017
New Revision: 320808
URL: https://svnweb.freebsd.org/changeset/base/320808
Log:
Add many bitmaps (now there are 13) for mouse cursors and logic to try
to choose the best one.
The old 9x13 cursor was was sort of correct for CGA 640x200 text mode,
Author: bde
Date: Sat Jul 8 15:01:55 2017
New Revision: 320805
URL: https://svnweb.freebsd.org/changeset/base/320805
Log:
Add files to help manage the (vga) syscons mouse cursor.
To mostly fix distortion of mouse cursors by non-square pixels, I
needed 8 variants of the same cursor shape
On Sun, 11 Jun 2017, Konstantin Belousov wrote:
On Sun, Jun 11, 2017 at 07:53:47PM +1000, Bruce Evans wrote:
On Sat, 10 Jun 2017, Konstantin Belousov wrote:
On Sat, Jun 10, 2017 at 09:33:48AM -0700, Jonathan Looney wrote:
Hi Konstantin,
On Sat, Jun 10, 2017 at 2:12 AM, Konstantin Belousov
On Sat, 10 Jun 2017, Konstantin Belousov wrote:
On Sat, Jun 10, 2017 at 09:33:48AM -0700, Jonathan Looney wrote:
Hi Konstantin,
On Sat, Jun 10, 2017 at 2:12 AM, Konstantin Belousov
wrote:
No, acquire is only specified for loads, and release for stores. In other
words, on some hypothetical l
On Sun, 4 Jun 2017, Bryan Drewery wrote:
On 6/4/17 4:27 PM, Ed Maste wrote:
On 4 June 2017 at 14:06, Bryan Drewery wrote:
In r189170. It seems to me we should change systm.h back to a macro
#define memmove(dst, src, len) bcopy((src), (dst), (len))
Note that they're not quite equivalent: me
On Fri, 2 Jun 2017, Ed Maste wrote:
Log:
msdosfs: use mem{cpy,move,set} instead of bcopy,bzero
This somewhat simplifies use of msdosfs code in userland (for makefs),
reduces diffs with NetBSD and is standard C as of C89.
This is a style bug in the kernel. The kernel should use the standar
On Sun, 28 May 2017, Dmitry Chagin wrote:
Log:
Strip _binary_linux_locore_o_size from ${VDSO}.so as it is a low absolute
symbol, and this breaks symbol lookup in ddb.
Requested by: bde@
Thanks.
This works because the symbol is auto-generated by the linker from the name
of a file and not
On Sun, 14 May 2017, Rick Macklem wrote:
Log:
Change the default uid/gid values for nobody/nogroup to 65534/65533.
The default values found in /etc/passwd and /etc/group are 65534, 65533.
In mountd.c, the defaults were -2, which was 65534 back when uid_t was 16bits.
Without this patch, a fi
On Tue, 9 May 2017, Ian Lepore wrote:
On Tue, 2017-05-09 at 08:36 +, Edward Tomasz Napierala wrote:
Author: trasz
Date: Tue May??9 08:36:09 2017
New Revision: 318017
URL: https://svnweb.freebsd.org/changeset/base/318017
Log:
? Fix device paths for USB serial adapters: the formatting string
401 - 500 of 2008 matches
Mail list logo