that people will
be able to use it on any POSIX-compliant system, and I've lost count of the
number of times I've been hit by this won't build on OS X or Linux because you
forgot to #include stdint.h.
Namespace pollution has a very real cost in wasted developer time.
--
Colin Percival
Security
Author: cperciva
Date: Tue Mar 19 04:42:04 2013
New Revision: 248487
URL: http://svnweb.freebsd.org/changeset/base/248487
Log:
If dumpdev is AUTO but no dump device has been set -- i.e., there is no swap
space configured for rc.d/dumpon to designate for dumping -- then exit
silently rather
Author: cperciva
Date: Tue Mar 19 05:08:25 2013
New Revision: 248488
URL: http://svnweb.freebsd.org/changeset/base/248488
Log:
Fix typo in previous commit: Exit if */dev/dumpdev* does not exist, not if
*/bin/realpath* does not exist...
Submitted by: markj
Pointy hat to:cperciva
Author: cperciva
Date: Thu Mar 7 20:48:36 2013
New Revision: 247940
URL: http://svnweb.freebsd.org/changeset/base/247940
Log:
Now that stable/7 is EOL, stop building INDEX-7.
MFC after:1 week
Modified:
head/etc/portsnap.conf
Modified: head/etc/portsnap.conf
be
working in Z(2^16), where subtraction is normal subtraction mod
65536.
Given that there's no such thing as GF(216) due to 216 = 2^3 * 3^3 not
being a prime power, the comment is definitely wrong. ;-)
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap
Author: cperciva
Date: Sun Feb 10 17:58:44 2013
New Revision: 246627
URL: http://svnweb.freebsd.org/changeset/base/246627
Log:
Don't try to suppress the inclusion of the build date in named's version
string by undefining __DATE__, since (unlike gcc) clang doesn't allow us
to do that.
Author: cperciva
Date: Sun Jan 27 23:33:42 2013
New Revision: 246016
URL: http://svnweb.freebsd.org/changeset/base/246016
Log:
Add a loader tunable hw.broken_txfifo which enables a workaround for a
bug in old versions of QEMU (and Xen, and other places using QEMU code).
On those buggy
Author: cperciva
Date: Fri Nov 23 01:48:31 2012
New Revision: 243419
URL: http://svnweb.freebsd.org/changeset/base/243419
Log:
MFS security patches which seem to have accidentally not reached HEAD:
Fix insufficient message length validation for EAP-TLS messages.
Fix Linux
Author: cperciva
Date: Mon Aug 13 07:36:57 2012
New Revision: 239228
URL: http://svn.freebsd.org/changeset/base/239228
Log:
Build modules along with the XENHVM kernels.
No objections from: freebsd-xen mailing list
MFC after:1 week
Modified:
head/sys/amd64/conf/XENHVM
that this was indeed the bug I
was running into.
Hopefully everybody else is sending signals to specific pids rather than
using killall during log rotation like I am. :-)
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups
it into an entropy pool which is *occasionally* reseeded
later. If even a very slow /dev/random becomes a scalability problem,
an application is doing something very very wrong.
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups
behind Logfile has a parity error or another memory error
or was clobbered by a buffer overrun), this assert() doesn't break the
library but just wastes space.
I asked eadler to include that on the basis that it made the code easier
to understand.
--
Colin Percival
Security Officer Emeritus, FreeBSD
On 06/20/12 14:15, Warner Losh wrote:
On Jun 20, 2012, at 10:36 AM, Colin Percival wrote:
On 06/20/12 09:27, Bruce Evans wrote:
On Wed, 20 Jun 2012, Eitan Adler wrote:
Log:
Don't close an uninitialized descriptor. [1]
Add a sanity check for the validity of the passed fd.
Library functions
on the disk as the consequence.
I just tested this hypothesis, and found no change in binary size using
either clang or gcc46. Presumably they're smart enough to ignore explicit
(and unnecessary) initializations of statics to zero.
--
Colin Percival
Security Officer, FreeBSD | freebsd.org
On 05/11/12 13:08, Warner Losh wrote:
On May 11, 2012, at 9:02 AM, Colin Percival wrote:
On 05/11/12 05:48, Konstantin Belousov wrote:
On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote:
+bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static
unsigned char **cmonths
a bug I need to
track down here.
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
___
svn-src-head@freebsd.org mailing list
http
Author: cperciva
Date: Mon Jan 16 02:38:45 2012
New Revision: 230183
URL: http://svn.freebsd.org/changeset/base/230183
Log:
Make XENHVM work on i386. The __ffs() function counts bits starting from
zero, unlike ffs(3), which starts counting from 1.
Modified:
Author: cperciva
Date: Mon Jan 16 02:42:16 2012
New Revision: 230184
URL: http://svn.freebsd.org/changeset/base/230184
Log:
Copy XENHVM config file from amd64, now that i386+XENHVM works.
Added:
- copied unchanged from r230183, head/sys/amd64/conf/XENHVM
Directory Properties:
to 2048 chunks.
Should be 11 bits, no?
I'm not a native speaker, but I think 11 bit wide is correct here.
I am a native speaker, and it's 11 bits wide. English is an odd language:
An 11 bit wide field is 11 bits wide. (Similarly, a 45 *foot* long bus
is 45 *feet* long.)
--
Colin Percival
Author: cperciva
Date: Fri Dec 23 15:00:37 2011
New Revision: 228843
URL: http://svn.freebsd.org/changeset/base/228843
Log:
Fix a problem whereby a corrupt DNS record can cause named to crash. [11:06]
Add an API for alerting internal libc routines to the presence of
unsafe paths
Author: cperciva
Date: Sun Oct 23 06:23:11 2011
New Revision: 226650
URL: http://svn.freebsd.org/changeset/base/226650
Log:
Add '%' and '@' to the set of characters which can appear in path names.
Without this change, freebsd-update refuses to accept 9.0 metadata files.
Modified:
makes look(1)
fail with File too large whenever it's larger than (int64_t)(UINT64_MAX) = -1
bytes long.
Please fix. :-)
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
(uintmax_t)SIZE_T_MAX)
That should work. I've also solved this problem in the past with
if ((sizeof(off_t) sizeof(size_t))
(sb.st_size (off_t)
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online
Author: cperciva
Date: Wed Oct 12 03:29:12 2011
New Revision: 226277
URL: http://svn.freebsd.org/changeset/base/226277
Log:
Now that the portsnap buildbox is generating the raw bits for INDEX-9,
add it to the set of INDEX files built by portsnap.
Modified:
head/etc/portsnap.conf
Modified:
Author: cperciva
Date: Tue Oct 4 19:07:38 2011
New Revision: 226023
URL: http://svn.freebsd.org/changeset/base/226023
Log:
Fix a bug in UNIX socket handling in the linux emulator which was
exposed by the security fix in FreeBSD-SA-11:05.unix.
Approved by: so (cperciva)
Approved by:
will be coming soon.
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn
Author: cperciva
Date: Tue Jul 5 18:43:54 2011
New Revision: 223797
URL: http://svn.freebsd.org/changeset/base/223797
Log:
Don't allow lro-len to exceed 65535, as this will result in overflow
when len is inserted back into the synthetic IP packet and cause a
multiple of 2^16 bytes of TCP
Author: cperciva
Date: Tue Jul 5 18:49:55 2011
New Revision: 223799
URL: http://svn.freebsd.org/changeset/base/223799
Log:
Remove #ifdef notyet code dating back to 4.3BSD Net/2 (and possibly earlier).
I think the benefit of making the code cleaner and easier to understand
outweighs the
is non-null it must point to at
.Xr sha 3
.Sh HISTORY
These functions appeared in
-.Fx 4.0 .
+.Fx 6.0 .
.Sh AUTHORS
The core hash routines were implemented by Colin Percival based on
the published
Modified: head/lib/libmd/sha512.3
Author: cperciva
Date: Wed May 11 15:23:27 2011
New Revision: 221780
URL: http://svn.freebsd.org/changeset/base/221780
Log:
Make freebsd-update(8) smarter in how it handles $FreeBSD$ tags in
configuration files.
If the current file differs from the canonical version from the old release
Author: cperciva
Date: Tue Jan 4 15:55:15 2011
New Revision: 216960
URL: http://svn.freebsd.org/changeset/base/216960
Log:
Add hamfisted locking to the Xen/PV pmap code: Only allow one thread to
be in {pmap_pinit, pmap_copy, pmap_release} at a time.
This reduces the rate of panics when
On 01/04/11 05:00, John Baldwin wrote:
On Monday, January 03, 2011 7:16:38 pm Colin Percival wrote:
+#ifdef INVARIANTS
if (__predict_true(gdtset))
-critical_enter();
+KASSERT(curthread-td_critnest 0,
+(xen queue flush should be in a critical
Author: cperciva
Date: Tue Jan 4 16:29:07 2011
New Revision: 216963
URL: http://svn.freebsd.org/changeset/base/216963
Log:
Spell CRITICAL_ASSERT correctly.
Submitted by: jhb
MFC with: r216944
Modified:
head/sys/i386/xen/xen_machdep.c
Modified: head/sys/i386/xen/xen_machdep.c
Author: cperciva
Date: Tue Jan 4 00:16:38 2011
New Revision: 216944
URL: http://svn.freebsd.org/changeset/base/216944
Log:
Adjust the critical section protecting _xen_flush_queue to cover the
entire range where the page mapping request queue needs to be atomically
examined and modified.
Author: cperciva
Date: Fri Dec 31 17:39:31 2010
New Revision: 216843
URL: http://svn.freebsd.org/changeset/base/216843
Log:
Make i386_set_ldt work on i386/XEN, step 1/5.
Lock the vm page queue mutex around calls to pte_store. As with many other
uses of the vm page queue mutex in
Author: cperciva
Date: Fri Dec 31 17:39:58 2010
New Revision: 216844
URL: http://svn.freebsd.org/changeset/base/216844
Log:
Make i386_set_ldt work on i386/XEN, step 2/5.
Don't map physical to machine page numbers in pte_load_store, since it uses
PT_SET_VA (which takes a physical page
Author: cperciva
Date: Fri Dec 31 17:40:30 2010
New Revision: 216845
URL: http://svn.freebsd.org/changeset/base/216845
Log:
Make i386_set_ldt work on i386/XEN, step 3/5.
Synchronize reality with comment: The user_ldt_alloc function is supposed to
return with dt_lock held. Due to broken
Author: cperciva
Date: Fri Dec 31 17:41:14 2010
New Revision: 216846
URL: http://svn.freebsd.org/changeset/base/216846
Log:
Make i386_set_ldt work on i386/XEN, step 4/5.
Use xen_update_descriptor to update the LDT rather than bcopy. Under Xen,
pages used for holding LDTs must be
Author: cperciva
Date: Fri Dec 31 17:42:25 2010
New Revision: 216847
URL: http://svn.freebsd.org/changeset/base/216847
Log:
Make i386_set_ldt work on i386/XEN, step 5/5.
When cleaning up a thread, reset its LDT to the default LDT.
Note: Casting the LDT pointer to an int and storing it
. Feel free to hop in a time machine and go back
6 years to encourage Wes to use a different name when he added the option.
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
Author: cperciva
Date: Thu Dec 30 01:13:42 2010
New Revision: 216811
URL: http://svn.freebsd.org/changeset/base/216811
Log:
Remove INDEX-6 from the default portsnap configuration file; the 6.x index
bits haven't been built since December 1st, although the mirrors are still
distributing the
Author: cperciva
Date: Thu Dec 30 01:28:56 2010
New Revision: 216812
URL: http://svn.freebsd.org/changeset/base/216812
Log:
Add xenpic_dynirq_disable_intr and set it as the .pic_disable_intr method
for xenpic_dynirq_template. This fixes a panic when a virtual disk is
removed, since that
Author: cperciva
Date: Tue Dec 28 14:36:32 2010
New Revision: 216762
URL: http://svn.freebsd.org/changeset/base/216762
Log:
Remove a not strictly correct (and panic-inducing) workaround for a bug
which doesn't seem to exist.
PR: kern/141328
MFC after:3 days
Modified:
Author: cperciva
Date: Wed Dec 29 05:13:21 2010
New Revision: 216790
URL: http://svn.freebsd.org/changeset/base/216790
Log:
A lack of console input is not the same thing as a byte of \0 input.
Correctly return -1 from cngetc when no input is available to be read.
This fixes the '(CTRL-C
Author: cperciva
Date: Mon Dec 27 23:52:40 2010
New Revision: 216746
URL: http://svn.freebsd.org/changeset/base/216746
Log:
Make it possible to specify WITHOUT_MODULES in a kernel config file.
MFC after:1 week
Modified:
head/sys/conf/kern.pre.mk
Modified: head/sys/conf/kern.pre.mk
Author: cperciva
Date: Sun Dec 26 13:05:43 2010
New Revision: 216703
URL: http://svn.freebsd.org/changeset/base/216703
Log:
Lock the vm page queue mutex in pmap_pte_release around the call
to PMAP_SET_VA; this fixes a mutex-not-held panic when a process
which called mlock(2) exits, and
Author: cperciva
Date: Sat Dec 11 20:12:42 2010
New Revision: 216382
URL: http://svn.freebsd.org/changeset/base/216382
Log:
Make the machdep.independent_wallclock sysctl do what it says on the box.
Modified:
head/sys/i386/xen/clock.c
Modified: head/sys/i386/xen/clock.c
Author: cperciva
Date: Sat Dec 11 22:33:33 2010
New Revision: 216385
URL: http://svn.freebsd.org/changeset/base/216385
Log:
Reduce the Xen timecounter from 1GHz to 2^-9 GHz, thereby increasing the
timecounter period from 2^32 ns (~4.3s) to 2^41 ns (~36m39s). Some time
sharing systems can
Author: cperciva
Date: Wed Dec 8 19:42:21 2010
New Revision: 216304
URL: http://svn.freebsd.org/changeset/base/216304
Log:
MFi386 r1.81, r1.82, r1.84: Reorganize code to reduce cache pressure and
branch mispredictions.
No objections from: scottl
Modified:
Author: cperciva
Date: Wed Dec 8 19:52:04 2010
New Revision: 216306
URL: http://svn.freebsd.org/changeset/base/216306
Log:
MFi386 r1.94: If XEN, make pmap_kextract = pmap_kextract_ma. This is a
no-op currently, since FreeBSD/amd64 doesn't have (paravirtualized) Xen
support, but if/when
Author: cperciva
Date: Wed Dec 8 20:20:10 2010
New Revision: 216308
URL: http://svn.freebsd.org/changeset/base/216308
Log:
On amd64, we have (since r1.72, in December 2005) MAX_BPAGES=8192,
while on i386 we have MAX_BPAGES=512. Implement this difference via
'#ifdef __i386__'.
With
Author: cperciva
Date: Tue Dec 7 23:33:20 2010
New Revision: 216280
URL: http://svn.freebsd.org/changeset/base/216280
Log:
Postpone the unmasking of event channels (aka. interrupts) until after
the interrupt handlers have been registered. NULL isn't a very good
interrupt handler.
On 12/07/10 15:33, Colin Percival wrote:
Log:
Postpone the unmasking of event channels (aka. interrupts) until after
the interrupt handlers have been registered. NULL isn't a very good
interrupt handler.
Forgot to add: While here, make bind_ipi_to_irq static, since it isn't used
from
Author: cperciva
Date: Mon Dec 6 20:40:15 2010
New Revision: 216241
URL: http://svn.freebsd.org/changeset/base/216241
Log:
Set correct maximum I/O length. We can only handle I/O of up to
max_request_segments * PAGE_SIZE if the I/O is page-aligned; the
largest I/O we can guarantee will
Author: cperciva
Date: Sat Dec 4 23:24:35 2010
New Revision: 216190
URL: http://svn.freebsd.org/changeset/base/216190
Log:
Remove unnecessary #includes which seem to have been accidentally added
as part of CVS r1.76 (in January 2006).
Modified:
head/sys/i386/i386/busdma_machdep.c
Author: cperciva
Date: Thu Nov 25 15:41:34 2010
New Revision: 215819
URL: http://svn.freebsd.org/changeset/base/215819
Log:
Work around paging bug. Somehow we seem to be ending up with entries in
the TLB which don't correspond to ptes with PG_V set; prior to this commit
I'm sometimes
Author: cperciva
Date: Mon Nov 22 09:04:29 2010
New Revision: 215663
URL: http://svn.freebsd.org/changeset/base/215663
Log:
In xen_get_timecount, return the full ns-precision time rather than
rounding to 1/HZ precision.
I have no idea why the rounding was introduced in the first place,
Author: cperciva
Date: Tue Nov 23 04:50:01 2010
New Revision: 215732
URL: http://svn.freebsd.org/changeset/base/215732
Log:
Add parentheses for clarity. The parentheses around the two terms of the
are unnecessary but I'm leaving them in for the sake of avoiding confusion
(I confuse
Author: cperciva
Date: Thu Nov 18 21:02:40 2010
New Revision: 215470
URL: http://svn.freebsd.org/changeset/base/215470
Log:
Don't KASSERT in pmap_release that
xpmap_ptom(VM_PAGE_TO_PHYS(m)) == (pmap-pm_pdpt[i] PG_FRAME)
for i = NPGPTD, since pmap-pm_pdpt[i] is only initialized for
0 =
Author: cperciva
Date: Thu Nov 18 21:29:43 2010
New Revision: 215472
URL: http://svn.freebsd.org/changeset/base/215472
Log:
Make pmap_release match pmap_pinit by invoking pmap_qremove(pmap-pm_pdpt)
to match pmap_pinit's pmap_qenter(pmap-pm_pdpt) call in the case of PAE.
Modified:
Author: cperciva
Date: Thu Nov 11 00:29:19 2010
New Revision: 215105
URL: http://svn.freebsd.org/changeset/base/215105
Log:
Zero the buffer containing the .gnu_debuglink section before writing
into it. Prior to this commit the .gnu_debuglink section can have up
to 3 bytes of uninitialized
Author: cperciva
Date: Wed Sep 29 23:47:06 2010
New Revision: 213287
URL: http://svn.freebsd.org/changeset/base/213287
Log:
Add advice to new fathers from Thomas Ptacek.
Suggested by: wilko
Approved by: Thomas Ptacek
Security: New parents often feel very insecure.
Modified:
Author: cperciva
Date: Mon Sep 20 14:58:08 2010
New Revision: 212901
URL: http://svn.freebsd.org/changeset/base/212901
Log:
Fix an integer overflow in RLE length parsing when decompressing
corrupt bzip2 data.
Approved by: so (cperciva)
Security: FreeBSD-SA-10:08.bzip2
Modified:
Author: cperciva
Date: Fri Sep 10 19:20:52 2010
New Revision: 212431
URL: http://svn.freebsd.org/changeset/base/212431
Log:
Remind the user that he needs to run 'freebsd-update install' to install
new bits after downloading them using 'freebsd-update upgrade'.
Submitted by: bapt
MFC
Author: cperciva
Date: Fri Sep 10 19:23:59 2010
New Revision: 212432
URL: http://svn.freebsd.org/changeset/base/212432
Log:
Add warning about freebsd-update upgrade needing lots of disk space.
Submitted by: jpaetzel
MFC after:1 month
Modified:
Author: cperciva
Date: Fri Sep 10 20:20:28 2010
New Revision: 212434
URL: http://svn.freebsd.org/changeset/base/212434
Log:
freebsd-update fetch -r NEWRELEASE is meaningless and probably a typo
for freebsd-update upgrade -r NEWRELEASE. Error out and suggest what
the user probably meant.
, ISLOWER);
+ add(ABCDEFGHIJKLMNOPQRSTUVWXYZ, ISUPPER);
Ok, I have to wonder: Why was there ever the extra 'C' between 'U' and 'V'?
It seems that it has been there ever since 4.4-Lite, but I don't have access
to historical sources beyond that point.
--
Colin Percival
Security Officer, FreeBSD
/*- for these, please change them instead to
/**, since that is an alternative box comment marker.
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
___
svn-src
Author: cperciva
Date: Tue Jul 13 02:45:17 2010
New Revision: 209964
URL: http://svn.freebsd.org/changeset/base/209964
Log:
Correctly copy the M_RDONLY flag when duplicating a reference
to an mbuf external buffer.
Approved by: so (cperciva)
Approved by: re (kensmith)
Security:
,
BETAs, and RCs). But a more *sensual* message is probably not necessary. :-)
--
Colin Percival
Security Officer, FreeBSD | freebsd.org | The power to serve
Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
___
svn-src-head
Author: cperciva
Date: Sun Jun 27 02:30:19 2010
New Revision: 209546
URL: http://svn.freebsd.org/changeset/base/209546
Log:
Note that internal_underscores should be used in identifier names rather
than camelCase or TitleCase.
According to grep and my checked-out source tree, we're
instead.
For what it's worth, I find that having tab completion disabled is very useful
when I paste pieces of shell script into consoles. If other people also do
this, it might be an argument in favour of providing a more user-friendly way
to disable tab completion.
--
Colin Percival
Security
Author: cperciva
Date: Sun Jun 13 01:13:36 2010
New Revision: 209117
URL: http://svn.freebsd.org/changeset/base/209117
Log:
In threaded processes, destroy the mutex atexit_mutex when we've
finished using it. This allows the mutex's allocated memory to be
freed.
This is one sense a
Author: cperciva
Date: Fri Jun 11 21:46:45 2010
New Revision: 209072
URL: http://svn.freebsd.org/changeset/base/209072
Log:
Clean up code by removing pre-C99 struct hack preprocessor magic.
Approved by: randi (maintainer)
Modified:
head/usr.sbin/sysinstall/sysinstall.h
Modified:
Author: cperciva
Date: Thu May 27 03:15:04 2010
New Revision: 208586
URL: http://svn.freebsd.org/changeset/base/208586
Log:
Change the current working directory to be inside the jail created by
the jail(8) command. [10:04]
Fix a one-NUL-byte buffer overflow in libopie. [10:05]
Author: cperciva
Date: Thu Apr 8 09:01:20 2010
New Revision: 206396
URL: http://svn.freebsd.org/changeset/base/206396
Log:
People working on sysinstall are encouraged to contact randi to
coordinate major changes.
Modified:
head/MAINTAINERS
Modified: head/MAINTAINERS
201 - 276 of 276 matches
Mail list logo