Re: svn commit: r363891 - head/sys/kern

On 5 Aug, Mateusz Guzik wrote: > Author: mjg > Date: Wed Aug 5 09:24:38 2020 > New Revision: 363891 > URL: https://svnweb.freebsd.org/changeset/base/363891 > > Log: > cache: reduce zone alignment to 8 bytes > > It used to be sizeof of the given struct to accomodate for 32 bit mips >

Re: svn commit: r357407 - head

On 2 Feb, Warner Losh wrote: > Author: imp > Date: Sun Feb 2 11:37:27 2020 > New Revision: 357407 > URL: https://svnweb.freebsd.org/changeset/base/357407 > > Log: > Per the firm plan, start to remove sparc64 > > The sparc64 architecture is being removed from FreeBSD 13, starting > now.

svn commit: r355553 - head/sbin/swapon

Author: truckman Date: Mon Dec 9 07:18:40 2019 New Revision: 33 URL: https://svnweb.freebsd.org/changeset/base/33 Log: Fix a logic bug in error handling code. It is an error if p == NULL. The linelen tests are only meaningful when p != NULL. Reported by: Coverity Coverity

Re: svn commit: r349256 - head/libexec/rc/rc.d

On 21 Jun, Xin LI wrote: > But ultimately, I think the real design question here that needs to be > solved would probably be "Why are piling up multiple layers of workarounds > around motd? Does it even need to be located in /etc?" The contents is > meant to be updated every time when there is a

Re: svn commit: r336859 - head/sbin/init/rc.d

On 29 Jul, Ian Lepore wrote: > On Sun, 2018-07-29 at 09:59 -0700, Don Lewis wrote: >> On 29 Jul, Ian Lepore wrote: >> > On Sun, 2018-07-29 at 05:42 +, Don Lewis wrote: >> >> Author: truckman >> >> Date: Sun Jul 29 05:42:07 2018 >> >> New

Re: svn commit: r336859 - head/sbin/init/rc.d

On 29 Jul, Ian Lepore wrote: > On Sun, 2018-07-29 at 05:42 +0000, Don Lewis wrote: >> Author: truckman >> Date: Sun Jul 29 05:42:07 2018 >> New Revision: 336859 >> URL: https://svnweb.freebsd.org/changeset/base/336859 >> >> Log: >>   Fix a variable

Re: r336845

On 28 Jul, Brad Davis wrote: > On Sat, Jul 28, 2018, at 10:56 PM, Don Lewis wrote: >> On 28 Jul, Don Lewis wrote: >> > On 28 Jul, Brad Davis wrote: >> >> On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >> >>> On Sat, Jul 28, 2018, at 8:21 PM, Don Le

svn commit: r336859 - head/sbin/init/rc.d

Author: truckman Date: Sun Jul 29 05:42:07 2018 New Revision: 336859 URL: https://svnweb.freebsd.org/changeset/base/336859 Log: Fix a variable name typo in r336845 that prevented the rc.d scripts from being installed in the correct directory. Resurrect a few rc.d scripts that were

Re: r336845

On 28 Jul, Don Lewis wrote: > On 28 Jul, Brad Davis wrote: >> On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >>> On Sat, Jul 28, 2018, at 8:21 PM, Don Lewis wrote: >>> > I just upgraded a machine from r336438 to r336855. When I ran >>> > mergemast

Re: r336845

On 28 Jul, Brad Davis wrote: > On Sat, Jul 28, 2018, at 9:10 PM, Brad Davis wrote: >> On Sat, Jul 28, 2018, at 8:21 PM, Don Lewis wrote: >> > I just upgraded a machine from r336438 to r336855. When I ran >> > mergemaster, it asked to delete a bunch of the /etc/rc.d

r336845

I just upgraded a machine from r336438 to r336855. When I ran mergemaster, it asked to delete a bunch of the /etc/rc.d scripts. Answering yes results in the machine being unbootable. I think that the rc.d-related changes in r336845 are the likely culprit. The following rc.d scripts are some of

svn commit: r336855 - head/sys/kern

Author: truckman Date: Sun Jul 29 00:30:06 2018 New Revision: 336855 URL: https://svnweb.freebsd.org/changeset/base/336855 Log: Fix the long term ULE load balancer so that it actually works. The initial call to sched_balance() during startup is meant to initialize balance_ticks, but does

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

On 7 Jul, Alexey Dokuchaev wrote: > On Fri, Jul 06, 2018 at 05:06:03PM -0700, Don Lewis wrote: >> The other machine is my Pentium-M laptop, which is mostly used for light >> browsing and as a VNC client when I'm on the road. Performance is >> acceptable for those use

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

On 6 Jul, Warner Losh wrote: > On Fri, Jul 6, 2018 at 6:06 PM, Don Lewis wrote: > >> On 6 Jul, Warner Losh wrote: >> > On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes < >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> >> > Author:

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

On 6 Jul, Warner Losh wrote: > On Fri, Jul 6, 2018 at 9:32 AM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> > Author: hselasky >> > Date: Fri Jul 6 10:13:42 2018 >> > New Revision: 336025 >> > URL: https://svnweb.freebsd.org/changeset/base/336025 >> > >> > Log: >> > Make

Re: svn commit: r334543 - head/usr.bin/top

On 2 Jun, Rodney W. Grimes wrote: >> Author: eadler >> Date: Sat Jun 2 22:06:27 2018 >> New Revision: 334543 >> URL: https://svnweb.freebsd.org/changeset/base/334543 >> >> Log: >> top(1): chdir to / as init; remove unneeded comment >> >> - chdir to / to allow unmounting of wd >> -

Re: svn commit: r329875 - head/sys/kern

On 23 Feb, Rick Macklem wrote: > Konstantin Belousov wrote: >>Author: kib >>Date: Fri Feb 23 18:26:31 2018 >>New Revision: 329875 >>URL: https://svnweb.freebsd.org/changeset/base/329875 >> >>Log: >> Restore UP build. >> >> Reviewed by: truckman >> Sponsored by: The FreeBSD Foundation >>

svn commit: r329844 - head/sys/kern

Author: truckman Date: Fri Feb 23 00:12:51 2018 New Revision: 329844 URL: https://svnweb.freebsd.org/changeset/base/329844 Log: Decrease latency by not wrapping the idle loop's potentially lengthy search for a thread to steal inside a critical section. Since this allows the search to be

Re: svn commit: r328159 - head/sys/modules

On 19 Jan, Conrad Meyer wrote: > On Fri, Jan 19, 2018 at 9:37 AM, Rodney W. Grimes > wrote: >> If you think in assembler it is easy to understand why this is UB, >> most (all) architectures Right Logic or Arithmetic Shift only accept an >> operand that is a size

Re: svn commit: r328159 - head/sys/modules

On 19 Jan, David Chisnall wrote: > On 19 Jan 2018, at 05:07, Conrad Meyer wrote: >> >> The spec says the behavior is undefined; not that the compiler has to >> produce a warning or error message. The compiler *does* get to >> arbitrarily decide what it wants to do when it

Re: svn commit: r326758 - in head/sys/i386: conf include

On 12 Dec, Eugene Grosbein wrote: > Now I run FreeBSD 11/i386 as my home router with IPSEC and torrent > client, and I run several virtualized routers with IPSEC tunnels, > jabber and mail server, squid and ZFS for src/obj/ports compression > and they all easily crash unless kern.kstack_pages

Re: svn commit: r326376 - head/sys/kern

On 29 Nov, Cy Schubert wrote: > In message <201711292328.vatnseom046...@repo.freebsd.org>, Hans Petter > Selasky > writes: >> Author: hselasky >> Date: Wed Nov 29 23:28:40 2017 >> New Revision: 326376 >> URL: https://svnweb.freebsd.org/changeset/base/326376 >> >> Log: >> The sched_add()

Re: svn commit: r325404 - head/share/mk

On 4 Nov, Bryan Drewery wrote: > On 11/4/2017 3:30 PM, Cy Schubert wrote: >> In message <0fc7e918-dcf8-0197-6b50-5936dee23...@freebsd.org>, Bryan >> Drewery wr >> ites: >>> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >>> --dokLDw6wDnv1gUfKm3uwMSMnWeibN2RaD >>> Content-Type:

svn commit: r325008 - head/sys/netpfil/ipfw

Author: truckman Date: Thu Oct 26 10:11:35 2017 New Revision: 325008 URL: https://svnweb.freebsd.org/changeset/base/325008 Log: Fix Dummynet AQM packet marking function ecn_mark() and fq_codel / fq_pie schedulers packet classification functions in layer2 (bridge mode). Dummynet AQM

Re: svn commit: r324313 - head/sys/amd64/amd64

On 8 Oct, Konstantin Belousov wrote: > On Sat, Oct 07, 2017 at 01:54:05PM -0700, Don Lewis wrote: >> On 7 Oct, Konstantin Belousov wrote: >> > On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote: >> >> On 5 Oct, Konstantin Belousov wrote: >> >> &g

Re: svn commit: r324313 - head/sys/amd64/amd64

On 7 Oct, Konstantin Belousov wrote: > On Sat, Oct 07, 2017 at 01:04:09PM -0700, Don Lewis wrote: >> On 5 Oct, Konstantin Belousov wrote: >> > Author: kib >> > Date: Thu Oct 5 12:50:03 2017 >> > New Revision: 324313 >> > URL: https://svnweb.fre

Re: svn commit: r324313 - head/sys/amd64/amd64

On 5 Oct, Konstantin Belousov wrote: > Author: kib > Date: Thu Oct 5 12:50:03 2017 > New Revision: 324313 > URL: https://svnweb.freebsd.org/changeset/base/324313 > > Log: > Avoid a race betweem freeing LDT and context switches. > > cpu_switch.S uses curproc->p_md.md_ldt value as the flag

svn commit: r321899 - in head/sys/amd64: amd64 include linux

Author: truckman Date: Wed Aug 2 01:43:35 2017 New Revision: 321899 URL: https://svnweb.freebsd.org/changeset/base/321899 Log: Lower the amd64 shared page, which contains the signal trampoline, from the top of user memory to one page lower on machines with the Ryzen (AMD Family 17h) CPU.

Re: svn commit: r318441 - in head/etc: . cron.d

On 3 Jun, Rodney W. Grimes wrote: > As far as fixing the builds for optional stuff that is rather > easily done in the Makefile with some if's to build a list of > files that can then be catted to conf.foo, using m4 or even > cpp to pre process conf.foo.src, etc, several very easy ways > to

svn commit: r318527 - head/sys/netpfil/ipfw

Author: truckman Date: Fri May 19 08:38:03 2017 New Revision: 318527 URL: https://svnweb.freebsd.org/changeset/base/318527 Log: Fix the queue delay estimation in PIE/FQ-PIE when the timestamp (TS) method is used. When packet timestamp is used, the "current_qdelay" keeps storing the last

svn commit: r318511 - head/sys/netpfil/ipfw

Author: truckman Date: Fri May 19 01:23:06 2017 New Revision: 318511 URL: https://svnweb.freebsd.org/changeset/base/318511 Log: The result of right shifting a negative signed value is implementation defined. On machines without arithmetic shift instructions, zero bits may be shifted in

svn commit: r315516 - head/sys/netpfil/ipfw

Author: truckman Date: Sat Mar 18 23:00:13 2017 New Revision: 315516 URL: https://svnweb.freebsd.org/changeset/base/315516 Log: Change several constants used by the PIE algorithm from unsigned to signed. - PIE_MAX_PROB is compared to variable of int64_t and the type promotion rules

Re: svn commit: r285050 - in head: lib/libutil usr.sbin/pwd_mkdb

On 13 Oct, Alan Somers wrote: > On Thu, Jul 2, 2015 at 11:31 AM, Renato Botelho wrote: >> Author: garga (ports committer) >> Date: Thu Jul 2 17:30:59 2015 >> New Revision: 285050 >> URL: https://svnweb.freebsd.org/changeset/base/285050 >> >> Log: >> When passwd or group

svn commit: r302667 - head/sys/netpfil/ipfw

Author: truckman Date: Tue Jul 12 17:32:40 2016 New Revision: 302667 URL: https://svnweb.freebsd.org/changeset/base/302667 Log: Fix problems in the FQ-PIE AQM cleanup code that could leak memory or cause a crash. Because dummynet calls pie_cleanup() while holding a mutex, pie_cleanup()

svn commit: r302338 - head/sys/netpfil/ipfw

Author: truckman Date: Tue Jul 5 00:53:01 2016 New Revision: 302338 URL: https://svnweb.freebsd.org/changeset/base/302338 Log: Fix a race condition between the main thread in aqm_pie_cleanup() and the callout thread that can cause a kernel panic. Always do the final cleanup in the callout

svn commit: r301596 - head/lib/libc/gen

Author: truckman Date: Wed Jun 8 10:25:16 2016 New Revision: 301596 URL: https://svnweb.freebsd.org/changeset/base/301596 Log: Don't leak olinep if malloc() fails. If malloc() fails to allocate linep, then free olinep (if it exists) before returning to avoid a memory leak. Reported

svn commit: r301592 - head/lib/libc/resolv

Author: truckman Date: Wed Jun 8 09:40:06 2016 New Revision: 301592 URL: https://svnweb.freebsd.org/changeset/base/301592 Log: Don't leak addrinfo if ai->ai_addrlen <= minsiz test fails. If the ai->ai_addrlen <= minsiz test fails, then freeaddrinfo() does not get called to free the

svn commit: r301582 - head/bin/setfacl

Author: truckman Date: Wed Jun 8 05:32:39 2016 New Revision: 301582 URL: https://svnweb.freebsd.org/changeset/base/301582 Log: Explicitly NUL terminate the buffer filled by fread(). The fix in r300649 was not sufficient to convince Coverity that the buffer was NUL terminated, even with

svn commit: r301574 - head/usr.bin/random

Author: truckman Date: Wed Jun 8 02:14:05 2016 New Revision: 301574 URL: https://svnweb.freebsd.org/changeset/base/301574 Log: Fix a (false positive?) Argument cannot be negative coverity defect. Rather than guarding close(fd) with an fd >= 0 test and setting fd to -1 when it is closed

Re: svn commit: r301546 - head/release/doc/en_US.ISO8859-1/relnotes

On 7 Jun, Steven Kreuzer wrote: > Author: skreuzer (doc,ports committer) > Date: Tue Jun 7 14:11:15 2016 > New Revision: 301546 > URL: https://svnweb.freebsd.org/changeset/base/301546 > > Log: > Document 300779, Dummynet AQM version 0.2.1 > > Approved by:re (gjb, implicit,

svn commit: r301180 - head/sbin/ipfw

Author: truckman Date: Thu Jun 2 00:42:15 2016 New Revision: 301180 URL: https://svnweb.freebsd.org/changeset/base/301180 Log: Belatedly bump .Dd date for Dummynet AQM import in r300779. Modified: head/sbin/ipfw/ipfw.8 Modified: head/sbin/ipfw/ipfw.8

svn commit: r301162 - head/sys/netpfil/ipfw

Author: truckman Date: Wed Jun 1 20:04:24 2016 New Revision: 301162 URL: https://svnweb.freebsd.org/changeset/base/301162 Log: Replace constant expressions that contain multiplications by fractional floating point values with integer divides. This will eliminate any chance that the

Re: svn commit: r301139 - head/bin/sh

On 1 Jun, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Wed Jun 1 16:56:29 2016 > New Revision: 301139 > URL: https://svnweb.freebsd.org/changeset/base/301139 > > Log: > The (i < PROMPTLEN - 1) test added by r300442 in the code for the default > case of \c in the prompt

svn commit: r301139 - head/bin/sh

Author: truckman Date: Wed Jun 1 16:56:29 2016 New Revision: 301139 URL: https://svnweb.freebsd.org/changeset/base/301139 Log: The (i < PROMPTLEN - 1) test added by r300442 in the code for the default case of \c in the prompt format string is a no-op. We already passed this test at the

Re: svn commit: r300949 - head/sys/netpfil/ipfw

On 29 May, Bruce Evans wrote: > On Sun, 29 May 2016, Don Lewis wrote: > >> Log: >> Cast some expressions that multiply a long long constant by a >> floating point constant to int64_t. This avoids the runtime >> conversion of the the other operand in a set o

svn commit: r300950 - in head/sys: conf modules/dummynet

Author: truckman Date: Sun May 29 07:29:35 2016 New Revision: 300950 URL: https://svnweb.freebsd.org/changeset/base/300950 Log: Now that PIE is free of runtime floating point, revert r300853 to reconnect PIE to the build. Modified: head/sys/conf/files head/sys/modules/dummynet/Makefile

svn commit: r300949 - head/sys/netpfil/ipfw

Author: truckman Date: Sun May 29 07:23:56 2016 New Revision: 300949 URL: https://svnweb.freebsd.org/changeset/base/300949 Log: Cast some expressions that multiply a long long constant by a floating point constant to int64_t. This avoids the runtime conversion of the the other operand in a

svn commit: r300853 - in head/sys: conf modules/dummynet

Author: truckman Date: Fri May 27 17:07:07 2016 New Revision: 300853 URL: https://svnweb.freebsd.org/changeset/base/300853 Log: Disconnect PIE from the build until it is free of floating point math. Reported by: lidl, adrian Modified: head/sys/conf/files

Re: svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

On 27 May, Adrian Chadd wrote: > Hi, > > Did this introduce floating point into the kernel? Cr*p, it did. It looks fixable, but I'll disconnect PIE from the build for now. ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

On 26 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Thu May 26 21:40:13 2016 > New Revision: 300779 > URL: https://svnweb.freebsd.org/changeset/base/300779 > > Log: > Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). > > Centre for Advanced

svn commit: r300784 - head/sys/conf

Author: truckman Date: Thu May 26 22:07:09 2016 New Revision: 300784 URL: https://svnweb.freebsd.org/changeset/base/300784 Log: Include the new AQM files when compiling a kernel with options DUMMYNET. Reported by: Nikolay Denev MFC after:2 weeks (with r300779) Modified:

svn commit: r300783 - head/sys/netpfil/ipfw

Author: truckman Date: Thu May 26 22:03:28 2016 New Revision: 300783 URL: https://svnweb.freebsd.org/changeset/base/300783 Log: Correct a typo in a comment. MFC after:2 weeks (with r300779) Modified: head/sys/netpfil/ipfw/dn_aqm.h Modified: head/sys/netpfil/ipfw/dn_aqm.h

svn commit: r300781 - head/sys/netpfil/ipfw

Author: truckman Date: Thu May 26 21:44:52 2016 New Revision: 300781 URL: https://svnweb.freebsd.org/changeset/base/300781 Log: Modify BOUND_VAR() macro to wrap all of its arguments in () and tweak its expression to work on powerpc and sparc64 (gcc compatibility). Correct a typo in a

svn commit: r300779 - in head: sbin/ipfw sys/modules/dummynet sys/netinet sys/netpfil/ipfw

Author: truckman Date: Thu May 26 21:40:13 2016 New Revision: 300779 URL: https://svnweb.freebsd.org/changeset/base/300779 Log: Import Dummynet AQM version 0.2.1 (CoDel, FQ-CoDel, PIE and FQ-PIE). Centre for Advanced Internet Architectures Implementing AQM in FreeBSD * Overview

svn commit: r300706 - head/usr.sbin/tzsetup

Author: truckman Date: Thu May 26 01:45:04 2016 New Revision: 300706 URL: https://svnweb.freebsd.org/changeset/base/300706 Log: Avoid buffer overflow or truncation when constructing path_zoneinfo_file. Reported by: Coverity CID: 1011160 MFC after:1 week Modified:

svn commit: r300705 - head/usr.bin/fortune/unstr

Author: truckman Date: Thu May 26 01:33:24 2016 New Revision: 300705 URL: https://svnweb.freebsd.org/changeset/base/300705 Log: Avoid buffer overflow when copying the input file name and appending .dat. Check the return value from fread() to be sure that it was successful. Reported

svn commit: r300692 - head/bin/ed

Author: truckman Date: Wed May 25 18:38:30 2016 New Revision: 300692 URL: https://svnweb.freebsd.org/changeset/base/300692 Log: Close the input FILE * in read_file() and the output FILE * in write_file() if read_stream() or write_stream() fails to avoid leaking the FILE. Reported by:

Re: svn commit: r300686 - head/sbin/camcontrol

On 25 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Wed May 25 15:49:29 2016 > New Revision: 300686 > URL: https://svnweb.freebsd.org/changeset/base/300686 > > Log: > Fix a couple of Coverity Unintended sign extension sign extension > defects. When shifting an

Re: svn commit: r300685 - head/sbin/camcontrol

On 25 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Wed May 25 15:43:01 2016 > New Revision: 300685 > URL: https://svnweb.freebsd.org/changeset/base/300685 > > Log: > Fix a couple of new instances of a false positive Coverity buffer > overflow defect. Use the new

svn commit: r300686 - head/sbin/camcontrol

Author: truckman Date: Wed May 25 15:49:29 2016 New Revision: 300686 URL: https://svnweb.freebsd.org/changeset/base/300686 Log: Fix a couple of Coverity Unintended sign extension sign extension defects. When shifting an unsigned byte into the upper 8 bits of an int and the resulting value

svn commit: r300685 - head/sbin/camcontrol

Author: truckman Date: Wed May 25 15:43:01 2016 New Revision: 300685 URL: https://svnweb.freebsd.org/changeset/base/300685 Log: Fix a couple of new instances of a false positive Coverity buffer overflow defect. Use the new CCB_CLEAR_ALL_EXCEPT_HDR() macro instead of the calling bzero() on

svn commit: r300666 - head/lib/libfetch

Author: truckman Date: Wed May 25 07:43:32 2016 New Revision: 300666 URL: https://svnweb.freebsd.org/changeset/base/300666 Log: Call closedir() before returning from fetchListFile() to avoid a leak. Reported by: Coverity CID: 1016697 MFC after:1 week Modified:

svn commit: r300665 - head/lib/libfetch

Author: truckman Date: Wed May 25 07:39:48 2016 New Revision: 300665 URL: https://svnweb.freebsd.org/changeset/base/300665 Log: Don't leak addrinfo in fetch_bind() Reported by: Coverity CID: 1225038 MFC after:1 week Modified: head/lib/libfetch/common.c Modified:

svn commit: r300664 - head/lib/libcompat/4.3

Author: truckman Date: Wed May 25 07:26:22 2016 New Revision: 300664 URL: https://svnweb.freebsd.org/changeset/base/300664 Log: Fix Coverity CID 978183 Resource leak in rexec(). Close the socket if connect() fails to avoid leaking it. Reported by: Coverity CID: 978183

svn commit: r300662 - head/lib/libc/gen

Author: truckman Date: Wed May 25 07:13:53 2016 New Revision: 300662 URL: https://svnweb.freebsd.org/changeset/base/300662 Log: Fix Coverity CID 1016714 Resource leak in process_file_actions_entry() Don't leak a file descriptor of _dup2() fails (shouldn't happen). Reported by:

svn commit: r300660 - head/lib/libc/gen

Author: truckman Date: Wed May 25 06:55:53 2016 New Revision: 300660 URL: https://svnweb.freebsd.org/changeset/base/300660 Log: Fix 1016718 Resource leak. Don't leak a file descriptor if fchdir() fails. Reported by: Coverity CID: 1016718 MFC after:1 week Modified:

svn commit: r300649 - head/bin/setfacl

Author: truckman Date: Wed May 25 05:20:34 2016 New Revision: 300649 URL: https://svnweb.freebsd.org/changeset/base/300649 Log: Fix Coverity CID 1019054 (String not null terminated) in setfacl. Increase the size of buf[] by one to allow room for a NUL character at the end. Reported

svn commit: r300648 - head/bin/ps

Author: truckman Date: Wed May 25 05:12:56 2016 New Revision: 300648 URL: https://svnweb.freebsd.org/changeset/base/300648 Log: Fix CID 1011370 (Resource leak) in ps. There is no need to to call strdup() on the value returned by fmt(). The latter calls fmt_argv() which always returns a

svn commit: r300643 - head/bin/mv

Author: truckman Date: Wed May 25 02:51:15 2016 New Revision: 300643 URL: https://svnweb.freebsd.org/changeset/base/300643 Log: Close from_fd if malloc() fails to avoid a file descriptor leak. Reported by: Coverity CID: 1007203 MFC after:1 week Modified:

svn commit: r300642 - head/bin/sh

Author: truckman Date: Wed May 25 02:10:30 2016 New Revision: 300642 URL: https://svnweb.freebsd.org/changeset/base/300642 Log: Match the descriptions of the \H and \h prompt string sequences to reality. They were swapped. X-Confirmed by: jilles MFC after:1 week Modified:

svn commit: r300639 - head/usr.sbin/ypldap

Author: truckman Date: Wed May 25 01:37:25 2016 New Revision: 300639 URL: https://svnweb.freebsd.org/changeset/base/300639 Log: Fix Coverity CIDs 1340544 Resource leak and 1340543 Use after free At line 479 of ldapclient.c in client_build_req(), the error return leaks ldap_attrs (CID

svn commit: r300636 - head/usr.sbin/ypserv

Author: truckman Date: Wed May 25 00:25:38 2016 New Revision: 300636 URL: https://svnweb.freebsd.org/changeset/base/300636 Log: Delay calling yp_malloc_dnsent() until after some additional sanity checks to avoid leaking memory on error returns. Reported by: Coverity CID:

svn commit: r300635 - head/usr.sbin/ypserv

Author: truckman Date: Wed May 25 00:16:52 2016 New Revision: 300635 URL: https://svnweb.freebsd.org/changeset/base/300635 Log: Call free(cur) if strdup(dirp->d_name) fails to avoid a memory leak. Reported by: Coverity CID: 1007414 MFC after:1 week Modified:

svn commit: r300633 - head/usr.sbin/acpi/acpidb

Author: truckman Date: Tue May 24 23:41:36 2016 New Revision: 300633 URL: https://svnweb.freebsd.org/changeset/base/300633 Log: Fix acpidb CIDs 1011279 (Buffer not null terminated) and 978405 and 1199380 (Resource leak). load_dsdt() calls strncpy() to copy a filename and Coverity warns

svn commit: r300632 - head/usr.sbin/acpi/acpidump

Author: truckman Date: Tue May 24 23:36:43 2016 New Revision: 300632 URL: https://svnweb.freebsd.org/changeset/base/300632 Log: Fix acpidump CID 1011278 (Buffer not null terminated) and other issues Coverity reports that a buffer used for temporary file generation might not be NUL

svn commit: r300564 - head/usr.sbin/pw

Author: truckman Date: Tue May 24 05:02:24 2016 New Revision: 300564 URL: https://svnweb.freebsd.org/changeset/base/300564 Log: Fix CID 1006692 in /usr/sbin/pw pw_log() function and other fixes The length of the name returned from the $LOGNAME and $USER can be very long and it was being

Re: svn commit: r300547 - in head: lib/libcam sbin/camcontrol sbin/iscontrol sys/cam usr.sbin/camdd usr.sbin/mptutil

On 24 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Tue May 24 00:57:11 2016 > New Revision: 300547 > URL: https://svnweb.freebsd.org/changeset/base/300547 > > Log: > Fix multiple Coverity Out-of-bounds access false postive issues in CAM > > The currently used idiom

svn commit: r300547 - in head: lib/libcam sbin/camcontrol sbin/iscontrol sys/cam usr.sbin/camdd usr.sbin/mptutil

Author: truckman Date: Tue May 24 00:57:11 2016 New Revision: 300547 URL: https://svnweb.freebsd.org/changeset/base/300547 Log: Fix multiple Coverity Out-of-bounds access false postive issues in CAM The currently used idiom for clearing the part of a ccb after its header generates one or

svn commit: r300442 - head/bin/sh

Author: truckman Date: Mon May 23 01:01:23 2016 New Revision: 300442 URL: https://svnweb.freebsd.org/changeset/base/300442 Log: Hopefully fix Coverity CID 1008328 (Out-of-bounds write) in /bin/sh. Replace the magic constant 127 in the loop interation count with "PROMPTLEN - 1".

Re: svn commit: r300240 - head/sys/netinet

On 19 May, Ngie Cooper wrote: > On Thu, May 19, 2016 at 3:20 PM, Don Lewis <truck...@freebsd.org> wrote: >> Author: truckman >> Date: Thu May 19 22:20:35 2016 >> New Revision: 300240 >> URL: https://svnweb.freebsd.org/changeset/base/300240 >> >> Log: &

svn commit: r300247 - head/share/man/man4

Author: truckman Date: Thu May 19 23:03:07 2016 New Revision: 300247 URL: https://svnweb.freebsd.org/changeset/base/300247 Log: Document new net.inet.tcp.ecn.enable sysctl settings. MFC after:1 month (with r300240) Modified: head/share/man/man4/tcp.4 Modified:

svn commit: r300240 - head/sys/netinet

Author: truckman Date: Thu May 19 22:20:35 2016 New Revision: 300240 URL: https://svnweb.freebsd.org/changeset/base/300240 Log: Change net.inet.tcp.ecn.enable sysctl mib from a binary off/on control to a three way setting. 0 - Totally disable ECN. (no change) 1 - Enable ECN if

Re: svn commit: r300174 - head/sbin/dhclient

On 18 May, Conrad E. Meyer wrote: > Author: cem > Date: Wed May 18 23:41:55 2016 > New Revision: 300174 > URL: https://svnweb.freebsd.org/changeset/base/300174 > > Log: > dhclient: Fix the trivial buffer overruns correctly > > A DHCP client identifier is simply the hardware type (one byte)

Re: svn commit: r300005 - head/usr.bin/ncal

On 16 May, To: c...@freebsd.org wrote: > On 16 May, Conrad Meyer wrote: >> On Mon, May 16, 2016 at 10:05 PM, Don Lewis <truck...@freebsd.org> wrote: >>> Author: truckman >>> Date: Tue May 17 05:05:30 2016 >>> New Revision: 35 >>> UR

svn commit: r300005 - head/usr.bin/ncal

Author: truckman Date: Tue May 17 05:05:30 2016 New Revision: 35 URL: https://svnweb.freebsd.org/changeset/base/35 Log: swprintf() and apparently wcsftime() want the their output buffer size specified in terms of the the number of wide characters and not sizeof(buffer).

svn commit: r300002 - head/usr.sbin/rarpd

Author: truckman Date: Tue May 17 04:03:45 2016 New Revision: 32 URL: https://svnweb.freebsd.org/changeset/base/32 Log: When clearing rtmsg, pass to bzero() instead of the address of just the header Reported by: Coverity CID: 1007568, 1194256 MFC after:1 week

svn commit: r299991 - head/usr.sbin/ppp

Author: truckman Date: Mon May 16 23:47:08 2016 New Revision: 21 URL: https://svnweb.freebsd.org/changeset/base/21 Log: Don't walk off the end of the array when proto isn't explicitly listed above. Instead update the catch-all "Others" bucket. Reported by: Coverity CID:

svn commit: r299988 - head/usr.sbin/rpc.statd

Author: truckman Date: Mon May 16 23:29:04 2016 New Revision: 299988 URL: https://svnweb.freebsd.org/changeset/base/299988 Log: Set ai2 to NULL in in find_host() before the loop and after calling freeaddrinfo() on it to indicate that it doesn't point to a valid addrinfo list. This fixes

svn commit: r299986 - head/usr.sbin/rpc.lockd

Author: truckman Date: Mon May 16 23:00:48 2016 New Revision: 299986 URL: https://svnweb.freebsd.org/changeset/base/299986 Log: Actually use the loop interation limit so carefully computed on the previous line to prevent buffer overflow. This turns out to not be important because the

svn commit: r299971 - head/usr.bin/chat

Author: truckman Date: Mon May 16 19:48:02 2016 New Revision: 299971 URL: https://svnweb.freebsd.org/changeset/base/299971 Log: Fix off by one error that overflowed the rep_len array when doing the final NUL termination. Reported by: Coverity CID: 1007617 MFC after:1

Re: svn commit: r299953 - head/usr.sbin/makefs

On 16 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Mon May 16 16:16:46 2016 > New Revision: 299953 > URL: https://svnweb.freebsd.org/changeset/base/299953 > > Log: > Fix an off by one error to avoid overflowing rp[]. > > Reported by:Coverity > CID:

svn commit: r299953 - head/usr.sbin/makefs

Author: truckman Date: Mon May 16 16:16:46 2016 New Revision: 299953 URL: https://svnweb.freebsd.org/changeset/base/299953 Log: Fix an off by one error to avoid overflowing rp[]. Reported by: Coverity CID: 1007579 Modified: head/usr.sbin/makefs/mtree.c Modified:

svn commit: r299952 - head/usr.bin/ldd

Author: truckman Date: Mon May 16 16:01:46 2016 New Revision: 299952 URL: https://svnweb.freebsd.org/changeset/base/299952 Log: Increase size of argv[] array to avoid running off the end. Reported by: Coverity CID: 1193819 MFC after:1 week Modified:

Re: svn commit: r299926 - head/lib/libpam/modules/pam_unix

On 16 May, Ed Maste wrote: > On 16 May 2016 at 04:34, Don Lewis <truck...@freebsd.org> wrote: >> Author: truckman >> Date: Mon May 16 08:34:17 2016 >> New Revision: 299926 >> URL: https://svnweb.freebsd.org/changeset/base/299926 >> >> Log: >>

svn commit: r299948 - head/lib/libpam/modules/pam_unix

Author: truckman Date: Mon May 16 15:32:02 2016 New Revision: 299948 URL: https://svnweb.freebsd.org/changeset/base/299948 Log: Set retval in the empty password case to avoid a path through the code that fails to set retval before falling through to the final return(). Reported by:

svn commit: r299926 - head/lib/libpam/modules/pam_unix

Author: truckman Date: Mon May 16 08:34:17 2016 New Revision: 299926 URL: https://svnweb.freebsd.org/changeset/base/299926 Log: Hoist the getpwnam() call outside the first if/else block in pam_sm_chauthtok(). Set user = getlogin() inside the true branch so that it is initialized for the

Re: svn commit: r299922 - head/lib/libc/net

On 16 May, To: src-committ...@freebsd.org wrote: > Author: truckman > Date: Mon May 16 08:13:30 2016 > New Revision: 299922 > URL: https://svnweb.freebsd.org/changeset/base/299922 > > Log: > Don't call free_addrselectpolicy() before policyhead has been > initialized. > > Reported by:

svn commit: r299922 - head/lib/libc/net

Author: truckman Date: Mon May 16 08:13:30 2016 New Revision: 299922 URL: https://svnweb.freebsd.org/changeset/base/299922 Log: Don't call free_addrselectpolicy() before policyhead has been initialized. Reported by: Coverity CID: 1018727 Modified: head/lib/libc/net/name6.c

svn commit: r299921 - head/sbin/ifconfig

Author: truckman Date: Mon May 16 08:07:32 2016 New Revision: 299921 URL: https://svnweb.freebsd.org/changeset/base/299921 Log: Add an assertion to catch a potential underflow in an array index calculation, though this should not happen in the current code. Reported by: Coverity CID:

svn commit: r299897 - head/usr.sbin/rpc.lockd

Author: truckman Date: Mon May 16 05:17:43 2016 New Revision: 299897 URL: https://svnweb.freebsd.org/changeset/base/299897 Log: NULL releasedfl after calling deallocate_file_lock() which frees it to avoid a use-after-free error in the debuglog() call at the top of the loop. Reported

  1   2   >