svn commit: r368657 - head/libexec/tftpd

2020-12-15 Thread Michael Tuexen
Author: tuexen Date: Tue Dec 15 09:43:18 2020 New Revision: 368657 URL: https://svnweb.freebsd.org/changeset/base/368657 Log: When receiving a file having a length, which is a mulitple of the blocksize, close the file once it is received. Reported by: Timo Voelker MFC after:1 week

svn commit: r368647 - head/libexec/tftpd

2020-12-14 Thread Michael Tuexen
Author: tuexen Date: Mon Dec 14 22:13:58 2020 New Revision: 368647 URL: https://svnweb.freebsd.org/changeset/base/368647 Log: Improve the counting of blocks used to transfer a file from the server to the client in case of not using an OACK: Don't miss the first block in case of it is not

svn commit: r368622 - head/sys/netinet

2020-12-13 Thread Michael Tuexen
Author: tuexen Date: Sun Dec 13 23:51:51 2020 New Revision: 368622 URL: https://svnweb.freebsd.org/changeset/base/368622 Log: Harden the handling of outgoing streams in case of an restart or INIT collision. This avouds an out-of-bounce access in case the peer can break the cookie signature.

svn commit: r368593 - head/sys/netinet

2020-12-12 Thread Michael Tuexen
Author: tuexen Date: Sat Dec 12 22:23:45 2020 New Revision: 368593 URL: https://svnweb.freebsd.org/changeset/base/368593 Log: Clean up more resouces of an existing SCTP association in case of a restart. This fixes a use-after-free scenario, which was reported by Felix Wilhelm from

svn commit: r368521 - head/libexec/tftpd

2020-12-10 Thread Michael Tuexen
Author: tuexen Date: Thu Dec 10 19:36:33 2020 New Revision: 368521 URL: https://svnweb.freebsd.org/changeset/base/368521 Log: Fix the TFTP client when performing a RRQ for files smaller than 512 bytes and the server not sending an OACK: * Close the file. * Report the correct the number of

svn commit: r368394 - head/libexec/tftpd

2020-12-06 Thread Michael Tuexen
Author: tuexen Date: Sun Dec 6 18:43:12 2020 New Revision: 368394 URL: https://svnweb.freebsd.org/changeset/base/368394 Log: When dropping packets (RRQ or WRQ) for debugging, report the send operation as successful. Reporting a failure stops the transfer instead of using timeouts. MFC

Re: svn commit: r368163 - in head: sbin/ifconfig sys/dev/if_wg sys/dev/if_wg/include sys/dev/if_wg/include/crypto sys/dev/if_wg/include/sys sys/dev/if_wg/include/zinc sys/dev/if_wg/module sys/dev/if_w

2020-11-30 Thread Michael Tuexen
> On 29. Nov 2020, at 20:38, Matt Macy wrote: > > Author: mmacy > Date: Sun Nov 29 19:38:03 2020 > New Revision: 368163 > URL: https://svnweb.freebsd.org/changeset/base/368163 > > Log: > Import kernel WireGuard support > > Data path largely shared with the OpenBSD implementation by >

Re: svn commit: r368167 - head/sys/dev/nvme

2020-11-30 Thread Michael Tuexen
> On 30. Nov 2020, at 08:01, Michal Meloun wrote: > > Author: mmel > Date: Mon Nov 30 07:01:12 2020 > New Revision: 368167 > URL: https://svnweb.freebsd.org/changeset/base/368167 > > Log: > NVME: Don't try to swap data on little endian machines. > These swapping functions violate BUSDMA

svn commit: r367946 - head/sys/netinet

2020-11-23 Thread Michael Tuexen
Author: tuexen Date: Mon Nov 23 10:13:56 2020 New Revision: 367946 URL: https://svnweb.freebsd.org/changeset/base/367946 Log: Fix two occurences of a typo in a comment introduced in r367530. Reported by: lstewart@ MFC after:1 week Differential Revision:

Re: svn commit: r367530 - in head/sys/netinet: . tcp_stacks

2020-11-20 Thread Michael Tuexen
On 20. Nov 2020, at 00:13, John Baldwin wrote: > > On 11/19/20 2:55 PM, John Baldwin wrote: >> On 11/9/20 1:49 PM, Michael Tuexen wrote: >>> Author: tuexen >>> Date: Mon Nov 9 21:49:40 2020 >>> New Revision: 367530 >>> URL: https://svnweb.freebsd.

svn commit: r367891 - head/sys/netinet

2020-11-20 Thread Michael Tuexen
Author: tuexen Date: Fri Nov 20 13:00:28 2020 New Revision: 367891 URL: https://svnweb.freebsd.org/changeset/base/367891 Log: Fix an issue I introuced in r367530: tcp_twcheck() can be called with to == NULL for SYN segments. So don't assume tp != NULL. Thanks to jhb@ for reporting and

Re: svn commit: r367530 - in head/sys/netinet: . tcp_stacks

2020-11-19 Thread Michael Tuexen
> On 20. Nov 2020, at 00:13, John Baldwin wrote: > > On 11/19/20 2:55 PM, John Baldwin wrote: >> On 11/9/20 1:49 PM, Michael Tuexen wrote: >>> Author: tuexen >>> Date: Mon Nov 9 21:49:40 2020 >>> New Revision: 367530 >>> URL: https://sv

svn commit: r367530 - in head/sys/netinet: . tcp_stacks

2020-11-09 Thread Michael Tuexen
Author: tuexen Date: Mon Nov 9 21:49:40 2020 New Revision: 367530 URL: https://svnweb.freebsd.org/changeset/base/367530 Log: RFC 7323 specifies that: * TCP segments without timestamps should be dropped when support for the timestamp option has been negotiated. * TCP segments with

svn commit: r367520 - head/sys/netinet

2020-11-09 Thread Michael Tuexen
Author: tuexen Date: Mon Nov 9 13:12:07 2020 New Revision: 367520 URL: https://svnweb.freebsd.org/changeset/base/367520 Log: Fix a potential use-after-free bug introduced in https://svnweb.freebsd.org/changeset/base/363046 Thanks to Taylor Brandstetter for finding this issue using fuzz

svn commit: r367464 - head/sys/kern

2020-11-07 Thread Michael Tuexen
Author: tuexen Date: Sat Nov 7 21:17:49 2020 New Revision: 367464 URL: https://svnweb.freebsd.org/changeset/base/367464 Log: The ioctl() calls using FIONREAD, FIONWRITE, FIONSPACE, and SIOCATMARK access the socket send or receive buffer. This is not possible for listening sockets since

svn commit: r366750 - head/sys/netinet

2020-10-16 Thread Michael Tuexen
Author: tuexen Date: Fri Oct 16 10:44:48 2020 New Revision: 366750 URL: https://svnweb.freebsd.org/changeset/base/366750 Log: Improve the handling of cookie life times. The staleness reported in an error cause is in us, not ms. Enforce limits on the life time via sysct; and socket options

svn commit: r366517 - head/sys/netinet

2020-10-07 Thread Michael Tuexen
Author: tuexen Date: Wed Oct 7 15:22:48 2020 New Revision: 366517 URL: https://svnweb.freebsd.org/changeset/base/366517 Log: Minor cleanups. MFC after:3 days Modified: head/sys/netinet/sctp_cc_functions.c head/sys/netinet/sctp_output.c Modified:

svn commit: r366489 - head/sys/netinet

2020-10-06 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 6 14:26:05 2020 New Revision: 366489 URL: https://svnweb.freebsd.org/changeset/base/366489 Log: Reset delayed SACK state when restarting an SCTP association. MFC after:3 days Modified: head/sys/netinet/sctp_input.c Modified:

svn commit: r366483 - head/sys/netinet

2020-10-06 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 6 11:29:08 2020 New Revision: 366483 URL: https://svnweb.freebsd.org/changeset/base/366483 Log: Ensure variables are initialized before used. MFC after:3 days Modified: head/sys/netinet/sctp_input.c head/sys/netinet/sctp_pcb.c Modified:

svn commit: r366482 - head/sys/netinet

2020-10-06 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 6 11:08:52 2020 New Revision: 366482 URL: https://svnweb.freebsd.org/changeset/base/366482 Log: Remove dead stores reported by clang static code analysis MFC after:3 days Modified: head/sys/netinet/sctp_input.c head/sys/netinet/sctp_output.c

svn commit: r366480 - head/sys/netinet

2020-10-06 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 6 10:41:04 2020 New Revision: 366480 URL: https://svnweb.freebsd.org/changeset/base/366480 Log: Cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r366474 - head/sys/netinet

2020-10-06 Thread Michael Tuexen
Author: tuexen Date: Tue Oct 6 09:51:40 2020 New Revision: 366474 URL: https://svnweb.freebsd.org/changeset/base/366474 Log: Whitespace changes. MFC after:3 days Modified: head/sys/netinet/sctp_input.c Modified: head/sys/netinet/sctp_input.c

svn commit: r366426 - head/sys/netinet

2020-10-04 Thread Michael Tuexen
Author: tuexen Date: Sun Oct 4 15:37:34 2020 New Revision: 366426 URL: https://svnweb.freebsd.org/changeset/base/366426 Log: Use __func__ instead of __FUNCTION__ for consistency. MFC after:3 days Modified: head/sys/netinet/sctp_bsd_addr.c head/sys/netinet/sctp_indata.c

svn commit: r366425 - head/sys/netinet

2020-10-04 Thread Michael Tuexen
Author: tuexen Date: Sun Oct 4 15:22:14 2020 New Revision: 366425 URL: https://svnweb.freebsd.org/changeset/base/366425 Log: Cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_indata.c Modified: head/sys/netinet/sctp_indata.c

Re: svn commit: r366340 - head/sys/kern

2020-10-01 Thread Michael Tuexen
> On 1. Oct 2020, at 21:17, Bryan Drewery wrote: > > Author: bdrewery > Date: Thu Oct 1 19:17:03 2020 > New Revision: 366340 > URL: https://svnweb.freebsd.org/changeset/base/366340 > > Log: > Use unlocked page lookup for inmem() to avoid object lock contention > > Reviewed By: kib, markj >

svn commit: r366248 - head/sys/netinet

2020-09-29 Thread Michael Tuexen
Author: tuexen Date: Tue Sep 29 09:36:06 2020 New Revision: 366248 URL: https://svnweb.freebsd.org/changeset/base/366248 Log: Improve the input validation and processing of cookies. This avoids setting the association in an inconsistent state, which could result in a use-after-free

svn commit: r366226 - head/sys/netinet

2020-09-28 Thread Michael Tuexen
Author: tuexen Date: Mon Sep 28 14:11:53 2020 New Revision: 366226 URL: https://svnweb.freebsd.org/changeset/base/366226 Log: Minor cleanup. MFC after:3 days Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r366199 - head/sys/netinet

2020-09-27 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 27 13:32:02 2020 New Revision: 366199 URL: https://svnweb.freebsd.org/changeset/base/366199 Log: Cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_indata.c Modified: head/sys/netinet/sctp_indata.c

svn commit: r366198 - head/sys/netinet

2020-09-27 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 27 13:24:01 2020 New Revision: 366198 URL: https://svnweb.freebsd.org/changeset/base/366198 Log: Improve the handling of receiving unordered and unreliable user messages using DATA chunks. Don't use fsn_included when not being sure that it is set to an

svn commit: r366114 - head/sys/netinet

2020-09-24 Thread Michael Tuexen
Author: tuexen Date: Thu Sep 24 12:26:06 2020 New Revision: 366114 URL: https://svnweb.freebsd.org/changeset/base/366114 Log: Whitespace changes. MFC after:3 days Modified: head/sys/netinet/sctp_cc_functions.c head/sys/netinet/sctp_header.h head/sys/netinet/sctp_indata.c

svn commit: r365688 - head/usr.bin/netstat

2020-09-13 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 13 09:14:32 2020 New Revision: 365688 URL: https://svnweb.freebsd.org/changeset/base/365688 Log: Add a -C option to netstat to display the congestion control for TCP connections. Reviewed by: rscheff MFC after:1 week Sponsored by:

svn commit: r365687 - head/usr.bin/sockstat

2020-09-13 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 13 09:12:25 2020 New Revision: 365687 URL: https://svnweb.freebsd.org/changeset/base/365687 Log: Add a -C option to sockstat to display the congestion control for TCP connections. Reviewed by: rscheff MFC after:1 week Sponsored by:

svn commit: r365686 - head/sys/netinet

2020-09-13 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 13 09:06:50 2020 New Revision: 365686 URL: https://svnweb.freebsd.org/changeset/base/365686 Log: Export the name of the congestion control. This will be used by sockstat and netstat. Reviewed by: rscheff MFC after:1 week Sponsored by:

svn commit: r365685 - head/usr.sbin/traceroute6

2020-09-13 Thread Michael Tuexen
Author: tuexen Date: Sun Sep 13 09:00:00 2020 New Revision: 365685 URL: https://svnweb.freebsd.org/changeset/base/365685 Log: Add a -t option to traceroute6 to control the traffic class used when sending probe packets. Reviewed by: rscheff MFC after:1 week

svn commit: r365658 - head/usr.sbin/traceroute6

2020-09-12 Thread Michael Tuexen
Author: tuexen Date: Sat Sep 12 11:24:36 2020 New Revision: 365658 URL: https://svnweb.freebsd.org/changeset/base/365658 Log: Fix the length of probe packets when using UDP. Since https://svnweb.freebsd.org/changeset/base/365378 a raw socket is used for sending UDP probe packets instead of

svn commit: r365657 - head/usr.sbin/traceroute6

2020-09-12 Thread Michael Tuexen
Author: tuexen Date: Sat Sep 12 11:19:54 2020 New Revision: 365657 URL: https://svnweb.freebsd.org/changeset/base/365657 Log: Simplify code, no functional change. Since https://svnweb.freebsd.org/base?view=revision=365378 UDP is handled the same way as SCTP and TCP (using a raw socket).

Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgrap

2020-09-02 Thread Michael Tuexen
> On 2. Sep 2020, at 20:28, Pedro Giffuni wrote: > > > On 02/09/2020 13:06, Alexey Dokuchaev wrote: >> On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote: >>> On 01/09/2020 21:05, Alexey Dokuchaev wrote: ... This is common sense. I can't count how often I wanted to hack on

Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgrap

2020-09-02 Thread Michael Tuexen
> On 2. Sep 2020, at 04:05, Alexey Dokuchaev wrote: > > On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote: >>> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote: >>> Author: mjg >>> Date: Tue Sep 1 21:19:14 2020 >>> New Revision: 365071

Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgrap

2020-09-01 Thread Michael Tuexen
> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote: > > Author: mjg > Date: Tue Sep 1 21:19:14 2020 > New Revision: 365071 > URL: https://svnweb.freebsd.org/changeset/base/365071 > > Log: > net: clean up empty lines in .c and .h files Hi Mateusz, which rules are enforced? Why? Best regards

svn commit: r364937 - head/sys/netinet

2020-08-28 Thread Michael Tuexen
Author: tuexen Date: Fri Aug 28 20:05:18 2020 New Revision: 364937 URL: https://svnweb.freebsd.org/changeset/base/364937 Log: Fix a regression with the explicit EOR mode I introduced in r364268. A short MFC time as discussed with the secteam. Reported by: Taylor Brandstetter

svn commit: r364754 - in head/sys/netinet: . tcp_stacks

2020-08-25 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 25 09:42:03 2020 New Revision: 364754 URL: https://svnweb.freebsd.org/changeset/base/364754 Log: RFC 3465 defines a limit L used in TCP slow start for limiting the number of acked bytes as described in Section 2.2 of that document. This patch ensures that this

svn commit: r364353 - head/sys/netinet

2020-08-18 Thread Michael Tuexen
Author: tuexen Date: Tue Aug 18 19:25:03 2020 New Revision: 364353 URL: https://svnweb.freebsd.org/changeset/base/364353 Log: Fix two bugs I introduced in r362563. Found by running syzkaller. MFC after:3 days Modified: head/sys/netinet/sctp_usrreq.c Modified:

svn commit: r364270 - head/sys/netinet

2020-08-16 Thread Michael Tuexen
Author: tuexen Date: Sun Aug 16 13:31:14 2020 New Revision: 364270 URL: https://svnweb.freebsd.org/changeset/base/364270 Log: Remove a line which is needed and was added in https://svnweb.freebsd.org/changeset/base/364268 MFC after:3 days Modified:

svn commit: r364268 - head/sys/netinet

2020-08-16 Thread Michael Tuexen
Author: tuexen Date: Sun Aug 16 11:50:37 2020 New Revision: 364268 URL: https://svnweb.freebsd.org/changeset/base/364268 Log: Improve the handling of concurrent send() calls for SCTP sockets, especially when having the explicit EOR mode enabled. Reported by:

svn commit: r364247 - head/sys/netinet

2020-08-15 Thread Michael Tuexen
Author: tuexen Date: Sat Aug 15 11:22:07 2020 New Revision: 364247 URL: https://svnweb.freebsd.org/changeset/base/364247 Log: Enter epoch earlier. This is needed because we are exiting it also in error cases. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified:

svn commit: r364089 - head/sys/netinet

2020-08-10 Thread Michael Tuexen
Author: tuexen Date: Mon Aug 10 20:24:48 2020 New Revision: 364089 URL: https://svnweb.freebsd.org/changeset/base/364089 Log: Fix the following issues related to the TCP SYN-cache: * Let the accepted TCP/IPv4 socket inherit the configured TTL and TOS value. * Let the accepted TCP/IPv6

svn commit: r364054 - head/sys/netinet

2020-08-08 Thread Michael Tuexen
Author: tuexen Date: Sat Aug 8 19:39:38 2020 New Revision: 364054 URL: https://svnweb.freebsd.org/changeset/base/364054 Log: Improve the ECN negotiation when the TCP SYN-cache is used by making sure that * ECN is disabled if the client sends an non-ECN-setup SYN segment. * ECN is

svn commit: r363456 - head/sys/netinet

2020-07-23 Thread Michael Tuexen
Author: tuexen Date: Thu Jul 23 19:43:49 2020 New Revision: 363456 URL: https://svnweb.freebsd.org/changeset/base/363456 Log: Clear the pointer to the socket when closing it also in case of an ungraceful operation. This fixes a use-after-free bug found and reported by Taylor Brandstetter

svn commit: r363440 - head/sys/netinet

2020-07-22 Thread Michael Tuexen
Author: tuexen Date: Thu Jul 23 01:35:24 2020 New Revision: 363440 URL: https://svnweb.freebsd.org/changeset/base/363440 Log: Detect and handle an invalid reassembly constellation, which results in a memory leak. Thanks to Felix Weinrank for finding this issue using fuzz testing the

svn commit: r363323 - head/sys/netinet

2020-07-19 Thread Michael Tuexen
Author: tuexen Date: Sun Jul 19 12:34:19 2020 New Revision: 363323 URL: https://svnweb.freebsd.org/changeset/base/363323 Log: Add reference counts for inp/stcb/net when timers are running. This avoids a use-after-free reported for the userland stack. Thanks to Taylor Brandstetter for

svn commit: r363309 - head/sys/netinet

2020-07-18 Thread Michael Tuexen
Author: tuexen Date: Sat Jul 18 13:10:02 2020 New Revision: 363309 URL: https://svnweb.freebsd.org/changeset/base/363309 Log: Remove code which is not needed. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r363275 - head/sys/netinet

2020-07-17 Thread Michael Tuexen
Author: tuexen Date: Fri Jul 17 15:09:49 2020 New Revision: 363275 URL: https://svnweb.freebsd.org/changeset/base/363275 Log: Improve the locking of address lists by adding some asserts and rearranging the addition of address such that the lock is not given up during checking and adding.

svn commit: r363256 - head/sys/netinet

2020-07-16 Thread Michael Tuexen
Author: tuexen Date: Thu Jul 16 16:46:24 2020 New Revision: 363256 URL: https://svnweb.freebsd.org/changeset/base/363256 Log: (Re)-allow 0.0.0.0 to be used as an address in connect() for TCP In r361752 an error handling was introduced for using 0.0.0.0 or 255.255.255.255 as the address in

svn commit: r363194 - head/sys/netinet

2020-07-14 Thread Michael Tuexen
Author: tuexen Date: Tue Jul 14 20:32:50 2020 New Revision: 363194 URL: https://svnweb.freebsd.org/changeset/base/363194 Log: Improve the error handling in generating ASCONF chunks. In case of errors, the cleanup was not consistent. Thanks to Felix Weinrank for fuzzing the userland stack

svn commit: r363133 - head/sys/netinet

2020-07-12 Thread Michael Tuexen
Author: tuexen Date: Sun Jul 12 18:34:09 2020 New Revision: 363133 URL: https://svnweb.freebsd.org/changeset/base/363133 Log: Cleanup, no functional change intended. This file is only compiled if INET or INET6 is defined. So there is no need for checking that. Reviewed by:

svn commit: r363129 - head/sys/netinet

2020-07-12 Thread Michael Tuexen
Author: tuexen Date: Sun Jul 12 14:50:12 2020 New Revision: 363129 URL: https://svnweb.freebsd.org/changeset/base/363129 Log: (Re)activate SCTP system calls when compiling SCTP support into the kernel r363079 introduced the possibility of loading the SCTP stack as a module in addition to

svn commit: r363080 - head/sys/netinet

2020-07-10 Thread Michael Tuexen
Author: tuexen Date: Fri Jul 10 16:59:06 2020 New Revision: 363080 URL: https://svnweb.freebsd.org/changeset/base/363080 Log: Whitespace changes due to upstreaming r363079. Modified: head/sys/netinet/sctp_os_bsd.h head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_os_bsd.h

svn commit: r363076 - head/sys/netinet

2020-07-10 Thread Michael Tuexen
Author: tuexen Date: Fri Jul 10 11:15:10 2020 New Revision: 363076 URL: https://svnweb.freebsd.org/changeset/base/363076 Log: Fix a use-after-free bug for the userland stack. The kernel stack is not affected. Thanks to Mark Wodrich from Google for finding and reporting the bug. MFC

svn commit: r363046 - head/sys/netinet

2020-07-09 Thread Michael Tuexen
Author: tuexen Date: Thu Jul 9 16:18:42 2020 New Revision: 363046 URL: https://svnweb.freebsd.org/changeset/base/363046 Log: Optimize flushing of receive queues. This addresses an issue found and reported for the userland stack in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21243

svn commit: r363012 - head/sys/netinet

2020-07-08 Thread Michael Tuexen
Author: tuexen Date: Wed Jul 8 16:23:40 2020 New Revision: 363012 URL: https://svnweb.freebsd.org/changeset/base/363012 Log: Improve consistency. MFC after:1 week Modified: head/sys/netinet/sctp_input.c Modified: head/sys/netinet/sctp_input.c

svn commit: r363011 - head/sys/netinet

2020-07-08 Thread Michael Tuexen
Author: tuexen Date: Wed Jul 8 16:04:06 2020 New Revision: 363011 URL: https://svnweb.freebsd.org/changeset/base/363011 Log: Fix error description. MFC after:1 week Modified: head/sys/netinet/sctp_indata.c Modified: head/sys/netinet/sctp_indata.c

svn commit: r363010 - head/sys/netinet

2020-07-08 Thread Michael Tuexen
Author: tuexen Date: Wed Jul 8 15:49:30 2020 New Revision: 363010 URL: https://svnweb.freebsd.org/changeset/base/363010 Log: Don't accept FORWARD-TSN chunks when I-FORWARD-TSN was negotiated and vice versa. MFC after:1 week Modified: head/sys/netinet/sctp_input.c

svn commit: r363008 - head/sys/netinet

2020-07-08 Thread Michael Tuexen
Author: tuexen Date: Wed Jul 8 12:25:19 2020 New Revision: 363008 URL: https://svnweb.freebsd.org/changeset/base/363008 Log: Improve handling of PKTDROP chunks. This includes the input validation to address two issues found by ossfuzz testing the userland stack: *

svn commit: r362846 - head/sys/netinet/tcp_stacks

2020-07-01 Thread Michael Tuexen
Author: tuexen Date: Wed Jul 1 17:17:06 2020 New Revision: 362846 URL: https://svnweb.freebsd.org/changeset/base/362846 Log: Fix the cleanup handling in a error path for TCP BBR. Reported by: syzbot+df7899c55c4cc52f5...@syzkaller.appspotmail.com Reviewed by: rscheff

svn commit: r362813 - head/sys/netinet

2020-06-30 Thread Michael Tuexen
Author: tuexen Date: Tue Jun 30 21:50:05 2020 New Revision: 362813 URL: https://svnweb.freebsd.org/changeset/base/362813 Log: Fix a bug introduced in https://svnweb.freebsd.org/changeset/base/362173 Reported by: syzbot+f3a6fccfa6ae9d3de...@syzkaller.appspotmail.com MFC after:

svn commit: r362722 - head/sys/netinet

2020-06-28 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 28 14:11:36 2020 New Revision: 362722 URL: https://svnweb.freebsd.org/changeset/base/362722 Log: Don't send packets containing ERROR chunks in response to unknown chunks when being in a state where the verification tag to be used is not known yet. MFC

svn commit: r362720 - head/sys/netinet

2020-06-28 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 28 11:12:03 2020 New Revision: 362720 URL: https://svnweb.freebsd.org/changeset/base/362720 Log: Don't check ch for not being NULL, since that is true. MFC after:1 week Modified: head/sys/netinet/sctp_input.c Modified:

svn commit: r362581 - head/sys/netinet

2020-06-24 Thread Michael Tuexen
Author: tuexen Date: Wed Jun 24 14:47:51 2020 New Revision: 362581 URL: https://svnweb.freebsd.org/changeset/base/362581 Log: Fix the acconting for fragmented unordered messages when using interleaving. This was reported for the userland stack in

svn commit: r362563 - head/sys/netinet

2020-06-23 Thread Michael Tuexen
Author: tuexen Date: Tue Jun 23 23:05:05 2020 New Revision: 362563 URL: https://svnweb.freebsd.org/changeset/base/362563 Log: Fix alignment issue manifesting in the userland stack. MFC after:1 wwek Modified: head/sys/netinet/sctp_usrreq.c Modified:

svn commit: r362498 - head/sys/netinet

2020-06-22 Thread Michael Tuexen
Author: tuexen Date: Mon Jun 22 14:36:14 2020 New Revision: 362498 URL: https://svnweb.freebsd.org/changeset/base/362498 Log: No need to include netinet/sctp_crc32.h twice. Modified: head/sys/netinet/sctp_crc32.c Modified: head/sys/netinet/sctp_crc32.c

svn commit: r362474 - head/lib/libc/net

2020-06-21 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 21 23:47:27 2020 New Revision: 362474 URL: https://svnweb.freebsd.org/changeset/base/362474 Log: Add include missing from my last commit. Modified: head/lib/libc/net/sctp_sys_calls.c Modified: head/lib/libc/net/sctp_sys_calls.c

svn commit: r362473 - in head: lib/libc/net sys/netinet

2020-06-21 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 21 23:12:56 2020 New Revision: 362473 URL: https://svnweb.freebsd.org/changeset/base/362473 Log: Cleanup the defintion of struct sctp_getaddresses. This stucture is used by the IPPROTO_SCTP level socket options SCTP_GET_PEER_ADDRESSES and

svn commit: r362462 - head/sys/netinet

2020-06-21 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 21 09:56:09 2020 New Revision: 362462 URL: https://svnweb.freebsd.org/changeset/base/362462 Log: Fix the build for an INET6 only configuration. The fix from the last commit is actually needed twice... MFC after:1 week Modified:

svn commit: r362454 - head/sys/netinet

2020-06-20 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 20 23:48:57 2020 New Revision: 362454 URL: https://svnweb.freebsd.org/changeset/base/362454 Log: Set a variable also in the case of an INET6 only kernel MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r362451 - in head: lib/libc/net sys/netinet

2020-06-20 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 20 21:06:02 2020 New Revision: 362451 URL: https://svnweb.freebsd.org/changeset/base/362451 Log: Use a struct sockaddr_in pr struct sockaddr_in6 as the option value for the IPPROTO_SCTP level socket options SCTP_BINDX_ADD_ADDR and SCTP_BINDX_REM_ADDR. These

svn commit: r362448 - head/sys/netinet

2020-06-20 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 20 20:20:16 2020 New Revision: 362448 URL: https://svnweb.freebsd.org/changeset/base/362448 Log: Cleanup the adding and deleting of addresses via sctp_bindx(). There is no need to use the association identifier, so remove it. While there, cleanup the code a

svn commit: r362377 - head/sys/netinet

2020-06-19 Thread Michael Tuexen
Author: tuexen Date: Fri Jun 19 12:35:29 2020 New Revision: 362377 URL: https://svnweb.freebsd.org/changeset/base/362377 Log: Remove last argument of sctp_addr_mgmt_ep_sa(), since it is not used. MFC after:1 week Modified: head/sys/netinet/sctp_asconf.c

svn commit: r362332 - head/lib/libc/net

2020-06-18 Thread Michael Tuexen
Author: tuexen Date: Thu Jun 18 16:22:09 2020 New Revision: 362332 URL: https://svnweb.freebsd.org/changeset/base/362332 Log: Whitespace changes, not functional change intended. MFC after:1 week Modified: head/lib/libc/net/sctp_sys_calls.c Modified:

svn commit: r362277 - head/sys/netinet

2020-06-17 Thread Michael Tuexen
Author: tuexen Date: Wed Jun 17 15:27:45 2020 New Revision: 362277 URL: https://svnweb.freebsd.org/changeset/base/362277 Log: Allow the self reference to be NULL in case the timer was stopped. Submitted by: Timo Voelker MFC after:1 week Modified:

svn commit: r362178 - head/sys/netinet

2020-06-14 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 14 16:05:08 2020 New Revision: 362178 URL: https://svnweb.freebsd.org/changeset/base/362178 Log: Allocate the mbuf for the signature in the COOKIE or the correct size. While there, do also do some cleanups. MFC after:1 week Modified:

svn commit: r362173 - head/sys/netinet

2020-06-14 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 14 09:50:00 2020 New Revision: 362173 URL: https://svnweb.freebsd.org/changeset/base/362173 Log: Cleanups, no functional change. MFC after:1 week Modified: head/sys/netinet/sctp_indata.c head/sys/netinet/sctp_output.c

svn commit: r362155 - head/sys/netinet

2020-06-13 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 13 21:23:26 2020 New Revision: 362155 URL: https://svnweb.freebsd.org/changeset/base/362155 Log: Remove usage of empty macro. MFC after:1 week Modified: head/sys/netinet/sctp_os_bsd.h head/sys/netinet/sctp_pcb.c Modified:

svn commit: r362153 - head/sys/netinet

2020-06-13 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 13 18:38:59 2020 New Revision: 362153 URL: https://svnweb.freebsd.org/changeset/base/362153 Log: Simpify a condition, no functional change. MFC after:1 week Modified: head/sys/netinet/sctp_input.c Modified: head/sys/netinet/sctp_input.c

svn commit: r362107 - head/sys/netinet

2020-06-12 Thread Michael Tuexen
Author: tuexen Date: Fri Jun 12 16:40:10 2020 New Revision: 362107 URL: https://svnweb.freebsd.org/changeset/base/362107 Log: Whitespace change due to upstream cleanup. MFC after:1 week Modified: head/sys/netinet/sctp_constants.h Modified: head/sys/netinet/sctp_constants.h

svn commit: r362106 - head/sys/netinet

2020-06-12 Thread Michael Tuexen
Author: tuexen Date: Fri Jun 12 16:31:13 2020 New Revision: 362106 URL: https://svnweb.freebsd.org/changeset/base/362106 Log: More cleanups due to ifdef cleanup done upstream MFC after:1 week Modified: head/sys/netinet/sctp_constants.h head/sys/netinet/sctp_input.c

svn commit: r362090 - head/sys/netinet

2020-06-12 Thread Michael Tuexen
Author: tuexen Date: Fri Jun 12 10:13:23 2020 New Revision: 362090 URL: https://svnweb.freebsd.org/changeset/base/362090 Log: Small cleanup due to upstream ifdef cleanups. MFC after:1 week Modified: head/sys/netinet/sctputil.h Modified: head/sys/netinet/sctputil.h

svn commit: r362054 - head/sys/netinet

2020-06-11 Thread Michael Tuexen
Author: tuexen Date: Thu Jun 11 13:34:09 2020 New Revision: 362054 URL: https://svnweb.freebsd.org/changeset/base/362054 Log: Non-functional changes due to upstream cleanup. MFC after:1 week Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_auth.c

svn commit: r361934 - head/sys/netinet

2020-06-08 Thread Michael Tuexen
Author: tuexen Date: Mon Jun 8 20:23:20 2020 New Revision: 361934 URL: https://svnweb.freebsd.org/changeset/base/361934 Log: Whitespace cleanups and removal of a stale comment. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.c head/sys/netinet/sctp_sysctl.c

svn commit: r361895 - in head/sys: netinet netinet6

2020-06-07 Thread Michael Tuexen
Author: tuexen Date: Sun Jun 7 14:39:20 2020 New Revision: 361895 URL: https://svnweb.freebsd.org/changeset/base/361895 Log: Retire SCTP_SO_LOCK_TESTING. This was intended to test the locking used in the MacOS X kernel on a FreeBSD system, to make use of WITNESS and other debugging

svn commit: r361877 - head/sys/netinet

2020-06-06 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 6 21:26:34 2020 New Revision: 361877 URL: https://svnweb.freebsd.org/changeset/base/361877 Log: Fix typo in comment. Submitted by Orgad Shaneh for the userland stack. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.c Modified:

Re: svn commit: r361872 - head/sys/netinet

2020-06-06 Thread Michael Tuexen
anything back, I think it is OK to reduce the #ifdef complexity upstream and remove it. Best regards Michael > > On Sat, Jun 6, 2020 at 11:20 AM Michael Tuexen wrote: >> >> Author: tuexen >> Date: Sat Jun 6 18:20:09 2020 >> New Revision: 361872 >> URL: htt

svn commit: r361872 - head/sys/netinet

2020-06-06 Thread Michael Tuexen
Author: tuexen Date: Sat Jun 6 18:20:09 2020 New Revision: 361872 URL: https://svnweb.freebsd.org/changeset/base/361872 Log: Non-functional changes due to cleanup (upstream removing of Panda support) of the code MFC after:1 week Modified: head/sys/netinet/sctp_constants.h

svn commit: r361750 - head/sys/netinet

2020-06-03 Thread Michael Tuexen
Author: tuexen Date: Wed Jun 3 13:51:53 2020 New Revision: 361750 URL: https://svnweb.freebsd.org/changeset/base/361750 Log: Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state Enabling TCP-FASTOPEN on an end-point which is in a state other than CLOSED or LISTEN, is a

Re: svn commit: r361706 - in head/sys: net net/route netinet netinet6

2020-06-01 Thread Michael Tuexen
> On 1. Jun 2020, at 22:49, Alexander V. Chernikov wrote: > > Author: melifaro > Date: Mon Jun 1 20:49:42 2020 > New Revision: 361706 > URL: https://svnweb.freebsd.org/changeset/base/361706 > > Log: > * Add rib__route() functions to manipulate the routing table. > > The main driver for the

svn commit: r361243 - head/sys/netinet

2020-05-19 Thread Michael Tuexen
Author: tuexen Date: Tue May 19 07:23:35 2020 New Revision: 361243 URL: https://svnweb.freebsd.org/changeset/base/361243 Log: Replace snprintf() by SCTP_SNPRINTF() and let SCTP_SNPRINTF() map to snprintf() on FreeBSD. This allows to check for failures of snprintf() on platforms other than

svn commit: r361242 - head/sys/netinet

2020-05-19 Thread Michael Tuexen
Author: tuexen Date: Tue May 19 07:21:11 2020 New Revision: 361242 URL: https://svnweb.freebsd.org/changeset/base/361242 Log: Revert r361209: cem noted that on FreeBSD snprintf() can not fail and code should not check for that. A followup commit will replace the usage of snprintf()

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 23:09, Ian Lepore wrote: > > On Mon, 2020-05-18 at 23:01 +0200, Michael Tuexen wrote: >>> On 18. May 2020, at 22:48, Ian Lepore wrote: >>> >>> On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: >>>>> Sure.

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 22:48, Ian Lepore wrote: > > On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: >>> Sure. You can certainly ignore user reports corresponding to bogus >>> flags, though, and encourage use of various flags. >> >> I could, but de

Re: svn commit: r361209 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
> On 18. May 2020, at 22:17, Conrad Meyer wrote: > > Hi Michael, > > On Mon, May 18, 2020 at 12:05 PM Michael Tuexen wrote: >> >>> On 18. May 2020, at 20:23, Conrad Meyer wrote: >> >>> If truncation is intended, the GCC warning is spurious. Giv

svn commit: r361227 - head/sys/netinet

2020-05-18 Thread Michael Tuexen
Author: tuexen Date: Mon May 18 19:48:38 2020 New Revision: 361227 URL: https://svnweb.freebsd.org/changeset/base/361227 Log: Remove assignment without effect. MFC after:3 days Modified: head/sys/netinet/sctp_auth.c Modified: head/sys/netinet/sctp_auth.c

  1   2   3   4   5   6   7   8   9   10   >