svn commit: r361226 - head/sys/netinet

Author: tuexen Date: Mon May 18 19:35:46 2020 New Revision: 361226 URL: https://svnweb.freebsd.org/changeset/base/361226 Log: Don't check an unsigned variable for being negative. MFC after:3 days. Modified: head/sys/netinet/sctp_usrreq.c Modified:

svn commit: r361225 - head/sys/netinet

Author: tuexen Date: Mon May 18 19:23:01 2020 New Revision: 361225 URL: https://svnweb.freebsd.org/changeset/base/361225 Log: Remove redundant assignment. MFC after:3 days Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

Re: svn commit: r361209 - head/sys/netinet

> On 18. May 2020, at 20:23, Conrad Meyer wrote: > > On Mon, May 18, 2020 at 10:35 AM Michael Tuexen wrote: >> >>> On 18. May 2020, at 17:38, Conrad Meyer wrote: >>> >>> These changes are a bit odd. The only reason a standards-compliant >>&

svn commit: r361224 - head/sys/netinet

Author: tuexen Date: Mon May 18 18:42:43 2020 New Revision: 361224 URL: https://svnweb.freebsd.org/changeset/base/361224 Log: Cleanup, no functional change intended. MFC after:3 days Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r361222 - head/sys/netinet

Author: tuexen Date: Mon May 18 18:32:58 2020 New Revision: 361222 URL: https://svnweb.freebsd.org/changeset/base/361222 Log: Avoid an integer underflow. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c Modified: head/sys/netinet/sctp_asconf.c

svn commit: r361221 - head/sys/netinet

Author: tuexen Date: Mon May 18 18:27:10 2020 New Revision: 361221 URL: https://svnweb.freebsd.org/changeset/base/361221 Log: Remove redundant check. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c Modified: head/sys/netinet/sctp_asconf.c

Re: svn commit: r361209 - head/sys/netinet

ate a standards-compliant portability shim for that >> platform instead of this more invasive change? >> >> FreeBSD's snprintf(9) does not have this bug, nor does its snprintf(3). >> >> Best regards, >> Conrad >> >> On Mon, May 18, 2020

Re: svn commit: r361209 - head/sys/netinet

more invasive change? If you want, I can revert the change and use the code only on non-FreeBSD platforms. Best regards Michael > > FreeBSD's snprintf(9) does not have this bug, nor does its snprintf(3). > > Best regards, > Conrad > > On Mon, May 18, 2020 at 3:07 AM Michael Tu

svn commit: r361214 - head/sys/netinet

Author: tuexen Date: Mon May 18 15:02:15 2020 New Revision: 361214 URL: https://svnweb.freebsd.org/changeset/base/361214 Log: Fix logical condition by looking at usecs. This issue was found by cpp-check running on the userland stack. MFC after:3 days Modified:

svn commit: r361213 - head/sys/netinet

Author: tuexen Date: Mon May 18 15:00:18 2020 New Revision: 361213 URL: https://svnweb.freebsd.org/changeset/base/361213 Log: Whitespace change. MFC after:3 days Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r361209 - head/sys/netinet

Author: tuexen Date: Mon May 18 10:07:01 2020 New Revision: 361209 URL: https://svnweb.freebsd.org/changeset/base/361209 Log: Handle failures of snprintf(). MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_indata.c

svn commit: r361145 - head/sys/netinet

Author: tuexen Date: Sun May 17 22:31:38 2020 New Revision: 361145 URL: https://svnweb.freebsd.org/changeset/base/361145 Log: Non-functional changes, cleanups. MFC after:3 days Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_os_bsd.h

svn commit: r361116 - head/sys/netinet

Author: tuexen Date: Sat May 16 19:26:39 2020 New Revision: 361116 URL: https://svnweb.freebsd.org/changeset/base/361116 Log: Ensure that an stcb is not dereferenced when it is about to be freed. This issue was found by SYZKALLER. MFC after:3 days Modified:

svn commit: r361081 - head/sys/netinet

Author: tuexen Date: Fri May 15 14:06:37 2020 New Revision: 361081 URL: https://svnweb.freebsd.org/changeset/base/361081 Log: Allow only IPv4 addresses in sendto() for TCP on AF_INET sockets. This problem was found by looking at syzkaller reproducers for some other problems.

svn commit: r360942 - head/sys/netinet

Author: tuexen Date: Mon May 11 22:47:20 2020 New Revision: 360942 URL: https://svnweb.freebsd.org/changeset/base/360942 Log: Fix a copy and paste error introduced in r360878. Reported-by: syzbot+a0863e972771f2f0d...@syzkaller.appspotmail.com Reported-by:

svn commit: r360885 - head/sys/netinet

Author: tuexen Date: Sun May 10 22:54:30 2020 New Revision: 360885 URL: https://svnweb.freebsd.org/changeset/base/360885 Log: Ensure that the SCTP iterator runs with an stcb and inp, which belong to each other. Reported by: syzbot+82d39d14f2f765e38...@syzkaller.appspotmail.com MFC

svn commit: r360879 - head/sys/netinet

Author: tuexen Date: Sun May 10 17:43:42 2020 New Revision: 360879 URL: https://svnweb.freebsd.org/changeset/base/360879 Log: Remove trailing whitespace. Modified: head/sys/netinet/tcp_usrreq.c Modified: head/sys/netinet/tcp_usrreq.c

svn commit: r360878 - head/sys/netinet

Author: tuexen Date: Sun May 10 17:19:19 2020 New Revision: 360878 URL: https://svnweb.freebsd.org/changeset/base/360878 Log: Ensure that we have a path when starting the T3 RXT timer. Reported by: syzbot+f2321629047f89486...@syzkaller.appspotmail.com MFC after:3 days Modified:

svn commit: r360869 - head/sys/netinet

Author: tuexen Date: Sun May 10 10:03:10 2020 New Revision: 360869 URL: https://svnweb.freebsd.org/changeset/base/360869 Log: Only drop DATA chunk with lower priorities as specified in RFC 7496. This issue was found by looking at a reproducer generated by syzkaller. MFC after:

svn commit: r360671 - head/sys/netinet

Author: tuexen Date: Tue May 5 19:54:30 2020 New Revision: 360671 URL: https://svnweb.freebsd.org/changeset/base/360671 Log: Avoid underflowing a variable, which would result in taking more data from the stream queues then needed. Thanks to Timo Voelker for finding this bug and

svn commit: r360662 - head/sys/netinet

Author: tuexen Date: Tue May 5 17:52:44 2020 New Revision: 360662 URL: https://svnweb.freebsd.org/changeset/base/360662 Log: Fix the computation of the numbers of entries of the mapping array to look at when generating a SACK. This was wrong in case of sequence numbers wrap arounds.

svn commit: r360645 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Mon May 4 23:05:11 2020 New Revision: 360645 URL: https://svnweb.freebsd.org/changeset/base/360645 Log: Add net epoch support back, which was taken out by accident in https://svnweb.freebsd.org/changeset/base/360639 Reviewed by: rrs Sponsored by:

svn commit: r360641 - head/sys/netinet/tcp_stacks

Author: tuexen Date: Mon May 4 22:02:49 2020 New Revision: 360641 URL: https://svnweb.freebsd.org/changeset/base/360641 Log: Enter the net epoch before calling the output routine in TCP BBR. This was only triggered when setting the IPPROTO_TCP level socket option TCP_DELACK. This issue

svn commit: r360209 - head/sys/netinet

Author: tuexen Date: Wed Apr 22 21:22:33 2020 New Revision: 360209 URL: https://svnweb.freebsd.org/changeset/base/360209 Log: Improve input validation when processing AUTH chunks. Thanks to Natalie Silvanovich from Google for finding and reporting the issue found by her in the SCTP

svn commit: r360193 - head/sys/netinet

Author: tuexen Date: Wed Apr 22 12:47:46 2020 New Revision: 360193 URL: https://svnweb.freebsd.org/changeset/base/360193 Log: Improve input validation when processing AUTH chunks. Thanks to Natalie Silvanovich from Google for finding and reporting the issue found by her in the SCTP

svn commit: r359926 - head/sys/netinet

Author: tuexen Date: Tue Apr 14 16:35:05 2020 New Revision: 359926 URL: https://svnweb.freebsd.org/changeset/base/359926 Log: Improve the TCP blackhole detection. The principle is to reduce the MSS in two steps and try each candidate two times. However, if two candidates are the same (which

Re: svn commit: r359809 - head/sys/netinet

> On 11. Apr 2020, at 23:35, Conrad Meyer wrote: > > Hi Michael, > > On Sat, Apr 11, 2020 at 1:37 PM Michael Tuexen wrote: >> >> Author: tuexen >> Date: Sat Apr 11 20:36:54 2020 >> New Revision: 359809 >> URL: https://svnweb.freebsd.org/changeset/

svn commit: r359822 - head/sys/netinet

Author: tuexen Date: Sun Apr 12 09:31:36 2020 New Revision: 359822 URL: https://svnweb.freebsd.org/changeset/base/359822 Log: Revert https://svnweb.freebsd.org/changeset/base/359809 The intended change was sp->next.tqe_next = NULL; sp->next.tqe_prev = NULL; which doesn't

svn commit: r359809 - head/sys/netinet

Author: tuexen Date: Sat Apr 11 20:36:54 2020 New Revision: 359809 URL: https://svnweb.freebsd.org/changeset/base/359809 Log: Zero out pointers for consistency. This was found by running syzkaller on an INVARIANTS kernel. MFC after:3 days Modified:

svn commit: r359657 - head/sys/netinet

Author: tuexen Date: Mon Apr 6 13:58:13 2020 New Revision: 359657 URL: https://svnweb.freebsd.org/changeset/base/359657 Log: Do more argument validation under INVARIANTS when starting/stopping an SCTP timer. MFC after:1 week Modified: head/sys/netinet/sctputil.c

svn commit: r359487 - in head: share/man/man4 sys/netinet sys/netinet/tcp_stacks

Author: tuexen Date: Tue Mar 31 15:54:54 2020 New Revision: 359487 URL: https://svnweb.freebsd.org/changeset/base/359487 Log: Allow the TCP backhole detection to be disabled at all, enabled only for IPv4, enabled only for IPv6, and enabled for IPv4 and IPv6. The current blackhole detection

svn commit: r359422 - head/share/man/man4

Author: tuexen Date: Sun Mar 29 15:43:00 2020 New Revision: 359422 URL: https://svnweb.freebsd.org/changeset/base/359422 Log: Be a bit more precisly in the description of the sysctl variable net.inet.tcp.pmtud_blackhole_detection. Also remove three entries, which are not sysctl variables

svn commit: r359410 - head/sys/netinet

Author: tuexen Date: Sat Mar 28 22:35:04 2020 New Revision: 359410 URL: https://svnweb.freebsd.org/changeset/base/359410 Log: Small cleanup by using a variable just assigned. MFC after:1 week Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r359405 - head/sys/netinet

Author: tuexen Date: Sat Mar 28 20:25:45 2020 New Revision: 359405 URL: https://svnweb.freebsd.org/changeset/base/359405 Log: Handle integer overflows correctly when converting msecs and secs to ticks and vice versa. These issues were caught by recently added panic() calls on INVARIANTS

svn commit: r359379 - head/sys/netinet

Author: tuexen Date: Fri Mar 27 21:48:52 2020 New Revision: 359379 URL: https://svnweb.freebsd.org/changeset/base/359379 Log: Some more uint32_t cleanups, no functional change. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.h head/sys/netinet/sctp_structs.h

svn commit: r359357 - head/sys/netinet

Author: tuexen Date: Fri Mar 27 11:08:11 2020 New Revision: 359357 URL: https://svnweb.freebsd.org/changeset/base/359357 Log: Use uint32_t where it is expected to be used. No functional change. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.h

svn commit: r359305 - head/sys/netinet

Author: tuexen Date: Wed Mar 25 18:14:12 2020 New Revision: 359305 URL: https://svnweb.freebsd.org/changeset/base/359305 Log: Improve consistency in debug output. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r359306 - head/sys/netinet

Author: tuexen Date: Wed Mar 25 18:20:37 2020 New Revision: 359306 URL: https://svnweb.freebsd.org/changeset/base/359306 Log: Remove an optimization, which was incorrect a couple of times and therefore doesn't seem worth to be there. In this case COOKIE where not retransmitted anymore, when

svn commit: r359302 - head/sys/netinet

Author: tuexen Date: Wed Mar 25 15:29:01 2020 New Revision: 359302 URL: https://svnweb.freebsd.org/changeset/base/359302 Log: Revert https://svnweb.freebsd.org/changeset/base/357829 This introduces a regression reported by koobs@ when running a pyhton test suite on a loaded system.

svn commit: r359301 - head/sys/netinet

Author: tuexen Date: Wed Mar 25 13:19:41 2020 New Revision: 359301 URL: https://svnweb.freebsd.org/changeset/base/359301 Log: Use consistent debug output. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r359300 - head/sys/netinet

Author: tuexen Date: Wed Mar 25 13:18:37 2020 New Revision: 359300 URL: https://svnweb.freebsd.org/changeset/base/359300 Log: Don't restore the vnet too early in error cases. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r359288 - head/sys/netinet

Author: tuexen Date: Tue Mar 24 23:04:07 2020 New Revision: 359288 URL: https://svnweb.freebsd.org/changeset/base/359288 Log: Only call panic when building with INVARIANTS. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r359287 - head/sys/netinet

Author: tuexen Date: Tue Mar 24 22:44:36 2020 New Revision: 359287 URL: https://svnweb.freebsd.org/changeset/base/359287 Log: Another cleanup of the timer code. Also be more pedantic about the parameters of the timer start and stop routines. Several inconsistencies have been fixed in

svn commit: r359234 - head/sys/netinet

Author: tuexen Date: Mon Mar 23 12:17:13 2020 New Revision: 359234 URL: https://svnweb.freebsd.org/changeset/base/359234 Log: Cleanup the file and add two ASSERT variants for locks, which will be used shortly. MFC after:1 week Modified: head/sys/netinet/sctp_lock_bsd.h

svn commit: r359195 - head/sys/netinet

Author: tuexen Date: Sat Mar 21 16:12:19 2020 New Revision: 359195 URL: https://svnweb.freebsd.org/changeset/base/359195 Log: More timer cleanups, no functional change. MFC after:1 week Modified: head/sys/netinet/sctp_asconf.c head/sys/netinet/sctp_input.c

svn commit: r359162 - head/sys/netinet

Author: tuexen Date: Fri Mar 20 14:49:44 2020 New Revision: 359162 URL: https://svnweb.freebsd.org/changeset/base/359162 Log: Remove a set, but unused variable. MFC after:1 week Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r359156 - head/sys/netinet

Author: tuexen Date: Thu Mar 19 23:07:52 2020 New Revision: 359156 URL: https://svnweb.freebsd.org/changeset/base/359156 Log: A a missing NET_EPOCH_ENTER/NET_EPOCH_EXIT pair. This was affecting implicit connection setups via sendmsg(). Reported by:

svn commit: r359152 - head/sys/netinet

Author: tuexen Date: Thu Mar 19 21:01:16 2020 New Revision: 359152 URL: https://svnweb.freebsd.org/changeset/base/359152 Log: Consistently provide arguments for timer start and stop routines. This is another step in cleaning up timer handling. MFC after:1 week Modified:

svn commit: r359151 - head/sys/netinet

Author: tuexen Date: Thu Mar 19 18:55:54 2020 New Revision: 359151 URL: https://svnweb.freebsd.org/changeset/base/359151 Log: Cleanup the stream reset and asconf timer. MFC after:1 week Modified: head/sys/netinet/sctp_timer.c head/sys/netinet/sctp_timer.h

svn commit: r359131 - head/sys/netinet

Author: tuexen Date: Thu Mar 19 14:37:28 2020 New Revision: 359131 URL: https://svnweb.freebsd.org/changeset/base/359131 Log: The MTU candidates MUST be a multiple of 4, so make them so. MFC after:1 week Modified: head/sys/netinet/sctputil.c Modified:

svn commit: r359048 - head/sys/netinet

Author: tuexen Date: Tue Mar 17 19:20:12 2020 New Revision: 359048 URL: https://svnweb.freebsd.org/changeset/base/359048 Log: Handle the timers in a consistent sequence according to the definition of the timer type. Just a cleanup, no functional change intended. MFC after:1

svn commit: r358965 - in head: lib/libc/sys sys/kern

Author: tuexen Date: Fri Mar 13 18:38:28 2020 New Revision: 358965 URL: https://svnweb.freebsd.org/changeset/base/358965 Log: sendfile() does currently not support SCTP sockets. Therefore, fail the call. Reviewed by: markj@ MFC after:1 week Differential Revision:

svn commit: r358911 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Thu Mar 12 15:37:41 2020 New Revision: 358911 URL: https://svnweb.freebsd.org/changeset/base/358911 Log: Use KMOD_TCPSTAT_INC instead of TCPSTAT_INC for RACK and BBR, since these are kernel modules. Also add a KMOD_TCPSTAT_ADD and use that instead of TCPSTAT_ADD.

svn commit: r358621 - head/sys/netinet

Author: tuexen Date: Wed Mar 4 16:41:25 2020 New Revision: 358621 URL: https://svnweb.freebsd.org/changeset/base/358621 Log: When using automatically generated flow labels and using TCP SYN cookies, use the same flow label for the segments sent during the handshake and after the handshake.

svn commit: r358614 - head/sys/netinet

Author: tuexen Date: Wed Mar 4 12:22:53 2020 New Revision: 358614 URL: https://svnweb.freebsd.org/changeset/base/358614 Log: Don't send an uninitilised traffic class in the IPv6 header, when sending a TCP segment from the TCP SYN cache (like a SYN-ACK). This fix initialises it to zero.

svn commit: r358482 - head/sys/netinet

Author: tuexen Date: Sun Mar 1 12:34:27 2020 New Revision: 358482 URL: https://svnweb.freebsd.org/changeset/base/358482 Log: Remove stale definitions. The removed definitions are not used right now and are incompatible with the correct ones in RFC 3168. Submitted by: Richard

svn commit: r358169 - head/sys/netinet

Author: tuexen Date: Thu Feb 20 15:37:44 2020 New Revision: 358169 URL: https://svnweb.freebsd.org/changeset/base/358169 Log: Remove an unused timer type. MFC after:1 week Modified: head/sys/netinet/sctp_constants.h Modified: head/sys/netinet/sctp_constants.h

svn commit: r358083 - in head/sys: netinet netinet6

Author: tuexen Date: Tue Feb 18 21:25:17 2020 New Revision: 358083 URL: https://svnweb.freebsd.org/changeset/base/358083 Log: Epochify SCTP. Modified: head/sys/netinet/sctp_os_bsd.h head/sys/netinet/sctp_output.c head/sys/netinet/sctp_usrreq.c head/sys/netinet/sctputil.c

svn commit: r358080 - head/sys/netinet

Author: tuexen Date: Tue Feb 18 19:41:55 2020 New Revision: 358080 URL: https://svnweb.freebsd.org/changeset/base/358080 Log: Remove unused function. Modified: head/sys/netinet/sctp_bsd_addr.c Modified: head/sys/netinet/sctp_bsd_addr.c

svn commit: r358028 - head/sys/netinet

Author: tuexen Date: Mon Feb 17 18:05:03 2020 New Revision: 358028 URL: https://svnweb.freebsd.org/changeset/base/358028 Log: Fix the non-default stream schedulers such that do not interleave user messages when it is now allowed. Thanks to Christian Wright for reporting the issue for the

svn commit: r358023 - head/sys/netinet

Author: tuexen Date: Mon Feb 17 14:54:21 2020 New Revision: 358023 URL: https://svnweb.freebsd.org/changeset/base/358023 Log: Don't use uninitialised stack memory if the sysctl variable net.inet.tcp.hostcache.enable is set to 0. The bug resulted in using possibly a too small MSS value or

svn commit: r357858 - in head: cddl/lib/libdtrace sys/netinet

Author: tuexen Date: Thu Feb 13 15:14:46 2020 New Revision: 357858 URL: https://svnweb.freebsd.org/changeset/base/357858 Log: sack_newdata and snd_recover hold the same value. Therefore, use only a single instance: use snd_recover also where sack_newdata was used. Submitted by:

svn commit: r357856 - head/sys/netinet

Author: tuexen Date: Thu Feb 13 13:58:34 2020 New Revision: 357856 URL: https://svnweb.freebsd.org/changeset/base/357856 Log: Whitespace cleanup. No functional change. Sponsored by: Netflix, Inc. Modified: head/sys/netinet/tcp_log_buf.h Modified: head/sys/netinet/tcp_log_buf.h

svn commit: r357830 - head/sys/netinet

Author: tuexen Date: Wed Feb 12 17:05:10 2020 New Revision: 357830 URL: https://svnweb.freebsd.org/changeset/base/357830 Log: Don't panic under INVARIANTS when we can't allocate memory for storing a vtag in time wait. This issue was found by running syzkaller. MFC after:1

svn commit: r357829 - head/sys/netinet

Author: tuexen Date: Wed Feb 12 17:02:15 2020 New Revision: 357829 URL: https://svnweb.freebsd.org/changeset/base/357829 Log: Mark the socket as disconnected when freeing the association the first time. This issue was found by running syzkaller. MFC after:1 week Modified:

Re: svn commit: r357761 - head/sys/netinet

> On 11. Feb 2020, at 20:52, Gleb Smirnoff wrote: > > Michael, > > On Tue, Feb 11, 2020 at 08:38:21PM +0100, Michael Tuexen wrote: > M> I can revert it and get it working in a different way. However, the > M> networking code uses ints for booleans in a lot of

svn commit: r357775 - head/sys/netinet

Author: tuexen Date: Tue Feb 11 20:02:20 2020 New Revision: 357775 URL: https://svnweb.freebsd.org/changeset/base/357775 Log: Revert https://svnweb.freebsd.org/changeset/base/357761 This was suggested by cem@ Modified: head/sys/netinet/sctp_pcb.c head/sys/netinet/sctputil.c

Re: svn commit: r357761 - head/sys/netinet

> On 11. Feb 2020, at 19:18, Conrad Meyer wrote: > > Hi Michael, > > On Tue, Feb 11, 2020 at 6:00 AM Michael Tuexen wrote: >> >> Author: tuexen >> Date: Tue Feb 11 14:00:27 2020 >> New Revision: 357761 >> URL: https://svnweb.freebsd.org/changeset/b

svn commit: r357768 - head/sys/netinet

Author: tuexen Date: Tue Feb 11 18:15:57 2020 New Revision: 357768 URL: https://svnweb.freebsd.org/changeset/base/357768 Log: Don't start an SCTP timer using a net, which has been removed. Submitted by: Taylor Brandstetter MFC after:1 week Modified:

svn commit: r357761 - head/sys/netinet

Author: tuexen Date: Tue Feb 11 14:00:27 2020 New Revision: 357761 URL: https://svnweb.freebsd.org/changeset/base/357761 Log: Use an int instead of a bool variable, since bool is not supported on all platforms the stack is running on in userland. Modified: head/sys/netinet/sctp_pcb.c

svn commit: r357708 - head/sys/netinet

Author: tuexen Date: Sun Feb 9 22:40:05 2020 New Revision: 357708 URL: https://svnweb.freebsd.org/changeset/base/357708 Log: Stop the PMTU and HB timer when removing a net, not when freeing it. Submitted by: Taylor Brandstetter MFC after:1 week Modified:

svn commit: r357705 - head/sys/netinet

Author: tuexen Date: Sun Feb 9 22:05:41 2020 New Revision: 357705 URL: https://svnweb.freebsd.org/changeset/base/357705 Log: Cleanup timer handling. Submitted by: Taylor Brandstetter MFC after:1 week Modified: head/sys/netinet/sctp_indata.c head/sys/netinet/sctp_output.c

Re: svn commit: r357641 - head/sys/kern

> On 6. Feb 2020, at 21:51, Jeff Roberson wrote: > > Author: jeff > Date: Thu Feb 6 20:51:46 2020 > New Revision: 357641 > URL: https://svnweb.freebsd.org/changeset/base/357641 > > Log: > Fix a race in smr_advance() that could result in unnecessary poll calls. > > This was relatively

svn commit: r357501 - head/sys/netinet

Author: tuexen Date: Tue Feb 4 14:01:07 2020 New Revision: 357501 URL: https://svnweb.freebsd.org/changeset/base/357501 Log: Remove unused timer. Submitted by: Taylor Brandstetter Modified: head/sys/netinet/sctp_pcb.c head/sys/netinet/sctp_structs.h

svn commit: r357500 - head/sys/netinet

Author: tuexen Date: Tue Feb 4 12:34:16 2020 New Revision: 357500 URL: https://svnweb.freebsd.org/changeset/base/357500 Log: Improve numbering of debug information. Submitted by: Taylor Brandstetter MFC after:1 week Modified: head/sys/netinet/sctp_constants.h

svn commit: r357197 - head/sys/netinet

Author: tuexen Date: Tue Jan 28 10:09:05 2020 New Revision: 357197 URL: https://svnweb.freebsd.org/changeset/base/357197 Log: Fix build issues for the userland stack on 32-bit platforms. Reported by: Felix Weinrank MFC after:1 week Modified:

svn commit: r357116 - in head/sys/netinet: . cc tcp_stacks

Author: tuexen Date: Sat Jan 25 13:45:10 2020 New Revision: 357116 URL: https://svnweb.freebsd.org/changeset/base/357116 Log: Sending CWR after an RTO is according to RFC 3168 generally required and not only for the DCTCP congestion control. Submitted by: Richard Scheffenegger

svn commit: r357115 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat Jan 25 13:34:29 2020 New Revision: 357115 URL: https://svnweb.freebsd.org/changeset/base/357115 Log: Don't set the ECT codepoint on retransmitted packets during SACK loss recovery. This is required by RFC 3168. Submitted by: Richard Scheffenegger

svn commit: r357114 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat Jan 25 13:11:14 2020 New Revision: 357114 URL: https://svnweb.freebsd.org/changeset/base/357114 Log: As a TCP client only enable ECN when the corresponding sysctl variable indicates that ECN should be negotiated for the client side. Submitted by: Richard

svn commit: r357101 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Fri Jan 24 22:50:23 2020 New Revision: 357101 URL: https://svnweb.freebsd.org/changeset/base/357101 Log: Don't delay the ACK for a TCP segment with the CWR flag set. This allows the data sender to increase the CWND faster. Submitted by: Richard Scheffenegger

svn commit: r357100 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Fri Jan 24 22:37:53 2020 New Revision: 357100 URL: https://svnweb.freebsd.org/changeset/base/357100 Log: The server side of TCP fast open relies on the delayed ACK timer to allow including user data in the SYN-ACK. When DSACK support was added in r347382, an immediate

Re: svn commit: r356989 - head/sys/netinet

> On 22. Jan 2020, at 18:19, Gleb Smirnoff wrote: > > Author: glebius > Date: Wed Jan 22 17:19:53 2020 > New Revision: 356989 > URL: https://svnweb.freebsd.org/changeset/base/356989 > > Log: > Plug possible calls into ip6?_output() without network epoch from SCTP > bluntly adding epoch

svn commit: r356796 - head/sys/netinet

Author: tuexen Date: Thu Jan 16 17:15:06 2020 New Revision: 356796 URL: https://svnweb.freebsd.org/changeset/base/356796 Log: Remove debug code not needed anymore. Submitted by: Richard Scheffenegger Reviewed by: tuexen@ MFC after:1 week Differential

svn commit: r356663 - in head/sys: netinet netinet6

Author: tuexen Date: Sun Jan 12 17:52:32 2020 New Revision: 356663 URL: https://svnweb.freebsd.org/changeset/base/356663 Log: Fix race when accepting TCP connections. When expanding a SYN-cache entry to a socket/inp a two step approach was taken: 1) The local address was filled in,

svn commit: r356660 - head/sys/netinet

Author: tuexen Date: Sun Jan 12 15:45:27 2020 New Revision: 356660 URL: https://svnweb.freebsd.org/changeset/base/356660 Log: Fix division by zero issue. Thanks to Stas Denisov for reporting the issue for the userland stack and providing a fix. MFC after:3 days

svn commit: r356378 - head/sys/netinet

Author: tuexen Date: Sun Jan 5 14:08:01 2020 New Revision: 356378 URL: https://svnweb.freebsd.org/changeset/base/356378 Log: Don't make the sendall iterator as being up if it could not be started. MFC after:1 week Modified: head/sys/netinet/sctp_output.c Modified:

svn commit: r356377 - head/sys/netinet

Author: tuexen Date: Sun Jan 5 14:06:40 2020 New Revision: 356377 URL: https://svnweb.freebsd.org/changeset/base/356377 Log: Return -1 consistently if an error occurs. MFC after:1 week Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c

svn commit: r356376 - head/sys/netinet

Author: tuexen Date: Sun Jan 5 13:56:32 2020 New Revision: 356376 URL: https://svnweb.freebsd.org/changeset/base/356376 Log: Ensure that we don't miss a trigger for kicking off the SCTP iterator. Reported by: nwhitehorn@ MFC after:1 week Modified:

svn commit: r356357 - in head: share/man/man4 sys/netinet

Author: tuexen Date: Sat Jan 4 20:33:12 2020 New Revision: 356357 URL: https://svnweb.freebsd.org/changeset/base/356357 Log: Make the message size limit used for SCTP_SENDALL configurable via a sysctl variable instead of a compiled in constant. This is based on a patch provided by

svn commit: r356271 - head/sys/netinet

Author: tuexen Date: Thu Jan 2 14:04:16 2020 New Revision: 356271 URL: https://svnweb.freebsd.org/changeset/base/356271 Log: Remove empty line which was added in r356270 by accident. MFC after:1 week Modified: head/sys/netinet/sctp.h Modified: head/sys/netinet/sctp.h

svn commit: r356270 - head/sys/netinet

Author: tuexen Date: Thu Jan 2 13:55:10 2020 New Revision: 356270 URL: https://svnweb.freebsd.org/changeset/base/356270 Log: Improve input validation of the spp_pathmtu field in the SCTP_PEER_ADDR_PARAMS socket option. The code in the stack assumes sane values for the MTU. This issue

svn commit: r356235 - in head/sys/netinet: . cc

Author: tuexen Date: Tue Dec 31 16:15:47 2019 New Revision: 356235 URL: https://svnweb.freebsd.org/changeset/base/356235 Log: Fix delayed ACK generation for DCTCP. Submitted by: Richard Scheffenegger Reviewed by: che...@netapp.com, rgrimes@, tuexen@ Differential

svn commit: r356227 - head/sys/netinet

Author: tuexen Date: Tue Dec 31 14:32:48 2019 New Revision: 356227 URL: https://svnweb.freebsd.org/changeset/base/356227 Log: Add flags for upcoming patches related to improved ECN handling. No functional change. Submitted by: Richard Scheffenegger Reviewed by: rgrimes@,

svn commit: r356226 - head/sys/netinet

Author: tuexen Date: Tue Dec 31 14:23:52 2019 New Revision: 356226 URL: https://svnweb.freebsd.org/changeset/base/356226 Log: Clear the flag indicating that the last received packet was marked CE also in the case where a packet not marked was received. Submitted by: Richard

svn commit: r356224 - head/sys/netinet/cc

Author: tuexen Date: Tue Dec 31 12:29:01 2019 New Revision: 356224 URL: https://svnweb.freebsd.org/changeset/base/356224 Log: Add curly braces missed in https://svnweb.freebsd.org/changeset/base/354773 Sponsored by: Netflix, Inc. CID: 1407649 Modified:

svn commit: r355931 - head/sys/netinet

Author: tuexen Date: Fri Dec 20 15:25:08 2019 New Revision: 355931 URL: https://svnweb.freebsd.org/changeset/base/355931 Log: Improve input validation for some parameters having a too small reported length. Thanks to Natalie Silvanovich from Google for finding one of these issues in

svn commit: r355273 - in head/sys/netinet: . cc tcp_stacks

Author: tuexen Date: Sun Dec 1 21:01:33 2019 New Revision: 355273 URL: https://svnweb.freebsd.org/changeset/base/355273 Log: Move all ECN related flags from the flags to the flags2 field. This allows adding more ECN related flags in the future. No functional change intended. Submitted

svn commit: r355272 - head/sys/netinet

Author: tuexen Date: Sun Dec 1 20:45:48 2019 New Revision: 355272 URL: https://svnweb.freebsd.org/changeset/base/355272 Log: Make the TF_* flags easier readable by humans by adding leading zeroes to make them aligned. Submitted by: Richard Scheffenegger Reviewed by:

svn commit: r355269 - in head: share/man/man4 sys/netinet sys/netinet/tcp_stacks

Author: tuexen Date: Sun Dec 1 20:35:41 2019 New Revision: 355269 URL: https://svnweb.freebsd.org/changeset/base/355269 Log: This is an initial step in implementing the new congestion window validation as specified in RFC 7661. Submitted by: Richard Scheffenegger Reviewed by:

svn commit: r355268 - head/share/man/man4

Author: tuexen Date: Sun Dec 1 19:20:28 2019 New Revision: 355268 URL: https://svnweb.freebsd.org/changeset/base/355268 Log: Add a description for the TCP sysctl variable rfc6675_pipe. It was introduced by r290122, but no documentation was provided. This is taken from

<    1   2   3   4   5   6   7   8   9   10   >