Re: svn commit: r246675 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-02-13 Thread Pawel Jakub Dawidek
, OID_AUTO, write_to_degraded, CTLFLAG_RW, Please use CTLFLAG_RWTUN flag here. +zfs_write_to_degraded, 0, +Allow writing data to degraded vdevs); BTW. Those two lines fit into 80 chars just fine. +TUNABLE_INT(vfs.zfs.write_to_degraded, zfs_write_to_degraded); -- Pawel Jakub Dawidek

svn commit: r246691 - head/sys/security/audit

2013-02-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 22:54:23 2013 New Revision: 246691 URL: http://svnweb.freebsd.org/changeset/base/246691 Log: Style. Modified: head/sys/security/audit/audit_private.h Modified: head/sys/security/audit/audit_private.h

svn commit: r246698 - head/sys/bsm

2013-02-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 23:14:54 2013 New Revision: 246698 URL: http://svnweb.freebsd.org/changeset/base/246698 Log: Style. Modified: head/sys/bsm/audit_kevents.h Modified: head/sys/bsm/audit_kevents.h == ---

svn commit: r246620 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:55:42 2013 New Revision: 246620 URL: http://svnweb.freebsd.org/changeset/base/246620 Log: Use arc4random_buf(3) instead of reimplementing it. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c

svn commit: r246621 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:56:20 2013 New Revision: 246621 URL: http://svnweb.freebsd.org/changeset/base/246621 Log: Assert that if we are not dealing with keyfile we are dealing with passfile. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c

svn commit: r246622 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:56:47 2013 New Revision: 246622 URL: http://svnweb.freebsd.org/changeset/base/246622 Log: Fix minor memory leak. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c

svn commit: r246643 - head/usr.bin/procstat

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 23:51:26 2013 New Revision: 246643 URL: http://svnweb.freebsd.org/changeset/base/246643 Log: Add CAP_MKNOD right. Sponsored by: The FreeBSD Foundation Modified: head/usr.bin/procstat/procstat_files.c Modified: head/usr.bin/procstat/procstat_files.c

svn commit: r246644 - head/usr.bin/procstat

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 00:10:35 2013 New Revision: 246644 URL: http://svnweb.freebsd.org/changeset/base/246644 Log: Capability rights for process management via process descriptors do exist already, so uncomment them. Sponsored by: The FreeBSD Foundation Modified:

svn commit: r246446 - head/sys/security/audit

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:24:23 2013 New Revision: 246446 URL: http://svnweb.freebsd.org/changeset/base/246446 Log: Add AUDIT_ARG_SOCKADDR() macro so we can start using the audit_arg_sockaddr() function, which is currently unused. Sponsored by: The FreeBSD Foundation Modified:

svn commit: r246447 - head/sys/kern

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:27:11 2013 New Revision: 246447 URL: http://svnweb.freebsd.org/changeset/base/246447 Log: Minor style tweaks. Modified: head/sys/kern/uipc_syscalls.c Modified: head/sys/kern/uipc_syscalls.c

svn commit: r246448 - head/sys/kern

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:36:00 2013 New Revision: 246448 URL: http://svnweb.freebsd.org/changeset/base/246448 Log: Audit sockaddr argument for bind(2), connect(2), accept(2), sendto(2) and recvfrom(2) syscalls. Sponsored by: The FreeBSD Foundation Modified:

svn commit: r246169 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:12:48 2013 New Revision: 246169 URL: http://svnweb.freebsd.org/changeset/base/246169 Log: Simplify code a bit. This is leftover after Giant removal from VFS. Modified: head/sys/kern/vfs_vnops.c Modified: head/sys/kern/vfs_vnops.c

svn commit: r246171 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:14:16 2013 New Revision: 246171 URL: http://svnweb.freebsd.org/changeset/base/246171 Log: Remove label that was accidentally moved during Giant removal from VFS. Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c

svn commit: r246172 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:15:41 2013 New Revision: 246172 URL: http://svnweb.freebsd.org/changeset/base/246172 Log: Remove leftover label after Giant removal from VFS. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c

svn commit: r246177 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:20:05 2013 New Revision: 246177 URL: http://svnweb.freebsd.org/changeset/base/246177 Log: Now that MPSAFE flag is gone, we can arrange code a bit better. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c

Re: svn commit: r245751 - head/tools

2013-01-22 Thread Pawel Jakub Dawidek
, -T, and -U. Adjust -M support to ignore an argument. I was doing installworld today and it failed on 'install -l ...' saying '/sys/sys' is not empty. When I removed /sys symlink it installed ok. Was this because of your change? -- Pawel Jakub Dawidek http

Re: svn commit: r245751 - head/tools

2013-01-22 Thread Pawel Jakub Dawidek
On Tue, Jan 22, 2013 at 07:00:05PM +0100, Pawel Jakub Dawidek wrote: On Mon, Jan 21, 2013 at 10:32:00PM +, Brooks Davis wrote: Author: brooks Date: Mon Jan 21 22:32:00 2013 New Revision: 245751 URL: http://svnweb.freebsd.org/changeset/base/245751 Log: Implement the -l option

Re: svn commit: r245696 - head/usr.sbin/inetd

2013-01-21 Thread Pawel Jakub Dawidek
*) } } if (sep-se_socktype == SOCK_STREAM) - listen(sep-se_fd, 64); + listen(sep-se_fd, -1); enable(sep); if (debug) { warnx(registered %s on %d, -- Pawel Jakub Dawidek http://www.wheelsystems.com

Re: svn commit: r245696 - head/usr.sbin/inetd

2013-01-21 Thread Pawel Jakub Dawidek
On Mon, Jan 21, 2013 at 12:54:31PM +0400, Andrey Zonov wrote: On 1/21/13 12:49 PM, Pawel Jakub Dawidek wrote: On Sun, Jan 20, 2013 at 07:44:34PM +, Andrey Zonov wrote: Author: zont Date: Sun Jan 20 19:44:33 2013 New Revision: 245696 URL: http://svnweb.freebsd.org/changeset/base

svn commit: r245750 - head/lib/libc/sys

2013-01-21 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Jan 21 22:07:34 2013 New Revision: 245750 URL: http://svnweb.freebsd.org/changeset/base/245750 Log: Note that SIGCHLD is special and if ignored, won't be recorded by the filter. Modified: head/lib/libc/sys/kqueue.2 Modified: head/lib/libc/sys/kqueue.2

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-05 Thread Pawel Jakub Dawidek
tasting cannot tell glabel about changes. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpbkmllYpcbU.pgp Description: PGP signature

svn commit: r244857 - head/cddl/contrib/opensolaris/cmd/zpool

2012-12-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 30 13:47:40 2012 New Revision: 244857 URL: http://svnweb.freebsd.org/changeset/base/244857 Log: Allow to create pool even if mount point directory is not empty if -f is given. Obtained from:WHEEL Systems Modified:

Re: svn commit: r244747 - head/lib/libutil

2012-12-27 Thread Pawel Jakub Dawidek
; } newgr-gr_mem[ndx] = NULL; } -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpcQ60CdtDg8.pgp Description: PGP signature

Re: svn commit: r244682 - head/bin/sh

2012-12-26 Thread Pawel Jakub Dawidek
. + sigstr = strsignal(i); + if (sigstr != NULL) + strcpy(statestr, sigstr); else strcpy(statestr, Suspended); When strsignal(3) can return NULL? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD

Re: svn commit: r244198 - in head: etc/rc.d sbin/sysctl

2012-12-21 Thread Pawel Jakub Dawidek
fclose(), instead you removed fclose(3) and you close(2) after parsefile() returned. You leak FILE structure this way. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am

svn commit: r244424 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:00:09 2012 New Revision: 244424 URL: http://svnweb.freebsd.org/changeset/base/244424 Log: The expand_name() function isn't called with the process lock held anymore, so we can safely use malloc(M_WAITOK) now. Pointed out by: kib Modified:

svn commit: r244426 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:10:14 2012 New Revision: 244426 URL: http://svnweb.freebsd.org/changeset/base/244426 Log: Style cleanups. Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c == ---

svn commit: r244428 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:12:53 2012 New Revision: 244428 URL: http://svnweb.freebsd.org/changeset/base/244428 Log: Do not audit paths we try when kern.corefile contains %I. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r244429 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:14:08 2012 New Revision: 244429 URL: http://svnweb.freebsd.org/changeset/base/244429 Log: The 'flags' argument can be modified in vn_open_cred(), so we need to set it for every loop interation. Pointed out by: kib Modified:

svn commit: r244451 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 23:40:02 2012 New Revision: 244451 URL: http://svnweb.freebsd.org/changeset/base/244451 Log: Use correct file permissions when looking for available core file if kern.corefile contains %I. Obtained from:WHEEL Systems Modified:

svn commit: r244452 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 23:59:48 2012 New Revision: 244452 URL: http://svnweb.freebsd.org/changeset/base/244452 Log: Replace expand_name() function with corefile_open() function, which not only returns name, but also vnode of corefile to use. This simplifies the code and closes few

svn commit: r244347 - head/sys/netpfil/pf

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:10:13 2012 New Revision: 244347 URL: http://svnweb.freebsd.org/changeset/base/244347 Log: Warn about reaching various PF limits. Reviewed by: glebius Obtained from:WHEEL Systems Modified: head/sys/netpfil/pf/pf.c head/sys/netpfil/pf/pf_norm.c

svn commit: r244351 - head/sys/kern

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:48:10 2012 New Revision: 244351 URL: http://svnweb.freebsd.org/changeset/base/244351 Log: Better variables naming in expand_name() to be more consistent with coredump(). Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified:

svn commit: r244352 - head/sys/kern

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:51:22 2012 New Revision: 244352 URL: http://svnweb.freebsd.org/changeset/base/244352 Log: Minor style tweaks. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

Re: svn commit: r244154 - head/bin/ps

2012-12-17 Thread Pawel Jakub Dawidek
On Sat, Dec 15, 2012 at 03:13:00AM +0200, Konstantin Belousov wrote: On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: In that case I'd prefer to make existing kern.pid_max sysctl read-only and make it loader tunable. I don't expect there are many users of this sysctl

svn commit: r244288 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 13:56:38 2012 New Revision: 244288 URL: http://svnweb.freebsd.org/changeset/base/244288 Log: Use 'cred' variable. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r244293 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:14:18 2012 New Revision: 244293 URL: http://svnweb.freebsd.org/changeset/base/244293 Log: Make the check easier to read. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r244294 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:24:59 2012 New Revision: 244294 URL: http://svnweb.freebsd.org/changeset/base/244294 Log: Don't add audit record when coredumps are disabled or name cannot be expanded. Discussed with: rwatson Obtained from:WHEEL Systems Modified:

svn commit: r244296 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:53:27 2012 New Revision: 244296 URL: http://svnweb.freebsd.org/changeset/base/244296 Log: Move expand_name() after process lock is released. This fixed panic where we hold mutex (process lock) and try to obtain sleepable lock (vnode lock in

svn commit: r244316 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:25 2012 New Revision: 244316 URL: http://svnweb.freebsd.org/changeset/base/244316 Log: Prefer snprintf() over sprintf(). Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r244317 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:58 2012 New Revision: 244317 URL: http://svnweb.freebsd.org/changeset/base/244317 Log: Sort flags properly. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r244319 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:04:31 2012 New Revision: 244319 URL: http://svnweb.freebsd.org/changeset/base/244319 Log: Make use of the fact that we changed working directory to the dump directory earlier. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c

svn commit: r244320 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:06:12 2012 New Revision: 244320 URL: http://svnweb.freebsd.org/changeset/base/244320 Log: Implement -m option to savecore(8) that allows to limit number of kernel dumps stored. Once the limit is reached it restarts from 0. Reviewed by: avg Obtained

svn commit: r244321 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:09:27 2012 New Revision: 244321 URL: http://svnweb.freebsd.org/changeset/base/244321 Log: With rotating kernel dumps the higest dump number is not necessarily the last one. To make it easier to find the last one create symlinks with 'last' suffix that will

svn commit: r244323 - in head: . etc/defaults

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:29:56 2012 New Revision: 244323 URL: http://svnweb.freebsd.org/changeset/base/244323 Log: Use new savecore(8) option and limit number of kernel dumps that will be kept around to the 10 most recent ones. Add UPDATING entry with info how to return to the

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
that was lack of a way to limit number of kernel dumps, which could lead to filling /var/ after hitting some panic/reboot cycle. My contribution to solve this is implementation of 3: http://people.freebsd.org/~pjd/patches/savecore.patch The first two should be easy to do. -- Pawel Jakub

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
as possible. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpqjwluHf81m.pgp Description: PGP signature

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
will succeed. I much prefer to either compress the dumps with savecore(8) or use ZFS dataset with compression enabled for /var/crash/. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am

svn commit: r244280 - head/sys/dev/wbwd

2012-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 15 22:26:16 2012 New Revision: 244280 URL: http://svnweb.freebsd.org/changeset/base/244280 Log: sbuf_trim() cannot be used on sbuf with drain function set. This fixes panic when listing sysctls on INVARIANTS-enabled kernel while having wbwd loaded. This panic

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
, so the less code you execute in that state the higher chances your dump will succeed. I much prefer to either compress the dumps with savecore(8) or use ZFS dataset with compression enabled for /var/crash/. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD

svn commit: r244215 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:01:23 2012 New Revision: 244215 URL: http://svnweb.freebsd.org/changeset/base/244215 Log: Whitespace cleanups. Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r244216 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:03:12 2012 New Revision: 244216 URL: http://svnweb.freebsd.org/changeset/base/244216 Log: If we are not going to clear the dump (we are either just checking if the dump exists or we want to keep it), open device read-only. Obtained from:WHEEL

svn commit: r244217 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:04:39 2012 New Revision: 244217 URL: http://svnweb.freebsd.org/changeset/base/244217 Log: The clear option (-c) is not compatible with keep (-k) and compress (-z) options. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c

svn commit: r244218 - in head: etc/rc.d sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:12:08 2012 New Revision: 244218 URL: http://svnweb.freebsd.org/changeset/base/244218 Log: - When checking if a dump exists on the given device there is no need to provide dump directory. Eliminate this redundant argument. This changes the usage, but the

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread Pawel Jakub Dawidek
On Fri, Dec 14, 2012 at 11:52:15AM -0500, John Baldwin wrote: On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: Author: pjd

Re: svn commit: r244188 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-12-14 Thread Pawel Jakub Dawidek
); +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, trim_on_init, CTLFLAG_RW, +vdev_trim_on_init, 0, Enable/disable full vdev trim on initialisation); I'd also make it loader tunable. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wrote: Author: pjd Date: Wed Dec 12 15:45:03 2012 New Revision: 244154 URL: http://svnweb.freebsd.org/changeset/base/244154 Log: Use kern.max_pid

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... How about defining

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 08:16:21PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: On Wed, Dec

svn commit: r244153 - head/lib/libc/gen

2012-12-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 12 15:27:33 2012 New Revision: 244153 URL: http://svnweb.freebsd.org/changeset/base/244153 Log: Eliminate redundant variable. Modified: head/lib/libc/gen/sysctlbyname.c Modified: head/lib/libc/gen/sysctlbyname.c

svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 12 15:45:03 2012 New Revision: 244154 URL: http://svnweb.freebsd.org/changeset/base/244154 Log: Use kern.max_pid sysctl to obtain maximum PID number instead of using local define. Reviewed by: jhb Modified: head/bin/ps/ps.c Modified: head/bin/ps/ps.c

Re: svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:37:00AM -0500, Eitan Adler wrote: On 12 December 2012 10:45, Pawel Jakub Dawidek p...@freebsd.org wrote: + if (sysctlbyname(kern.pid_max, pid_max, intsize, NULL, 0) 0) { + warn(unable to read kern.pid_max); Silly question, when could

svn commit: r244123 - head/sys/sys

2012-12-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Dec 11 19:54:35 2012 New Revision: 244123 URL: http://svnweb.freebsd.org/changeset/base/244123 Log: Similar to CTLFLAG_RDTUN, provide CTLFLAG_RWTUN that defines writable sysctl that can also be modified by loader tunable. Modified: head/sys/sys/sysctl.h Modified:

Re: svn commit: r244106 - head/sbin/sysctl

2012-12-11 Thread Pawel Jakub Dawidek
on boot only (or on module load via kenv(1)). Your change makes it useful to also mark read-write sysctls as tunables and I suspect there is huge number of such sysctls that have no CTLFLAG_TUN flag. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer

Re: svn commit: r243994 - head/sys/kern

2012-12-08 Thread Pawel Jakub Dawidek
On Fri, Dec 07, 2012 at 08:19:03PM -0800, Neel Natu wrote: Hi Pawel, On Fri, Dec 7, 2012 at 2:15 PM, Pawel Jakub Dawidek p...@freebsd.org wrote: Author: pjd Date: Fri Dec 7 22:15:51 2012 New Revision: 243994 URL: http://svnweb.freebsd.org/changeset/base/243994 Log: - Make

Re: svn commit: r243999 - head/sys/kern

2012-12-08 Thread Pawel Jakub Dawidek
On Sat, Dec 08, 2012 at 02:24:03PM +1100, Bruce Evans wrote: On Fri, 7 Dec 2012, Pawel Jakub Dawidek wrote: Log: Configure UMA warnings for the following zones: - unp_zone: kern.ipc.maxsockets limit reached - socket_zone: kern.ipc.maxsockets limit reached These still have part

svn commit: r244031 - head/sys/netinet

2012-12-08 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 8 12:51:06 2012 New Revision: 244031 URL: http://svnweb.freebsd.org/changeset/base/244031 Log: More warnings for zones that depend on the kern.ipc.maxsockets limit. Obtained from:WHEEL Systems Modified: head/sys/netinet/in_pcb.c

svn commit: r243992 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:05:42 2012 New Revision: 243992 URL: http://svnweb.freebsd.org/changeset/base/243992 Log: There is no need anymore to include vm/uma.h after r241726. Obtained from:WHEEL Systems Modified: head/sys/kern/uipc_domain.c Modified:

svn commit: r243993 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:13:33 2012 New Revision: 243993 URL: http://svnweb.freebsd.org/changeset/base/243993 Log: Style cleanups. Modified: head/sys/kern/uipc_socket.c Modified: head/sys/kern/uipc_socket.c

svn commit: r243994 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:15:51 2012 New Revision: 243994 URL: http://svnweb.freebsd.org/changeset/base/243994 Log: - Make socket_zone static - it is used only in this file. - Update maxsockets on uma_zone_set_max(). Obtained from:WHEEL Systems Modified:

svn commit: r243995 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:19:41 2012 New Revision: 243995 URL: http://svnweb.freebsd.org/changeset/base/243995 Log: Style cleanups. Modified: head/sys/kern/kern_mbuf.c Modified: head/sys/kern/kern_mbuf.c ==

svn commit: r243996 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:22:04 2012 New Revision: 243996 URL: http://svnweb.freebsd.org/changeset/base/243996 Log: More style cleanups. Modified: head/sys/kern/kern_mbuf.c Modified: head/sys/kern/kern_mbuf.c

svn commit: r243997 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:23:53 2012 New Revision: 243997 URL: http://svnweb.freebsd.org/changeset/base/243997 Log: Make use of the fact that uma_zone_set_max(9) already returns actual limit set. Modified: head/sys/kern/kern_mbuf.c Modified: head/sys/kern/kern_mbuf.c

svn commit: r243998 - in head: share/man/man9 sys/vm

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:27:13 2012 New Revision: 243998 URL: http://svnweb.freebsd.org/changeset/base/243998 Log: Implemented uma_zone_set_warning(9) function that sets a warning, which will be printed once the given zone becomes full and cannot allocate an item. The warning will

Re: svn commit: r243895 - head/usr.sbin/pw

2012-12-05 Thread Pawel Jakub Dawidek
(file, crontab -u %s -r, pwd-pw_name); system(file); -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl

svn commit: r243861 - head/libexec/rtld-elf

2012-12-04 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Dec 4 12:39:26 2012 New Revision: 243861 URL: http://svnweb.freebsd.org/changeset/base/243861 Log: Change /usr/libexec/ld-elf.so.1 to point at ../../libexec/ld-elf.so.1 instead of /libexec/ld-elf.so.1. Below in the Makefile we execute 'chflags noschg

svn commit: r243862 - head/libexec/rtld-elf

2012-12-04 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Dec 4 12:51:33 2012 New Revision: 243862 URL: http://svnweb.freebsd.org/changeset/base/243862 Log: Do not change entire BINDIR, it might be needed later, just change symlink target. MFC after:2 weeks Modified: head/libexec/rtld-elf/Makefile Modified:

svn commit: r243864 - head/libexec/rtld-elf

2012-12-04 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Dec 4 14:36:01 2012 New Revision: 243864 URL: http://svnweb.freebsd.org/changeset/base/243864 Log: Use absolute path for /usr/libexec/ld-elf.so.1 symlink. Requested by: kan, kib Use -h flags for chflags, so we won't remove 'schg' flag from system's

Re: svn commit: r243762 - head/sys/cddl/contrib/opensolaris/uts/common/fs

2012-12-02 Thread Pawel Jakub Dawidek
bugs in the past. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpJ2Bmj4oaoS.pgp Description: PGP signature

svn commit: r243715 - head/crypto/openssl/crypto/rand

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 22:23:23 2012 New Revision: 243715 URL: http://svnweb.freebsd.org/changeset/base/243715 Log: Allow OpenSSL to use arc4random(3) on FreeBSD. arc4random(3) was modified some time ago to use sysctl instead of /dev/random to get random data, so is now much better

svn commit: r243719 - head/sys/kern

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 22:49:28 2012 New Revision: 243719 URL: http://svnweb.freebsd.org/changeset/base/243719 Log: IFp4 @208450: Remove redundant call to AUDIT_ARG_UPATH1(). Path will be remembered by the following NDINIT(AUDITVNODE1) call. Sponsored by: FreeBSD Foundation

svn commit: r243720 - head/sys/security/audit

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 22:52:35 2012 New Revision: 243720 URL: http://svnweb.freebsd.org/changeset/base/243720 Log: IFp4 @208381: For VOP_GETATTR() we just need vnode to be shared-locked. Sponsored by: FreeBSD Foundation (auditdistd) MFC after:2 weeks Modified:

svn commit: r243722 - head/sys/security/audit

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 22:59:20 2012 New Revision: 243722 URL: http://svnweb.freebsd.org/changeset/base/243722 Log: IFp4 @208382: Currently on each record write we call VFS_STATFS() to get available space on the file system as well as VOP_GETATTR() to get trail file size. We

svn commit: r243723 - head/sys/security/audit

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 23:03:51 2012 New Revision: 243723 URL: http://svnweb.freebsd.org/changeset/base/243723 Log: IFp4 @208383: Currently when we discover that trail file is greater than configured limit we send AUDIT_TRIGGER_ROTATE_KERNEL trigger to the auditd daemon once. If

svn commit: r243727 - head/sys/security/audit

2012-11-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Nov 30 23:21:55 2012 New Revision: 243727 URL: http://svnweb.freebsd.org/changeset/base/243727 Log: IFp4 @208452: Audit handling for missing events: - AUE_READLINKAT - AUE_FACCESSAT - AUE_MKDIRAT - AUE_MKFIFOAT - AUE_MKNODAT - AUE_SYMLINKAT Sponsored

svn commit: r243669 - head/sys/net

2012-11-29 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Nov 29 08:06:23 2012 New Revision: 243669 URL: http://svnweb.freebsd.org/changeset/base/243669 Log: - Use more appropriate loop (do { } while()) when generating ethernet address for bridge interface. - If we found a collision we can break the loop - only one

Re: svn commit: r241726 - head/sys/kern

2012-11-29 Thread Pawel Jakub Dawidek
* of the change so that they can update their dependent limits as required. */ -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpWvE1dQDGWp.pgp

Re: svn commit: r241726 - head/sys/kern

2012-11-29 Thread Pawel Jakub Dawidek
On Thu, Nov 29, 2012 at 09:52:08AM +0100, Pawel Jakub Dawidek wrote: On Fri, Oct 19, 2012 at 10:15:32AM +, Andre Oppermann wrote: Author: andre Date: Fri Oct 19 10:15:32 2012 New Revision: 241726 URL: http://svn.freebsd.org/changeset/base/241726 Log: Move UMA socket zone

svn commit: r243607 - head/sys/kern

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:11:54 2012 New Revision: 243607 URL: http://svnweb.freebsd.org/changeset/base/243607 Log: Style fixes (mostly whitespaces). Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r243608 - head/sys/kern

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:15:58 2012 New Revision: 243608 URL: http://svnweb.freebsd.org/changeset/base/243608 Log: More style fixes. Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c ==

svn commit: r243609 - head/sys/kern

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:16:48 2012 New Revision: 243609 URL: http://svnweb.freebsd.org/changeset/base/243609 Log: Allow to modify kern.sugid_coredump and kern.corefile from loader.conf. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified:

svn commit: r243610 - head/sys/kern

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:22:40 2012 New Revision: 243610 URL: http://svnweb.freebsd.org/changeset/base/243610 Log: Allow to use kill(2) in capability mode, but process can send a signal only to himself. For example abort(3) at first tries to do kill(getpid(), SIGABRT) which was

svn commit: r243612 - in head/sys: kern sys

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:32:35 2012 New Revision: 243612 URL: http://svnweb.freebsd.org/changeset/base/243612 Log: - Add NOCAPCHECK flag to namei that allows lookup to work even if the process is in capability mode. - Add VN_OPEN_NOCAPCHECK flag for vn_open_cred() to will ne

svn commit: r243613 - head/sys/kern

2012-11-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Nov 27 10:38:11 2012 New Revision: 243613 URL: http://svnweb.freebsd.org/changeset/base/243613 Log: Add kern.capmode_coredump sysctl/tunable to allow processes in capability mode to dump core. Reviewed by: rwatson Obtained from:WHEEL Systems MFC after:

Re: svn commit: r243524 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2012-11-25 Thread Pawel Jakub Dawidek
. IllumOS 13887:196932ec9e6a and 13888:7204b3392a58 3236 zio nop-write This is a nice change, although I don't understand why it depends on compression being turned on. It won't save any space. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer

Re: svn commit: r243142 - in head/sys: fs/nfsclient kern sys

2012-11-25 Thread Pawel Jakub Dawidek
On Sun, Nov 25, 2012 at 06:21:52PM +0200, Konstantin Belousov wrote: On Sat, Nov 24, 2012 at 11:24:08PM +0100, Pawel Jakub Dawidek wrote: I think we should move zpfind_locked() under 'pid = PID_MAX': sx_slock(allproc_lock); if (pid = PID_MAX) { p = pfind_locked(pid

Re: svn commit: r243142 - in head/sys: fs/nfsclient kern sys

2012-11-24 Thread Pawel Jakub Dawidek
) { p = pfind_tid_locked(pid); } else { p = NULL; } sx_sunlock(allproc_lock); if (p == NULL) return (ESRCH); -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http

Re: svn commit: r243320 - head/usr.bin/cut

2012-11-21 Thread Pawel Jakub Dawidek
and tabs count as one single field separator. That's very useful. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpKxjLhtDs2N.pgp Description

Re: svn commit: r243341 - head/sys/kern

2012-11-21 Thread Pawel Jakub Dawidek
not rearm the callout if it is already armed and the ticks is negative. Otherwise rearm it to fire in abs(ticks) ticks in the future. Can you document that in taskqueue(9)? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http

Re: svn commit: r242620 - head/bin/sh

2012-11-05 Thread Pawel Jakub Dawidek
cmdtype; /* index identifying command */ + signed char cmdtype;/* index identifying command */ Why not simply 'char'? char rehash;/* if set, cd done since entry created */ char cmdname[]; /* name of command */ }; -- Pawel Jakub Dawidek

<    1   2   3   4   5   6   7   8   9   10   >