Re: svn commit: r368769 - head/sys/net

On Tue, Dec 22, 2020 at 10:31 AM Mateusz Guzik wrote: > > this makes NOIP kernels fail to compile: > > /usr/src/sys/net/rtsock.c:802:11: error: unused variable 'scopeid' > [-Werror,-Wunused-variable] > uint32_t scopeid = 0; > > Fix in progress: https://reviews.freebsd.org/D27730 > On

Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc

On Sat, Dec 19, 2020 at 7:23 PM John Baldwin wrote: > > On 12/19/20 12:38 AM, Ryan Libby wrote: > > Author: rlibby > > Date: Sat Dec 19 08:38:31 2020 > > New Revision: 368789 > > URL: https://svnweb.freebsd.org/changeset/base/368789 > > > > Log: > &

svn commit: r368789 - head/libexec/rtld-elf/rtld-libc

Author: rlibby Date: Sat Dec 19 08:38:31 2020 New Revision: 368789 URL: https://svnweb.freebsd.org/changeset/base/368789 Log: rtld-elf: link udivmoddi4 from compiler_rt This fixes the gcc9 build of rtld-elf32 on amd64, which needed an implementation of udivmoddi4. rtld-elf uses

svn commit: r368788 - head/libexec/rtld-elf/rtld-libc

Author: rlibby Date: Sat Dec 19 08:38:27 2020 New Revision: 368788 URL: https://svnweb.freebsd.org/changeset/base/368788 Log: rtld-libc: fix incremental build ar cr is an update of an archive, not a creation of a new one. During incremental builds (e.g. with meta mode) the archive was

svn commit: r368745 - head/sys/dev/ice

Author: rlibby Date: Thu Dec 17 22:53:45 2020 New Revision: 368745 URL: https://svnweb.freebsd.org/changeset/base/368745 Log: ice: quiet -Wredundant-decls Reapply r364240 after driver update in r365617. Reviewed by: lwhsu Sponsored by: Dell EMC Isilon Differential Revision:

Re: svn commit: r364761 - in head: share/mk sys/conf sys/modules/cloudabi32 sys/modules/cloudabi64 sys/modules/linux sys/modules/linux64

On Mon, Dec 14, 2020 at 2:33 AM Alexander Richardson wrote: > > On Sun, 13 Dec 2020 at 19:22, Ryan Libby wrote: > > > > On Tue, Aug 25, 2020 at 6:30 AM Alex Richardson > > wrote: > > > > > > Author: arichardson > > > Date: Tue Aug 25 13:30:

Re: svn commit: r364761 - in head: share/mk sys/conf sys/modules/cloudabi32 sys/modules/cloudabi64 sys/modules/linux sys/modules/linux64

On Tue, Aug 25, 2020 at 6:30 AM Alex Richardson wrote: > > Author: arichardson > Date: Tue Aug 25 13:30:03 2020 > New Revision: 364761 > URL: https://svnweb.freebsd.org/changeset/base/364761 > > Log: > Pass -fuse-ld=/path/to/ld if ${LD} != "ld" > > This is needed so that setting LD/XLD is not

svn commit: r368569 - head/tests/sys/kern

Author: rlibby Date: Fri Dec 11 22:52:16 2020 New Revision: 368569 URL: https://svnweb.freebsd.org/changeset/base/368569 Log: fdgrowtable_test.c: appease gcc Work around bogus gcc -Wreturn-type. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44511 Reviewed by: kevans, rew

svn commit: r368565 - head/sys/ufs/ffs

Author: rlibby Date: Fri Dec 11 22:51:57 2020 New Revision: 368565 URL: https://svnweb.freebsd.org/changeset/base/368565 Log: ffs: quiet -Wstrict-prototypes Reviewed by: kib, markj, mckusick Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D27558

svn commit: r368564 - head/sys/dev/qat

Author: rlibby Date: Fri Dec 11 22:51:53 2020 New Revision: 368564 URL: https://svnweb.freebsd.org/changeset/base/368564 Log: qat: quiet -Wredundant-decls Reviewed by: markj Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D27554 Modified:

svn commit: r368570 - head/tests/sys/posixshm

Author: rlibby Date: Fri Dec 11 22:52:20 2020 New Revision: 368570 URL: https://svnweb.freebsd.org/changeset/base/368570 Log: posixshm_test.c: remove tautological checks Reviewed by: kib, markj Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r368568 - head/sbin/savecore

Author: rlibby Date: Fri Dec 11 22:52:12 2020 New Revision: 368568 URL: https://svnweb.freebsd.org/changeset/base/368568 Log: savecore: bail on write error even when decompressing Reviewed by: markj Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r368567 - head/sys/modules/zfs

Author: rlibby Date: Fri Dec 11 22:52:08 2020 New Revision: 368567 URL: https://svnweb.freebsd.org/changeset/base/368567 Log: zfs: quiet gcc -Wmissing-include-dirs Don't tell it to look for headers in a non-existent directory. Reviewed by: imp, mmacy Sponsored by: Dell EMC Isilon

svn commit: r368566 - in head/sys: dev/if_wg/include/sys dev/if_wg/module modules/if_wg

Author: rlibby Date: Fri Dec 11 22:52:03 2020 New Revision: 368566 URL: https://svnweb.freebsd.org/changeset/base/368566 Log: if_wg: appease gcc - remove -ferror-limit option - quiet -Wredundant-decls Reviewed by: mmacy Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r368563 - head/sys/dev/ntb/ntb_hw

Author: rlibby Date: Fri Dec 11 22:51:48 2020 New Revision: 368563 URL: https://svnweb.freebsd.org/changeset/base/368563 Log: ntb: quiet gcc -Wreturn-type Reviewed by: cem, markj Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D27553 Modified:

svn commit: r368562 - head/sys/kern

Author: rlibby Date: Fri Dec 11 22:51:44 2020 New Revision: 368562 URL: https://svnweb.freebsd.org/changeset/base/368562 Log: cache_fplookup: quiet gcc -Wreturn-type Reviewed by: markj, mjg Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D27555

svn commit: r368490 - in head/sys: dev/iommu x86/iommu

Author: rlibby Date: Wed Dec 9 18:43:58 2020 New Revision: 368490 URL: https://svnweb.freebsd.org/changeset/base/368490 Log: dmar: reserve memory windows of PCIe root port PCI memory address space is shared between memory-mapped devices (MMIO) and host memory (which may be remapped by

Re: svn commit: r358439 - head/sys/amd64/include

On Wed, Mar 4, 2020 at 10:28 AM Brooks Davis wrote: > > On Wed, Mar 04, 2020 at 12:27:08PM +0100, Guido Falsi wrote: > > On 02/03/20 18:13, Ryan Libby wrote: > > > On Mon, Mar 2, 2020 at 12:45 AM Alexander V. Chernikov > > > wrote: > > >> > > >

Re: svn commit: r358439 - head/sys/amd64/include

On Wed, Mar 4, 2020 at 3:27 AM Guido Falsi wrote: > > On 02/03/20 18:13, Ryan Libby wrote: > > On Mon, Mar 2, 2020 at 12:45 AM Alexander V. Chernikov > > wrote: > >> > >> 28.02.2020, 18:32, "Ryan Libby" : > >>> Author: rlibby >

Re: svn commit: r358439 - head/sys/amd64/include

On Mon, Mar 2, 2020 at 12:45 AM Alexander V. Chernikov wrote: > > 28.02.2020, 18:32, "Ryan Libby" : > > Author: rlibby > > Date: Fri Feb 28 18:32:36 2020 > > New Revision: 358439 > > URL: https://svnweb.freebsd.org/changeset/base/358439 > >

svn commit: r358440 - head/sys/amd64/amd64

Author: rlibby Date: Fri Feb 28 18:32:40 2020 New Revision: 358440 URL: https://svnweb.freebsd.org/changeset/base/358440 Log: amd64 pmap.c: minor codegen optimization in flag access Following previous revision, apply the same minor optimization to hand-rolled atomic_fcmpset_128 in

svn commit: r358439 - head/sys/amd64/include

Author: rlibby Date: Fri Feb 28 18:32:36 2020 New Revision: 358439 URL: https://svnweb.freebsd.org/changeset/base/358439 Log: amd64 atomic.h: minor codegen optimization in flag access Previously the pattern to extract status flags from inline assembly blocks was to use setcc in the block

Re: svn commit: r358377 - head/sys/vm

On Thu, Feb 27, 2020 at 12:23 AM Jeff Roberson wrote: > > Author: jeff > Date: Thu Feb 27 08:23:10 2020 > New Revision: 358377 > URL: https://svnweb.freebsd.org/changeset/base/358377 > > Log: > A pair of performance improvements. > > Swap buckets on free as well as alloc so that alloc is

Re: svn commit: r358257 - in head/sys: kern sys

On Sat, Feb 22, 2020 at 7:53 PM Kyle Evans wrote: > > On Sat, Feb 22, 2020 at 9:32 PM Ryan Libby wrote: > > > > Author: rlibby > > Date: Sun Feb 23 03:32:11 2020 > > New Revision: 358257 > > URL: https://svnweb.freebsd.org/changeset/base/358257 > >

svn commit: r358258 - in head/sys: kern sys

Author: rlibby Date: Sun Feb 23 03:32:16 2020 New Revision: 358258 URL: https://svnweb.freebsd.org/changeset/base/358258 Log: sys/kern: quiet -Wwrite-strings Quiet a variety of Wwrite-strings warnings in sys/kern at low-impact sites. This patch avoids addressing certain others which

svn commit: r358257 - in head/sys: kern sys

Author: rlibby Date: Sun Feb 23 03:32:11 2020 New Revision: 358257 URL: https://svnweb.freebsd.org/changeset/base/358257 Log: vfs: quiet -Wwrite-strings Reviewed by: kib, markj Differential Revision:https://reviews.freebsd.org/D23797 Modified: head/sys/kern/vfs_subr.c

svn commit: r358256 - in head/sys: kern sys vm

Author: rlibby Date: Sun Feb 23 03:32:04 2020 New Revision: 358256 URL: https://svnweb.freebsd.org/changeset/base/358256 Log: sys/vm: quiet -Wwrite-strings Discussed with: kib Reviewed by: markj Differential Revision:https://reviews.freebsd.org/D23796 Modified:

svn commit: r358094 - head/sys/powerpc/aim

Author: rlibby Date: Wed Feb 19 04:46:41 2020 New Revision: 358094 URL: https://svnweb.freebsd.org/changeset/base/358094 Log: powerpc: unconditionally mark SLB zones UMA_ZONE_CONTIG PR: 244118 Reported by: Francis Little Tested by:Francis Little, Mark Millard

svn commit: r357644 - head/sys/sys

Author: rlibby Date: Fri Feb 7 00:47:58 2020 New Revision: 357644 URL: https://svnweb.freebsd.org/changeset/base/357644 Log: smr.h: fix build after r357641 r357641 missed committing the change to sys/sys/smr.h. Reported by: jkim Submitted by: jeff Reviewed by: rlibby

svn commit: r357611 - head/libexec/rc/rc.d

Author: rlibby Date: Thu Feb 6 08:32:30 2020 New Revision: 357611 URL: https://svnweb.freebsd.org/changeset/base/357611 Log: auditd_stop: wait_for_pids instead of sleeping It's faster and more reliable to wait_for_pids than to sleep 1. cem@ suggested just to remove auditd_stop() and

svn commit: r357610 - head/sys/vm

Author: rlibby Date: Thu Feb 6 08:32:25 2020 New Revision: 357610 URL: https://svnweb.freebsd.org/changeset/base/357610 Log: uma: remove UMA_ZFLAG_CACHEONLY flag UMA_ZFLAG_CACHEONLY was essentially the same thing as UMA_ZONE_VM, but with a more confusing name. Remove the flag, make

svn commit: r357548 - in head/sys: i386/i386 kern powerpc/aim

Author: rlibby Date: Tue Feb 4 22:40:23 2020 New Revision: 357548 URL: https://svnweb.freebsd.org/changeset/base/357548 Log: uma: convert mbuf_jumbo_alloc to UMA_ZONE_CONTIG & tag others Remove mbuf_jumbo_alloc and let large mbuf zones use the new uma default contig allocator (a copy of

svn commit: r357550 - head/sys/vm

Author: rlibby Date: Tue Feb 4 22:40:45 2020 New Revision: 357550 URL: https://svnweb.freebsd.org/changeset/base/357550 Log: uma: multipage chicken switch Add a switch to allow disabling multipage slabs, in order to facilitate measuring memory usage and performance effects. The tunable

svn commit: r357549 - head/sys/vm

Author: rlibby Date: Tue Feb 4 22:40:34 2020 New Revision: 357549 URL: https://svnweb.freebsd.org/changeset/base/357549 Log: uma: grow slabs to enforce minimum memory efficiency Memory efficiency can be poor with awkward item sizes (e.g. 1/2 or 1 page size + epsilon). In order to

svn commit: r357547 - in head: share/man/man9 sys/vm

Author: rlibby Date: Tue Feb 4 22:40:11 2020 New Revision: 357547 URL: https://svnweb.freebsd.org/changeset/base/357547 Log: uma: add UMA_ZONE_CONTIG, and a default contig_alloc For now, copy the mbuf allocator. Reviewed by: jeff, markj (previous version) Sponsored by: Dell EMC

svn commit: r357546 - head/sys/vm

Author: rlibby Date: Tue Feb 4 22:39:58 2020 New Revision: 357546 URL: https://svnweb.freebsd.org/changeset/base/357546 Log: uma: pcpu_page_free needs to startup_free pages from startup_alloc After r357392, it is apparent that we do have some early-boot PCPU zones. Make it so we can

svn commit: r357019 - head/sys/vm

Author: rlibby Date: Thu Jan 23 04:56:38 2020 New Revision: 357019 URL: https://svnweb.freebsd.org/changeset/base/357019 Log: uma: fix zone domain overlaying pcpu cache with disabled cpus UMA zone structures have two arrays at the end which are sized according to the machine: an array of

svn commit: r357018 - head/sys/vm

Author: rlibby Date: Thu Jan 23 04:56:34 2020 New Revision: 357018 URL: https://svnweb.freebsd.org/changeset/base/357018 Log: uma: report leaks more accurately Previously UMA had some false negatives in the leak report at keg destruction time, where it only reported leaks if there were

Re: svn commit: r356919 - head/sys/x86/x86

On Mon, Jan 20, 2020 at 9:23 AM Konstantin Belousov wrote: > > Author: kib > Date: Mon Jan 20 17:23:03 2020 > New Revision: 356919 > URL: https://svnweb.freebsd.org/changeset/base/356919 > > Log: > x86: Wait for curthread to be set up as an indicator that the boot stack > is no longer used. >

svn commit: r356716 - head/sys/kern

Author: rlibby Date: Tue Jan 14 02:14:02 2020 New Revision: 356716 URL: https://svnweb.freebsd.org/changeset/base/356716 Log: malloc: remove assumptions about MINALLOCSIZE Remove assumptions about the minimum MINALLOCSIZE, in order to allow testing of smaller MINALLOCSIZE. A following

svn commit: r356717 - head/sys/vm

Author: rlibby Date: Tue Jan 14 02:14:15 2020 New Revision: 356717 URL: https://svnweb.freebsd.org/changeset/base/356717 Log: uma: split slabzone into two sizes By allowing more items per slab, we can improve memory efficiency for small allocs. If we were just to increase the bitmap

svn commit: r356715 - head/sys/vm

Author: rlibby Date: Tue Jan 14 02:13:46 2020 New Revision: 356715 URL: https://svnweb.freebsd.org/changeset/base/356715 Log: uma: fixup some ktr messages Reviewed by: markj Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D23148 Modified:

Re: svn commit: r356613 - head/sys/dev/virtio/network

On Fri, Jan 10, 2020 at 1:22 PM Gleb Smirnoff wrote: > > Author: glebius > Date: Fri Jan 10 21:22:03 2020 > New Revision: 356613 > URL: https://svnweb.freebsd.org/changeset/base/356613 > > Log: > Add pfil(9) hook to vtnet(4). > > The patch could be simplier, using only the second chunk to >

svn commit: r356535 - head/sys/vm

Author: rlibby Date: Thu Jan 9 02:03:17 2020 New Revision: 356535 URL: https://svnweb.freebsd.org/changeset/base/356535 Log: uma: unify layout paths and improve efficiency Unify the keg layout selection paths (keg_small_init, keg_large_init, keg_cachespread_init), and slightly improve

svn commit: r356534 - in head: share/man/man9 sys/arm/arm sys/vm

Author: rlibby Date: Thu Jan 9 02:03:03 2020 New Revision: 356534 URL: https://svnweb.freebsd.org/changeset/base/356534 Log: uma: reorganize flags - Garbage collect UMA_ZONE_PAGEABLE & UMA_ZONE_STATIC. - Move flag VTOSLAB from public to private. - Introduce public NOTPAGE flag and

svn commit: r355976 - head/contrib/googletest/googlemock/include/gmock/internal

Author: rlibby Date: Sat Dec 21 02:44:50 2019 New Revision: 355976 URL: https://svnweb.freebsd.org/changeset/base/355976 Log: googletest: pick from upstream: Don't allow signed/unsigned wchar_t in gcc 9 and later Pick 711fccf8317b4fb7adc21c00fc1e20823c5d875f from upstream googletest:

svn commit: r355974 - head/lib/libdevdctl

Author: rlibby Date: Sat Dec 21 02:44:26 2019 New Revision: 355974 URL: https://svnweb.freebsd.org/changeset/base/355974 Log: libdevdctl: g++9 avoid Wdeprecated-copy g++9 now warns about having defined an assignment operator but using the default copy constructor, or vice versa. Avoid

svn commit: r355975 - head/contrib/jemalloc/src

Author: rlibby Date: Sat Dec 21 02:44:38 2019 New Revision: 355975 URL: https://svnweb.freebsd.org/changeset/base/355975 Log: jemalloc: pick from upstream: Fix GCC-9.1 warning with macro GET_ARG_NUMERIC Pick 2d6d099fed05b1509e81e54458516528bfbbf38d from upstream jemalloc: Fix

svn commit: r355971 - head/share/mk

Author: rlibby Date: Sat Dec 21 02:43:49 2019 New Revision: 355971 URL: https://svnweb.freebsd.org/changeset/base/355971 Log: gcc9: quiet Waddress-of-packed-member for user build Disable the warning for WARNS <= 3. This is lame, but it's what we already do for the clang build.

svn commit: r355972 - in head: sbin/camcontrol sys/sys

Author: rlibby Date: Sat Dec 21 02:44:00 2019 New Revision: 355972 URL: https://svnweb.freebsd.org/changeset/base/355972 Log: Declare packed struct ata_params as 2-byte-aligned This avoids gcc9 warning about unaligned access to the structure when casting to uint16_t pointer type.

svn commit: r355973 - head/cddl/contrib/opensolaris/lib/libdtrace/common

Author: rlibby Date: Sat Dec 21 02:44:13 2019 New Revision: 355973 URL: https://svnweb.freebsd.org/changeset/base/355973 Log: dtrace: avoid gcc9 Walloca-larger-than gcc9 grew a new warning for unbounded allocas, such as the one in dt_options_load. Remove both uses of alloca in

svn commit: r355970 - head/sys/conf

Author: rlibby Date: Sat Dec 21 02:43:37 2019 New Revision: 355970 URL: https://svnweb.freebsd.org/changeset/base/355970 Log: gcc9: quiet Waddress-of-packed-member for kernel build This is lame, but it's what we already do for the clang build. We take misaligned pointers into network

svn commit: r355969 - head/sys/sys

Author: rlibby Date: Sat Dec 21 02:43:20 2019 New Revision: 355969 URL: https://svnweb.freebsd.org/changeset/base/355969 Log: gcc: quiet Wattribute for no_sanitize("address") This is an unfortunate instance where the __has_attribute check does not function usefully. Gcc does have the

Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys

On Mon, Dec 16, 2019 at 7:30 AM Ed Maste wrote: > > On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: > > > > Author: jeff > > Date: Sun Dec 15 21:26:50 2019 > > New Revision: 355784 > > URL: https://svnweb.freebsd.org/changeset/base/355784 > > > > Log: > > schedlock 4/4 > > FYI i386, arm,

Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo

On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer wrote: > > Author: cem > Date: Sat Dec 14 08:28:10 2019 > New Revision: 355747 > URL: https://svnweb.freebsd.org/changeset/base/355747 > > Log: > Deprecate sranddev(3) API > > It serves no useful purpose and wasn't as popular as its equally

svn commit: r355746 - head/sys/vm

Author: rlibby Date: Sat Dec 14 05:21:56 2019 New Revision: 355746 URL: https://svnweb.freebsd.org/changeset/base/355746 Log: uma dbg: flexible size for slab debug bitset too Recently (r355315) the size of the struct uma_slab bitset field us_free became dynamic instead of conservative.

svn commit: r355711 - in head: lib/libmemstat sys/vm

Author: rlibby Date: Fri Dec 13 11:21:28 2019 New Revision: 355711 URL: https://svnweb.freebsd.org/changeset/base/355711 Log: Revert r355706 & r355710 The quick fix didn't work. I'll sort it out tomorrow. Revert r355710: "libmemstat: unbreak build" Revert r355706: "uma dbg:

svn commit: r355710 - head/lib/libmemstat

Author: rlibby Date: Fri Dec 13 10:34:19 2019 New Revision: 355710 URL: https://svnweb.freebsd.org/changeset/base/355710 Log: libmemstat: unbreak build r355706 added an instance of offsetof() to the UMA private kernel header file uma_int.h. Userspace memstat_uma.c includes that header,

svn commit: r355709 - in head: share/man/man9 sys/i386/i386 sys/kern sys/sparc64/sparc64 sys/sys sys/x86/x86

Author: rlibby Date: Fri Dec 13 09:32:16 2019 New Revision: 355709 URL: https://svnweb.freebsd.org/changeset/base/355709 Log: bitset: rename confusing macro NAND to ANDNOT s/BIT_NAND/BIT_ANDNOT/, and for CPU and DOMAINSET too. The actual implementation is "and not" (or "but not"), i.e.

svn commit: r355706 - head/sys/vm

Author: rlibby Date: Fri Dec 13 09:31:59 2019 New Revision: 355706 URL: https://svnweb.freebsd.org/changeset/base/355706 Log: uma dbg: flexible size for slab debug bitset too Recently (r355315) the size of the struct uma_slab bitset field us_free became dynamic instead of conservative.

svn commit: r355708 - head/sys/vm

Author: rlibby Date: Fri Dec 13 09:32:09 2019 New Revision: 355708 URL: https://svnweb.freebsd.org/changeset/base/355708 Log: uma: report slab efficiency Reviewed by: jeff Sponsored by: Dell EMC Isilon Differential Revision:https://reviews.freebsd.org/D22766 Modified:

svn commit: r355707 - head/sys/vm

Author: rlibby Date: Fri Dec 13 09:32:03 2019 New Revision: 355707 URL: https://svnweb.freebsd.org/changeset/base/355707 Log: uma: delay bucket_init() until we might actually enable buckets This helps with a bootstrapping problem in upcoming work. We don't first enable buckets until

svn commit: r355605 - head/sys/vm

Author: rlibby Date: Wed Dec 11 06:50:55 2019 New Revision: 355605 URL: https://svnweb.freebsd.org/changeset/base/355605 Log: uma: pretty print zone flags sysctl Requested by: jeff Reviewed by: jeff, markj Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r355400 - head/sys/sys

Author: rlibby Date: Wed Dec 4 20:15:17 2019 New Revision: 355400 URL: https://svnweb.freebsd.org/changeset/base/355400 Log: bistring: avoid gcc -Wsign-compare Appease gcc after after r355377, which broke gcc builds. Reviewed by: dougm MFC with: r355377 Differential

svn commit: r355396 - head/sys/kern

Author: rlibby Date: Wed Dec 4 18:21:29 2019 New Revision: 355396 URL: https://svnweb.freebsd.org/changeset/base/355396 Log: mbuf zones: take out the trash The mbuf zones were explicitly specifying the uma trash procedures on zcreate, conditionally on INVARIANTS, because that used to be

Re: svn commit: r355137 - head/sys/vm

On Tue, Dec 3, 2019 at 1:12 PM Ian Lepore wrote: > > On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > > +* XXX UMA_ZONE_OFFPAGE. > > All over freebsd we have cryptic XXX comments that have no meaning to > anyone except whoever wrote them (and, I susp

Re: svn commit: r355137 - head/sys/vm

On Tue, Dec 3, 2019 at 12:43 PM Gleb Smirnoff wrote: > > Ryan, > > On Wed, Nov 27, 2019 at 07:49:56PM +, Ryan Libby wrote: > R> Author: rlibby > R> Date: Wed Nov 27 19:49:55 2019 > R> New Revision: 355137 > R> URL: https://svnweb.freebsd.org/changeset/b

svn commit: r355343 - head/sys/mips/mips

Author: rlibby Date: Tue Dec 3 17:43:52 2019 New Revision: 355343 URL: https://svnweb.freebsd.org/changeset/base/355343 Log: mips busdma: bzero map on alloc Maps from the mips busdma dmamap_zone were not completely initialized. In particular, pagesneeded and pagesreserved were not

svn commit: r355344 - head/sys/sys

Author: rlibby Date: Tue Dec 3 17:43:57 2019 New Revision: 355344 URL: https://svnweb.freebsd.org/changeset/base/355344 Log: bitset: avoid pessimized code when bitset size is not constant We have a couple optimizations for when the bitset is known to be just one word. But with

svn commit: r355208 - head/sys/conf

Author: rlibby Date: Fri Nov 29 06:25:07 2019 New Revision: 355208 URL: https://svnweb.freebsd.org/changeset/base/355208 Log: kern.mk: -Wno-error=stringop-overflow for gcc due to false positives Demote gcc's Wstringop-overflow to Wno-error due to false positives. E.g. the riscv64 build

svn commit: r355207 - head/sys/kern

Author: rlibby Date: Fri Nov 29 06:25:03 2019 New Revision: 355207 URL: https://svnweb.freebsd.org/changeset/base/355207 Log: ktls_session zone: don't need to specify uma trash The use of the uma trash procedures is automatic, there's no need to pass them explicitly here. Reviewed

svn commit: r355166 - head/sys/vm

Author: rlibby Date: Thu Nov 28 04:15:16 2019 New Revision: 355166 URL: https://svnweb.freebsd.org/changeset/base/355166 Log: uma: move sysctl vm.uma defn out from under INVARIANTS Fix non-INVARIANTS builds after r355149. Reported by: Michael Butler Reviewed by: markj

svn commit: r355137 - head/sys/vm

Author: rlibby Date: Wed Nov 27 19:49:55 2019 New Revision: 355137 URL: https://svnweb.freebsd.org/changeset/base/355137 Log: uma: trash memory when ctor/dtor supplied too On INVARIANTS kernels, UMA has a use-after-free detection mechanism. This mechanism previously required that all of

svn commit: r355126 - in head/sys: kern sys

Author: rlibby Date: Wed Nov 27 01:54:39 2019 New Revision: 355126 URL: https://svnweb.freebsd.org/changeset/base/355126 Log: witness: sleepable rm locks are not sleepable in read mode There are two classes of rm lock, one "sleepable" and one not. But even a "sleepable" rm lock is only

svn commit: r355103 - head/sys/netinet

Author: rlibby Date: Mon Nov 25 22:25:34 2019 New Revision: 355103 URL: https://svnweb.freebsd.org/changeset/base/355103 Log: in_mcast.c: need if_addr_lock around inm_release_deferred Apply a similar fix as for in6_mcast.c. Reviewed by: hselasky Sponsored by: Dell EMC Isilon

svn commit: r355102 - head/sys/netinet6

Author: rlibby Date: Mon Nov 25 22:25:10 2019 New Revision: 355102 URL: https://svnweb.freebsd.org/changeset/base/355102 Log: in6_joingroup_locked: need if_addr_lock around in6m_disconnect_locked It looks like the call that requires the lock was introduced in r337866. Reviewed by:

Re: svn commit: r355101 - head/sys/dev/cfi

On Mon, Nov 25, 2019 at 1:21 PM Ed Maste wrote: > > Author: emaste > Date: Mon Nov 25 21:21:37 2019 > New Revision: 355101 > URL: https://svnweb.freebsd.org/changeset/base/355101 > > Log: > cfi: check for inter overflow in cfi_devioctl > > Reported by:Pietro Oliva > Reviewed by: markj

svn commit: r355083 - head/sys/kern

Author: rlibby Date: Mon Nov 25 07:38:27 2019 New Revision: 355083 URL: https://svnweb.freebsd.org/changeset/base/355083 Log: sysctl sysctls: wire old buf before output with sysctl lock Several sysctl sysctls output to a user buffer while holding a non-sleepable lock that protects the

svn commit: r355084 - head/sys/vm

Author: rlibby Date: Mon Nov 25 07:38:31 2019 New Revision: 355084 URL: https://svnweb.freebsd.org/changeset/base/355084 Log: vm_object_collapse_scan_wait: drop locks before reacquiring Regression from r352174. In the vm_page_rename() failure case we forgot to unlock the vm object locks

svn commit: r349586 - head/sys/geom/eli

Author: rlibby Date: Mon Jul 1 22:06:16 2019 New Revision: 349586 URL: https://svnweb.freebsd.org/changeset/base/349586 Log: g_eli_create: only dec g_access acw if we inc'd it Reviewed by: cem, markj Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r349587 - head/sys/geom/mirror

Author: rlibby Date: Mon Jul 1 22:06:36 2019 New Revision: 349587 URL: https://svnweb.freebsd.org/changeset/base/349587 Log: g_mirror_taste: avoid deadlock, always clear tasting flag If g_mirror_taste encountered an error at g_mirror_add_disk, it might try to g_mirror_destroy the device

svn commit: r349373 - head/sys/netipsec

Author: rlibby Date: Tue Jun 25 15:43:52 2019 New Revision: 349373 URL: https://svnweb.freebsd.org/changeset/base/349373 Log: netipsec key_register: check for M_NOWAIT alloc failure Reviewed by: ae, cem Sponsored by: Dell EMC Isilon Differential Revision:

svn commit: r349288 - head/sys/ddb

Author: rlibby Date: Sat Jun 22 05:35:23 2019 New Revision: 349288 URL: https://svnweb.freebsd.org/changeset/base/349288 Log: ddb show proc typo Modified: head/sys/ddb/db_ps.c Modified: head/sys/ddb/db_ps.c == ---

svn commit: r348770 - in head: share/man/man9 sys/sys

Author: rlibby Date: Fri Jun 7 04:09:12 2019 New Revision: 348770 URL: https://svnweb.freebsd.org/changeset/base/348770 Log: Allow fail points to have separate declarations, definitions, and evals Submitted by: Matthew Bryan Reviewed by: cem Sponsored by: Dell EMC Isilon

svn commit: r347646 - head/sys/ddb

Author: rlibby Date: Thu May 16 05:29:54 2019 New Revision: 347646 URL: https://svnweb.freebsd.org/changeset/base/347646 Log: db show thread: avoid overflow in tick conversion The previous calculations for displaying the time since last switch easily overflowed, after less than 36 min

svn commit: r347645 - head/sys/x86/iommu

Author: rlibby Date: Thu May 16 04:24:08 2019 New Revision: 347645 URL: https://svnweb.freebsd.org/changeset/base/347645 Log: iommu static analysis cleanup A static analyzer complained about a couple instances of checking a variable against NULL after already having dereferenced it. -

svn commit: r347628 - in head/sys: amd64/amd64 i386/i386

Author: rlibby Date: Wed May 15 18:13:43 2019 New Revision: 347628 URL: https://svnweb.freebsd.org/changeset/base/347628 Log: x86: spell vpxor %zmm0 as vpxord Fix gcc/gas amd64 & i386 build after r347566. Reviewed by: kib Sponsored by: Dell EMC Isilon Differential Revision:

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

[Re-sending from my subscription address, sorry for the spam] On Fri, Jun 29, 2018 at 1:26 PM, John Baldwin wrote: > On 6/28/18 7:54 PM, Mark Millard wrote: >> On 2018-Jun-28, at 6:04 PM, Mark Millard wrote: >> >>> On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: >>> [ ci.free.bsd.org

Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build)

On Fri, Jun 29, 2018 at 1:26 PM, John Baldwin wrote: > On 6/28/18 7:54 PM, Mark Millard wrote: >> On 2018-Jun-28, at 6:04 PM, Mark Millard wrote: >> >>> On 2018-Jun-28, at 5:39 PM, Mark Millard wrote: >>> [ ci.free.bsd.org jumped from -r335773 (built) to -r335784 (failed) for

Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core

On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy wrote: > Author: mmacy > Date: Wed Jun 13 23:30:54 2018 > New Revision: 335094 > URL: https://svnweb.freebsd.org/changeset/base/335094 > > Log: > fix OFED build after r335053 > > Modified: > head/sys/ofed/drivers/infiniband/core/ib_user_mad.c > >

svn commit: r335076 - head/sys/i386/i386

Author: rlibby Date: Wed Jun 13 19:57:03 2018 New Revision: 335076 URL: https://svnweb.freebsd.org/changeset/base/335076 Log: i386: copyin/copyout error is EFAULT Discussed with: kib MFC with: r332489 Sponsored by: Dell EMC Isilon Modified: head/sys/i386/i386/copyout.c

svn commit: r334957 - in head: lib/libpmc usr.sbin/pmc

Author: rlibby Date: Mon Jun 11 16:09:54 2018 New Revision: 334957 URL: https://svnweb.freebsd.org/changeset/base/334957 Log: pmc gcc fixups Fix the build of lib/libpmc and usr.sbin/pmc for gcc on amd64. Reviewed by:mmacy Sponsored by: Dell EMC Isilon Differential Revision:

Re: svn commit: r334708 - head/sys/kern

On Thu, Jun 7, 2018 at 10:03 PM, Mateusz Guzik wrote: > On Fri, Jun 8, 2018 at 6:29 AM, Ryan Libby wrote: >> >> On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: >> > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> >> On Wed, Jun

Re: svn commit: r334708 - head/sys/kern

On Thu, Jun 7, 2018 at 8:32 PM, Mark Johnston wrote: > On Wed, Jun 06, 2018 at 05:03:11PM +0300, Konstantin Belousov wrote: >> On Wed, Jun 06, 2018 at 12:57:12PM +, Justin Hibbits wrote: >> > Author: jhibbits >> > Date: Wed Jun 6 12:57:11 2018 >> > New Revision: 334708 >> > URL:

Re: svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

On Sat, Oct 21, 2017 at 12:43 AM, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> wrote: > >> On Oct 21, 2017, at 00:23, Ryan Libby <rli...@freebsd.org> wrote: >> >> Author: rlibby >> Date: Sat Oct 21 07:23:45 2017 >> New Revision: 324811 >> UR

svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

Author: rlibby Date: Sat Oct 21 07:23:45 2017 New Revision: 324811 URL: https://svnweb.freebsd.org/changeset/base/324811 Log: pms/freebsd: fix compiler warnings - A number of unused variable warnings, - a missing prototype warning (actually a dead function), - and a potential use of

svn commit: r324728 - in head/sys/dev: qlnx/qlnxe qlxgb qlxgbe qlxge

Author: rlibby Date: Wed Oct 18 19:28:28 2017 New Revision: 324728 URL: https://svnweb.freebsd.org/changeset/base/324728 Log: ql*_def.h: fix QL_ALIGN parenthesization QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with

Re: svn commit: r324713 - head/sys/fs/ext2fs

On Tue, Oct 17, 2017 at 11:21 PM, Fedor Uporov wrote: > Ryan, > > Seems like, I lost the dual declaration when made the merging and then did > not check the gcc build. > > Thanks for fix. > No problem. Welcome aboard.

svn commit: r324713 - head/sys/fs/ext2fs

Author: rlibby Date: Wed Oct 18 00:41:23 2017 New Revision: 324713 URL: https://svnweb.freebsd.org/changeset/base/324713 Log: ext2: delete redundant decl of ext2_fserr Fix gcc build after r324706. Reviewed by: pfg Differential Revision:https://reviews.freebsd.org/D12709

svn commit: r324705 - head/sys/dev/cxgbe/tom

Author: rlibby Date: Tue Oct 17 20:37:31 2017 New Revision: 324705 URL: https://svnweb.freebsd.org/changeset/base/324705 Log: cxgbe: delete now-redundant vnet decls r324539 gathered some vnet decls into netinet/tcp_var.h, so that they are now redundant in

  1   2   >