Re: svn commit: r368721 - head/stand/efi/loader

2020-12-17 Thread Warner Losh
On Thu, Dec 17, 2020 at 1:00 PM Andrew Gallatin wrote: > On 12/17/20 2:49 PM, Kyle Evans wrote: > > On Thu, Dec 17, 2020 at 1:47 PM Andrew Gallatin > wrote: > >> > >> On 12/17/20 12:02 PM, Warner Losh wrote: > >>> Author: imp > >>> Dat

svn commit: r368721 - head/stand/efi/loader

2020-12-17 Thread Warner Losh
Author: imp Date: Thu Dec 17 17:02:09 2020 New Revision: 368721 URL: https://svnweb.freebsd.org/changeset/base/368721 Log: Drop EFI_STAGING_SIZE back down to 64M vmware can't cope with anything larger than 64MB. Drop this back to 64MB everywhere but arm. PR: 251866 MFC After: 1

Re: svn commit: r368585 - in head: sys/dev/gpio sys/sys tools/test tools/test/gpioevents usr.sbin/gpioctl

2020-12-12 Thread Warner Losh
FWIW I generally approved the code, but didn't have the time to review it in detail. I got the impression people were at least generally happy from the review. Thanks so much for picking this up. Warner On Sat, Dec 12, 2020, 11:34 AM Ian Lepore wrote: > Author: ian > Date: Sat Dec 12 18:34:15

svn commit: r368352 - head/sys/dev/nvme

2020-12-04 Thread Warner Losh
Author: imp Date: Fri Dec 4 21:34:48 2020 New Revision: 368352 URL: https://svnweb.freebsd.org/changeset/base/368352 Log: nvme: Remove a wmb() that's not necessary. bus_dmamap_sync() ensures that memory that's prepared for PREWRITE can be DMA'd immediately after it returns. The details

svn commit: r368351 - head/sys/x86/x86

2020-12-04 Thread Warner Losh
Author: imp Date: Fri Dec 4 21:34:04 2020 New Revision: 368351 URL: https://svnweb.freebsd.org/changeset/base/368351 Log: busdma: Annotate bus_dmamap_sync() with fence Add an explicit thread fence release before returning from bus_dmamap_sync. This should be a no-op in practice, but

Re: svn commit: r368329 - head/stand/kshim

2020-12-04 Thread Warner Losh
On Fri, Dec 4, 2020 at 9:06 AM Hans Petter Selasky wrote: > On 12/4/20 4:59 PM, Alexander Richardson wrote: > > On Fri, 4 Dec 2020 at 14:51, Hans Petter Selasky > wrote: > >> > >> Author: hselasky > >> Date: Fri Dec 4 14:50:55 2020 > >> New Revision: 368329 > >> URL:

Re: svn commit: r368279 - head/sys/dev/nvme

2020-12-02 Thread Warner Losh
On Wed, Dec 2, 2020 at 10:48 AM Konstantin Belousov wrote: > On Wed, Dec 02, 2020 at 04:54:24PM +, Michal Meloun wrote: > > Author: mmel > > Date: Wed Dec 2 16:54:24 2020 > > New Revision: 368279 > > URL: https://svnweb.freebsd.org/changeset/base/368279 > > > > Log: > > NVME: Multiple

Re: svn commit: r368187 - head/sys/dev/nvme

2020-11-30 Thread Warner Losh
On Mon, Nov 30, 2020 at 9:56 AM Michal Meloun wrote: > > > On 30.11.2020 17:02, Ian Lepore wrote: > > On Mon, 2020-11-30 at 14:51 +, Michal Meloun wrote: > >> Author: mmel > >> Date: Mon Nov 30 14:51:48 2020 > >> New Revision: 368187 > >> URL: https://svnweb.freebsd.org/changeset/base/368187

Re: svn commit: r368045 - in head: . etc/mtree rescue/rescue sbin sbin/ping sbin/ping/tests sbin/ping6 sbin/ping6/tests tools/build/mk

2020-11-26 Thread Warner Losh
On Thu, Nov 26, 2020, 8:37 AM Alan Somers wrote: > > > > > > >> > > I think you should add a LINKS=... here so people script which uses >> > > ping6 won't break (and of course adding support in the code to do ipv6 >> > > ping if progname is ping6 if this isn't the case). >> > > >> > > Cheers,

svn commit: r367963 - head/sbin/devd

2020-11-23 Thread Warner Losh
Author: imp Date: Mon Nov 23 18:37:19 2020 New Revision: 367963 URL: https://svnweb.freebsd.org/changeset/base/367963 Log: Prefer Em to Ar for emphasis Em is better than Ar if all we want to do is underline the text. Submitted by: yuripv@ Modified: head/sbin/devd/devd.conf.5

svn commit: r367847 - head/share/man/man4

2020-11-19 Thread Warner Losh
020 M. Warner Losh +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, are permitted provided that the following conditions +.\" are met: +.\" 1. Redistributions of source code must retain the above copyright +.\"

svn commit: r367810 - head/usr.sbin/mergemaster

2020-11-18 Thread Warner Losh
Author: imp Date: Wed Nov 18 19:22:24 2020 New Revision: 367810 URL: https://svnweb.freebsd.org/changeset/base/367810 Log: mergemaster: handle symbolic links during update. /etc/os-release is now a symbolic link to a generated file. Make mergemaster cope with symbolic links generically.

Re: svn commit: r367692 - head/sys/sys

2020-11-17 Thread Warner Losh
On Tue, Nov 17, 2020 at 3:18 PM John Baldwin wrote: > On 11/14/20 2:34 PM, Warner Losh wrote: > > true, but a version bump forces that and versions are cheap enough... > > Strictly speaking, version bumps don't force anything to recompile, they > just ensure that newer

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Warner Losh
On Sun, Nov 15, 2020 at 1:13 PM Scott Long wrote: > > > On Nov 15, 2020, at 1:05 PM, Warner Losh wrote: > > > > Hey Scott, > > > > On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > > The man page for strlcpy() made reference to the return value being

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Warner Losh
Hey Scott, On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > The man page for strlcpy() made reference to the return value being > equivalent to what snprintf() does. The man page for snprintf() states > that negatve return values are possible, so I assumed the same was > true for

Re: svn commit: r367692 - head/sys/sys

2020-11-14 Thread Warner Losh
true, but a version bump forces that and versions are cheap enough... Warner On Sat, Nov 14, 2020 at 1:58 PM Mateusz Guzik wrote: > you are expected to recompile all your kernel modules every time you > update head > > On 11/14/20, Shawn Webb wrote: > > Are there any kernel modules (in base,

svn commit: r367581 - head/sys/conf

2020-11-10 Thread Warner Losh
Author: imp Date: Tue Nov 10 23:25:16 2020 New Revision: 367581 URL: https://svnweb.freebsd.org/changeset/base/367581 Log: Add INIT_ALL_ZERO and INIT_ALL_PATTERN to kern.opts.mk These options need to be in the kern.opts.mk file to be alive for kernel and module builds. This also reverts

svn commit: r367514 - head/sys/dev/bxe

2020-11-08 Thread Warner Losh
Author: imp Date: Mon Nov 9 03:02:34 2020 New Revision: 367514 URL: https://svnweb.freebsd.org/changeset/base/367514 Log: Remove newline from bxe description, it's not done elsewhere. Modified: head/sys/dev/bxe/bxe.c Modified: head/sys/dev/bxe/bxe.c

svn commit: r367475 - head

2020-11-07 Thread Warner Losh
Author: imp Date: Sun Nov 8 02:46:04 2020 New Revision: 367475 URL: https://svnweb.freebsd.org/changeset/base/367475 Log: Also mention PORTS_MODULES PORTS_MODULES is also an effective way to update the tree. Also a minor rejustify on this an an adjacent paragraph. Suggested by:

svn commit: r367474 - head

2020-11-07 Thread Warner Losh
Author: imp Date: Sun Nov 8 02:20:21 2020 New Revision: 367474 URL: https://svnweb.freebsd.org/changeset/base/367474 Log: Be explicit about recompiling all the modules... Add a note about always recompiling all modules on every new kernel change / update. In addition, suggest using

Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd

2020-10-31 Thread Warner Losh
Go for it. Warner On Sat, Oct 31, 2020, 2:57 PM Mateusz Guzik wrote: > I agree. Please commit. > > On 10/31/20, Brandon Bergren wrote: > > Yeah, that is what was happening. The minimal implementation needed for > > libsa was missing. > > > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren

svn commit: r367189 - head/sys/sys

2020-10-30 Thread Warner Losh
Author: imp Date: Fri Oct 30 22:00:35 2020 New Revision: 367189 URL: https://svnweb.freebsd.org/changeset/base/367189 Log: Integrate 4.4BSD-Lite2 changes to IOC_* definitions Bring in the long-overdue 4.4BSD-Lite2 rev 8.3 by cgd of sys/ioccom.h. This uses UL suffix for the IOC_*

Re: svn commit: r367119 - head/stand/libsa/zfs

2020-10-28 Thread Warner Losh
On Wed, Oct 28, 2020 at 3:18 PM Warner Losh wrote: > Author: imp > Date: Wed Oct 28 21:18:04 2020 > New Revision: 367119 > URL: https://svnweb.freebsd.org/changeset/base/367119 > > Log: > loader: add aarch64 support for zstd > > We don't have NEON available in the boot lo

svn commit: r367119 - head/stand/libsa/zfs

2020-10-28 Thread Warner Losh
Author: imp Date: Wed Oct 28 21:18:04 2020 New Revision: 367119 URL: https://svnweb.freebsd.org/changeset/base/367119 Log: loader: add aarch64 support for zstd We don't have NEON available in the boot loader, so we have to disable it. OpenZFS included ZSTD which used the wrong symbol to

svn commit: r367118 - head/share/man/man9

2020-10-28 Thread Warner Losh
Author: imp Date: Wed Oct 28 21:09:56 2020 New Revision: 367118 URL: https://svnweb.freebsd.org/changeset/base/367118 Log: Note that sys/systm.h is special too If you need / want to includerd sys/systm.h, it has to be just after param.h/types.h. Document this existing practice. Not all

Re: svn commit: r367103 - head/usr.bin/calendar

2020-10-28 Thread Warner Losh
On Wed, Oct 28, 2020 at 9:09 AM Stefan Esser wrote: > Am 28.10.20 um 14:34 schrieb Kyle Evans: > > On Wed, Oct 28, 2020 at 8:24 AM Stefan Esser wrote: > >> I'm thinking about support for nested conditionals and #else in > >> calendar files, but I'm not sure about the possibility to MFC > >>

Re: svn commit: r366993 - head/sys/net

2020-10-27 Thread Warner Losh
On Tue, Oct 27, 2020 at 2:23 PM Konstantin Belousov wrote: > On Tue, Oct 27, 2020 at 02:52:38PM -0400, Ed Maste wrote: > > On Sat, 24 Oct 2020 at 06:46, Konstantin Belousov > wrote: > > > > > > > -#include > > > sys/systm.h should come right after sys/param.h. These two headers are > > >

svn commit: r367071 - in head/sys: geom sys

2020-10-27 Thread Warner Losh
Author: imp Date: Tue Oct 27 06:43:24 2020 New Revision: 367071 URL: https://svnweb.freebsd.org/changeset/base/367071 Log: Remove frontstuff Nothing implements this in the tree. Remove the ioctl and the conversion to the geom atttribute stuff. This was introduced in r94287 in 2002

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Warner Losh
On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: > On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: > > Am 25.10.20 um 06:56 schrieb Alex Kozlov: > > > On Sat, Oct 24, 2020 at 04:37:45PM +0200, Stefan Esser wrote: > > > > Am 24.10.20 um 09:48 schrieb Alex Kozlov: > > [...] > > >

svn commit: r367051 - in head: . usr.bin/calendar usr.bin/calendar/calendars usr.bin/calendar/calendars/de_AT.ISO_8859-15 usr.bin/calendar/calendars/de_DE.ISO8859-1 usr.bin/calendar/calendars/fr_FR...

2020-10-25 Thread Warner Losh
Author: imp Date: Mon Oct 26 03:26:18 2020 New Revision: 367051 URL: https://svnweb.freebsd.org/changeset/base/367051 Log: calendar: remove all datafiles except freebsd one Move all the data files for the calendar(1) program, except calendar.freebsd to the calendar-data package. When a

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-25 Thread Warner Losh
On Sun, Oct 25, 2020, 9:04 AM Kyle Evans wrote: > On Sun, Oct 25, 2020 at 5:21 AM Stefan Esser wrote: > > > > Am 25.10.20 um 04:46 schrieb Rodney W. Grimes: > > >> On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes < > free...@gndrsh.dnsmgr.net> > > >> wrote: > > +#define

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020 at 8:51 PM Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: se > > Date: Fri Oct 23 09:22:23 2020 > > New Revision: 366962 > > URL: https://svnweb.freebsd.org/changeset/base/366962 > > > > Log: > > Add search of LOCALBASE/share/calendar

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020 at 7:20 PM Ed Maste wrote: > On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: > > > >> Given we already have nice .clang-format, that does most of the job, > maybe it's worth considering looking into tweaking it further to fix this > part? > >

svn commit: r367032 - head/sys/sys

2020-10-24 Thread Warner Losh
Author: imp Date: Sat Oct 24 23:21:31 2020 New Revision: 367032 URL: https://svnweb.freebsd.org/changeset/base/367032 Log: cdefs.h: remove intel_compiler support The age of the intel compiler support is so old as to be uninteresting. No recent recports of intel compiler

svn commit: r367031 - in head/sys/i386: i386 include

2020-10-24 Thread Warner Losh
Author: imp Date: Sat Oct 24 23:21:27 2020 New Revision: 367031 URL: https://svnweb.freebsd.org/changeset/base/367031 Log: Remove support for intel compiler from i386 in_cksum We no longer support building the kernel with the old intel compiler. Remove support for it from in_cksum.

svn commit: r367029 - head/sys/dev/bxe

2020-10-24 Thread Warner Losh
Author: imp Date: Sat Oct 24 23:21:18 2020 New Revision: 367029 URL: https://svnweb.freebsd.org/changeset/base/367029 Log: Remove support for ancient compilers We don't support building the kernel from such old compilers, nor with the Intel Compiler specifically. Remove support for this

svn commit: r367030 - head/lib/msun/src

2020-10-24 Thread Warner Losh
Author: imp Date: Sat Oct 24 23:21:22 2020 New Revision: 367030 URL: https://svnweb.freebsd.org/changeset/base/367030 Log: Remove intel compiler support from math.h The intel compiler support has badly decayed over the years. Stop pretending that we support it. Note, I've stopped short

svn commit: r367028 - in head: include sys/sys

2020-10-24 Thread Warner Losh
Author: imp Date: Sat Oct 24 23:21:06 2020 New Revision: 367028 URL: https://svnweb.freebsd.org/changeset/base/367028 Log: Remove obsolete check for GCC < 3 and support for Intel Compiler We no longer support old versions of GCC. Remove this check by assuming it's false. That will make

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020 at 9:38 AM Kyle Evans wrote: > On Sat, Oct 24, 2020 at 4:52 AM Hans Petter Selasky > wrote: > > > > On 2020-10-24 02:13, Warner Losh wrote: > > > I was going to suggest and try this change, but life has been > complicated... >

Re: svn commit: r366993 - head/sys/net

2020-10-24 Thread Warner Losh
On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov wrote: > 24.10.2020, 14:08, "Hans Petter Selasky" : > > On 2020-10-24 14:52, Alexey Dokuchaev wrote: > >> On Sat, Oct 24, 2020 at 10:23:22AM +, Hans Petter Selasky wrote: > >>> New Revision: 366993 > >>> URL:

svn commit: r366989 - head/sys/dev/nvme

2020-10-23 Thread Warner Losh
Author: imp Date: Sat Oct 24 01:59:01 2020 New Revision: 366989 URL: https://svnweb.freebsd.org/changeset/base/366989 Log: nvme: Remove compat code for older kernels Remove code that supported pre-2011 kernels. CTLTYPE_S64 was defined in rev 217616. All supported branches have it, so

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

2020-10-23 Thread Warner Losh
On Sat, Oct 17, 2020 at 11:40 AM Warner Losh wrote: > > >> > > >> > > >> > > >> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov < > melif...@ipfw.ru> wrote: > > >>> > > >>> 17.10.2020, 14:07, "Hans P

svn commit: r366983 - head/lib/libc/gen

2020-10-23 Thread Warner Losh
Author: imp Date: Sat Oct 24 00:03:11 2020 New Revision: 366983 URL: https://svnweb.freebsd.org/changeset/base/366983 Log: warnx: fix needless static I noticed after the review that these shouldn't be static. Remove the 'static' from them, otherwise concurrent calls to warn* might see a

svn commit: r366982 - head/lib/libc/gen

2020-10-23 Thread Warner Losh
Author: imp Date: Fri Oct 23 23:56:00 2020 New Revision: 366982 URL: https://svnweb.freebsd.org/changeset/base/366982 Log: warnx: Save errno across calls that might change it. When warn() family of functions is being used after err_set_file() has been set to, for example, /dev/null,

svn commit: r366822 - in head: share/man/man5 usr.bin/login

2020-10-18 Thread Warner Losh
Author: imp Date: Mon Oct 19 01:16:39 2020 New Revision: 366822 URL: https://svnweb.freebsd.org/changeset/base/366822 Log: Add more explicit instructions about updating motd Not that you can regenerate the motd by editing motd.template and running 'service motd restart' rather than

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

2020-10-17 Thread Warner Losh
On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov wrote: > 17.10.2020, 14:07, "Hans Petter Selasky" : > > On 2020-10-17 14:34, Alexander V. Chernikov wrote: > > 17.10.2020, 12:32, "Hans Petter Selasky" : > > On 2020-10-17 13:27, Alexander V. Chernikov wrote: > >

Re: svn commit: r366732 - in head/release: amd64 arm64

2020-10-15 Thread Warner Losh
And on a related note, I can make it so we can build w/o ZSTD in the CD boot loader because it's not needed there. I'd rather not, but if the 800k limit is a real thing in relevant places, we have that as an option. Warner On Thu, Oct 15, 2020 at 1:34 PM Warner Losh wrote: > I'd recomm

Re: svn commit: r366732 - in head/release: amd64 arm64

2020-10-15 Thread Warner Losh
I'd recommend bumping this to 2MB or larger. This most likely is from the zstd landing which pushed arm64's size over the 1MB limit in memory, so it's only a matter of time before the file grows past 1MB in size. Warner On Thu, Oct 15, 2020 at 11:13 AM Glen Barber wrote: > Author: gjb > Date:

Re: svn commit: r366662 - head/sbin/devmatch

2020-10-13 Thread Warner Losh
On Mon, Oct 12, 2020, 11:50 PM Alexey Dokuchaev wrote: > On Tue, Oct 13, 2020 at 05:32:00AM +0000, Warner Losh wrote: > > New Revision: 32 > > URL: https://svnweb.freebsd.org/changeset/base/32 > > > > Log: > > devmatch: First appeared in 12.0 >

svn commit: r366663 - head/share/man/man5

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 05:39:43 2020 New Revision: 33 URL: https://svnweb.freebsd.org/changeset/base/33 Log: Document /boot/config as well as /boot.config Add a note about /boot/config being an alternative location for this information. Correct description of -P. Modified:

svn commit: r366662 - head/sbin/devmatch

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 05:32:00 2020 New Revision: 32 URL: https://svnweb.freebsd.org/changeset/base/32 Log: devmatch: First appeared in 12.0 Document that devmatch first appeared in FreeBSD 12.0. Also can't -> can not. But it doesn't help the sentence much. MFC

svn commit: r366661 - head/sbin/devd

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 05:19:00 2020 New Revision: 31 URL: https://svnweb.freebsd.org/changeset/base/31 Log: Document the rather suprising behavior with ' inside action rules. To prevent issues with odd shell characters appearing in, a surprising shell feature is used.

svn commit: r366660 - head/stand/libsa/zfs

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 04:37:57 2020 New Revision: 30 URL: https://svnweb.freebsd.org/changeset/base/30 Log: Force __BMI__ experimental instructions off. The OpenZFS code that uses the BMI instructions is broken. Forcibly disable them to prevent their use. When enabled, the

svn commit: r366659 - head/stand/libsa/zfs

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 03:49:12 2020 New Revision: 366659 URL: https://svnweb.freebsd.org/changeset/base/366659 Log: Add back org.freebsd:zstd_compress to features_for_read This list is the of features that are allowed on the whole pool, not the list of features that are

svn commit: r366658 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2020-10-12 Thread Warner Losh
Author: imp Date: Tue Oct 13 02:36:16 2020 New Revision: 366658 URL: https://svnweb.freebsd.org/changeset/base/366658 Log: Turn off zstd on aarch64 loader support for zstd and zfs doesn't work for aarch64. Disable it to unbreak the build. Modified: head/stand/libsa/zfs/Makefile.inc

svn commit: r366657 - in head: stand/efi/boot1 stand/libsa/zfs sys/cddl/boot/zfs sys/cddl/contrib/opensolaris/uts/common/os sys/contrib/openzfs/include/os/freebsd/linux sys/contrib/openzfs/include/...

2020-10-12 Thread Warner Losh
= --- head/sys/contrib/openzfs/include/os/freebsd/spl/sys/kmem_cache.hMon Oct 12 22:07:44 2020(r366656, copy source) +++ head/stand/libsa/zfs/zstd_shim.cMon Oct 12 22:19:07 2020 (r366657) @@ -1,6 +1,5 @@ -/* - * Copyright (c) 2020 iXsystems, Inc. - * All rights reserved. +/*- +

svn commit: r366656 - head/sys/kern

2020-10-12 Thread Warner Losh
Author: imp Date: Mon Oct 12 22:07:44 2020 New Revision: 366656 URL: https://svnweb.freebsd.org/changeset/base/366656 Log: newbus: use ssize_t to match sb's len and size, fix ordering of space check Both s_len and s_size are ssize_t, so their differece is also more properly a ssize_t not

svn commit: r366629 - head/sys/sys

2020-10-11 Thread Warner Losh
Author: imp Date: Mon Oct 12 05:56:29 2020 New Revision: 366629 URL: https://svnweb.freebsd.org/changeset/base/366629 Log: systm.h: forward declare ucred for _STANDALONE too There's a number of types we forward declare for the kernel. We need struct ucred for the ZSTD ZFS integration, so

Re: svn commit: r366626 - head/sbin/reboot

2020-10-11 Thread Warner Losh
On Sun, Oct 11, 2020, 8:13 PM Alexey Dokuchaev wrote: > On Sun, Oct 11, 2020 at 09:12:43AM -0600, Warner Losh wrote: > > ... > > There were cases that were discussed when the feature went in that > > required it to be removed in some failure modes for full functionalit

Re: svn commit: r366626 - head/sbin/reboot

2020-10-11 Thread Warner Losh
On Sun, Oct 11, 2020, 8:00 AM Kyle Evans wrote: > On Sun, Oct 11, 2020 at 8:30 AM Alexey Dokuchaev > wrote: > > > > On Sun, Oct 11, 2020 at 04:08:09PM +0300, Toomas Soome wrote: > > > > On 11. Oct 2020, at 16:01, Alexey Dokuchaev wrote: > > > >> ... > > > >> Also nextboot.conf not generic

Re: svn commit: r366578 - head/sbin/devd

2020-10-09 Thread Warner Losh
On Fri, Oct 9, 2020 at 12:47 PM Warner Losh wrote: > > > On Fri, Oct 9, 2020, 12:20 PM Renato Botelho wrote: > >> On 09/10/20 15:16, Renato Botelho wrote: >> > On 09/10/20 13:57, Warner Losh wrote: >> >> >> >> >> >> On Fri, Oct 9,

Re: svn commit: r366578 - head/sbin/devd

2020-10-09 Thread Warner Losh
On Fri, Oct 9, 2020, 12:20 PM Renato Botelho wrote: > On 09/10/20 15:16, Renato Botelho wrote: > > On 09/10/20 13:57, Warner Losh wrote: > >> > >> > >> On Fri, Oct 9, 2020 at 10:19 AM Renato Botelho >> <mailto:ga...@freebsd.org>> wrote:

Re: svn commit: r366578 - head/sbin/devd

2020-10-09 Thread Warner Losh
On Fri, Oct 9, 2020 at 10:19 AM Renato Botelho wrote: > On 09/10/20 12:29, Warner Losh wrote: > > Author: imp > > Date: Fri Oct 9 15:29:05 2020 > > New Revision: 366578 > > URL: https://svnweb.freebsd.org/changeset/base/366578 > > > > Log: > >Avo

svn commit: r366579 - head/sbin/devd

2020-10-09 Thread Warner Losh
Author: imp Date: Fri Oct 9 15:45:34 2020 New Revision: 366579 URL: https://svnweb.freebsd.org/changeset/base/366579 Log: Remove gratuitous use of '' around arguments There's no need to use ' here, so remove it. This use causes no problems, but is a bad example. Modified:

svn commit: r366578 - head/sbin/devd

2020-10-09 Thread Warner Losh
Author: imp Date: Fri Oct 9 15:29:05 2020 New Revision: 366578 URL: https://svnweb.freebsd.org/changeset/base/366578 Log: Avoid using single quotes in arguments to logger. Single quotes interfere with the workaround put in with r335753 and aren't necessary in this case. I believe that

svn commit: r366560 - head/sys/conf

2020-10-08 Thread Warner Losh
Author: imp Date: Fri Oct 9 01:48:21 2020 New Revision: 366560 URL: https://svnweb.freebsd.org/changeset/base/366560 Log: Remove now-unused files makeLINT.mk isn't needed or used anymore, remove it and all the files it uses. Reviewed by: kevans Differential Revision:

svn commit: r366559 - in head: . sys/amd64/conf sys/arm/conf sys/arm64/conf sys/i386/conf sys/powerpc/conf

2020-10-08 Thread Warner Losh
Author: imp Date: Fri Oct 9 01:48:14 2020 New Revision: 366559 URL: https://svnweb.freebsd.org/changeset/base/366559 Log: Create in-tree LINT files Now that config(8) has supported include for 19 years, transition to including the NOTES files. include support didn't exist at the time,

svn commit: r366555 - head

2020-10-08 Thread Warner Losh
Author: imp Date: Fri Oct 9 00:27:40 2020 New Revision: 366555 URL: https://svnweb.freebsd.org/changeset/base/366555 Log: Eliminate building LINT makefiles LINT config files are about to be checked in directly. Eliminate building them by hand here from NOTES files. Reviewed by:

svn commit: r366556 - head

2020-10-08 Thread Warner Losh
Author: imp Date: Fri Oct 9 00:27:45 2020 New Revision: 366556 URL: https://svnweb.freebsd.org/changeset/base/366556 Log: Stop ignoring makeLINT generated files We're going to check these files in shortly since we don't need to generate them anymore. Generated files cause issues for

svn commit: r366554 - head/usr.sbin/bsdinstall/scripts

2020-10-08 Thread Warner Losh
Author: imp Date: Fri Oct 9 00:16:26 2020 New Revision: 366554 URL: https://svnweb.freebsd.org/changeset/base/366554 Log: Initial support for implementing the bootXXX.efi workaround Too many version of UEFI firmware (so far only confirmed on amd64) don't really support efibootmgr

svn commit: r366547 - in head/sys: i386/include x86/isa

2020-10-08 Thread Warner Losh
Author: imp Date: Thu Oct 8 20:56:11 2020 New Revision: 366547 URL: https://svnweb.freebsd.org/changeset/base/366547 Log: timer_restore is now unused, remove it apm was the only consumer of timer_restore. Now that it's gone, this can be removed. Modified:

svn commit: r366544 - in head/sys/modules: . apm

2020-10-08 Thread Warner Losh
Author: imp Date: Thu Oct 8 20:55:55 2020 New Revision: 366544 URL: https://svnweb.freebsd.org/changeset/base/366544 Log: Remove apm module The apm code is about to be removed. Remove the module since it's about to be useless. Deleted: head/sys/modules/apm/Makefile Modified:

svn commit: r366546 - in head/sys: conf dev/syscons/apm i386/bios i386/conf

2020-10-08 Thread Warner Losh
Author: imp Date: Thu Oct 8 20:56:06 2020 New Revision: 366546 URL: https://svnweb.freebsd.org/changeset/base/366546 Log: Remove APM BIOS support APM BIOS was relevant only to early laptops (approximately P166 or P200 and slower). These have not been relevant for a long time, and this

svn commit: r366545 - in head/sys: conf i386/conf modules/syscons modules/syscons/apm

2020-10-08 Thread Warner Losh
Author: imp Date: Thu Oct 8 20:56:00 2020 New Revision: 366545 URL: https://svnweb.freebsd.org/changeset/base/366545 Log: Remove apm screen saver. APM BIOS support is about to be removed. Remove the apm screen saver and its module. They are about to be irrelevant. Deleted:

svn commit: r366541 - head

2020-10-08 Thread Warner Losh
Author: imp Date: Thu Oct 8 17:30:05 2020 New Revision: 366541 URL: https://svnweb.freebsd.org/changeset/base/366541 Log: Race in 32-bit fixed Use install insteald of install.sh for 32-bit builds to fight races there. Reviewed by: markj Modified: head/Makefile.libcompat Modified:

svn commit: r366511 - head/sbin/nvmecontrol/modules/wdc

2020-10-07 Thread Warner Losh
Author: imp Date: Wed Oct 7 07:55:55 2020 New Revision: 366511 URL: https://svnweb.freebsd.org/changeset/base/366511 Log: Use intmax_t to print uint64_t values. This fixes the 32-bit build where the types are different. Modified: head/sbin/nvmecontrol/modules/wdc/wdc.c Modified:

svn commit: r366508 - in head/sys: dev/rt geom/eli kern sys

2020-10-07 Thread Warner Losh
Author: imp Date: Wed Oct 7 06:16:37 2020 New Revision: 366508 URL: https://svnweb.freebsd.org/changeset/base/366508 Log: Move kernel env global variables, etc to sys/kenv.h The kernel globals for kenv are confined to 2 files that need them and a few that likely shouldn't (but as

svn commit: r366507 - head/sys/cam/scsi

2020-10-06 Thread Warner Losh
Author: imp Date: Wed Oct 7 05:44:35 2020 New Revision: 366507 URL: https://svnweb.freebsd.org/changeset/base/366507 Log: cam: Add quirk for Samsung MZ7* behind a SATA-to-SAS interposer Sometimes, this drive will be present in the system such that the the firmware identification string

svn commit: r366506 - head/sbin/nvmecontrol/modules/wdc

2020-10-06 Thread Warner Losh
Author: imp Date: Wed Oct 7 05:36:05 2020 New Revision: 366506 URL: https://svnweb.freebsd.org/changeset/base/366506 Log: nvmecontrol: Update wdc module for newer WDC NVMe products Update the to log fetch operation for latest WDC NVMe products. Tested on HGST SN100 (a few years old)

svn commit: r366505 - head/sys/cam/nvme

2020-10-06 Thread Warner Losh
Author: imp Date: Tue Oct 6 23:35:26 2020 New Revision: 366505 URL: https://svnweb.freebsd.org/changeset/base/366505 Log: nvme: Note where the CCB was released for passthrough command Modified: head/sys/cam/nvme/nvme_da.c Modified: head/sys/cam/nvme/nvme_da.c

svn commit: r366504 - head/sys/cam

2020-10-06 Thread Warner Losh
Author: imp Date: Tue Oct 6 23:33:56 2020 New Revision: 366504 URL: https://svnweb.freebsd.org/changeset/base/366504 Log: cam: Assert we have a reference when freeing sim Before we decrement refcount to sleep on the sim, assert that the refcount >= 1. If it were 0 here, we'd never wake

Re: svn commit: r366431 - head/sys/dev/usb/serial

2020-10-05 Thread Warner Losh
On Mon, Oct 5, 2020 at 5:46 AM Ronald Klop wrote: > Hi, > > I was interested by this commit. But the commit and commit message don't > have much information. I was surprised that the "Differential Revision" > link contains a lot of info about this. How permanent is this > review.freebsd.org

Re: svn commit: r366265 - head/sys/sys

2020-09-29 Thread Warner Losh
On Tue, Sep 29, 2020, 1:00 PM Hans Petter Selasky wrote: > On 2020-09-29 20:06, Warner Losh wrote: > > Author: imp > > Date: Tue Sep 29 18:06:02 2020 > > New Revision: 366265 > > URL: https://svnweb.freebsd.org/changeset/base/366265 > > > > Log: > >

svn commit: r366266 - head/lib/libc/sys

2020-09-29 Thread Warner Losh
Author: imp Date: Tue Sep 29 18:13:54 2020 New Revision: 366266 URL: https://svnweb.freebsd.org/changeset/base/366266 Log: Updates to chroot(2) docs 1. Note what settings give historic behavior 2. Recommend jail under security considerations. Modified: head/lib/libc/sys/chroot.2

svn commit: r366265 - head/sys/sys

2020-09-29 Thread Warner Losh
Author: imp Date: Tue Sep 29 18:06:02 2020 New Revision: 366265 URL: https://svnweb.freebsd.org/changeset/base/366265 Log: Standalone SX shims Create a do-nothing version of SX locks. OpenZFS needs them. However, since the boot loader is single threaded, they can be nops. Modified:

svn commit: r366260 - head/stand/libsa

2020-09-29 Thread Warner Losh
) 2020 M. Warner Losh + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions

svn commit: r366228 - head/stand/lua

2020-09-28 Thread Warner Losh
Author: imp Date: Mon Sep 28 16:19:21 2020 New Revision: 366228 URL: https://svnweb.freebsd.org/changeset/base/366228 Log: Report the kernel console on the boot screen Report what console the boot loader is telling the kernel to use: o Dual (Serial Primary) o Dual (Video

svn commit: r366229 - head/sys/kern

2020-09-28 Thread Warner Losh
Author: imp Date: Mon Sep 28 16:19:29 2020 New Revision: 366229 URL: https://svnweb.freebsd.org/changeset/base/366229 Log: For mulitcons boot, report it and which console is primary Until we can do proper /etc/rc output on both consoles in multicons boot (or all of them if we ever

svn commit: r366217 - head/tools/boot

2020-09-28 Thread Warner Losh
Author: imp Date: Mon Sep 28 06:00:56 2020 New Revision: 366217 URL: https://svnweb.freebsd.org/changeset/base/366217 Log: Speciy the dev in an easily changed variable Rather than hard coding ada0 everywhere, use ${dev}. Also, set dev=vtbd0 since both qemu and bhyve support this. More

svn commit: r366216 - head/stand/efi/loader

2020-09-28 Thread Warner Losh
Author: imp Date: Mon Sep 28 06:00:39 2020 New Revision: 366216 URL: https://svnweb.freebsd.org/changeset/base/366216 Log: Fix video on PCI heuristic The video on PCI heuristic was broken. It was supposed to infer a video device when the last element of the path was a PCI DEVICE PATH

Re: svn commit: r365643 - head/bin/cp

2020-09-26 Thread Warner Losh
On Sat, Sep 26, 2020, 1:50 PM Benjamin Kaduk wrote: > On Sat, Sep 26, 2020 at 12:35 PM Warner Losh wrote: > >> >> >> On Sat, Sep 26, 2020 at 12:58 PM Benjamin Kaduk >> wrote: >> >>> On Sat, Sep 26, 2020 at 11:55 AM Warner Losh wrote: >>

Re: svn commit: r365643 - head/bin/cp

2020-09-26 Thread Warner Losh
On Sat, Sep 26, 2020 at 12:58 PM Benjamin Kaduk wrote: > On Sat, Sep 26, 2020 at 11:55 AM Warner Losh wrote: > >> And there's the rub: how did this file come to exist? I'm certain it isn't >> booting or shutting down the system based on when devfs is mounted (before >> i

Re: svn commit: r366186 - in head/usr.sbin: bsdconfig/share/media bsdinstall/scripts

2020-09-26 Thread Warner Losh
On Sat, Sep 26, 2020 at 12:54 PM Niclas Zeising wrote: > On 2020-09-26 20:28, Rodney W. Grimes wrote: > >> On 2020-09-26 20:12, Rodney W. Grimes wrote: > Author: zeising (doc,ports committer) > Date: Sat Sep 26 16:27:09 2020 > New Revision: 366186 > URL:

Re: svn commit: r365643 - head/bin/cp

2020-09-26 Thread Warner Losh
On Sat, Sep 26, 2020 at 11:02 AM Rodney W. Grimes wrote: > > > On Fri, 2020-09-25 at 10:55 -0700, Rodney W. Grimes wrote: > > > > I was under the impression from previous reading and kib's response > > > > that this is a complete non-issue, there's no way you can go > > > > multi-user without a

Re: svn commit: r366169 - head/sys/mips/include

2020-09-25 Thread Warner Losh
On Fri, Sep 25, 2020 at 5:05 PM Jessica Clarke wrote: > On 26 Sep 2020, at 00:01, Alexander Richardson > wrote: > > > > > > On Fri, 25 Sep 2020, 20:04 Justin Hibbits, wrote: > > Author: jhibbits > > Date: Fri Sep 25 19:04:03 2020 > > New Revision: 366169 > > URL:

svn commit: r366181 - head

2020-09-25 Thread Warner Losh
Author: imp Date: Sat Sep 26 04:06:16 2020 New Revision: 366181 URL: https://svnweb.freebsd.org/changeset/base/366181 Log: fix typo imorted -> imported. Noticed by: Maigurs Stalidzans Modified: head/UPDATING Modified: head/UPDATING

svn commit: r366173 - head/sys/sys

2020-09-25 Thread Warner Losh
Author: imp Date: Fri Sep 25 20:51:07 2020 New Revision: 366173 URL: https://svnweb.freebsd.org/changeset/base/366173 Log: Adjustments to includes for openzfs in _STANDALONE Allow the necessary parts of systm.h to be visible in the _STANDALONE environnment. Limit the reset to only being

svn commit: r366168 - head/sys/sys

2020-09-25 Thread Warner Losh
Author: imp Date: Fri Sep 25 19:02:49 2020 New Revision: 366168 URL: https://svnweb.freebsd.org/changeset/base/366168 Log: Dont let kernel and standalone both be defined at the same time _KERNEL and _STANDALONE are different things. They cannot both be true at the same time. If things

svn commit: r366164 - head/usr.sbin/efivar

2020-09-25 Thread Warner Losh
Author: imp Date: Fri Sep 25 18:20:41 2020 New Revision: 366164 URL: https://svnweb.freebsd.org/changeset/base/366164 Log: Tweak output of the loader variable When the DEVICE_PATH is <= 4 that means it's effectively empty. I have a laptop that has a BIOS that likes to generate these:

svn commit: r366165 - head/usr.sbin/efivar

2020-09-25 Thread Warner Losh
Author: imp Date: Fri Sep 25 18:20:45 2020 New Revision: 366165 URL: https://svnweb.freebsd.org/changeset/base/366165 Log: Comment out bogus command line entry Linux implements -d to mean --print-decimal. We don't implement that and use -d for --device-path. Note that. Modified:

  1   2   3   4   5   6   7   8   9   10   >