Re: svn commit: r240850 - head/lib/libstand

2012-09-24 Thread David Chisnall
On 23 Sep 2012, at 20:27, Garrett Cooper wrote: +1. free(3) should silently ignore NULL parameters passed into it. Indeed. The C standard's description for free() states that: If ptr is a null pointer, no action occurs. This means that a standards-compilant compiler is entirely at

Re: svn commit: r240850 - head/lib/libstand

2012-09-24 Thread Konstantin Belousov
On Mon, Sep 24, 2012 at 09:47:45AM +0100, David Chisnall wrote: On 23 Sep 2012, at 20:27, Garrett Cooper wrote: +1. free(3) should silently ignore NULL parameters passed into it. Indeed. The C standard's description for free() states that: If ptr is a null pointer, no action

Re: svn commit: r240850 - head/lib/libstand

2012-09-23 Thread Konstantin Belousov
On Sun, Sep 23, 2012 at 08:38:06AM +, Kevin Lo wrote: Author: kevlo Date: Sun Sep 23 08:38:06 2012 New Revision: 240850 URL: http://svn.freebsd.org/changeset/base/240850 Log: Avoid NULL dereference Modified: head/lib/libstand/nfs.c Modified: head/lib/libstand/nfs.c

Re: svn commit: r240850 - head/lib/libstand

2012-09-23 Thread Garrett Cooper
On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov kostik...@gmail.com wrote: On Sun, Sep 23, 2012 at 08:38:06AM +, Kevin Lo wrote: Author: kevlo Date: Sun Sep 23 08:38:06 2012 New Revision: 240850 URL: http://svn.freebsd.org/changeset/base/240850 Log: Avoid NULL dereference

Re: Re: svn commit: r240850 - head/lib/libstand

2012-09-23 Thread Kevin Lo
On 2012/09/24 03:27, Garrett Cooper wrote: On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov kostik...@gmail.com wrote: On Sun, Sep 23, 2012 at 08:38:06AM +, Kevin Lo wrote: Author: kevlo Date: Sun Sep 23 08:38:06 2012 New Revision: 240850 URL:

Re: svn commit: r240850 - head/lib/libstand

2012-09-23 Thread Garrett Cooper
Sent from my iPhone On Sep 23, 2012, at 7:06 PM, Kevin Lo ke...@freebsd.org wrote: On 2012/09/24 03:27, Garrett Cooper wrote: On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov kostik...@gmail.com wrote: On Sun, Sep 23, 2012 at 08:38:06AM +, Kevin Lo wrote: Author: kevlo Date: Sun

Re: Re: svn commit: r240850 - head/lib/libstand

2012-09-23 Thread Konstantin Belousov
On Mon, Sep 24, 2012 at 10:06:03AM +0800, Kevin Lo wrote: On 2012/09/24 03:27, Garrett Cooper wrote: On Sun, Sep 23, 2012 at 3:52 AM, Konstantin Belousov kostik...@gmail.com wrote: On Sun, Sep 23, 2012 at 08:38:06AM +, Kevin Lo wrote: Author: kevlo Date: Sun Sep 23 08:38:06 2012