Re: svn commit: r325239 - head/sys/dev/ena

2017-11-22 Thread Gleb Smirnoff
Michał, thanks for explanation. Looks like in this case software counters are indeed superior to hardware ones. On Wed, Nov 22, 2017 at 05:19:54PM +0100, Michał Krawczyk wrote: M> Hi Gleb, M> We are counting the statistics in the software because of the alignment M> with the newest ena-com

Re: svn commit: r325239 - head/sys/dev/ena

2017-11-22 Thread Michał Krawczyk
Hi Gleb, We are counting the statistics in the software because of the alignment with the newest ena-com API (HAL) which is delivered to us from NIC's vendor. Regarding fetching them periodically - there are 2 issues with that. First of all, there may be problem with the counter overflow.

Re: svn commit: r325239 - head/sys/dev/ena

2017-11-21 Thread Gleb Smirnoff
Hi Martin and Michal, On Tue, Oct 31, 2017 at 04:31:23PM +, Marcin Wojtas wrote: M> Author: mw M> Date: Tue Oct 31 16:31:23 2017 M> New Revision: 325239 M> URL: https://svnweb.freebsd.org/changeset/base/325239 M> M> Log: M> Rework counting of hardware statistics in ENA driver M> M>