Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-15 Thread Hans Petter Selasky
On 11/15/18 2:15 AM, Gleb Smirnoff wrote: I wish to do that, but struct thread is exposed to userland, and all epoch structures are not. There is another way to solve this problem which doesn't involve "struct thread" and is more safe and guards against recursive use of these functions! Can

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Gleb Smirnoff
On Wed, Nov 14, 2018 at 10:27:48PM +0200, Konstantin Belousov wrote: K> On Wed, Nov 14, 2018 at 08:28:31AM -0800, Gleb Smirnoff wrote: K> > On Wed, Nov 14, 2018 at 11:06:38AM +0100, Hans Petter Selasky wrote: K> > H> On 11/14/18 10:33 AM, Cy Schubert wrote: K> > H> > + epoch_thread_init(td);

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Konstantin Belousov
On Wed, Nov 14, 2018 at 08:28:31AM -0800, Gleb Smirnoff wrote: > On Wed, Nov 14, 2018 at 11:06:38AM +0100, Hans Petter Selasky wrote: > H> On 11/14/18 10:33 AM, Cy Schubert wrote: > H> > +epoch_thread_init(td); > H> > H> Did you forget to call epoch_thread_init() for thread0 ? > > Yes,

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Gleb Smirnoff
On Wed, Nov 14, 2018 at 11:06:38AM +0100, Hans Petter Selasky wrote: H> On 11/14/18 10:33 AM, Cy Schubert wrote: H> > + epoch_thread_init(td); H> H> Did you forget to call epoch_thread_init() for thread0 ? Yes, this is my guess. I'm preparing patch for Cy to test. -- Gleb Smirnoff

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Cy Schubert
In message <178c3d69-4a3b-49cb-dab4-f6f4139df...@selasky.org>, Hans Petter Sela sky writes: > On 11/14/18 10:33 AM, Cy Schubert wrote: > > + epoch_thread_init(td); > > Did you forget to call epoch_thread_init() for thread0 ? > > --HPS It appears that interfaces that call if_maddr_rlock(ifp)

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Hans Petter Selasky
On 11/14/18 10:33 AM, Cy Schubert wrote: + epoch_thread_init(td); Did you forget to call epoch_thread_init() for thread0 ? --HPS ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe,

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Cy Schubert
Sorry. This should have been a private email. But now that it's in the wild, if_sk.c calls epoch_enter_preempt() at line 84 which causes panic early in boot. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.

Re: svn commit: r340413 - in head/sys: kern net sys

2018-11-14 Thread Cy Schubert
In message <201811132258.wadmwctl063...@repo.freebsd.org>, Gleb Smirnoff writes : > Author: glebius > Date: Tue Nov 13 22:58:38 2018 > New Revision: 340413 > URL: https://svnweb.freebsd.org/changeset/base/340413 > > Log: > For compatibility KPI functions like if_addr_rlock() that used to have >