Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread Bruce Evans
On Wed, 13 Oct 2010, John Baldwin wrote: On Wednesday, October 13, 2010 12:29:27 am Bruce Evans wrote: On Tue, 12 Oct 2010, David O'Brien wrote: On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: ... Of course, debugging and profiling are magic, but I don't want to have to adorn al

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread David O'Brien
On Wed, Oct 13, 2010 at 09:07:59AM -0400, John Baldwin wrote: > To be honest, I think changing STATIC is excessive churn. At this point I'm just making everything consistently "static" so that folks that add to ash won't need to realize that "STATIC" exists. Some of the folks making various FreeB

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread David O'Brien
On Wed, Oct 13, 2010 at 03:29:27PM +1100, Bruce Evans wrote: > Add __noinline or whatever attributes to STATIC (but keep static in > it) for the DEBUG >= 3 case if you are going that far. __noinline > should be a syntax error for variables, so this should also find any > STATICs still on variables

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread John Baldwin
On Wednesday, October 13, 2010 12:29:27 am Bruce Evans wrote: > On Tue, 12 Oct 2010, David O'Brien wrote: > > > On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: > >> On Tue, 12 Oct 2010, David E. O'Brien wrote: > >>> Log: > >>> If DEBUG is 3 or greater, disable STATICization of functi

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread Bruce Evans
On Tue, 12 Oct 2010, David O'Brien wrote: On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: On Tue, 12 Oct 2010, David E. O'Brien wrote: Log: If DEBUG is 3 or greater, disable STATICization of functions. Also correct the documented location of the trace file. Private functions s

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread David O'Brien
On Wed, Oct 13, 2010 at 02:18:33PM +1100, Bruce Evans wrote: > On Tue, 12 Oct 2010, David E. O'Brien wrote: >> Log: >> If DEBUG is 3 or greater, disable STATICization of functions. >> Also correct the documented location of the trace file. > > Private functions should always be static, which no

Re: svn commit: r213744 - head/bin/sh

2010-10-12 Thread Bruce Evans
On Tue, 12 Oct 2010, David E. O'Brien wrote: Log: If DEBUG is 3 or greater, disable STATICization of functions. Also correct the documented location of the trace file. Private functions should always be static, which no `#define STATIC static' hack to control this, but there are compiler bug

svn commit: r213744 - head/bin/sh

2010-10-12 Thread David E. O'Brien
Author: obrien Date: Tue Oct 12 19:24:41 2010 New Revision: 213744 URL: http://svn.freebsd.org/changeset/base/213744 Log: If DEBUG is 3 or greater, disable STATICization of functions. Also correct the documented location of the trace file. Modified: head/bin/sh/Makefile head/bin/sh/shell.