Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-16 Thread Marcel Moolenaar
On May 15, 2011, at 10:25 AM, Andrey V. Elsukov wrote: As I said: I'm fine with the change, but please assess the consequences of dropping the fall-back, for it may be better to make this change on -current after 9-stable branched and without the MFC. So, would you like to revert this

svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Andrey V. Elsukov
Author: ae Date: Sun May 15 11:45:13 2011 New Revision: 221952 URL: http://svn.freebsd.org/changeset/base/221952 Log: Simplify the code a bit. For own providers GEOM_PART always provides start and end config attributes. MFC after:1 week Modified:

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Marcel Moolenaar
On May 15, 2011, at 7:45 AM, Andrey V. Elsukov wrote: Author: ae Date: Sun May 15 11:45:13 2011 New Revision: 221952 URL: http://svn.freebsd.org/changeset/base/221952 Log: Simplify the code a bit. For own providers GEOM_PART always provides start and end config attributes. MFC

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Alexey Dokuchaev
On Sun, May 15, 2011 at 11:09:10AM -0400, Marcel Moolenaar wrote: On May 15, 2011, at 7:45 AM, Andrey V. Elsukov wrote: Author: ae Date: Sun May 15 11:45:13 2011 New Revision: 221952 URL: http://svn.freebsd.org/changeset/base/221952 Log: Simplify the code a bit. For own providers

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Andrey V. Elsukov
On 15.05.2011 19:09, Marcel Moolenaar wrote: Simplify the code a bit. For own providers GEOM_PART always provides start and end config attributes. MFC after: 1 week Just to make sure: the code deals with backward compatibility. If you're aware of the issue, but don't care (anymore)

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Marcel Moolenaar
On May 15, 2011, at 11:27 AM, Andrey V. Elsukov wrote: On 15.05.2011 19:09, Marcel Moolenaar wrote: Simplify the code a bit. For own providers GEOM_PART always provides start and end config attributes. MFC after: 1 week Just to make sure: the code deals with backward compatibility. If

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Marcel Moolenaar
On May 15, 2011, at 12:59 PM, Marcel Moolenaar wrote: /* ... paging in non-commit details ... */ The point is that this is what's happening *now*. This is not what happened before. With support for logical partitions (i.e. the EBR scheme), the total partition bounds and the effective

Re: svn commit: r221952 - head/sbin/geom/class/part

2011-05-15 Thread Andrey V. Elsukov
On 15.05.2011 20:59, Marcel Moolenaar wrote: g_part_dumpconf() function does set both pair of parameters: (start, end) and (offset, length). I do not see a way how one pair can not be present in XML tree. /* ... paging in non-commit details ... */ The point is that this is what's