Re: svn commit: r233773 - head/usr.sbin/arp

2012-04-10 Thread Gleb Smirnoff
Qing, On Mon, Apr 09, 2012 at 02:26:06PM -0700, Qing Li wrote: Q You missed my points. Q Q That if check as part of r201282 was meant to resolve a couple of Q issues related Q to PPP links, as noted in my commit message. In this PPP/proxy Q resolution context Q the error message applies, which

Re: svn commit: r233773 - head/usr.sbin/arp

2012-04-09 Thread Gleb Smirnoff
Qing, On Sun, Apr 08, 2012 at 10:41:11AM -0700, Qing Li wrote: Q This is not the right way to support RFC3021. Q Q The code you removed is used for checking against attempt at adding Q duplicate entry. Q Both the message and the code apply in that context. I tried to state Q clearly and

Re: svn commit: r233773 - head/usr.sbin/arp

2012-04-09 Thread Qing Li
You missed my points. That if check as part of r201282 was meant to resolve a couple of issues related to PPP links, as noted in my commit message. In this PPP/proxy resolution context the error message applies, which is why I actually used the word context in my previous reply. Your removing of

Re: svn commit: r233773 - head/usr.sbin/arp

2012-04-08 Thread Qing Li
This is not the right way to support RFC3021. The code you removed is used for checking against attempt at adding duplicate entry. Both the message and the code apply in that context. I tried to state clearly and concisely what r201282 was intended in solving and was verified by actual users who

svn commit: r233773 - head/usr.sbin/arp

2012-04-02 Thread Gleb Smirnoff
Author: glebius Date: Mon Apr 2 10:44:25 2012 New Revision: 233773 URL: http://svn.freebsd.org/changeset/base/233773 Log: Historically arp(8) did a route lookup for the entry it is about to add, and failed if it exist and had invalid data link type. Later on, in r201282, this check