Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-28 Thread Bruce Evans
On Mon, 28 May 2012, Robert N. M. Watson wrote: On 28 May 2012, at 09:36, Konstantin Belousov wrote: On Sun, May 27, 2012 at 07:49:36AM +1000, Bruce Evans wrote: On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: The 'low level' AKA

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-28 Thread Konstantin Belousov
On Sun, May 27, 2012 at 07:49:36AM +1000, Bruce Evans wrote: On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: The 'low level' AKA magic happens in several *_fetch_syscall_args() functions. For both linux32 and freebsd32, the magic

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-28 Thread Bruce Evans
On Mon, 28 May 2012, Konstantin Belousov wrote: On Sun, May 27, 2012 at 07:49:36AM +1000, Bruce Evans wrote: On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: The 'low level' AKA magic happens in several *_fetch_syscall_args()

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-28 Thread Robert N. M. Watson
On 28 May 2012, at 09:36, Konstantin Belousov wrote: On Sun, May 27, 2012 at 07:49:36AM +1000, Bruce Evans wrote: On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: The 'low level' AKA magic happens in several *_fetch_syscall_args()

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-27 Thread Bruce Evans
On Sun, 27 May 2012, Bruce Evans wrote: On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: ... All the non-indirect char *s for pathnames and other things seem to be completely wrong on amd64 too. These pointers start as 32 bits, and

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-26 Thread Bruce Evans
On Fri, 25 May 2012, Ed Schouten wrote: Log: Remove use of non-ISO-C integer types from system call tables. These files already use ISO-C-style integer types, so make them less inconsistent by preferring the standard types. These should actually be Linux types l_foo_t. ISO-C-style

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-26 Thread Konstantin Belousov
On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: On Fri, 25 May 2012, Ed Schouten wrote: Log: Remove use of non-ISO-C integer types from system call tables. These files already use ISO-C-style integer types, so make them less inconsistent by preferring the standard types.

Re: svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-26 Thread Bruce Evans
On Sat, 26 May 2012, Konstantin Belousov wrote: On Sat, May 26, 2012 at 10:21:25PM +1000, Bruce Evans wrote: Please don't quote the whole thing. On Fri, 25 May 2012, Ed Schouten wrote: Log: Remove use of non-ISO-C integer types from system call tables. These files already use ISO-C-style

svn commit: r236026 - in head/sys: amd64/linux32 compat/freebsd32 kern

2012-05-25 Thread Ed Schouten
Author: ed Date: Fri May 25 21:50:48 2012 New Revision: 236026 URL: http://svn.freebsd.org/changeset/base/236026 Log: Remove use of non-ISO-C integer types from system call tables. These files already use ISO-C-style integer types, so make them less inconsistent by preferring the