Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-30 Thread David Chisnall
On 30 May 2012, at 09:01, Marius Strobl wrote: Ehm, yes, but given that this wouldn't be the first such flag we have is avoiding it really worth the link time and run time overheads in the long term? Given the small overhead of the extra hashes, yes. At some point in the future, we can

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-30 Thread Konstantin Belousov
On Wed, May 30, 2012 at 10:00:02AM +0100, David Chisnall wrote: On 30 May 2012, at 09:01, Marius Strobl wrote: Ehm, yes, but given that this wouldn't be the first such flag we have is avoiding it really worth the link time and run time overheads in the long term? Given the small

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-29 Thread Marius Strobl
On Mon, May 28, 2012 at 11:47:28PM +0300, Konstantin Belousov wrote: On Mon, May 28, 2012 at 09:03:55PM +0200, Marius Strobl wrote: On Sun, May 27, 2012 at 05:27:48AM +, Konstantin Belousov wrote: Author: kib Date: Sun May 27 05:27:47 2012 New Revision: 236137 URL:

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-29 Thread Konstantin Belousov
On Wed, May 30, 2012 at 12:48:33AM +0200, Marius Strobl wrote: On Mon, May 28, 2012 at 11:47:28PM +0300, Konstantin Belousov wrote: On Mon, May 28, 2012 at 09:03:55PM +0200, Marius Strobl wrote: On Sun, May 27, 2012 at 05:27:48AM +, Konstantin Belousov wrote: Author: kib Date:

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread David Chisnall
On 28 May 2012, at 20:33, Dimitry Andric wrote: On the other hand, it's really platform-dependent: I've checked several Linux distributions, and it is fairly unpredictable whether their gcc passes --hash-style to the linker, or if they do, which option they use. Can we make it dependent on

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread Konstantin Belousov
On Mon, May 28, 2012 at 09:03:55PM +0200, Marius Strobl wrote: On Sun, May 27, 2012 at 05:27:48AM +, Konstantin Belousov wrote: Author: kib Date: Sun May 27 05:27:47 2012 New Revision: 236137 URL: http://svn.freebsd.org/changeset/base/236137 Log: Enable gnu hash generation

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread Konstantin Belousov
On Mon, May 28, 2012 at 09:17:23PM +0100, David Chisnall wrote: On 28 May 2012, at 20:33, Dimitry Andric wrote: On the other hand, it's really platform-dependent: I've checked several Linux distributions, and it is fairly unpredictable whether their gcc passes --hash-style to the linker,

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread Dimitry Andric
On 2012-05-28 22:17, David Chisnall wrote: On 28 May 2012, at 20:33, Dimitry Andric wrote: On the other hand, it's really platform-dependent: I've checked several Linux distributions, and it is fairly unpredictable whether their gcc passes --hash-style to the linker, or if they do, which

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread Marius Strobl
On Sun, May 27, 2012 at 05:27:48AM +, Konstantin Belousov wrote: Author: kib Date: Sun May 27 05:27:47 2012 New Revision: 236137 URL: http://svn.freebsd.org/changeset/base/236137 Log: Enable gnu hash generation for dynamic ELF binaries on x86. As far as I remember from your

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-28 Thread Dimitry Andric
On 2012-05-27 22:31, Roman Divacky wrote: Fwiw, to enable the same thing in clang you want this simple patch: === --- Tools.cpp (revision 157545) +++ Tools.cpp (working copy) @@ -4794,6 +4794,7 @@ if

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-27 Thread Roman Divacky
Fwiw, to enable the same thing in clang you want this simple patch: === --- Tools.cpp (revision 157545) +++ Tools.cpp (working copy) @@ -4794,6 +4794,7 @@ if (Args.hasArg(options::OPT_static)) {

Re: svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-27 Thread Konstantin Belousov
On Sun, May 27, 2012 at 10:31:00PM +0200, Roman Divacky wrote: Fwiw, to enable the same thing in clang you want this simple patch: === --- Tools.cpp (revision 157545) +++ Tools.cpp (working copy) @@ -4794,6 +4794,7 @@

svn commit: r236137 - head/contrib/gcc/config/i386

2012-05-26 Thread Konstantin Belousov
Author: kib Date: Sun May 27 05:27:47 2012 New Revision: 236137 URL: http://svn.freebsd.org/changeset/base/236137 Log: Enable gnu hash generation for dynamic ELF binaries on x86. Reviewed by: kan Modified: head/contrib/gcc/config/i386/freebsd.h