Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread John Baldwin
On Wednesday, September 26, 2012 8:48:03 am Ed Maste wrote: > On 26 September 2012 00:52, Konstantin Belousov wrote: > > On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: > >> Author: emaste > >> Date: Tue Sep 25 22:10:14 2012 > >> New Revision: 240938 > >> URL: http://svn.freebsd.org/chan

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Konstantin Belousov
On Wed, Sep 26, 2012 at 08:48:03AM -0400, Ed Maste wrote: > On 26 September 2012 00:52, Konstantin Belousov wrote: > > On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: > >> Author: emaste > >> Date: Tue Sep 25 22:10:14 2012 > >> New Revision: 240938 > >> URL: http://svn.freebsd.org/change

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Ed Maste
On 26 September 2012 00:52, Konstantin Belousov wrote: > On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: >> Author: emaste >> Date: Tue Sep 25 22:10:14 2012 >> New Revision: 240938 >> URL: http://svn.freebsd.org/changeset/base/240938 >> >> Log: >> Avoid INVARIANTS panic destroying an i

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Pawel Jakub Dawidek
On Wed, Sep 26, 2012 at 09:54:43AM +0200, Pawel Jakub Dawidek wrote: > On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: > [...] > > Note: if_tun had the same issue, addressed in SVN revisions r186391, > > r186483 and r186497. The use of the condvar there appears to be > > redundant

Re: svn commit: r240938 - head/sys/net

2012-09-26 Thread Pawel Jakub Dawidek
On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: [...] > Note: if_tun had the same issue, addressed in SVN revisions r186391, > r186483 and r186497. The use of the condvar there appears to be > redundant with the functionality provided by destroy_dev. [...] > --- head/sys/net/if_tap

Re: svn commit: r240938 - head/sys/net

2012-09-25 Thread Gleb Smirnoff
On Wed, Sep 26, 2012 at 10:56:15AM +0400, Gleb Smirnoff wrote: T> Ed, T> T> On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: T> E> Author: emaste T> E> Date: Tue Sep 25 22:10:14 2012 T> E> New Revision: 240938 T> E> URL: http://svn.freebsd.org/changeset/base/240938 T> E> T> E> Log: T>

Re: svn commit: r240938 - head/sys/net

2012-09-25 Thread Gleb Smirnoff
Ed, On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: E> Author: emaste E> Date: Tue Sep 25 22:10:14 2012 E> New Revision: 240938 E> URL: http://svn.freebsd.org/changeset/base/240938 E> E> Log: E> Avoid INVARIANTS panic destroying an in-use tap(4) E> E> The requirement (implied b

Re: svn commit: r240938 - head/sys/net

2012-09-25 Thread Konstantin Belousov
On Tue, Sep 25, 2012 at 10:10:14PM +, Ed Maste wrote: > Author: emaste > Date: Tue Sep 25 22:10:14 2012 > New Revision: 240938 > URL: http://svn.freebsd.org/changeset/base/240938 > > Log: > Avoid INVARIANTS panic destroying an in-use tap(4) > > The requirement (implied by the KASSERT in

svn commit: r240938 - head/sys/net

2012-09-25 Thread Ed Maste
Author: emaste Date: Tue Sep 25 22:10:14 2012 New Revision: 240938 URL: http://svn.freebsd.org/changeset/base/240938 Log: Avoid INVARIANTS panic destroying an in-use tap(4) The requirement (implied by the KASSERT in tap_destroy) that the tap is closed isn't valid; destroy_dev will block i