Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-05 Thread Bruce Evans
On Thu, 4 Apr 2013, Alexander Motin wrote: On 04.04.2013 23:53, Adrian Chadd wrote: Hi, Isn't this a prime candidate to replace with KASSERT()? It could be, but NULL dereference attempt will crash system no less reliably then KASSERT. Much more reliably: - if INAVRIANTS is not

Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-05 Thread mdf
On Fri, Apr 5, 2013 at 8:21 AM, Bruce Evans b...@optusnet.com.au wrote: This method works well in userland too. Instead of assert() or abort(), use an null dereference, or more portably, a signal Digressing quite a bit, doesn't abort() send a signal already, i.e. SIGABRT? And doesn't

Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-05 Thread Bruce Evans
On Fri, 5 Apr 2013 m...@freebsd.org wrote: On Fri, Apr 5, 2013 at 8:21 AM, Bruce Evans b...@optusnet.com.au wrote: This method works well in userland too. Instead of assert() or abort(), use an null dereference, or more portably, a signal Digressing quite a bit, doesn't abort() send a

svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-04 Thread Alexander Motin
Author: mav Date: Thu Apr 4 19:04:15 2013 New Revision: 249105 URL: http://svnweb.freebsd.org/changeset/base/249105 Log: MFprojects/camlock r248930: Remove extra NULL checks. d_drv1 can never be NULL during periph life cycle. MFC after:2 weeks Modified: head/sys/cam/ata/ata_da.c

Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-04 Thread Adrian Chadd
Hi, Isn't this a prime candidate to replace with KASSERT()? Thanks, Adrian On 4 April 2013 12:04, Alexander Motin m...@freebsd.org wrote: Author: mav Date: Thu Apr 4 19:04:15 2013 New Revision: 249105 URL: http://svnweb.freebsd.org/changeset/base/249105 Log: MFprojects/camlock

Re: svn commit: r249105 - in head/sys/cam: ata scsi

2013-04-04 Thread Alexander Motin
On 04.04.2013 23:53, Adrian Chadd wrote: Hi, Isn't this a prime candidate to replace with KASSERT()? It could be, but NULL dereference attempt will crash system no less reliably then KASSERT. On 4 April 2013 12:04, Alexander Motin m...@freebsd.org wrote: Author: mav Date: Thu Apr 4