Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-31 Thread Andriy Gapon
on 31/08/2013 01:30 Xin Li said the following: I've re-examined the code with some instruments and it looks like the case where tdzp and sdzp have different z_zfsvfs were caught by upper layer in our VFS. I don't believe this to be true. -- Andriy Gapon

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-30 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Davide, On 08/28/13 03:19, Davide Italiano wrote: On Wed, Aug 28, 2013 at 3:02 AM, Xin Li delp...@delphij.net wrote: On 08/27/13 01:59, Davide Italiano wrote: I've written a patch that attempts to fix the second problem.

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-28 Thread Andriy Gapon
on 28/08/2013 04:02 Xin Li said the following: I'm not sure that this is right. Now we have: tdzp = VTOZ(tdvp); ZFS_VERIFY_ZP(tdzp); zfsvfs = tdzp-z_zfsvfs; ZFS_ENTER(zfsvfs);// tdzp's z_zfsvfs entered zilog = zfsvfs-z_log; sdzp

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-28 Thread Davide Italiano
On Wed, Aug 28, 2013 at 3:02 AM, Xin Li delp...@delphij.net wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 [snip] On 08/27/13 01:59, Davide Italiano wrote: I've written a patch that attempts to fix the second problem. http://people.freebsd.org/~davide/review/zfsrename_recycle.diff

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Andriy Gapon
on 27/08/2013 02:03 Xin Li said the following: On 08/26/13 08:35, Andriy Gapon wrote: on 26/08/2013 01:15 Jeremie Le Hen said the following: Hi Xin, On Tue, Aug 20, 2013 at 10:31:14PM +, Xin LI wrote: [snip] @@ zfs_rename(vnode_t *sdvp, char *snm, vno if (VOP_REALVP(tdvp, realvp, ct) ==

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Andriy Gapon
on 27/08/2013 06:41 Jeremie Le Hen said the following: On Mon, Aug 26, 2013 at 04:03:08PM -0700, Xin Li wrote: Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c === ---

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Jeremie Le Hen
On Tue, Aug 27, 2013 at 11:01:30AM +0300, Andriy Gapon wrote: on 27/08/2013 06:41 Jeremie Le Hen said the following: On Mon, Aug 26, 2013 at 04:03:08PM -0700, Xin Li wrote: Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Davide Italiano
On Tue, Aug 27, 2013 at 10:00 AM, Andriy Gapon a...@freebsd.org wrote: on 27/08/2013 02:03 Xin Li said the following: On 08/26/13 08:35, Andriy Gapon wrote: on 26/08/2013 01:15 Jeremie Le Hen said the following: Hi Xin, On Tue, Aug 20, 2013 at 10:31:14PM +, Xin LI wrote: [snip] @@

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-27 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/27/13 01:59, Davide Italiano wrote: On Tue, Aug 27, 2013 at 10:00 AM, Andriy Gapon a...@freebsd.org wrote: on 27/08/2013 02:03 Xin Li said the following: On 08/26/13 08:35, Andriy Gapon wrote: on 26/08/2013 01:15 Jeremie Le Hen said the

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-26 Thread Andriy Gapon
on 26/08/2013 01:15 Jeremie Le Hen said the following: Hi Xin, On Tue, Aug 20, 2013 at 10:31:14PM +, Xin LI wrote: Author: delphij Date: Tue Aug 20 22:31:13 2013 New Revision: 254585 URL: http://svnweb.freebsd.org/changeset/base/254585 Log: MFV r254220: Illumos ZFS issues:

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-26 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/26/13 08:35, Andriy Gapon wrote: on 26/08/2013 01:15 Jeremie Le Hen said the following: Hi Xin, On Tue, Aug 20, 2013 at 10:31:14PM +, Xin LI wrote: Author: delphij Date: Tue Aug 20 22:31:13 2013 New Revision: 254585 URL:

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-26 Thread Jeremie Le Hen
On Mon, Aug 26, 2013 at 04:03:08PM -0700, Xin Li wrote: Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c === --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c (revision 254924) +++

Re: svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-25 Thread Jeremie Le Hen
Hi Xin, On Tue, Aug 20, 2013 at 10:31:14PM +, Xin LI wrote: Author: delphij Date: Tue Aug 20 22:31:13 2013 New Revision: 254585 URL: http://svnweb.freebsd.org/changeset/base/254585 Log: MFV r254220: Illumos ZFS issues: 4039 zfs_rename()/zfs_link() needs stronger test for

svn commit: r254585 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-08-20 Thread Xin LI
Author: delphij Date: Tue Aug 20 22:31:13 2013 New Revision: 254585 URL: http://svnweb.freebsd.org/changeset/base/254585 Log: MFV r254220: Illumos ZFS issues: 4039 zfs_rename()/zfs_link() needs stronger test for XDEV Modified: