Re: svn commit: r279828 - head/sys/dev/cadence

2015-03-11 Thread Hans Petter Selasky
On 03/09/15 23:39, Ian Lepore wrote: - if ((ifp-if_flags IFF_BROADCAST) == 0) + if ((if_getflags(ifp) IFF_BROADCAST) == 0) A comment: I think it would be better if the flags were not a bitmask, but an enum or structure, allowing for more than 32 or 64 bit-flags.

Re: svn commit: r279828 - head/sys/dev/cadence

2015-03-10 Thread Gleb Smirnoff
On Mon, Mar 09, 2015 at 10:39:59PM +, Ian Lepore wrote: I Author: ian I Date: Mon Mar 9 22:39:58 2015 I New Revision: 279828 I URL: https://svnweb.freebsd.org/changeset/base/279828 I I Log: I Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of I pre-allocating them

Re: svn commit: r279828 - head/sys/dev/cadence

2015-03-10 Thread Ian Lepore
On Tue, 2015-03-10 at 13:25 +0300, Gleb Smirnoff wrote: On Mon, Mar 09, 2015 at 10:39:59PM +, Ian Lepore wrote: I Author: ian I Date: Mon Mar 9 22:39:58 2015 I New Revision: 279828 I URL: https://svnweb.freebsd.org/changeset/base/279828 I I Log: I Use the new ifnet API. Also,

Re: svn commit: r279828 - head/sys/dev/cadence

2015-03-10 Thread Ian Lepore
On Tue, 2015-03-10 at 13:33 -0600, Scott Long wrote: On Mar 9, 2015, at 4:39 PM, Ian Lepore i...@freebsd.org wrote: Author: ian Date: Mon Mar 9 22:39:58 2015 New Revision: 279828 URL: https://svnweb.freebsd.org/changeset/base/279828 Log: Use the new ifnet API. Also, allocate

Re: svn commit: r279828 - head/sys/dev/cadence

2015-03-10 Thread Scott Long via svn-src-head
On Mar 9, 2015, at 4:39 PM, Ian Lepore i...@freebsd.org wrote: Author: ian Date: Mon Mar 9 22:39:58 2015 New Revision: 279828 URL: https://svnweb.freebsd.org/changeset/base/279828 Log: Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of pre-allocating them all

svn commit: r279828 - head/sys/dev/cadence

2015-03-09 Thread Ian Lepore
Author: ian Date: Mon Mar 9 22:39:58 2015 New Revision: 279828 URL: https://svnweb.freebsd.org/changeset/base/279828 Log: Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of pre-allocating them all at start-up. Also fix a bug in cgem_stop(); before, it wasn't properly