Author: tuexen
Date: Sat Nov 21 16:25:09 2015
New Revision: 291137
URL: https://svnweb.freebsd.org/changeset/base/291137

Log:
  Don't send SHUTDOWN chunk when the association is in a front state
  and the applications calls shutdown(..., SHUT_WR) or
  shutdown(..., SHUT_RDWR).
  
  MFC after:    1 week.

Modified:
  head/sys/netinet/sctp_pcb.c
  head/sys/netinet/sctp_usrreq.c

Modified: head/sys/netinet/sctp_pcb.c
==============================================================================
--- head/sys/netinet/sctp_pcb.c Sat Nov 21 16:25:03 2015        (r291136)
+++ head/sys/netinet/sctp_pcb.c Sat Nov 21 16:25:09 2015        (r291137)
@@ -3640,13 +3640,11 @@ sctp_inpcb_free(struct sctp_inpcb *inp, 
         * macro here since le_next will get freed as part of the
         * sctp_free_assoc() call.
         */
-       if (so) {
 #ifdef IPSEC
+       if (ip_pcb->inp_sp != NULL) {
                ipsec_delete_pcbpolicy(ip_pcb);
-#endif                         /* IPSEC */
-
-               /* Unlocks not needed since the socket is gone now */
        }
+#endif
        if (ip_pcb->inp_options) {
                (void)sctp_m_free(ip_pcb->inp_options);
                ip_pcb->inp_options = 0;

Modified: head/sys/netinet/sctp_usrreq.c
==============================================================================
--- head/sys/netinet/sctp_usrreq.c      Sat Nov 21 16:25:03 2015        
(r291136)
+++ head/sys/netinet/sctp_usrreq.c      Sat Nov 21 16:25:09 2015        
(r291137)
@@ -1007,16 +1007,15 @@ sctp_shutdown(struct socket *so)
                } else {
                        netp = stcb->asoc.primary_destination;
                }
-               if (TAILQ_EMPTY(&asoc->send_queue) &&
+               if ((SCTP_GET_STATE(asoc) == SCTP_STATE_OPEN) &&
+                   TAILQ_EMPTY(&asoc->send_queue) &&
                    TAILQ_EMPTY(&asoc->sent_queue) &&
                    (asoc->stream_queue_cnt == 0)) {
                        if (asoc->locked_on_sending) {
                                goto abort_anyway;
                        }
                        /* there is nothing queued to send, so I'm done... */
-                       if (SCTP_GET_STATE(asoc) == SCTP_STATE_OPEN) {
-                               SCTP_STAT_DECR_GAUGE32(sctps_currestab);
-                       }
+                       SCTP_STAT_DECR_GAUGE32(sctps_currestab);
                        SCTP_SET_STATE(asoc, SCTP_STATE_SHUTDOWN_SENT);
                        SCTP_CLEAR_SUBSTATE(asoc, SCTP_STATE_SHUTDOWN_PENDING);
                        sctp_stop_timers_for_shutdown(stcb);
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to