Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Steven Hartland
On 07/02/2017 20:34, Ed Maste wrote: On 7 February 2017 at 10:30, Steven Hartland wrote: All I'm suggesting is, while one could guess this may be a performance or possibly a compatibility thing, the reason is not obvious, so a small piece of detail on why the

Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Ed Maste
On 7 February 2017 at 10:30, Steven Hartland wrote: > All I'm suggesting is, while one could guess this may be a performance or > possibly a compatibility thing, the reason is not obvious, so a small piece > of detail on why the change was done should always be

Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Steven Hartland
On 07/02/2017 14:57, Mateusz Guzik wrote: On Sun, Feb 05, 2017 at 03:17:46PM +, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and

Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Mateusz Guzik
On Sun, Feb 05, 2017 at 03:17:46PM +, Alexey Dokuchaev wrote: > On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: > > For instance, plugging an unused variable, a memory leak, doing a > > lockless check first etc. are all pretty standard and unless there is > > something unusual

Re: svn commit: r313260 - head/sys/kern

2017-02-05 Thread Steven Hartland
On 05/02/2017 15:17, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and unless there is something unusual going on (e.g. complicated

Re: svn commit: r313260 - head/sys/kern

2017-02-05 Thread Alexey Dokuchaev
On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: > For instance, plugging an unused variable, a memory leak, doing a > lockless check first etc. are all pretty standard and unless there is > something unusual going on (e.g. complicated circumstances leading to a > leak) there is not

Re: svn commit: r313260 - head/sys/kern

2017-02-04 Thread Mateusz Guzik
On Sun, Feb 05, 2017 at 02:16:12AM +, Steven Hartland wrote: > Hi Mateusz could you improve on the commit message as it currently > describes what is changed, which can be obtained from the diff, but > not why? > > I hope on one feels like I'm trying to teach them to suck eggs, as I > know

Re: svn commit: r313260 - head/sys/kern

2017-02-04 Thread Ngie Cooper (yaneurabeya)
> On Feb 4, 2017, at 18:16, Steven Hartland > wrote: > > Hi Mateusz could you improve on the commit message as it currently describes > what is changed, which can be obtained from the diff, but not why? > > I hope on one feels like I'm trying to teach them to

Re: svn commit: r313260 - head/sys/kern

2017-02-04 Thread Steven Hartland
Hi Mateusz could you improve on the commit message as it currently describes what is changed, which can be obtained from the diff, but not why? I hope on one feels like I'm trying to teach them to suck eggs, as I know everyone here has a wealth of experience, but I strongly believe commit

svn commit: r313260 - head/sys/kern

2017-02-04 Thread Mateusz Guzik
Author: mjg Date: Sun Feb 5 01:40:27 2017 New Revision: 313260 URL: https://svnweb.freebsd.org/changeset/base/313260 Log: fd: switch fget_unlocked to atomic_fcmpset Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c