Re: svn commit: r314189 - head/lib/libcam

2017-02-24 Thread Ian Lepore
On Fri, 2017-02-24 at 13:28 -0800, Ngie Cooper (yaneurabeya) wrote: > > > > On Feb 24, 2017, at 13:17, Ian Lepore wrote: > … > > > > > Alright.  That answers everything except the actual important > > question. > >  So, again: > > > > What *real* benefit does this churn

Re: svn commit: r314189 - head/lib/libcam

2017-02-24 Thread Ngie Cooper (yaneurabeya)
> On Feb 24, 2017, at 13:17, Ian Lepore wrote: … > Alright. That answers everything except the actual important question. > So, again: > > What *real* benefit does this churn bring? The benefits are: clarity in intent in the code and fixing dead (always false or always

Re: svn commit: r314189 - head/lib/libcam

2017-02-24 Thread Ian Lepore
On Fri, 2017-02-24 at 13:02 -0800, Ngie Cooper (yaneurabeya) wrote: > > > > On Feb 24, 2017, at 07:36, Ian Lepore wrote: > > > > On Fri, 2017-02-24 at 06:24 +, Ngie Cooper wrote: > > > > > > Author: ngie > > > Date: Fri Feb 24 06:24:39 2017 > > > New Revision: 314189 > >

Re: svn commit: r314189 - head/lib/libcam

2017-02-24 Thread Ngie Cooper (yaneurabeya)
> On Feb 24, 2017, at 07:36, Ian Lepore wrote: > > On Fri, 2017-02-24 at 06:24 +, Ngie Cooper wrote: >> Author: ngie >> Date: Fri Feb 24 06:24:39 2017 >> New Revision: 314189 >> URL: https://svnweb.freebsd.org/changeset/base/314189 >> >> Log: >> Fix up NULL/'\0' uses

Re: svn commit: r314189 - head/lib/libcam

2017-02-24 Thread Ian Lepore
On Fri, 2017-02-24 at 06:24 +, Ngie Cooper wrote: > Author: ngie > Date: Fri Feb 24 06:24:39 2017 > New Revision: 314189 > URL: https://svnweb.freebsd.org/changeset/base/314189 > > Log: >   Fix up NULL/'\0' uses and fix 2 derefs after NULL >    >   MFC after: 2 weeks >   Reported by:

svn commit: r314189 - head/lib/libcam

2017-02-23 Thread Ngie Cooper
Author: ngie Date: Fri Feb 24 06:24:39 2017 New Revision: 314189 URL: https://svnweb.freebsd.org/changeset/base/314189 Log: Fix up NULL/'\0' uses and fix 2 derefs after NULL MFC after:2 weeks Reported by: Coverity CID: 1018898, 1018899 Differential Revision: