Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-26 Thread Rodney W. Grimes
> Rodney, > > On Tue, Apr 25, 2017 at 11:30:17AM -0700, Rodney W. Grimes wrote: > R> > Author: glebius > R> > Date: Tue Apr 25 15:56:46 2017 > R> > New Revision: 317409 > R> > URL: https://svnweb.freebsd.org/changeset/base/317409 > R> > > R> > Log: > R> > Cherry-pick

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-26 Thread Gleb Smirnoff
Rodney, On Tue, Apr 25, 2017 at 11:30:17AM -0700, Rodney W. Grimes wrote: R> > Author: glebius R> > Date: Tue Apr 25 15:56:46 2017 R> > New Revision: 317409 R> > URL: https://svnweb.freebsd.org/changeset/base/317409 R> > R> > Log: R> > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-26 Thread Julian Elischer
On 26/4/17 4:38 am, Benjamin Kaduk wrote: On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin > wrote: I do think that when referring to a Git hash the citation should also include something to identify which repository it came from. It

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-26 Thread Julian Elischer
On 26/4/17 3:29 am, Xin LI wrote: On Tue, Apr 25, 2017 at 12:07 PM, Rodney W. Grimes wrote: [ Charset UTF-8 unsupported, converting... ] On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: [ Charset UTF-8 unsupported,

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Bryan Drewery
On 4/25/2017 3:12 PM, Ngie Cooper wrote: > On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery wrote: > > ... > >> It is definitely more useful to note which repository and what VCS >> system the revision/hash/version refers to. But there's nothing >> inherently wrong about

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Ngie Cooper
On Tue, Apr 25, 2017 at 2:26 PM, Bryan Drewery wrote: ... > It is definitely more useful to note which repository and what VCS > system the revision/hash/version refers to. But there's nothing > inherently wrong about using a git hash. Github != git. It is merely an >

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Bryan Drewery
On 4/25/2017 1:38 PM, Benjamin Kaduk wrote: > On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin > wrote: > > > I do think that when referring to a Git hash the citation should > also include > something to identify which repository it came

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin wrote: > > I do think that when referring to a Git hash the citation should also > include > something to identify which repository it came from. It doesn't have to > be a > URL per se (we just use 'NetBSD' for makefs, not a full

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread John Baldwin
On Tuesday, April 25, 2017 01:10:00 PM Rodney W. Grimes wrote: > > full > > (github or otherwise) URL including the commit hash to just a bare commit > > hash, > > but find either acceptable and adequate for the purpose. (FWIW, the > > correct commit > > was the top google hit for me.) > > > > I

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Andriy Gapon
On 25/04/2017 23:10, Rodney W. Grimes wrote: > This is the first time I have seen a raw git1 sha used in the body of > the commit message, at best it should be in a Obtained From: > > Are there other commits that use a raw git sha1 as the explination > for the commit, with or without supporting

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Rodney W. Grimes
> On Tue, Apr 25, 2017 at 2:07 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > > > > On the contrary, a git SHA1 seems like an eminently stable and unique > > > search parameter! > > > I agree that a commit log should inline

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 2:07 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > > > On the contrary, a git SHA1 seems like an eminently stable and unique > > search parameter! > > I agree that a commit log should inline some summary of

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Xin LI
On Tue, Apr 25, 2017 at 12:07 PM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < >> free...@pdx.rh.cn85.dnsmgr.net> wrote: >> >> > [ Charset UTF-8 unsupported, converting... ] >> > >

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > Author: glebius > > > Date: Tue Apr 25 15:56:46 2017 > > > New Revision: 317409 > > > URL:

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Benjamin Kaduk
On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: glebius > > Date: Tue Apr 25 15:56:46 2017 > > New Revision: 317409 > > URL: https://svnweb.freebsd.org/changeset/base/317409 > > > > Log: > >

Re: svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Author: glebius > Date: Tue Apr 25 15:56:46 2017 > New Revision: 317409 > URL: https://svnweb.freebsd.org/changeset/base/317409 > > Log: > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after > free Lets not use git hashes as

svn commit: r317409 - head/contrib/tcpdump

2017-04-25 Thread Gleb Smirnoff
Author: glebius Date: Tue Apr 25 15:56:46 2017 New Revision: 317409 URL: https://svnweb.freebsd.org/changeset/base/317409 Log: Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after free if tcpdump(1) is run on non-existent interface. Suggested by: zeising Modified: