Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Warner Losh wrote: On Fri, May 4, 2018 at 5:12 PM, Mateusz Guzik wrote: On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Bruce Evans
On Fri, 4 May 2018, Warner Losh wrote: While i wholeheartedly agree, an earlier commit explained why in this case. It allows the compiler to inline for small copies. [This should have been killfiled due to top-posting.] No, it has nothing to do with that. The compiler can inline either bcopy

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Warner Losh
On Fri, May 4, 2018 at 5:12 PM, Mateusz Guzik wrote: > On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < > steven.hartl...@multiplay.co.uk> wrote: > >> Can we get the why in commit messages please? >> >> This sort of message doesnt provide anything more that can be obtained >> from reading the d

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Juli Mallett
On 4 May 2018 at 16:12, Mateusz Guzik wrote: > On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < > steven.hartl...@multiplay.co.uk> wrote: > >> Can we get the why in commit messages please? >> >> This sort of message doesnt provide anything more that can be obtained >> from reading the diff, whi

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < > steven.hartl...@multiplay.co.uk> wrote: > > > Can we get the why in commit messages please? > > > > This sort of message doesnt provide anything more that can be obtained > > from reading the diff,

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Mateusz Guzik
On Sat, May 5, 2018 at 12:58 AM, Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: > Can we get the why in commit messages please? > > This sort of message doesnt provide anything more that can be obtained > from reading the diff, which just leaves us wondering why? > > I’m sure there is a

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Warner Losh
While i wholeheartedly agree, an earlier commit explained why in this case. It allows the compiler to inline for small copies. Warner On Fri, May 4, 2018, 4:58 PM Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: > Can we get the why in commit messages please? > > This sort of message do

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Steven Hartland
Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be obtained from reading the diff, which just leaves us wondering why? I’m sure there is a good reason, but without confirmation we’re just left guessing. The knock on to this is if some assum

svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Mateusz Guzik
Author: mjg Date: Fri May 4 22:41:12 2018 New Revision: 333266 URL: https://svnweb.freebsd.org/changeset/base/333266 Log: amd64: syscall path bcopy -> memcpy Modified: head/sys/amd64/amd64/trap.c Modified: head/sys/amd64/amd64/trap.c =