Re: svn commit: r338209 - in head: sbin/ipfw sbin/pfctl sys/net sys/net/altq sys/netpfil/pf usr.sbin/bsnmpd/modules/snmp_pf

2018-08-22 Thread Patrick Kelsey
Gleb, Thanks for taking a look. I don't think there is all that much complication in the compatibility layer, and I think what is there is worth the properties it yields. The approach taken to backwards compatibility has a clear and regular structure, it allows out of tree consumers of the

Re: svn commit: r338209 - in head: sbin/ipfw sbin/pfctl sys/net sys/net/altq sys/netpfil/pf usr.sbin/bsnmpd/modules/snmp_pf

2018-08-22 Thread Gleb Smirnoff
Patrick, thanks for the change. The compatibility layer seems overcomplicated though. IMHO, it would be enough just to provide binary compatibility keeping the old structure and ioctl number as compat, not declaring them in public headers. And the compat layer should be embraced with

svn commit: r338209 - in head: sbin/ipfw sbin/pfctl sys/net sys/net/altq sys/netpfil/pf usr.sbin/bsnmpd/modules/snmp_pf

2018-08-22 Thread Patrick Kelsey
Author: pkelsey Date: Wed Aug 22 19:38:48 2018 New Revision: 338209 URL: https://svnweb.freebsd.org/changeset/base/338209 Log: Extended pf(4) ioctl interface and pfctl(8) to allow bandwidths of 2^32 bps or greater to be used. Prior to this, bandwidth parameters would simply wrap at the